Fri, Aug 09, 2019 at 06:11:30AM CEST, ro...@cumulusnetworks.com wrote:
>On Fri, Jul 19, 2019 at 4:00 AM Jiri Pirko wrote:
>>
>> From: Jiri Pirko
>>
>> Add two commands to add and delete alternative ifnames for net device.
>> Each net device can have multiple alternative names.
>>
>> Signed-off-by
From: Heiner Kallweit
Date: Wed, 7 Aug 2019 21:38:22 +0200
> We allocate 16kb per rx buffer, so we can avoid some overhead by using
> alloc_pages_node directly instead of bothering kmalloc_node. Due to
> this change buffers are page-aligned now, therefore the alignment check
> can be removed.
>
From: Jakub Kicinski
Date: Wed, 7 Aug 2019 17:03:59 -0700
> sk_validate_xmit_skb() and drivers depend on the sk member of
> struct sk_buff to identify segments requiring encryption.
> Any operation which removes or does not preserve the original TLS
> socket such as skb_orphan() or skb_clone() w
From: Roman Mashak
Date: Wed, 7 Aug 2019 15:57:27 -0400
> When adding or deleting a batch of entries, the kernel sends up to
> TCA_ACT_MAX_PRIO (defined to 32 in kernel) entries in an event to user
> space. However it does not consider that the action sizes may vary and
> require different skb s
From: Ido Schimmel
Date: Wed, 7 Aug 2019 13:42:31 +0300
> From: Jiri Pirko
>
> Extend existing driver for Spectrum and Spectrum-2 ASICs
> to support Spectrum-3 ASIC as well.
>
> Signed-off-by: Jiri Pirko
> Reviewed-by: Petr Machata
> Signed-off-by: Ido Schimmel
Applied.
From: john.rutherf...@dektech.com.au
Date: Wed, 7 Aug 2019 12:52:29 +1000
> From: John Rutherford
>
> Since node internal messages are passed directly to the socket, it is not
> possible to observe those messages via tcpdump or wireshark.
>
> We now remedy this by making it possible to clone s
On Fri, Jul 19, 2019 at 4:00 AM Jiri Pirko wrote:
>
> From: Jiri Pirko
>
> Add two commands to add and delete alternative ifnames for net device.
> Each net device can have multiple alternative names.
>
> Signed-off-by: Jiri Pirko
> ---
> include/linux/netdevice.h | 4 ++
> include/uapi/
From: we...@ucloud.cn
Date: Wed, 7 Aug 2019 09:13:48 +0800
> This series patch make nftables offload support the vlan and
> tunnel device offload through indr-block architecture.
>
> The first four patches mv tc indr block to flow offload and
> rename to flow-indr-block.
> Because the new flow-i
From: David Miller
Date: Thu, 08 Aug 2019 18:37:56 -0700 (PDT)
> I applied this without patch #17 which you said you would respin in order
> to get rid of the now unused local variable.
Actually, there is a bunch of fallout still:
drivers/net/wimax/i2400m/debugfs.c: In function ‘i2400m_debugfs_
From: Greg Kroah-Hartman
Date: Tue, 6 Aug 2019 18:11:11 +0200
> There is no need to test the result of any debugfs call anymore. The
> debugfs core warns the user if something fails, and the return value of
> a debugfs call can always be fed back into another debugfs call with no
> problems.
>
From: Edward Cree
Date: Tue, 6 Aug 2019 14:52:06 +0100
> This series listifies part of GRO processing, in a manner which allows those
> packets which are not GROed (i.e. for which dev_gro_receive returns
> GRO_NORMAL) to be passed on to the listified regular receive path.
> dev_gro_receive() it
On Thu, 8 Aug 2019 20:22:00 +, Saeed Mahameed wrote:
> From: Maxim Mikityanskiy
>
> The current ARFS code relies on certain fields to be set in the SKB
> (e.g. transport_header) and extracts IP addresses and ports by custom
> code that parses the packet. The necessary SKB fields, however, are
From: Rahul Verma
Date: Mon, 5 Aug 2019 23:59:50 -0700
> Supported ports in ethtool are displayed based on media type.
> For media type fibre and twinaxial, port type is "FIBRE". Media type
> Base-T is "TP" and media KR is "Backplane".
>
> V1->V2:
> Corrected the subject.
>
> Signed-off-by: Ra
On Mon, Aug 05, 2019 at 11:34:41PM +0300, Alexey Dobriyan wrote:
> Delete long obsoleted "register" keyword.
>
> Signed-off-by: Alexey Dobriyan
> ---
>
> drivers/net/ethernet/apple/bmac.c |4 ++--
> drivers/net/slip/slhc.c | 30 +++---
> net/netfilter/ipv
From: David Ahern
Date: Mon, 5 Aug 2019 15:41:37 -0700
> From: David Ahern
>
> Add IPv4 and IPv6 l2tp tests. Current set is over IP and with
> IPsec.
>
> v2
> - add l2tp.sh to TEST_PROGS in Makefile
>
> Signed-off-by: David Ahern
Applied.
From: Stephen Hemminger
Date: Mon, 5 Aug 2019 15:30:02 -0700
> Both IPX and TR have not been supported for a while now.
> Remove them from the /proc/sys/net documentation.
>
> Signed-off-by: Stephen Hemminger
Applied.
From: Stephen Hemminger
Date: Mon, 5 Aug 2019 15:30:03 -0700
> IPX is no longer supported, but the example in the documentation
> might useful. Replace it with IPv6.
>
> Signed-off-by: Stephen Hemminger
Applied.
From: Alexey Dobriyan
Date: Mon, 5 Aug 2019 23:43:31 +0300
> Use more pleasant looking
>
> struct notifier_block *nb,
>
> instead of "this".
>
> Signed-off-by: Alexey Dobriyan
Sorry, this is a lot of churn for something that is basically an
opinion of being nicer or less nice.
I actua
From: Alexey Dobriyan
Date: Mon, 5 Aug 2019 23:34:41 +0300
> Delete long obsoleted "register" keyword.
>
> Signed-off-by: Alexey Dobriyan
Applied.
From: Ross Lagerwall
Date: Mon, 5 Aug 2019 16:34:34 +0100
> At this point nr_frags has been incremented but the frag does not yet
> have a page assigned so freeing the skb results in a crash. Reset
> nr_frags before freeing the skb to prevent this.
>
> Signed-off-by: Ross Lagerwall
Applied and
/proc/config has never existed as far as I can see, but /proc/config.gz
is present on Arch Linux. Add support for decompressing config.gz using
zlib which is a mandatory dependency of libelf. Replace existing stdio
functions with gzFile operations since the latter transparently handles
uncompressed
This patch set add netdev_level_ratelimited to avoid netdev msg flush.
The second patch fixed ibmveth msg flush when add lots of(e.g. 2000) group
memberships in one group at the same time.
In my testing, there will be the
ibmveth 3003 env3: h_multicast_ctrl rc=4 when adding an entry to the fi
When add lots of (e.g. add 3000) memberships in one multicast group on
ibmveth, the following error message flushes our console log file
8507[ 901.478251] ibmveth 3003 env3: h_multicast_ctrl rc=4 when adding
an entry to the filter table
...
1718386 [ 5636.808658] ibmveth 3003 env3: h
Add netdev_level_ratelimited so we can use it in the future.
The code is copied from device.h.
Suggested-by: Joe Perches
Signed-off-by: Hangbin Liu
---
include/linux/netdevice.h | 53 +++
1 file changed, 53 insertions(+)
diff --git a/include/linux/netdevice.
On Thu, 8 Aug 2019 12:52:11 -0700, Y Song wrote:
> > Ah ok. In this scenario if driver has a native xdp support we would be
> > invoking
> > its ndo_bpf even if there's no prog currently attached and it wouldn't
> > return
> > error value.
> >
> > Looking at dev_xdp_uninstall, setting driver's pr
mvpp 2.2 supports RXAUI, which requires two serdes lanes, and XAUI which
requires four serdes lanes instead of the usual single lane required by other
interface modes. This patch expands the number of lanes that can be associated
to a port so that all relevant serdes lanes are correctly configured
This patch set implements support for configuring Marvell's mvpp2 hardware for
RXAUI operation. There are two other patches necessary for this to work
correctly that concern Marvell's cp110 comphy that were emailed to the general
linux-kernel mailing list earlier on. I can post them here if need be
Marvell's mvpp2 packet processor supports RXAUI on port zero in a
similar manner to the existing 10G protocols that have already been
implemented. This patch implements the miscellaneous extra configuration
steps required for RXAUI operation.
Signed-off-by: Matt Pelland
---
drivers/net/ethernet/
From: Guillaume Nault
Date: Fri, 2 Aug 2019 17:15:03 +0200
> Before commit d4289fcc9b16 ("net: IP6 defrag: use rbtrees for IPv6
> defrag"), a netperf UDP_STREAM test[0] using big IPv6 datagrams (thus
> generating many fragments) and running over an IPsec tunnel, reported
> more than 6Gbps through
From: Holger Hoffstätte
Disabling TSO but leaving SG active results is a significant
performance drop. Therefore disable also SG on RTL8168evl.
This restores the original performance.
Fixes: 93681cd7d94f ("r8169: enable HW csum and TSO")
Signed-off-by: Holger Hoffstätte
Signed-off-by: Heiner Kal
Thanks a lot, Yonghong. I'll fix and split up the patch.
Thanks again for your help.
Bests
On Thu, Aug 08, 2019 at 08:47:14PM +, Yonghong Song wrote:
>
>
> On 8/8/19 1:26 PM, carlos antonio neira bustos wrote:
> > Hi Yonghong,
> >
> > I’m sorry, just to be sure, I’m just missing the error
On 8/7/19 4:30 AM, Ido Schimmel wrote:
> Example usage with patched dropwatch [1] can be found here [2]. Example
> dissection of drop monitor netlink events with patched wireshark [3] can
> be found here [4]. I will submit both changes upstream after the kernel
> changes are accepted. Another chang
On Wed, Aug 7, 2019 at 5:08 AM Paul Blakey wrote:
>
> Offloaded OvS datapath rules are translated one to one to tc rules,
> for example the following simplified OvS rule:
>
> recirc_id(0),in_port(dev1),eth_type(0x0800),ct_state(-trk)
> actions:ct(),recirc(2)
>
> Will be translated to the followin
On 8/8/19 1:26 PM, carlos antonio neira bustos wrote:
> Hi Yonghong,
>
> I’m sorry, just to be sure, I’m just missing the error codes from
> filename_lookup() right ?.
From kernel functionality point of view. Yes, I am talking about
error codes returned by filename_lookup().
For example, if C
Hi Yonghong,
I'm sorry just to be sure, I'm just missing the error codes from
filename_lookup()?.
I'll work on that.
Bests
> > > Maybe reword by following the code sequence.
> > > if *size_of_pidns* is not valid or unable to get ns, pid or tgid of
> > > the current task.
> > >
> > > > +
On Fri, Aug 9, 2019 at 1:48 AM Quentin Monnet
wrote:
>
> 2019-08-07 11:25 UTC+0900 ~ Daniel T. Lee
> > Since, new sub-command 'net attach/detach' has been added for
> > attaching XDP program on interface,
> > this commit documents usage and sample output of `net attach/detach`.
> >
> > Signed-off
On 08.08.2019 22:20, Andrew Lunn wrote:
>> I have a contact in Realtek who provided the information about
>> the vendor-specific registers used in the patch. I also asked for
>> a method to auto-detect 2.5Gbps support but have no feedback so far.
>> What may contribute to the problem is that also t
From: Tariq Toukan
Use the proper tisn field name from the union in struct mlx5_wqe_ctrl_seg.
Fixes: d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload support")
Signed-off-by: Tariq Toukan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c | 6 +++---
From: Aya Levin
Remove wrong error return value when SQ is not in error state.
CQE recovery on TX reporter queries the sq state. If the sq is not in
error state, the sq is either in ready or reset state. Ready state is
good state which doesn't require recovery and reset state is a temporal
state
From: Aya Levin
CQE recovery function begins with test and set of recovery bit. Add an
error flow which ensures clearing of this bit when leaving the recovery
function, to allow further recoveries to take place. This allows removal
of clearing recovery bit on sq activate.
Fixes: de8650a82071 ("n
From: Tariq Toukan
Shift the tisn field in the WQE control segment, per the
HW specification.
Fixes: d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload support")
Signed-off-by: Tariq Toukan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c | 6 +++---
From: Aya Levin
Remove check of recovery bit, in the beginning of the CQE recovery
function. This test is already performed right before the reporter
is invoked, when CQE error is detected.
Fixes: de8650a82071 ("net/mlx5e: Add tx reporter support")
Signed-off-by: Aya Levin
Signed-off-by: Saeed
From: Mohamad Heib
Setting speed to 56GBASE is allowed only with auto-negotiation enabled.
This patch prevent setting speed to 56GBASE when auto-negotiation disabled.
Fixes: f62b8bb8f2d3 ("net/mlx5: Extend mlx5_core to support ConnectX-4 Ethernet
functionality")
Signed-off-by: Mohamad Heib
Si
From: Tariq Toukan
Fix the 128b key offset in key encryption key creation command,
per the HW specification.
Fixes: 45d3b55dc665 ("net/mlx5: Add crypto library to support create/destroy
encryption key")
Signed-off-by: Tariq Toukan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellan
From: Tariq Toukan
The TLS progress params context WQE should not include an
Eth segment, drop it.
In addition, align the tls_progress_params layout with the
HW specification document:
- fix the tisn field name.
- remove the valid bit.
Fixes: a12ff35e0fb7 ("net/mlx5: Introduce TLS TX offload har
From: Tariq Toukan
Fix the used constants for TLS TIS opmods, per the HW specification.
Fixes: a12ff35e0fb7 ("net/mlx5: Introduce TLS TX offload hardware bits and
structures")
Signed-off-by: Tariq Toukan
Signed-off-by: Saeed Mahameed
---
include/linux/mlx5/device.h | 4 ++--
1 file changed,
On 8/8/19 10:47 AM, Andrii Nakryiko wrote:
> On Wed, Aug 7, 2019 at 9:24 PM Yonghong Song wrote:
>>
>>
>>
>> On 8/7/19 5:32 PM, Andrii Nakryiko wrote:
>>> Make .BTF section allocated and expose its contents through sysfs.
>>>
>>> /sys/kernel/btf directory is created to contain all the BTFs prese
From: Huy Nguyen
Only support changing tx/rx pause frame setting if the net device
is the vport group manager.
Fixes: 3c2d18ef22df ("net/mlx5e: Support ethtool get/set_pauseparam")
Signed-off-by: Huy Nguyen
Reviewed-by: Parav Pandit
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mell
From: Huy Nguyen
We have an issue that OVS application creates an offloaded drop rule
that drops VXLAN traffic with both inner and outer header match
criteria. mlx5_core driver detects correctly the inner and outer
header match criteria but does not enable the inner header match criteria
due to a
level = inner_match_level;
+ flow->esw_attr->outer_match_level = outer_match_level;
++>>>>>>> (net)
To resolve, use hunks from net (2nd) and replace:
if (flow->flags & MLX5E_TC_FLOW_ESWITCH)
with
if (is_eswitch_flow)
Thanks,
Saeed.
---
The follow
From: Maxim Mikityanskiy
The current ARFS code relies on certain fields to be set in the SKB
(e.g. transport_header) and extracts IP addresses and ports by custom
code that parses the packet. The necessary SKB fields, however, are not
always set at that point, which leads to an out-of-bounds acce
> I have a contact in Realtek who provided the information about
> the vendor-specific registers used in the patch. I also asked for
> a method to auto-detect 2.5Gbps support but have no feedback so far.
> What may contribute to the problem is that also the integrated 1Gbps
> PHY's (all with the sa
On 2019-08-08, at 13:23:55 +0200, Pablo Neira Ayuso wrote:
> On Wed, Aug 07, 2019 at 03:16:58PM +0100, Jeremy Sowden wrote:
> [...]
> > +/* Called from uadd only, protected by the set spinlock.
> > + * The kadt functions don't use the comment extensions in any way.
> > + */
> > +static inline void
On 08.08.2019 21:32, Andrew Lunn wrote:
> On Thu, Aug 08, 2019 at 09:03:42PM +0200, Heiner Kallweit wrote:
>> The integrated PHY in 2.5Gbps chip RTL8125 is the first (known to me)
>> PHY that uses standard Clause 22 for all modes up to 1Gbps and adds
>> 2.5Gbps control using vendor-specific registe
On 08.08.2019 21:52, Holger Hoffstätte wrote:
> On 8/8/19 8:17 PM, Heiner Kallweit wrote:
>> On 08.08.2019 17:53, Holger Hoffstätte wrote:
>>> On 8/8/19 4:37 PM, Holger Hoffstätte wrote:
Hello Heiner -
On 7/28/19 11:25 AM, Heiner Kallweit wrote:
> There was a previous attemp
On Thu, 8 Aug 2019 12:57:05 -0700
Y Song wrote:
> On Thu, Aug 8, 2019 at 12:43 PM Toke Høiland-Jørgensen
> wrote:
> >
> > Alexei Starovoitov writes:
> >
> > > On Fri, Jul 26, 2019 at 9:06 AM Toke Høiland-Jørgensen
> > > wrote:
> > >>
> > >> This series adds a new map type, devmap_hash, t
On Thu, Aug 8, 2019 at 12:43 PM Toke Høiland-Jørgensen wrote:
>
> Alexei Starovoitov writes:
>
> > On Fri, Jul 26, 2019 at 9:06 AM Toke Høiland-Jørgensen
> > wrote:
> >>
> >> This series adds a new map type, devmap_hash, that works like the existing
> >> devmap type, but using a hash-based inde
On 8/8/19 8:17 PM, Heiner Kallweit wrote:
On 08.08.2019 17:53, Holger Hoffstätte wrote:
On 8/8/19 4:37 PM, Holger Hoffstätte wrote:
Hello Heiner -
On 7/28/19 11:25 AM, Heiner Kallweit wrote:
There was a previous attempt to use xmit_more, but the change had to be
reverted because under load s
On Wed, Aug 7, 2019 at 1:40 PM Maciej Fijalkowski
wrote:
>
> On Wed, 7 Aug 2019 13:12:17 -0700
> Y Song wrote:
>
> > On Wed, Aug 7, 2019 at 11:30 AM Maciej Fijalkowski
> > wrote:
> > >
> > > On Wed, 7 Aug 2019 10:02:04 -0700
> > > Y Song wrote:
> > >
> > > > On Tue, Aug 6, 2019 at 7:25 PM Danie
On 8/8/19 8:03 PM, David Miller wrote:
> From: Oliver Neukum
> Date: Thu, 8 Aug 2019 11:28:25 +0200
>
>> Lest we leak kernel memory to a device we better zero out buffers.
>>
>> Reported-by: syzbot+513e4d0985298538b...@syzkaller.appspotmail.com
>> Signed-off-by: Oliver Neukum
>
> Please CC: th
On 08.08.2019 21:37, Andrew Lunn wrote:
> On Thu, Aug 08, 2019 at 09:05:54PM +0200, Heiner Kallweit wrote:
>> This adds support for the integrated 2.5Gbps PHY in Realtek RTL8125.
>> Advertisement of 2.5Gbps mode is done via a vendor-specific register.
>> Same applies to reading NBase-T link partner
On Thu, Aug 8, 2019 at 9:17 AM Jesper Dangaard Brouer wrote:
>
> This address the TODO in samples/bpf/xdp_fwd_kern.c, which points out
> that the chosen egress index should be checked for existence in the
> devmap. This can now be done via taking advantage of Toke's work in
> commit 0cdbb4b09a06 (
On Thu, Aug 8, 2019 at 10:52 AM Carlos Antonio Neira Bustos
wrote:
>
> Yonghong,
>
> I have modified the patch following your feedback.
> Let me know if I'm missing something.
Yes, I have some other requests about formating.
https://lore.kernel.org/netdev/20190808174848.poybtaagg5ctle7t@dev00/T/#
On Thu, Aug 08, 2019 at 09:05:54PM +0200, Heiner Kallweit wrote:
> This adds support for the integrated 2.5Gbps PHY in Realtek RTL8125.
> Advertisement of 2.5Gbps mode is done via a vendor-specific register.
> Same applies to reading NBase-T link partner advertisement.
> Unfortunately this 2.5Gbps
On Thu, Aug 08, 2019 at 09:03:42PM +0200, Heiner Kallweit wrote:
> The integrated PHY in 2.5Gbps chip RTL8125 is the first (known to me)
> PHY that uses standard Clause 22 for all modes up to 1Gbps and adds
> 2.5Gbps control using vendor-specific registers. To use phylib for
> the standard part lit
Alexei Starovoitov writes:
> On Fri, Jul 26, 2019 at 9:06 AM Toke Høiland-Jørgensen
> wrote:
>>
>> This series adds a new map type, devmap_hash, that works like the existing
>> devmap type, but using a hash-based indexing scheme. This is useful for the
>> use
>> case where a devmap is indexed
On Fri, Aug 9, 2019 at 1:48 AM Quentin Monnet
wrote:
>
> 2019-08-07 11:25 UTC+0900 ~ Daniel T. Lee
> > This commit adds bash-completion for new "net attach/detach"
> > subcommand for attaching XDP program on interface.
> >
> > Signed-off-by: Daniel T. Lee
> > ---
> > tools/bpf/bpftool/bash-comp
On Fri, Aug 9, 2019 at 2:50 AM Jakub Kicinski
wrote:
>
> On Thu, 8 Aug 2019 07:15:22 +0900, Daniel T. Lee wrote:
> > > > + return -EINVAL;
> > > > + }
> > > > +
> > > > + NEXT_ARG();
> > >
> > > nit: the new line should be before NEXT_ARG(), IOV NEXT_ARG() belongs
> > > to the
On 08/08/2019 3:03, Jakub Kicinski wrote:
> sk_validate_xmit_skb() and drivers depend on the sk member of
> struct sk_buff to identify segments requiring encryption.
> Any operation which removes or does not preserve the original TLS
> socket such as skb_orphan() or skb_clone() will cause clear t
Jesper Dangaard Brouer writes:
> Make it clear that this XDP program depend on the network
> stack to do the ARP resolution. This is connected with the
> BPF_FIB_LKUP_RET_NO_NEIGH return code from bpf_fib_lookup().
>
> Another common mistake (seen via XDP-tutorial) is that users
> don't realize
Jesper Dangaard Brouer writes:
> This address the TODO in samples/bpf/xdp_fwd_kern.c, which points out
> that the chosen egress index should be checked for existence in the
> devmap. This can now be done via taking advantage of Toke's work in
> commit 0cdbb4b09a06 ("devmap: Allow map lookups from
Jesper Dangaard Brouer writes:
> The devmap name 'tx_port' came from a copy-paste from xdp_redirect_map
> which only have a single TX port. Change name to xdp_tx_ports
> to make it more descriptive.
>
> Signed-off-by: Jesper Dangaard Brouer
> Reviewed-by: David Ahern
> Acked-by: Yonghong Song
Add helper function phy_modify_paged_changed, behavior is the same
as for phy_modify_changed.
Signed-off-by: Heiner Kallweit
---
drivers/net/phy/phy-core.c | 29 -
include/linux/phy.h| 2 ++
2 files changed, 26 insertions(+), 5 deletions(-)
diff --git a/driv
The integrated PHY in 2.5Gbps chip RTL8125 is the first (known to me)
PHY that uses standard Clause 22 for all modes up to 1Gbps and adds
2.5Gbps control using vendor-specific registers. To use phylib for
the standard part little extensions are needed:
- Move most of genphy_config_aneg to a new fun
This adds support for the integrated 2.5Gbps PHY in Realtek RTL8125.
Advertisement of 2.5Gbps mode is done via a vendor-specific register.
Same applies to reading NBase-T link partner advertisement.
Unfortunately this 2.5Gbps PHY shares the PHY ID with the integrated
1Gbps PHY's in other Realtek ne
This series adds support for the integrated 2.5Gbps PHY in RTL8125.
First two patches add necessary functionality to phylib.
Heiner Kallweit (3):
net: phy: prepare phylib to deal with PHY's extending Clause 22
net: phy: add phy_modify_paged_changed
net: phy: realtek: add support for the 2.5G
On Tue, Aug 6, 2019 at 5:21 PM Jakub Kicinski
wrote:
>
> No error message is currently printed if the pin syscall
> itself fails. It got lost in the loadall refactoring.
>
> Fixes: 77380998d91d ("bpftool: add loadall command")
> Reported-by: Andy Lutomirski
> Signed-off-by: Jakub Kicinski
> Revi
On Thu, Aug 08, 2019 at 07:57:53AM +0300, Denis Efremov wrote:
> octeon_mbox_process_cmd() directly writes the PCI_EXP_DEVCTL_BCR_FLR
> bit, which bypasses timing requirements imposed by the PCIe spec.
> This patch fixes the function to use the pcie_flr() interface instead.
>
> Signed-off-by: Deni
Hi Jeremy,
On Wed, 7 Aug 2019, Jeremy Sowden wrote:
> linux/netfilter/ipset/ip_set.h included four other header files:
>
> include/linux/netfilter/ipset/ip_set_comment.h
> include/linux/netfilter/ipset/ip_set_counter.h
> include/linux/netfilter/ipset/ip_set_skbinfo.h
> include/linux/netf
On Mon, Aug 5, 2019 at 5:11 PM Jakub Kicinski
wrote:
>
> On Sat, 3 Aug 2019 23:52:16 -0700, Y Song wrote:
> > > include/uapi/linux/bpf.h | 21 +++--
> > > net/core/filter.c | 20
> > > tools/include/uapi/linux/bpf.h| 21
On Thu, Aug 08, 2019 at 08:28:30AM -0700, Stanislav Fomichev wrote:
> On 08/08, Martin Lau wrote:
> > On Wed, Aug 07, 2019 at 08:47:18AM -0700, Stanislav Fomichev wrote:
> > > Add new helper bpf_sk_storage_clone which optionally clones sk storage
> > > and call it from bpf_sk_storage_clone. Reuse t
On 08.08.2019 17:53, Holger Hoffstätte wrote:
> On 8/8/19 4:37 PM, Holger Hoffstätte wrote:
>>
>> Hello Heiner -
>>
>> On 7/28/19 11:25 AM, Heiner Kallweit wrote:
>>> There was a previous attempt to use xmit_more, but the change had to be
>>> reverted because under load sometimes a transmit timeout
On Thu, Aug 8, 2019 at 1:32 PM Jakub Kicinski
wrote:
>
> On Thu, 8 Aug 2019 11:59:18 -0400, Willem de Bruijn wrote:
> > > diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c
> > > index 7c0b2b778703..43922d86e510 100644
> > > --- a/net/tls/tls_device.c
> > > +++ b/net/tls/tls_device.c
> > > @
On Thu, Aug 08, 2019 at 10:53:44AM -0700, Andrii Nakryiko wrote:
> On Wed, Aug 7, 2019 at 11:08 PM Greg KH wrote:
> >
> > On Thu, Aug 08, 2019 at 04:24:25AM +, Yonghong Song wrote:
> > >
> > >
> > > On 8/7/19 5:32 PM, Andrii Nakryiko wrote:
> > > > Make .BTF section allocated and expose its co
On 6 Aug 2019, at 12:06, Andrew Lunn wrote:
On Tue, Aug 06, 2019 at 11:54:49AM -0700, Jakub Kicinski wrote:
On Tue, 6 Aug 2019 20:38:41 +0200, Jiri Pirko wrote:
So the proposal is to have some new device, say "kernelnet", that
would implicitly create per-namespace devlink instance. This
de
From: Oliver Neukum
Date: Thu, 8 Aug 2019 11:28:25 +0200
> Lest we leak kernel memory to a device we better zero out buffers.
>
> Reported-by: syzbot+513e4d0985298538b...@syzkaller.appspotmail.com
> Signed-off-by: Oliver Neukum
Please CC: the CAN subsystem maintainers, as this is clearly list
On Wed, Aug 7, 2019 at 11:08 PM Greg KH wrote:
>
> On Thu, Aug 08, 2019 at 04:24:25AM +, Yonghong Song wrote:
> >
> >
> > On 8/7/19 5:32 PM, Andrii Nakryiko wrote:
> > > Make .BTF section allocated and expose its contents through sysfs.
>
> Was this original patch not on bpf@vger? I can't fin
On Thu, 8 Aug 2019 07:15:22 +0900, Daniel T. Lee wrote:
> > > + return -EINVAL;
> > > + }
> > > +
> > > + NEXT_ARG();
> >
> > nit: the new line should be before NEXT_ARG(), IOV NEXT_ARG() belongs
> > to the code which consumed the argument
> >
>
> I'm not sure I'm following
Yonghong,
I have modified the patch following your feedback.
Let me know if I'm missing something.
Bests
>From 70f8d5584700c9cfc82c006901d8ee9595c53f15 Mon Sep 17 00:00:00 2001
From: Carlos
Date: Wed, 7 Aug 2019 20:04:30 -0400
Subject: [PATCH] [PATCH v6 bpf-next] BPF: New helper to obtain name
On Wed, Aug 7, 2019 at 9:24 PM Yonghong Song wrote:
>
>
>
> On 8/7/19 5:32 PM, Andrii Nakryiko wrote:
> > Make .BTF section allocated and expose its contents through sysfs.
> >
> > /sys/kernel/btf directory is created to contain all the BTFs present
> > inside kernel. Currently there is only kerne
On Thu, 8 Aug 2019 11:59:18 -0400, Willem de Bruijn wrote:
> > diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c
> > index 7c0b2b778703..43922d86e510 100644
> > --- a/net/tls/tls_device.c
> > +++ b/net/tls/tls_device.c
> > @@ -373,9 +373,9 @@ static int tls_push_data(struct sock *sk,
> >
On Thu, Aug 8, 2019 at 4:30 AM Jesper Dangaard Brouer wrote:
>
> Another improvement from Toke, is that the bpf_redirect_map() helper,
> now also check if the redirect index is valid in the map. If not, then
> it returns another value than XDP_REDIRECT. You can choose the
> alternative return va
2019-08-07 11:25 UTC+0900 ~ Daniel T. Lee
> Since, new sub-command 'net attach/detach' has been added for
> attaching XDP program on interface,
> this commit documents usage and sample output of `net attach/detach`.
>
> Signed-off-by: Daniel T. Lee
> ---
> .../bpf/bpftool/Documentation/bpftool-
2019-08-07 11:25 UTC+0900 ~ Daniel T. Lee
> This commit adds bash-completion for new "net attach/detach"
> subcommand for attaching XDP program on interface.
>
> Signed-off-by: Daniel T. Lee
> ---
> tools/bpf/bpftool/bash-completion/bpftool | 64 +++
> 1 file changed, 55 ins
From: Taehee Yoo
ixgbe_service_task() calls unregister_netdev() under rtnl_lock().
But unregister_netdev() internally calls rtnl_lock().
So deadlock would occur.
Fixes: 59dd45d550c5 ("ixgbe: firmware recovery mode")
Signed-off-by: Taehee Yoo
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
On Wed, 2019-08-07 at 15:08 +0900, Taehee Yoo wrote:
> On Wed, 7 Aug 2019 at 08:36, David Miller
> wrote:
>
> Hi David
> Thank you for the review!
>
> > From: Jeff Kirsher
> > Date: Mon, 5 Aug 2019 13:04:03 -0700
> >
> > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > > b/dri
This address the TODO in samples/bpf/xdp_fwd_kern.c, which points out
that the chosen egress index should be checked for existence in the
devmap. This can now be done via taking advantage of Toke's work in
commit 0cdbb4b09a06 ("devmap: Allow map lookups from eBPF").
This change makes xdp_fwd more
The devmap name 'tx_port' came from a copy-paste from xdp_redirect_map
which only have a single TX port. Change name to xdp_tx_ports
to make it more descriptive.
Signed-off-by: Jesper Dangaard Brouer
Reviewed-by: David Ahern
Acked-by: Yonghong Song
---
samples/bpf/xdp_fwd_kern.c |5 +++--
Make it clear that this XDP program depend on the network
stack to do the ARP resolution. This is connected with the
BPF_FIB_LKUP_RET_NO_NEIGH return code from bpf_fib_lookup().
Another common mistake (seen via XDP-tutorial) is that users
don't realize that sysctl net.ipv{4,6}.conf.all.forwarding
V3: Hopefully fixed all issues point out by Yonghong Song
V2: Addressed issues point out by Yonghong Song
- Please ACK patch 2/3 again
- Added ACKs and reviewed-by to other patches
This patchset is focused on improvements for XDP forwarding sample
named xdp_fwd, which leverage the existing FIB
1 - 100 of 143 matches
Mail list logo
