2019-08-07 11:25 UTC+0900 ~ Daniel T. Lee <danieltim...@gmail.com> > This commit adds bash-completion for new "net attach/detach" > subcommand for attaching XDP program on interface. > > Signed-off-by: Daniel T. Lee <danieltim...@gmail.com> > --- > tools/bpf/bpftool/bash-completion/bpftool | 64 +++++++++++++++++++---- > 1 file changed, 55 insertions(+), 9 deletions(-) > > diff --git a/tools/bpf/bpftool/bash-completion/bpftool > b/tools/bpf/bpftool/bash-completion/bpftool > index c8f42e1fcbc9..1d81cb09d478 100644 > --- a/tools/bpf/bpftool/bash-completion/bpftool > +++ b/tools/bpf/bpftool/bash-completion/bpftool > @@ -201,6 +201,10 @@ _bpftool() > _bpftool_get_prog_tags > return 0 > ;; > + dev) > + _sysfs_get_netdevs > + return 0 > + ;;
Makes sense to have this for "dev", thanks! But it seems you missed one place where it was used, for "bpftool feature probe" (We have "[[ $prev == "dev" ]] && _sysfs_get_netdevs && return 0"). Could you also remove that one please? Other than this looks good, thanks: Reviewed-by: Quentin Monnet <quentin.mon...@netronome.com>
