On Wed, 2019-08-07 at 15:08 +0900, Taehee Yoo wrote:
> On Wed, 7 Aug 2019 at 08:36, David Miller <da...@davemloft.net>
> wrote:
>
> Hi David
> Thank you for the review!
>
> > From: Jeff Kirsher <jeffrey.t.kirs...@intel.com>
> > Date: Mon, 5 Aug 2019 13:04:03 -0700
> >
> > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > > b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > > index cbaf712d6529..3386e752e458 100644
> > > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > > @@ -7898,9 +7898,7 @@ static void ixgbe_service_task(struct
> > > work_struct *work)
> > > }
> > > if (ixgbe_check_fw_error(adapter)) {
> > > if (!test_bit(__IXGBE_DOWN, &adapter->state)) {
> > > - rtnl_lock();
> > > unregister_netdev(adapter->netdev);
> > > - rtnl_unlock();
> > > }
> >
> > Please remove the (now unnecessary) curly braces for this basic
> > block.
> >
>
> I will send a v2 patch.
> Thank you!I have already created a v2 on your behalf Taechee and will submit to Dave here shortly.
signature.asc
Description: This is a digitally signed message part
