On Thu, Aug 08, 2019 at 09:03:42PM +0200, Heiner Kallweit wrote: > The integrated PHY in 2.5Gbps chip RTL8125 is the first (known to me) > PHY that uses standard Clause 22 for all modes up to 1Gbps and adds > 2.5Gbps control using vendor-specific registers. To use phylib for > the standard part little extensions are needed: > - Move most of genphy_config_aneg to a new function > __genphy_config_aneg that takes a parameter whether restarting > auto-negotiation is needed (depending on whether content of > vendor-specific advertisement register changed). > - Don't clear phydev->lp_advertising in genphy_read_status so that > we can set non-C22 mode flags before. > > Basically both changes mimic the behavior of the equivalent Clause 45 > functions. > > Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> > --- > drivers/net/phy/phy_device.c | 35 +++++++++++++++-------------------- > include/linux/phy.h | 8 +++++++- > 2 files changed, 22 insertions(+), 21 deletions(-) > > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c > index 7ddd91df9..bd7e7db8c 100644 > --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c > @@ -1571,11 +1571,9 @@ static int genphy_config_advert(struct phy_device > *phydev) > /* Only allow advertising what this PHY supports */ > linkmode_and(phydev->advertising, phydev->advertising, > phydev->supported); > - if (!ethtool_convert_link_mode_to_legacy_u32(&advertise, > - phydev->advertising)) > - phydev_warn(phydev, "PHY advertising (%*pb) more modes than > genphy supports, some modes not advertised.\n", > - __ETHTOOL_LINK_MODE_MASK_NBITS, > - phydev->advertising); > + > + ethtool_convert_link_mode_to_legacy_u32(&advertise, > + phydev->advertising);
Hi Heiner linkmode_adv_to_mii_adv_t() would remove the need to use ethtool_convert_link_mode_to_legacy_u32(), and this warning would also go away. Andrew
