Re: [PATCH nf-next 4/4] netfilter: merge ctinfo into nfct pointer storage area

2017-01-04 Thread kbuild test robot
Hi Florian, [auto build test WARNING on nf-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Westphal/netfilter-skbuff-merge-nfctinfo-bits-and-nfct-pointer/20170105-133727 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master config: x86_64-randconf

[PATCH net-next] cxgb4: Synchronize access to mailbox

2017-01-04 Thread Hariprasad Shenai
The issue comes when there are multiple threads attempting to use the mailbox facility at the same time. When DCB operations and interface up/down is run in a loop for every 0.1 sec, we observed mailbox collisions. And out of the two commands one would fail with the present code, since we don't que

Re: [PATCH net-next] packet: fix panic in __packet_set_timestamp on tpacket_v3 in tx mode

2017-01-04 Thread David Miller
From: Daniel Borkmann Date: Thu, 5 Jan 2017 02:34:28 +0100 > When TX timestamping is in use with TPACKET_V3's TX ring, then we'll > hit the BUG() in __packet_set_timestamp() when ring buffer slot is > returned to user space via tpacket_destruct_skb(). This is due to v3 > being assumed as unreach

Re: [net PATCH 1/2] virtio_net: cap mtu when XDP programs are running

2017-01-04 Thread Michael S. Tsirkin
On Wed, Jan 04, 2017 at 07:11:18PM -0800, John Fastabend wrote: > XDP programs can not consume multiple pages so we cap the MTU to > avoid this case. Virtio-net however only checks the MTU at XDP > program load and does not block MTU changes after the program > has loaded. Do drivers really have t

Re: [net PATCH 1/2] virtio_net: cap mtu when XDP programs are running

2017-01-04 Thread John Fastabend
On 17-01-04 07:11 PM, John Fastabend wrote: > XDP programs can not consume multiple pages so we cap the MTU to > avoid this case. Virtio-net however only checks the MTU at XDP > program load and does not block MTU changes after the program > has loaded. > > This patch sets/clears the max_mtu value

[net PATCH 2/2] virtio_net: use dev_kfree_skb for small buffer XDP receive

2017-01-04 Thread John Fastabend
In the small buffer case during driver unload we currently use put_page instead of dev_kfree_skb. Resolve this by adding a check for virtnet mode when checking XDP queue type. Also name the function so that the code reads correctly to match the additional check. Signed-off-by: John Fastabend ---

[net PATCH 1/2] virtio_net: cap mtu when XDP programs are running

2017-01-04 Thread John Fastabend
XDP programs can not consume multiple pages so we cap the MTU to avoid this case. Virtio-net however only checks the MTU at XDP program load and does not block MTU changes after the program has loaded. This patch sets/clears the max_mtu value at XDP load/unload time. Signed-off-by: John Fastabend

Re: [RFC PATCH] virtio_net: XDP support for adjust_head

2017-01-04 Thread Jason Wang
On 2017年01月05日 02:58, John Fastabend wrote: [...] @@ -393,34 +397,39 @@ static u32 do_xdp_prog(struct virtnet_info *vi, struct bpf_prog *xdp_prog, void *data, int len) { -int hdr_padded_len; struct xdp_buff xdp; -void *buf; unsigned

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-04 Thread Jason Wang
On 2017年01月05日 02:57, John Fastabend wrote: [...] On 2017年01月04日 00:48, John Fastabend wrote: On 17-01-02 10:14 PM, Jason Wang wrote: On 2017年01月03日 06:30, John Fastabend wrote: XDP programs can not consume multiple pages so we cap the MTU to avoid this case. Virtio-net however only checks

[PATCH] net: stmmac: fix maxmtu assignment to be within valid range

2017-01-04 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" There is no checking valid value of maxmtu when getting it from devicetree. This resolution added the checking condition to ensure the assignment is made within a valid range. Signed-off-by: Kweh, Hock Leong --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |3

Re: [PATCH net-next] packet: fix panic in __packet_set_timestamp on tpacket_v3 in tx mode

2017-01-04 Thread Sowmini Varadhan
On (01/05/17 02:34), Daniel Borkmann wrote: > When TX timestamping is in use with TPACKET_V3's TX ring, then we'll > hit the BUG() in __packet_set_timestamp() when ring buffer slot is > returned to user space via tpacket_destruct_skb(). This is due to v3 > being assumed as unreachable here, but sin

[PATCH net-next] packet: fix panic in __packet_set_timestamp on tpacket_v3 in tx mode

2017-01-04 Thread Daniel Borkmann
When TX timestamping is in use with TPACKET_V3's TX ring, then we'll hit the BUG() in __packet_set_timestamp() when ring buffer slot is returned to user space via tpacket_destruct_skb(). This is due to v3 being assumed as unreachable here, but since 7f953ab2ba46 ("af_packet: TX_RING support for TPA

RE: [PATCH] stmmac: Enable Clause 45 PHYs in GMAC4 (eQOS)

2017-01-04 Thread Kweh, Hock Leong
> -Original Message- > From: Joao Pinto [mailto:joao.pi...@synopsys.com] > Sent: Wednesday, January 04, 2017 10:36 PM > To: da...@davemloft.net > Cc: Kweh, Hock Leong ; netdev@vger.kernel.org; > Joao Pinto > Subject: [PATCH] stmmac: Enable Clause 45 PHYs in GMAC4 (eQOS) > > The eQOS IP Co

[PATCH net-next] liquidio: fix wrong information about channels reported to ethtool

2017-01-04 Thread Felix Manlunas
From: Weilin Chang Information reported to ethtool about channels is sometimes wrong for PF, and always wrong for VF. Fix them by getting the information from the right fields from the right structs. Signed-off-by: Weilin Chang Signed-off-by: Felix Manlunas Signed-off-by: Derek Chickles Sign

RE: [PATCH] scm: remove use CMSG{_COMPAT}_ALIGN(sizeof(struct {compat_}cmsghdr))

2017-01-04 Thread YUAN Linyu
Thanks > -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, January 05, 2017 2:25 AM > To: cug...@163.com > Cc: netdev@vger.kernel.org; YUAN Linyu > Subject: Re: [PATCH] scm: remove use CMSG{_COMPAT}_ALIGN(sizeof(struct > {compat_}cmsghdr)) > > From: yu

Re: [PATCH v3 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter

2017-01-04 Thread Shuah Khan
On 01/04/2017 03:55 PM, Sowmini Varadhan wrote: > On (01/04/17 15:37), Shuah Khan wrote: >>> + /* the filter below checks for all of the following conditions that >>> +* are based on the contents of create_payload() >>> +* ether type 0x800 and >>> +* ip proto udp and >>> +*

Re: [PATCH v3 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter

2017-01-04 Thread Daniel Borkmann
On 01/04/2017 11:48 PM, Sowmini Varadhan wrote: On (01/04/17 23:26), Daniel Borkmann wrote: [...] As it stands it makes it a bit harder to parse / less readable with macros actually. Rest seems fine, thanks. Usually macros are there (a) as an abstraction so you dont have to hard-code things,

Re: [PATCH 2/2] PCI: lock each enable/disable num_vfs operation in sysfs

2017-01-04 Thread Gavin Shan
On Wed, Jan 04, 2017 at 04:00:20PM +, Tantilov, Emil S wrote: >>On Tue, Jan 03, 2017 at 04:48:31PM -0800, Emil Tantilov wrote: >>>Enabling/disabling SRIOV via sysfs by echo-ing multiple values >>>simultaneously: >>> >>>echo 63 > /sys/class/net/ethX/device/sriov_numvfs& >>>echo 63 > /sys/class/n

[RFC PATCH next] ipv6: do not send RTM_DELADDR for tentative addresses

2017-01-04 Thread Mahesh Bandewar
From: Mahesh Bandewar RTM_NEWADDR notification is sent when IFA_F_TENTATIVE is cleared from the address. So if the address is added and deleted before DAD probes completes, the RTM_DELADDR will be sent for which there was no RTM_NEWADDR causing asymmetry in notification. However if the same logic

Re: [PATCH v3 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter

2017-01-04 Thread Sowmini Varadhan
On (01/04/17 15:37), Shuah Khan wrote: > > + /* the filter below checks for all of the following conditions that > > +* are based on the contents of create_payload() > > +* ether type 0x800 and > > +* ip proto udp and > > +* ip len == ip_len and > > +* udp[38] == 'a' o

Re: [PATCH v3 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter

2017-01-04 Thread Sowmini Varadhan
On (01/04/17 15:37), Shuah Khan wrote: > Looks like you have to do v4 anyway, please make sure your comment > block is one of the acceptable formats based on coding style: I'm not sure about that. I can just keep patch 2. thanks, --Sowmini

Re: [PATCH v3 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter

2017-01-04 Thread Sowmini Varadhan
On (01/04/17 23:26), Daniel Borkmann wrote: > > >>As it stands it makes it a bit harder to parse / less readable with macros > >>actually. Rest seems fine, thanks. Usually macros are there (a) as an abstraction so you dont have to hard-code things, and, (b) to make things more readable. (maybe

Re: [net-next PATCH 5/6] i40e: Add TX and RX support in switchdev mode.

2017-01-04 Thread Samudrala, Sridhar
On 1/3/2017 3:03 PM, Or Gerlitz wrote: On Fri, Dec 30, 2016 at 7:04 PM, Samudrala, Sridhar wrote: On 12/30/2016 7:31 AM, Or Gerlitz wrote: Are you exposing switchdev ops for the representators? didn't see that or maybe it's in the 4th patch which didn't make it to the list? Not at this time

Re: [PATCH v3 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter

2017-01-04 Thread Shuah Khan
On 01/04/2017 11:45 AM, Sowmini Varadhan wrote: > The bpf_prog used in sock_setfilter() only attempts to check for > ip pktlen, and verifies that the contents of the 80'th packet in > the ethernet frame is 'a' or 'b'. Thus many non-udp packets > could incorrectly pass through this filter and cause

Re: [PATCH v3 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter

2017-01-04 Thread Daniel Borkmann
On 01/04/2017 11:22 PM, Sowmini Varadhan wrote: On (01/04/17 23:16), Daniel Borkmann wrote: Just reading up on the thread, sorry to jump in late. Can't you just use the generated code from bpf_asm (tools/net/) and add the asm program as a comment above? Something like we do in net/core/ptp_clas

Re: [PATCH net-next v2] tcp: provide timestamps for partial writes

2017-01-04 Thread Willem de Bruijn
On Wed, Jan 4, 2017 at 11:19 AM, Soheil Hassas Yeganeh wrote: > From: Soheil Hassas Yeganeh > > For TCP sockets, TX timestamps are only captured when the user data > is successfully and fully written to the socket. In many cases, > however, TCP writes can be partial for which no timestamp is > co

Re: [PATCH v3 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter

2017-01-04 Thread Sowmini Varadhan
On (01/04/17 23:16), Daniel Borkmann wrote: > > Just reading up on the thread, sorry to jump in late. Can't you just > use the generated code from bpf_asm (tools/net/) and add the asm program > as a comment above? Something like we do in net/core/ptp_classifier.c +13. I was actually using the exa

Re: [PATCH v3 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter

2017-01-04 Thread Daniel Borkmann
On 01/04/2017 07:45 PM, Sowmini Varadhan wrote: The bpf_prog used in sock_setfilter() only attempts to check for ip pktlen, and verifies that the contents of the 80'th packet in the ethernet frame is 'a' or 'b'. Thus many non-udp packets could incorrectly pass through this filter and cause incor

Re: [PATCH net-next] net: dsa: b53: Utilize common helpers for u64/MAC

2017-01-04 Thread Andrew Lunn
On Wed, Jan 04, 2017 at 01:53:20PM -0800, Florian Fainelli wrote: > Utilize the two functions recently introduced: u64_to_ether() and > ether_to_u64() instead of our own versions. :-) And i expect these have been tested on big endian systems. I never thought to look if one of the other drivers al

[PATCH net-next] net: dsa: b53: Utilize common helpers for u64/MAC

2017-01-04 Thread Florian Fainelli
Utilize the two functions recently introduced: u64_to_ether() and ether_to_u64() instead of our own versions. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 2 +- drivers/net/dsa/b53/b53_priv.h | 23 ++- 2 files changed, 3 insertions(+), 22 deletion

[GIT] Networking

2017-01-04 Thread David Miller
1) stmmac_drv_probe() can race with stmmac_open() because we register the netdevice too early. Fix from Florian Fainelli. 2) UFO handling in __ip6_append_data() and ip6_finish_output() use different tests for deciding whether a frame will be fragmented or not, put them in sync. Fix fro

Re: [PATCH repost net-next] dsa: mv88e6xxx: Optimise atu_get

2017-01-04 Thread Andrew Lunn
> Maybe I over-reacted. I'm happy somebody other than me is thinking about this. > I just ran some test programs in userspace on both little and big > endian and they checked out. Great, thanks for testing. Andrew

Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-04 Thread Florian Fainelli
On 01/04/2017 08:10 AM, Zefir Kurtisi wrote: > On 01/04/2017 04:30 PM, Florian Fainelli wrote: >> >> >> On 01/04/2017 07:27 AM, Zefir Kurtisi wrote: >>> On 01/04/2017 04:13 PM, Florian Fainelli wrote: On 01/04/2017 07:04 AM, Zefir Kurtisi wrote: > While in RUNNING state, phy_stat

Re: [PATCH net-next 0/6] Prepare BPF for VLAN_TAG_PRESENT cleanup

2017-01-04 Thread Michał Mirosław
On Wed, Jan 04, 2017 at 09:11:57PM +0100, Daniel Borkmann wrote: > On 01/04/2017 02:18 AM, Michał Mirosław wrote: > > Those patches prepare BPF ant its JITs for removal of VLAN_TAG_PRESENT. > > The set depends on "Preparation for VLAN_TAG_PRESENT cleanup" patchset. > > > > The series is supposed t

[PATCH] sh_eth: R8A7740 supports packet shecksumming

2017-01-04 Thread Sergei Shtylyov
The R8A7740 GEther controller supports the packet checksum offloading but the 'hw_crc' (bad name, I'll fix it) flag isn't set in the R8A7740 data, thus CSMR isn't cleared... Fixes: 73a0d907301e ("net: sh_eth: add support R8A7740") Signed-off-by: Sergei Shtylyov --- This patch is against DaveM's

Re: [PATCH repost net-next] dsa: mv88e6xxx: Optimise atu_get

2017-01-04 Thread David Miller
From: Andrew Lunn Date: Wed, 4 Jan 2017 22:19:57 +0100 > On Wed, Jan 04, 2017 at 04:11:03PM -0500, David Miller wrote: >> From: Andrew Lunn >> Date: Wed, 4 Jan 2017 19:56:24 +0100 >> >> > +static inline u64 ether_addr_to_u64(const u8 *addr) >> > +{ >> > + u64 u = 0; >> > + int i; >> > + >> >

Re: [PATCH repost net-next] dsa: mv88e6xxx: Optimise atu_get

2017-01-04 Thread Florian Fainelli
On 01/04/2017 01:19 PM, Andrew Lunn wrote: > On Wed, Jan 04, 2017 at 04:11:03PM -0500, David Miller wrote: >> From: Andrew Lunn >> Date: Wed, 4 Jan 2017 19:56:24 +0100 >> >>> +static inline u64 ether_addr_to_u64(const u8 *addr) >>> +{ >>> + u64 u = 0; >>> + int i; >>> + >>> + for (i = 0; i

Re: [PATCH repost net-next] dsa: mv88e6xxx: Optimise atu_get

2017-01-04 Thread Andrew Lunn
On Wed, Jan 04, 2017 at 04:11:03PM -0500, David Miller wrote: > From: Andrew Lunn > Date: Wed, 4 Jan 2017 19:56:24 +0100 > > > +static inline u64 ether_addr_to_u64(const u8 *addr) > > +{ > > + u64 u = 0; > > + int i; > > + > > + for (i = 0; i < ETH_ALEN; i++) > > + u = u << 8 | a

Re: [PATCH] sh_eth: enable RX descriptor word 0 shift on SH7734

2017-01-04 Thread David Miller
From: Sergei Shtylyov Date: Wed, 04 Jan 2017 23:10:23 +0300 > The RX descriptor word 0 on SH7734 has the RFS[9:0] field in bits 16-25 > (bits 0-15 usually used for that are occupied by the packet checksum). > Thus we need to set the 'shift_rd0' field in the SH7734 SoC data... > > Fixes: f0e81

Re: [PATCH repost net-next] dsa: mv88e6xxx: Optimise atu_get

2017-01-04 Thread David Miller
From: Andrew Lunn Date: Wed, 4 Jan 2017 19:56:24 +0100 > +static inline u64 ether_addr_to_u64(const u8 *addr) > +{ > + u64 u = 0; > + int i; > + > + for (i = 0; i < ETH_ALEN; i++) > + u = u << 8 | addr[i]; > + > + return u; > +} ... > +static inline void u64_to_ether

[PATCH net] amd-xgbe: Fix IRQ processing when running in single IRQ mode

2017-01-04 Thread Tom Lendacky
When running in single IRQ mode, the additional IRQ routines were being skipped because only the XGMAC interrupt status was being checked. Update the code so that the additional IRQ routines are checked whenever an interrupt is received. Signed-off-by: Tom Lendacky --- drivers/net/ethernet/amd/x

[PATCH] sh_eth: enable RX descriptor word 0 shift on SH7734

2017-01-04 Thread Sergei Shtylyov
The RX descriptor word 0 on SH7734 has the RFS[9:0] field in bits 16-25 (bits 0-15 usually used for that are occupied by the packet checksum). Thus we need to set the 'shift_rd0' field in the SH7734 SoC data... Fixes: f0e81fecd4f8 ("net: sh_eth: Add support SH7734") Signed-off-by: Sergei Shtyly

Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-04 Thread kbuild test robot
Hi Zefir, [auto build test ERROR on net-next/master] [also build test ERROR on v4.10-rc2 next-20170104] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Zefir-Kurtisi/phy-state-machine-failsafe

Re: [PATCH net-next 0/6] Prepare BPF for VLAN_TAG_PRESENT cleanup

2017-01-04 Thread Daniel Borkmann
On 01/04/2017 02:18 AM, Michał Mirosław wrote: Those patches prepare BPF ant its JITs for removal of VLAN_TAG_PRESENT. The set depends on "Preparation for VLAN_TAG_PRESENT cleanup" patchset. The series is supposed to be bisect-friendly and that requires temporary insertion of #define VLAN_TAG_PR

Re: [PATCH net-next rfc 5/6] net-tc: convert tc_at to tc_at_ingress

2017-01-04 Thread Willem de Bruijn
On Wed, Jan 4, 2017 at 2:51 PM, Daniel Borkmann wrote: > On 01/04/2017 08:26 PM, Willem de Bruijn wrote: diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c index ef53ede..be4e18d 100644 --- a/net/sched/sch_api.c +++ b/net/sched/sch_api.c @@ -1865,6 +1865,7 @@ int

Re: [RESEND net-next PATCH v5] net: dummy: Introduce dummy virtual functions

2017-01-04 Thread Phil Sutter
On Wed, Jan 04, 2017 at 02:09:14PM -0500, David Miller wrote: > From: Phil Sutter > Date: Wed, 4 Jan 2017 14:44:06 +0100 > > > The idea for this was born when testing VF support in iproute2 which was > > impeded by hardware requirements. In fact, not every VF-capable hardware > > driver implemen

Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-04 Thread kbuild test robot
Hi Zefir, [auto build test ERROR on net-next/master] [also build test ERROR on v4.10-rc2 next-20170104] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Zefir-Kurtisi/phy-state-machine-failsafe

Re: [PATCH net-next rfc 5/6] net-tc: convert tc_at to tc_at_ingress

2017-01-04 Thread Daniel Borkmann
On 01/04/2017 08:26 PM, Willem de Bruijn wrote: diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c index ef53ede..be4e18d 100644 --- a/net/sched/sch_api.c +++ b/net/sched/sch_api.c @@ -1865,6 +1865,7 @@ int tc_classify(struct sk_buff *skb, const struct tcf_proto *tp, const struct tcf

[PATCH net-next] liquidio VF: fix incorrect struct being used

2017-01-04 Thread Felix Manlunas
From: Prasad Kanneganti The VF driver is using the wrong struct when sending commands to the NIC firmware, sometimes causing adverse effects in the firmware. The right struct is the one that the PF is using, so make the VF use that as well. Signed-off-by: Prasad Kanneganti Signed-off-by: Felix

Re: [PATCH] sh_eth: fix EESIPR values for SH77{34|63}

2017-01-04 Thread Sergei Shtylyov
On 01/04/2017 10:18 PM, Sergei Shtylyov wrote: As the SH77{34|63} manuals are freely available, I've checked the EESIPR values written against the manuals, and they appeared to set the reserved bits 11-15 (which should be 0 on write). Fix those EESIPR values. Fixes: 380af9e390ec ("net: sh_eth:

Re: [PATCH net-next rfc 5/6] net-tc: convert tc_at to tc_at_ingress

2017-01-04 Thread Willem de Bruijn
>> diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c >> index ef53ede..be4e18d 100644 >> --- a/net/sched/sch_api.c >> +++ b/net/sched/sch_api.c >> @@ -1865,6 +1865,7 @@ int tc_classify(struct sk_buff *skb, const struct >> tcf_proto *tp, >> const struct tcf_proto *old_tp = tp; >>

Re: [PATCH net] sfc: don't report RX hash keys to ethtool when RSS wasn't enabled

2017-01-04 Thread David Miller
From: Edward Cree Date: Wed, 4 Jan 2017 15:10:56 + > If we failed to set up RSS on EF10 (e.g. because firmware declared > RX_RSS_LIMITED), ethtool --show-nfc $dev rx-flow-hash ... should report > no fields, rather than confusingly reporting what fields we _would_ be > hashing on if RSS was

[PATCH] sh_eth: fix EESIPR values for SH77{34|63}

2017-01-04 Thread Sergei Shtylyov
As the SH77{34|63} manuals are freely available, I've checked the EESIPR values written against the manuals, and they appeared to set the reserved bits 11-15 (which should be 0 on write). Fix those EESIPR values. Fixes: 380af9e390ec ("net: sh_eth: CPU dependency code collect to "struct sh_eth_cp

Re: [PATCH net-next rfc 5/6] net-tc: convert tc_at to tc_at_ingress

2017-01-04 Thread Daniel Borkmann
Hi Willem, overall I think the series looks great, thanks for working on it! On 12/28/2016 08:13 PM, Willem de Bruijn wrote: From: Willem de Bruijn Field tc_at is used only within tc actions to distinguish ingress from egress processing. A single bit is sufficient for this purpose. Set it wit

Re: [PATCH] stmmac: Enable Clause 45 PHYs in GAMC4

2017-01-04 Thread David Miller
From: Joao Pinto Date: Wed, 4 Jan 2017 14:35:26 + > The eQOS IP Core (best known in stmmac as gmac4) has a register that must be > set if using a Clause 45 PHY. If this register is not set, the PHY won't work. > This patch will have no impact in setups using Clause 22 PHYs. > > Signed-off-b

Re: [RESEND net-next PATCH v5] net: dummy: Introduce dummy virtual functions

2017-01-04 Thread David Miller
From: Phil Sutter Date: Wed, 4 Jan 2017 14:44:06 +0100 > The idea for this was born when testing VF support in iproute2 which was > impeded by hardware requirements. In fact, not every VF-capable hardware > driver implements all netdev ops, so testing the interface is still hard > to do even wit

Re: [PATCH v2 net-next] cxgb4: Support compressed error vector for T6

2017-01-04 Thread David Miller
From: Ganesh Goudar Date: Wed, 4 Jan 2017 19:04:20 +0530 > From: Arjun V > > t6fw-1.15.15.0 enabled compressed error vector in cpl_rx_pkt for T6. > Updating driver to take care of these changes. > > Signed-off-by: Santosh Rastapur > Signed-off-by: Arjun V > Signed-off-by: Hariprasad Shenai

Re: [RFC PATCH] virtio_net: XDP support for adjust_head

2017-01-04 Thread John Fastabend
[...] >> @@ -393,34 +397,39 @@ static u32 do_xdp_prog(struct virtnet_info *vi, >> struct bpf_prog *xdp_prog, >> void *data, int len) >> { >> -int hdr_padded_len; >> struct xdp_buff xdp; >> -void *buf; >> unsigned int qp; >> u32 act; >>

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-04 Thread John Fastabend
[...] > On 2017年01月04日 00:48, John Fastabend wrote: >> On 17-01-02 10:14 PM, Jason Wang wrote: >>> >>> On 2017年01月03日 06:30, John Fastabend wrote: XDP programs can not consume multiple pages so we cap the MTU to avoid this case. Virtio-net however only checks the MTU at XDP program

[PATCH repost net-next] dsa: mv88e6xxx: Optimise atu_get

2017-01-04 Thread Andrew Lunn
Lookup in the ATU can be performed starting from a given MAC address. This is faster than starting with the first possible MAC address and iterating all entries. Entries are returned in numeric order. So if the MAC address returned is bigger than what we are searching for, we know it is not in the

Re: [PATCH net-next] net/hyperv: remove use of VLAN_TAG_PRESENT

2017-01-04 Thread Stephen Hemminger
On Wed, 4 Jan 2017 01:07:58 +0100 (CET) Michał Mirosław wrote: > Signed-off-by: Michał Mirosław I have a cleaner way of handling this in the receive path for hyperv. Rather than passing vlan_tci, pass the vlan info

Re: [PATCH 0/2] sh_eth: E-MAC interrupt handler cleanups

2017-01-04 Thread David Miller
From: Sergei Shtylyov Date: Wed, 04 Jan 2017 15:09:36 +0300 >Here's a set of 3 patches against DaveM's 'net-next.git' repo. I'm cleaning > up the E-MAC interrupt handling with the main goal of factoring out the E-MAC > interrupt handler into a separate function. > > [1/3] sh_eth: handle only

Re: [PATCH net-next] net: phy: add extension of phy-mode for XLGMII

2017-01-04 Thread Florian Fainelli
On 01/04/2017 10:42 AM, David Miller wrote: > From: Jie Deng > Date: Wed, 4 Jan 2017 13:04:04 +0800 > >> The Synopsys DWC_xlgmac core provides a multiplexed 40-Gigabit >> Media-Independent Interface (XLGMII, an IEEE 802.3 Clause 81 >> compliant reconciliation sub-layer) for communication with >>

Re: [PATCH 0/2] dpaa_eth: a couple of fixes

2017-01-04 Thread David Miller
From: Madalin Bucur Date: Wed, 4 Jan 2017 13:21:28 +0200 > Add cleanup on PHY initialization failure path, avoid using > uninitialized memory at CGR init. Series applied, thanks.

Re: [PATCH net-next] net: phy: add extension of phy-mode for XLGMII

2017-01-04 Thread David Miller
From: Jie Deng Date: Wed, 4 Jan 2017 13:04:04 +0800 > The Synopsys DWC_xlgmac core provides a multiplexed 40-Gigabit > Media-Independent Interface (XLGMII, an IEEE 802.3 Clause 81 > compliant reconciliation sub-layer) for communication with > the 100/50/40/25-Gigabit PHY and 10-Gigabit Media-Inde

[PATCH v3 net-next 0/2] tools: psock_tpacket bug fixes

2017-01-04 Thread Sowmini Varadhan
This patchset includes fixes to psock_tpacket for false-negatives sporadically reported by the test when it was run concurrently with other heavy network traffic (e.g., over an ssh session, as opposed to running the test from the console of the test machine). The test sometimes failed with errors r

[PATCH v3 net-next 2/2] tools: psock_tpacket: block Rx until socket filter has been added and socket has been bound to loopback.

2017-01-04 Thread Sowmini Varadhan
Packets from any/all interfaces may be queued up on the PF_PACKET socket before it is bound to the loopback interface by psock_tpacket, and when these are passed up by the kernel, they could interfere with the Rx tests. Avoid interference from spurious packet by blocking Rx until the socket filter

[PATCH v3 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter

2017-01-04 Thread Sowmini Varadhan
The bpf_prog used in sock_setfilter() only attempts to check for ip pktlen, and verifies that the contents of the 80'th packet in the ethernet frame is 'a' or 'b'. Thus many non-udp packets could incorrectly pass through this filter and cause incorrect test results. This commit hardens the condit

Re: [PATCH next v1] ipvlan: assign unique dev-id for each slave device.

2017-01-04 Thread David Miller
From: Mahesh Bandewar Date: Tue, 3 Jan 2017 12:47:16 -0800 > From: Mahesh Bandewar > > IPvlan setup uses one mac-address (of master). The IPv6 link-local > addresses are derived using the mac-address on the link. Lack of > dev-ids makes these link-local addresses same for all slaves including

Re: [PATCH net 0/2] net: systemport: Fix padding vs. TSB insertion

2017-01-04 Thread David Miller
From: Florian Fainelli Date: Tue, 3 Jan 2017 16:34:47 -0800 > This patch series fixes how we pad the packets submitted to the SYSTEMPORT > adapter, and how the transmit status block (prepended 8 bytes) fits in the > picture. The first patch is not technically a bug fix, but is required for the >

Re: [PATCH net-next v2] net: dsa: remove out label in dsa_switch_setup_one

2017-01-04 Thread David Miller
From: Vivien Didelot Date: Tue, 3 Jan 2017 14:31:49 -0500 > The "out" label in dsa_switch_setup_one() is useless, thus remove it. > > Reviewed-by: Andrew Lunn > Signed-off-by: Vivien Didelot Applied.

Re: [PATCH net-next] liquidio: remove PTP support in 23XX adapters

2017-01-04 Thread David Miller
From: Felix Manlunas Date: Tue, 3 Jan 2017 11:27:33 -0800 > From: Prasad Kanneganti > > liquidio driver incorrectly indicates that PTP is supported in 23XX > adapters; this patch fixes that. PTP is supported in 66XX and 68XX > adapters, and the driver correctly indicates that. > > Signed-off-

Re: [PATCH net] libcxgb: fix error check for ip6_route_output()

2017-01-04 Thread David Miller
From: Varun Prakash Date: Tue, 3 Jan 2017 21:25:48 +0530 > ip6_route_output() never returns NULL so > check dst->error instead of !dst. > > Signed-off-by: Varun Prakash Applied, thanks.

Re: [PATCH] LiquidIO VF: s/select/imply/ for PTP_1588_CLOCK

2017-01-04 Thread David Miller
From: Nicolas Pitre Date: Tue, 3 Jan 2017 13:57:00 -0500 (EST) > Fix a minor fallout from the merge of the timers and the networking > trees. The following error may result if the PTP_1588_CLOCK > prerequisites are not available: > > drivers/built-in.o: In function `ptp_clock_unregister': > (.

Re: [PATCH] scm: remove use CMSG{_COMPAT}_ALIGN(sizeof(struct {compat_}cmsghdr))

2017-01-04 Thread David Miller
From: yuan linyu Date: Tue, 3 Jan 2017 20:42:17 +0800 > From: yuan linyu > > sizeof(struct cmsghdr) and sizeof(struct compat_cmsghdr) already aligned. > remove use CMSG_ALIGN(sizeof(struct cmsghdr)) and > CMSG_COMPAT_ALIGN(sizeof(struct compat_cmsghdr)) keep code consistent. > > Signed-off-by

Re: [PATCH v2 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter

2017-01-04 Thread Shuah Khan
Hi Sowmini, Thanks for the patch. On 01/04/2017 10:33 AM, Sowmini Varadhan wrote: > The bpf_prog used in sock_setfilter() only attempts to check for > ip pktlen, and verifies that the contents of the 80'th packet in > the ethernet frame is 'a' or 'b'. Thus many non-udp packets > could incorrectl

Re: [PATCH 1/1] net: usb: asix_devices: add .reset_resume for USB PM

2017-01-04 Thread David Miller
From: Peter Chen Date: Tue, 3 Jan 2017 17:22:20 +0800 > The USB core may call reset_resume when it fails to resume asix device. > And USB core can recovery this abnormal resume at low level driver, > the same .resume at asix driver can work too. Add .reset_resume can > avoid disconnecting after b

Re: [PATCH net] openvswitch: upcall: Fix vlan handling.

2017-01-04 Thread Jiri Benc
On Mon, 26 Dec 2016 08:31:27 -0800, Pravin B Shelar wrote: > Networking stack accelerate vlan tag handling by > keeping topmost vlan header in skb. This works as > long as packet remains in OVS datapath. But during > OVS upcall vlan header is pushed on to the packet. > When such packet is sent back

[PATCH v2 net-next 2/2] tools: psock_tpacket: block Rx until socket filter has been added and socket has been bound to loopback.

2017-01-04 Thread Sowmini Varadhan
Packets from any/all interfaces may be queued up on the PF_PACKET socket before it is bound to the loopback interface by psock_tpacket, and when these are passed up by the kernel, they could interfere with the Rx tests. Avoid interference from spurious packet by blocking Rx until the socket filter

[PATCH v2 net-next 0/2] tools: psock_tpacket bug fixes

2017-01-04 Thread Sowmini Varadhan
This patchset includes fixes to psock_tpacket for false-negatives sporadically reported by the test when it was run concurrently with other heavy network traffic (e.g., over an ssh session, as opposed to running the test from the console of the test machine). The test sometimes failed with errors r

[PATCH v2 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter

2017-01-04 Thread Sowmini Varadhan
The bpf_prog used in sock_setfilter() only attempts to check for ip pktlen, and verifies that the contents of the 80'th packet in the ethernet frame is 'a' or 'b'. Thus many non-udp packets could incorrectly pass through this filter and cause incorrect test results. This commit hardens the condit

Re: [PATCH] MIPS: NI 169445 board support

2017-01-04 Thread Nathan Sullivan
On Tue, Dec 20, 2016 at 05:34:34PM +0100, Ralf Baechle wrote: > On Fri, Dec 02, 2016 at 09:42:09AM -0600, Nathan Sullivan wrote: > > Date: Fri, 2 Dec 2016 09:42:09 -0600 > > From: Nathan Sullivan > > To: r...@linux-mips.org, mark.rutl...@arm.com, robh...@kernel.org > > CC: linux-m...@linux-mips.

Re: [PATCH] ethtool: add one ethtool option to set relax ordering mode

2017-01-04 Thread Alexander Duyck
On Wed, Jan 4, 2017 at 1:02 AM, maowenan wrote: > > >> -Original Message- >> From: maowenan >> Sent: Monday, December 26, 2016 4:33 PM >> To: maowenan; 'Alexander Duyck' >> Cc: 'Jeff Kirsher'; 'Stephen Hemminger'; 'netdev@vger.kernel.org'; weiyongjun >> (A); Dingtianhong; Wangzhou (B) >> S

Re: [PATCH v3 3/3] stmmac: adding new glue driver dwmac-dwc-qos-eth

2017-01-04 Thread Joao Pinto
Às 4:31 PM de 1/4/2017, Niklas Cassel escreveu: > I think you accidentally removed the Reviewed-by from Lars. I took it off because the driver was changed after the first review (v1->v2). Lars, could you please confirm that everything is fine for you? Thanks. > > On 01/04/2017 05:22 PM, Joao Pi

Re: [PATCH v3 3/3] stmmac: adding new glue driver dwmac-dwc-qos-eth

2017-01-04 Thread Niklas Cassel
I think you accidentally removed the Reviewed-by from Lars. On 01/04/2017 05:22 PM, Joao Pinto wrote: > This patch adds a new glue driver called dwmac-dwc-qos-eth which > was based in the dwc_eth_qos as is. To assure retro-compatibility a slight > tweak was also added to stmmac_platform. > > Signe

[SIDE DISCUSSION] Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-04 Thread Matthias May
On 04/01/17 17:16, Andrew Lunn wrote: >> The setup is as follows: >> mv88e6321: >> * ports 0+1 connected to fibre-optics transceivers at fixed 100 Mbps >> * port 4 is CPU port >> * custom phy driver (replacement for marvell.ko) only populated with >> * .config_init to >> * set fixed speed for

Re: [PATCH net-next 2/2] tools: psock_tpacket: verify that packet was received on lo before counting it

2017-01-04 Thread Willem de Bruijn
On Wed, Jan 4, 2017 at 11:12 AM, Sowmini Varadhan wrote: > On (01/04/17 11:07), Willem de Bruijn wrote: >> >> Please do. Then the patch is just a one-line change to >> the third argument of the socket call. Thanks! > > ok but it's going to be more than a one-line change. Today you > have >

Re: [PATCH net-next 2/2] tools: psock_tpacket: verify that packet was received on lo before counting it

2017-01-04 Thread Sowmini Varadhan
On (01/04/17 11:24), Willem de Bruijn wrote: > > Oh, good point. It may require some more refactoring. Feel free to > leave it for me if you prefer. actually it may not be so bad, let me do it, since I already have a reliable way of reproducing this.. --Sowmini

[PATCH net-next v2] tcp: provide timestamps for partial writes

2017-01-04 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh For TCP sockets, TX timestamps are only captured when the user data is successfully and fully written to the socket. In many cases, however, TCP writes can be partial for which no timestamp is collected. Collect timestamps whenever any user data is (fully or partially

Re: [PATCH v3 2/3] stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to platform structure

2017-01-04 Thread Niklas Cassel
Tested-by: Niklas Cassel On 01/04/2017 05:22 PM, Joao Pinto wrote: > This patch moves stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to the > plat_stmmacenet_data structure. It also moves these platform variables > initialization to stmmac_platform. This was done for two reasons: > > a) If PCI is u

Re: [PATCH v3 1/3] stmmac: adding DT parameter for LPI tx clock gating

2017-01-04 Thread Niklas Cassel
Tested-by: Niklas Cassel On 01/04/2017 05:22 PM, Joao Pinto wrote: > This patch adds a new parameter to the stmmac DT: snps,en-tx-lpi-clockgating. > It was ported from synopsys/dwc_eth_qos.c and it is useful if lpi tx clock > gating is needed by stmmac users also. > > Signed-off-by: Joao Pinto >

Re: [PATCH v3 3/3] stmmac: adding new glue driver dwmac-dwc-qos-eth

2017-01-04 Thread Niklas Cassel
Tested-by: Niklas Cassel On 01/04/2017 05:22 PM, Joao Pinto wrote: > This patch adds a new glue driver called dwmac-dwc-qos-eth which > was based in the dwc_eth_qos as is. To assure retro-compatibility a slight > tweak was also added to stmmac_platform. > > Signed-off-by: Joao Pinto > --- > chan

[PATCH v3 2/3] stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to platform structure

2017-01-04 Thread Joao Pinto
This patch moves stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to the plat_stmmacenet_data structure. It also moves these platform variables initialization to stmmac_platform. This was done for two reasons: a) If PCI is used, platform related code is being executed in stmmac_main resulting in warni

[PATCH v3 1/3] stmmac: adding DT parameter for LPI tx clock gating

2017-01-04 Thread Joao Pinto
This patch adds a new parameter to the stmmac DT: snps,en-tx-lpi-clockgating. It was ported from synopsys/dwc_eth_qos.c and it is useful if lpi tx clock gating is needed by stmmac users also. Signed-off-by: Joao Pinto --- changes v1 -> v3: - Nothing changed, just to keep up patch set version Do

[PATCH v3 3/3] stmmac: adding new glue driver dwmac-dwc-qos-eth

2017-01-04 Thread Joao Pinto
This patch adds a new glue driver called dwmac-dwc-qos-eth which was based in the dwc_eth_qos as is. To assure retro-compatibility a slight tweak was also added to stmmac_platform. Signed-off-by: Joao Pinto --- changes v2 -> v3: - Nothing changed, just to keep up patch set version changes v1 -> v

[PATCH v3 0/3] adding new glue driver dwmac-dwc-qos-eth

2017-01-04 Thread Joao Pinto
This patch set contains the porting of the synopsys/dwc_eth_qos.c driver to the stmmac structure. This operation resulted in the creation of a new platform glue driver called dwmac-dwc-qos-eth which was based in the dwc_eth_qos as is. dwmac-dwc-qos-eth inherited dwc_eth_qos DT bindings, to assure

Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-04 Thread Andrew Lunn
> The setup is as follows: > mv88e6321: > * ports 0+1 connected to fibre-optics transceivers at fixed 100 Mbps > * port 4 is CPU port > * custom phy driver (replacement for marvell.ko) only populated with > * .config_init to > * set fixed speed for ports 0+1 (when in FO mode) > * run genp

RE: [PATCH 2/2] PCI: lock each enable/disable num_vfs operation in sysfs

2017-01-04 Thread Tantilov, Emil S
>-Original Message- >From: Gavin Shan [mailto:gws...@linux.vnet.ibm.com] >Sent: Tuesday, January 03, 2017 6:16 PM >To: Tantilov, Emil S >Cc: linux-...@vger.kernel.org; intel-wired-...@lists.osuosl.org; Duyck, >Alexander H ; netdev@vger.kernel.org; linux- >ker...@vger.kernel.org >Subject: R

Re: [PATCH net-next 2/2] tools: psock_tpacket: verify that packet was received on lo before counting it

2017-01-04 Thread Sowmini Varadhan
On (01/04/17 11:07), Willem de Bruijn wrote: > > Please do. Then the patch is just a one-line change to > the third argument of the socket call. Thanks! ok but it's going to be more than a one-line change. Today you have sock = pfsocket(version); memset(&ring, 0, sizeof(ring));

Re: [PATCH] phy state machine: failsafe leave invalid RUNNING state

2017-01-04 Thread Zefir Kurtisi
On 01/04/2017 04:30 PM, Florian Fainelli wrote: > > > On 01/04/2017 07:27 AM, Zefir Kurtisi wrote: >> On 01/04/2017 04:13 PM, Florian Fainelli wrote: >>> >>> >>> On 01/04/2017 07:04 AM, Zefir Kurtisi wrote: While in RUNNING state, phy_state_machine() checks for link changes by comparing

  1   2   >