On 01/04/2017 03:55 PM, Sowmini Varadhan wrote: > On (01/04/17 15:37), Shuah Khan wrote: >>> + /* the filter below checks for all of the following conditions that >>> + * are based on the contents of create_payload() >>> + * ether type 0x800 and >>> + * ip proto udp and >>> + * ip len == ip_len and >>> + * udp[38] == 'a' or udp[38] == 'b' >>> + */ >> >> Looks like you have to do v4 anyway, please make sure your comment >> block is one of the acceptable formats based on coding style: >> >> https://marc.info/?l=linux-crypto-vger&m=146799837129319&w=2 > > BTW, the above is conformant with the comment style required for > networking: > > https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt > > which seems to be used in psock_fanout.c and reuseport_bpf.c as well.
I would like to see the comment blocks in selftest consistent with the Kernel coding style. > > Thanks > --Sowmini > Could you please split this patch into two. Hardening part in one and the cleanup in a separate patch. This way I can get the hardening fix into 4.10 in my next Kselftest update. Cleanup patch can go in later. thanks, -- Shuah
