Re: [RFC PATCH v2] packet: remove handling of tx_ring

2015-06-21 Thread Maninder Singh
Hi Frans, >> v1 = replace if()/BUG with BUG_ON() for tx_ring. >> >> v2 = > >I would keep this below the ---. There's little historical use for >this version information when it gets merged. > >> remove handling of tx_ring in prb_setup_retire_blk_timer >> for TPACKET_V3 because init_prb_bdqc is cal

Re: [PATCH] lib: test_bpf: purge CPP register redefinitions

2015-06-21 Thread Richard Weinberger
Am 22.06.2015 um 08:05 schrieb Alexei Starovoitov: > to get rid of warning you proposing to do 1k line renames?! > Just add: > +#undef R8 > +#undef R9 > +#undef R10 > #define R0 BPF_REG_0 This would be also just another hack. > Though I think the better fix woud be to clean up: > arc

Re: [PATCH] stmmac: explicitly zero des0 & des1 on init

2015-06-21 Thread Alexey Brodkin
Hi David, On Sun, 2015-06-21 at 09:29 -0700, David Miller wrote: > From: Alexey Brodkin > Date: Tue, 16 Jun 2015 20:40:41 +0300 > > > Current implementtion of descriptor init procedure only takes care > > about > > ownership flag. While it is perfectly possible to have underlying > > memory >

Re: [RFC PATCH v2] packet: remove handling of tx_ring

2015-06-21 Thread Frans Klaver
On Mon, Jun 22, 2015 at 7:54 AM, Maninder Singh wrote: > v1 = replace if()/BUG with BUG_ON() for tx_ring. > > v2 = I would keep this below the ---. There's little historical use for this version information when it gets merged. > remove handling of tx_ring in prb_setup_retire_blk_timer > for TPA

Re: [PATCH] ipv6: Fixed source specific default route handling.

2015-06-21 Thread Steven Barth
On 22.06.2015 00:35, Matthias Schiffer wrote: > Could you explain in detail what you mean with "If you want specific SA, > add same route with higher metric and/or (more) specific src match."? > Routes aren't bound to specific addresses except via the "src" attribute > (which is called prefsrc in t

Re: [PATCH] lib: test_bpf: purge CPP register redefinitions

2015-06-21 Thread Alexei Starovoitov
On Sun, Jun 21, 2015 at 09:41:03PM +0200, Nicolai Stange wrote: > Fix compilation failer with allmodconfig on ARCH=um: > lib/test_bpf.c:50:0: warning: "R8" redefined >#define R8 BPF_REG_8 >^ > In file included from arch/um/include/asm/ptrace-generic.h:11:0, >from ar

[RFC PATCH v2] packet: remove handling of tx_ring

2015-06-21 Thread Maninder Singh
v1 = replace if()/BUG with BUG_ON() for tx_ring. v2 = remove handling of tx_ring in prb_setup_retire_blk_timer for TPACKET_V3 because init_prb_bdqc is called only for NULL tx_ring and thus prb_setup_retire_blk_timer for NULL tx_ring only. And also in funciton init_prb_bdqc there is no usage of t

RE: [PATCH net-next] Modify Liquidio Kconfig for crc lib

2015-06-21 Thread Vatsavayi, Raghu
Thanks Much Dave. Regards Raghu > -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Sunday, June 21, 2015 9:52 AM > To: Vatsavayi, Raghu > Cc: netdev@vger.kernel.org; valentinrothb...@gmail.com; Chickles, Derek; > Burla, Satananda; Manlunas, Felix; Vatsavayi,

Re: [PATCH ipv6 0/1] ipv6: addrconf: routes are not deleted if last ipv6 address is removed

2015-06-21 Thread GMAIL
On Thursday 18 June 2015 04:53 PM, Hannes Frederic Sowa wrote: On Thu, 2015-06-18 at 14:59 +0530, Mazhar Rana wrote: Hi, After 'commit 876fd05ddbae03166e7037fca957b55bb3be6594 ("ipv6: don't disable interface if last ipv6 address is removed")' it is not clearing ipv6 interface configurations(rou

Re: [PATCH 1/1] ssb: remove unncessary out label

2015-06-21 Thread Maninder Singh
Hi Michael, >> pdev = bus->host_pci; >> mutex_init(&bus->sprom_mutex); >> -err = device_create_file(&pdev->dev, &dev_attr_ssb_sprom); >> -if (err) >> -goto out; >> - >> -out: >> -return err; >> +return device_create_file(&pdev->dev, &dev_attr_ssb_sprom); >> }

linux-next: manual merge of the net-next tree with the net tree

2015-06-21 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/packet/af_packet.c between commit: 468479e6043c ("packet: avoid out of bounds read in round robin fanout") from the net tree and commit: 3b3a5b0aab5b ("packet: rollover huge flows before small flows") from the

Re: [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels

2015-06-21 Thread roopa
On 6/21/15, 1:40 PM, Thomas Graf wrote: On 06/20/15 at 07:27am, roopa wrote: On 6/19/15, 11:39 AM, Robert Shearman wrote: Sorry for not being clear, but I meant that there would have to be lwtunnel_skb_lwstate functions for ipv4 and ipv6 to match the output functions. So in the vxlan use case

Re: [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels

2015-06-21 Thread roopa
On 6/21/15, 1:32 PM, Thomas Graf wrote: On 06/18/15 at 09:49pm, Roopa Prabhu wrote: +#include +#include + +#define LWTUNNEL_HASH_BITS 7 +#define LWTUNNEL_HASH_SIZE (1 << LWTUNNEL_HASH_BITS) + +struct lwtunnel_hdr { + int len; + __u8data[0]; +}; The name

Re: [PATCH net-next RFC v2 3/3] mpls: support for ip tunnels

2015-06-21 Thread roopa
On 6/21/15, 1:27 PM, Thomas Graf wrote: On 06/18/15 at 09:49pm, Roopa Prabhu wrote: diff --git a/net/mpls/Kconfig b/net/mpls/Kconfig index 17bde79..3e87a6b 100644 --- a/net/mpls/Kconfig +++ b/net/mpls/Kconfig @@ -27,4 +27,9 @@ config MPLS_ROUTING help Add support for forwarding

Re: [PATCH net-next RFC v2 2/3] ipv4: add support for light weight tunnel encap attributes

2015-06-21 Thread roopa
On 6/21/15, 1:20 PM, Thomas Graf wrote: On 06/18/15 at 09:49pm, Roopa Prabhu wrote: From: Roopa Prabhu Introduces two netlink attributes RTA_ENCAP_TYPE and RTA_ENCAP to support attaching encap information to ipv4 routes. RTA_ENCAP is a nested attribute as suggested by Thomas (and also as Robe

Re: [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels

2015-06-21 Thread roopa
On 6/20/15, 9:38 AM, Nikolay Aleksandrov wrote: <<>> diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c new file mode 100644 index 000..29c7802 --- /dev/null +++ b/net/core/lwtunnel.c @@ -0,0 +1,162 @@ +/* + * lwtunnelInfrastructure for light weight tunnels like mpls + * + * + *

Re: [PATCH] ipv6: Fixed source specific default route handling.

2015-06-21 Thread Markus Stenberg
You have /128 dst. To override it you need dst/128 AND src/>0 route. ( or just /128 dst and higher metric). Sorry if I am bit unclear - can explain better given real keyboard but that is avail only week from now. -Markus (on the road, via iPhone) 21.6.2015 23.35、Matthias Schiffer のメッセージ:

Re: [PATCH] ipv6: Fixed source specific default route handling.

2015-06-21 Thread Matthias Schiffer
On 06/22/2015 12:05 AM, Markus Stenberg wrote: > Prefsrc is essentially historic non IPv6 construct. IPv6 SAS is based on dst, > src, metric ordered lookup just like the routing is too ( lookup rfc, some > src specific routing drafts for details ). > > Therefore I do not see a problem. If you w

Re: [PATCH] ipv6: Fixed source specific default route handling.

2015-06-21 Thread Markus Stenberg
Prefsrc is essentially historic non IPv6 construct. IPv6 SAS is based on dst, src, metric ordered lookup just like the routing is too ( lookup rfc, some src specific routing drafts for details ). Therefore I do not see a problem. If you want specific SA, add same route with higher metric and/o

Re: [PATCH net-next 05/12] net/mlx5e: Poll rx cq before tx cq to improve round-trip latency

2015-06-21 Thread achiad shochat
Hello Dave, In mlx5 the RX processing is broken down into two stages: 1) Hand to kernel SKBs of completed RX packets - @mlx5e_poll_rx_cq() 2) Allocate and post to HW new RX buffers - @mlx5e_post_rx_wqes() Would handling of TX completions in between stages (1) and (2) be OK? On 21 June 2015 at 20

Re: [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels

2015-06-21 Thread Thomas Graf
On 06/20/15 at 07:27am, roopa wrote: > On 6/19/15, 11:39 AM, Robert Shearman wrote: > >On 19/06/15 19:34, roopa wrote: > >>On 6/19/15, 10:25 AM, Robert Shearman wrote: > >>>n 19/06/15 16:14, roopa wrote: > >>> > >>In the netdevice case, this output function is not called atall. It > >>should just f

Re: [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels

2015-06-21 Thread Thomas Graf
On 06/18/15 at 09:49pm, Roopa Prabhu wrote: > +#include > +#include > + > +#define LWTUNNEL_HASH_BITS 7 > +#define LWTUNNEL_HASH_SIZE (1 << LWTUNNEL_HASH_BITS) > + > +struct lwtunnel_hdr { > + int len; > + __u8data[0]; > +}; The name header is a bit misleading

[PATCH next] drivers/net: remove all references to obsolete Ethernet-HOWTO

2015-06-21 Thread Paul Gortmaker
This howto made sense in the 1990s when users had to manually configure ISA cards with jumpers or vendor utilities, but with the implementation of PCI it became increasingly less and less relevant, to the point where it has been well over a decade since I last updated it. And there is no value in

Re: [PATCH net-next RFC v2 3/3] mpls: support for ip tunnels

2015-06-21 Thread Thomas Graf
On 06/18/15 at 09:49pm, Roopa Prabhu wrote: > diff --git a/net/mpls/Kconfig b/net/mpls/Kconfig > index 17bde79..3e87a6b 100644 > --- a/net/mpls/Kconfig > +++ b/net/mpls/Kconfig > @@ -27,4 +27,9 @@ config MPLS_ROUTING > help >Add support for forwarding of mpls packets. > > +config MP

Re: [PATCHv2 net-next] net: fec: Ensure clocks are enabled while using mdio bus

2015-06-21 Thread Andrew Lunn
On Sat, Jun 20, 2015 at 06:01:33PM -0700, Florian Fainelli wrote: > Le 06/20/15 09:15, Andrew Lunn a écrit : > > When a switch is attached to the mdio bus, the mdio bus can be used > > while the interface is not open. If the IPG clock are not enabled, > > MDIO reads/writes will simply time out. So

Re: [PATCH net-next RFC v2 2/3] ipv4: add support for light weight tunnel encap attributes

2015-06-21 Thread Thomas Graf
On 06/18/15 at 09:49pm, Roopa Prabhu wrote: > From: Roopa Prabhu > > Introduces two netlink attributes RTA_ENCAP_TYPE and > RTA_ENCAP to support attaching encap information to ipv4 routes. > > RTA_ENCAP is a nested attribute as suggested by Thomas > (and also as Robert had it in his series). RTA

[PATCH v2 0/4] net: stmmac: dwmac-rk: add support for rk3368

2015-06-21 Thread Heiko Stuebner
Apart from small cleanups, this series provides support for the dwmac on the new rk3368 ARM64 soc. Tested on a R88 board using a RMII phy. Changes since v1: - Adapt to changes resulting from patch d42202dce002 ("net: stmmac: dwmac-rk: Don't add function name in info or err messages") Heiko Stue

[PATCH v2 1/4] net: stmmac: dwmac-rk: remove unused gpio register defines

2015-06-21 Thread Heiko Stuebner
In a first version the driver did want to do some gpio wiggling, which of course never made it into the kernel, but somehow these register defines where forgotten. Remove them, as they shouldn't be here. Signed-off-by: Heiko Stuebner --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 3 --- 1

[PATCH v2 3/4] net: stmmac: dwmac-rk: abstract access to mac settings in GRF

2015-06-21 Thread Heiko Stuebner
The mac settings like RGMII/RMII, speeds etc are done in the so called "General Register Files", contain numerous other settings as well and always seem to change between Rockchip SoCs. Therefore abstract the register accesses into a per-soc ops struct to make this reusable on other Rockchip SoCs.

[PATCH v2 4/4] net: stmmac: dwmac-rk: add rk3368-specific data

2015-06-21 Thread Heiko Stuebner
Add constants and callback functions for the dwmac on rk3368 socs. As can be seen, the base structure is the same, only registers and the bits in them moved slightly. Signed-off-by: Heiko Stuebner --- .../devicetree/bindings/net/rockchip-dwmac.txt | 2 +- drivers/net/ethernet/stmicro/stmma

[PATCH v2 2/4] net: stmmac: dwmac-rk: Fix clk rate when provided by soc

2015-06-21 Thread Heiko Stuebner
The first iteration of the dwmac-rk support did access an intermediate clock directly below the pll selector. This was removed in a subsequent revision, but the clock and one invocation remained. This results in the driver trying to set the rate of a non-existent clock when the soc and not some ext

[PATCH] lib: test_bpf: purge CPP register redefinitions

2015-06-21 Thread Nicolai Stange
Fix compilation failer with allmodconfig on ARCH=um: lib/test_bpf.c:50:0: warning: "R8" redefined #define R8 BPF_REG_8 ^ In file included from arch/um/include/asm/ptrace-generic.h:11:0, from arch/x86/um/asm/ptrace.h:8, from arch/x86/include/asm/alter

Re: [PATCH 1/2] batman-adv: Avoid u32 overflow during gateway select

2015-06-21 Thread Sven Eckelmann
On Sunday 21 June 2015 09:37:13 David Miller wrote: > From: Antonio Quartulli > Date: Tue, 16 Jun 2015 21:06:23 +0200 > > > @@ -133,7 +133,7 @@ batadv_gw_get_best_gw_node(struct batadv_priv > > *bat_priv)> > > struct batadv_neigh_node *router; > > struct batadv_neigh_ifinfo *router_ifinf

Re: [PATCH] isdn: disable HiSax NetJet driver on microblaze arch

2015-06-21 Thread Nicolai Stange
David Miller writes: >> Note that endianess on microblaze is not determined through Kconfig, >> but by means of a compiler provided CPP macro, namely __MICROBLAZEEL__. >> However, gcc defaults to big endianess on that platform. > Applied, but we're long overdue for an across-the-board-available >

Re: [PATCH] ipv6: Fixed source specific default route handling.

2015-06-21 Thread Matthias Schiffer
On 05/05/2015 12:36 PM, Markus Stenberg wrote: > If there are only IPv6 source specific default routes present, the > host gets -ENETUNREACH on e.g. connect() because ip6_dst_lookup_tail > calls ip6_route_output first, and given source address any, it fails, > and ip6_route_get_saddr is never calle

Re: [PATCH 0/4] net: stmmac: dwmac-rk: add support for rk3368

2015-06-21 Thread David Miller
From: Heiko Stuebner Date: Wed, 17 Jun 2015 23:54:42 +0200 > Apart from small cleanups, this series provides support for the dwmac > on the new rk3368 ARM64 soc. > > Tested on a R88 board using a RMII phy. These patches do not apply to the net-next tree, please respin and resubmit. Thanks. --

Re: [PATCH net-next 0/3] bna: clean-up 2

2015-06-21 Thread David Miller
From: Ivan Vecera Date: Wed, 17 Jun 2015 18:41:55 +0200 > Next round of cleaning patches. Series applied, thanks Ivan. -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH net v2] packet: avoid out of bounds read in round robin fanout

2015-06-21 Thread David Miller
From: Willem de Bruijn Date: Wed, 17 Jun 2015 15:59:34 -0400 > From: Willem de Bruijn > > PACKET_FANOUT_LB computes f->rr_cur such that it is modulo > f->num_members. It returns the old value unconditionally, but > f->num_members may have changed since the last store. Ensure > that the return v

Re: [PATCH net-next v2] ipv4: include NLM_F_APPEND flag in append route notifications

2015-06-21 Thread David Miller
From: roopa Date: Wed, 17 Jun 2015 13:37:23 -0700 > On 6/17/15, 11:30 AM, Scott Feldman wrote: >> On Wed, Jun 17, 2015 at 11:07 AM, Roopa Prabhu >> wrote: >>> From: Roopa Prabhu >>> >>> This patch adds NLM_F_APPEND flag to struct nlmsg_hdr->nlmsg_flags >>> in newroute notifications if the route

Re: [PATCH - regression 4.1-rc8] can: fix loss of CAN frames in raw_rcv

2015-06-21 Thread Oliver Hartkopp
On 21.06.2015 18:57, Marc Kleine-Budde wrote: I'll send a pullrequest to David asap, I'll add stable on Cc if this doesn't make it into v4.1 anymore. Thanks Marc! I sent it to netdev and Dave directly too as he was working on his backlog - and I was not sure if you are available until the n

Re: [PATCH net-next 05/12] net/mlx5e: Poll rx cq before tx cq to improve round-trip latency

2015-06-21 Thread David Miller
From: Or Gerlitz Date: Wed, 17 Jun 2015 18:26:22 +0300 > From: Achiad Shochat > > For better round trip latency, handle rx completions before > tx completions. > > Signed-off-by: Achiad Shochat > Signed-off-by: Saeed Mahameed > Signed-off-by: Or Gerlitz I completely disagree with this chan

[PATCH] can: fix loss of CAN frames in raw_rcv

2015-06-21 Thread Marc Kleine-Budde
From: Oliver Hartkopp As reported by Manfred Schlaegl here http://marc.info/?l=linux-netdev&m=143482089824232&w=2 commit 514ac99c64b "can: fix multiple delivery of a single CAN frame for overlapping CAN filters" requires the skb->tstamp to be set to check for identical CAN skbs. As net time

Re: [PATCH net-next] sock_diag: fetch source port from inet_sock

2015-06-21 Thread David Miller
From: Craig Gallek Date: Wed, 17 Jun 2015 10:59:10 -0400 > When an inet_sock is destroyed, its source port (sk_num) is set to > zero as part of the unhash procedure. In order to supply a source > port as part of the NETLINK_SOCK_DIAG socket destruction broadcasts, > the source port number must b

pull-request: can 2015-06-21

2015-06-21 Thread Marc Kleine-Budde
l/git/mkl/linux-can.git tags/linux-can-fixes-for-4.1-20150621 for you to fetch changes up to 36c01245eb8046c16eee6431e7dbfbb302635fa8: can: fix loss of CAN frames in raw_rcv (2015-06-21 18:58:58 +0200) linux-can-fixes-for-4.1-201

Re: [PATCH] mac80211: fix locking in update_vlan_tailroom_need_count()

2015-06-21 Thread David Miller
From: Johannes Berg Date: Wed, 17 Jun 2015 13:54:54 +0200 > From: Johannes Berg > > Unfortunately, Michal's change to fix AP_VLAN crypto tailroom > caused a locking issue that was reported by lockdep, but only > in a few cases - the issue was a classic ABBA deadlock caused > by taking the mtx a

Re: [PATCH - regression 4.1-rc8] can: fix loss of CAN frames in raw_rcv

2015-06-21 Thread Marc Kleine-Budde
On 06/21/2015 06:50 PM, Oliver Hartkopp wrote: > As reported by Manfred Schlaegl here > >http://marc.info/?l=linux-netdev&m=143482089824232&w=2 > > commit 514ac99c64b "can: fix multiple delivery of a single CAN frame for > overlapping CAN filters" requires the skb->tstamp to be set to check f

Re: [PATCH 2/2] net: via/Kconfig: replace USE_OF with OF_???

2015-06-21 Thread David Miller
From: Antonio Borneo Date: Wed, 17 Jun 2015 19:42:31 +0800 > USE_OF is used as intermediate Kconfig option by few > arch's (ARM, MIPS, Xtensa). > Replace instances of USE_OF outside of arch folders > with proper OF_???. > > Signed-off-by: Antonio Borneo Applied to net-next, thanks. -- To unsub

[PATCH - regression 4.1-rc8] can: fix loss of CAN frames in raw_rcv

2015-06-21 Thread Oliver Hartkopp
As reported by Manfred Schlaegl here http://marc.info/?l=linux-netdev&m=143482089824232&w=2 commit 514ac99c64b "can: fix multiple delivery of a single CAN frame for overlapping CAN filters" requires the skb->tstamp to be set to check for identical CAN skbs. As net timestamping is influenced b

Re: [PATCH] net: Update out-of-date comment

2015-06-21 Thread David Miller
From: Zhaowei Yuan Date: Wed, 17 Jun 2015 17:56:27 +0800 > Struct inet_proto no longer exists, so update the > comment which is out of date. > > Signed-off-by: Zhaowei Yuan Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH net-next] cxgb4: Add PCI device ID for custom T522 & T520 adapter

2015-06-21 Thread David Miller
From: Hariprasad Shenai Date: Wed, 17 Jun 2015 14:40:04 +0530 > Signed-off-by: Hariprasad Shenai Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH] net: Cavium: Bug fix: MAC address setting in shutdown state

2015-06-21 Thread David Miller
From: Pavel Fedin Date: Wed, 17 Jun 2015 10:35:14 +0300 > This bug pops up with NetworkManager on Fedora 21. NetworkManager tends to > stop the interface (nicvf_stop() is called) before changing settings. In > stopped state MAC cannot be sent to a PF. However, when the interface is > restarted (n

Re: [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON

2015-06-21 Thread David Miller
From: Frans Klaver Date: Wed, 17 Jun 2015 10:30:18 +0200 > Ah, that explains something. If retire timer is not going to be needed > for tx, wouldn't it be better to remove the whole tx_ring handling > from this function altogether, rather than changing the BUG()? Agreed. -- To unsubscribe from t

Re: [PATCH] isdn: disable HiSax NetJet driver on microblaze arch

2015-06-21 Thread David Miller
From: Nicolai Stange Date: Wed, 17 Jun 2015 03:05:02 +0200 > Fix an allmodconfig compilation failer on microblaze due to big endian > architectures being apparently unsupported by the NetJet code: > drivers/isdn/hisax/nj_s.c: In function 'setup_netjet_s': > drivers/isdn/hisax/nj_s.c:265:2: >

Re: [PATCH] cxgb3: avoid needless buffer copy for firmware

2015-06-21 Thread David Miller
From: Kees Cook Date: Tue, 16 Jun 2015 15:36:17 -0700 > There's no reason to perform a buffer copy for the firmware name. This > also avoids a (currently impossible with current callers) NULL dereference > if there was no matching firmware. > > Signed-off-by: Kees Cook Applied to net-next, tha

Re: [PATCH net-next] Modify Liquidio Kconfig for crc lib

2015-06-21 Thread David Miller
From: Raghu Vatsavayi Date: Tue, 16 Jun 2015 16:51:43 -0700 > Following patch contains changes in liquidio Kconfig for > selecting LIBCRC32C. > > Signed-off-by: Derek Chickles > Signed-off-by: Satanand Burla > Signed-off-by: Felix Manlunas > Signed-off-by: Raghu Vatsavayi Applied, thank you

Re: [PATCH RESEND] pkt_sched: sch_qfq: remove redundant -if- control statement

2015-06-21 Thread David Miller
From: Andrea Parri Date: Wed, 17 Jun 2015 00:16:59 +0200 > The control !hlist_unhashed() in qfq_destroy_agg() is unnecessary > because already performed in hlist_del_init(), so remove it. > > Signed-off-by: Andrea Parri Applied. -- To unsubscribe from this list: send the line "unsubscribe netd

Re: [PATCH RFC net] neigh: do not modify unlinked entries

2015-06-21 Thread David Miller
From: Julian Anastasov Date: Tue, 16 Jun 2015 22:56:39 +0300 > The lockless lookups can return entry that is unlinked. > Sometimes they get reference before last neigh_cleanup_and_release, > sometimes they do not need reference. Later, any > modification attempts may result in the following probl

Re: [PATCH v4 1/3] net/xen-netfront: Correct printf format in xennet_get_responses

2015-06-21 Thread David Miller
From: Julien Grall Date: Tue, 16 Jun 2015 20:10:46 +0100 > rx->status is an int16_t, print it using %d rather than %u in order to > have a meaningful value when the field is negative. > > Also use %u rather than %x for rx->offset. > > Signed-off-by: Julien Grall > Reviewed-by: David Vrabel A

Re: [PATCH v4 2/3] net/xen-netback: Remove unused code in xenvif_rx_action

2015-06-21 Thread David Miller
From: Julien Grall Date: Tue, 16 Jun 2015 20:10:47 +0100 > The variables old_req_cons and ring_slots_used are assigned but never > used since commit 1650d5455bd2dc6b5ee134bd6fc1a3236c266b5b "xen-netback: > always fully coalesce guest Rx packets". > > Signed-off-by: Julien Grall > Acked-by: Wei

Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format

2015-06-21 Thread David Miller
From: Julien Grall Date: Tue, 16 Jun 2015 20:10:48 +0100 > Append 0x to all %x in order to avoid while reading when there is other > decimal value in the log. > > Also replace some of the hexadecimal print to decimal to uniformize the > format with netfront. > > Signed-off-by: Julien Grall Ap

Re: [PATCH 1/2] batman-adv: Avoid u32 overflow during gateway select

2015-06-21 Thread David Miller
From: Antonio Quartulli Date: Tue, 16 Jun 2015 21:06:23 +0200 > @@ -133,7 +133,7 @@ batadv_gw_get_best_gw_node(struct batadv_priv *bat_priv) > struct batadv_neigh_node *router; > struct batadv_neigh_ifinfo *router_ifinfo; > struct batadv_gw_node *gw_node, *curr_gw = NULL; > -

Re: [PATCH V2 net-next] net: rds: use for_each_sg() for scatterlist parsing

2015-06-21 Thread David Miller
From: Fabian Frederick Date: Tue, 16 Jun 2015 20:44:07 +0200 > This patch also renames sg to sglist and aligns function parameters. > See Documentation/DMA-API.txt - Part Id for scatterlist details > > Signed-off-by: Fabian Frederick > --- > This is untested. > V2: reorder variables (suggested

Re: [PATCH net-next] packet: free packet_rollover after synchronize_net

2015-06-21 Thread David Miller
From: Willem de Bruijn Date: Tue, 16 Jun 2015 12:51:37 -0400 > From: Willem de Bruijn > > Destruction of the po->rollover must be delayed until there are no > more packets in flight that can access it. The field is destroyed in > packet_release, before synchronize_net. Delay using rcu. > > Fix

Re: [PATCH] stmmac: explicitly zero des0 & des1 on init

2015-06-21 Thread David Miller
From: Alexey Brodkin Date: Tue, 16 Jun 2015 20:40:41 +0300 > Current implementtion of descriptor init procedure only takes care about > ownership flag. While it is perfectly possible to have underlying memory > filled with garbage on boot or driver installation. > > And randomly set flags in non

Re: [PATCH net] packet: read num_members once in packet_rcv_fanout()

2015-06-21 Thread David Miller
From: Eric Dumazet Date: Tue, 16 Jun 2015 07:59:11 -0700 > From: Eric Dumazet > > We need to tell compiler it must not read f->num_members multiple > times. Otherwise testing if num is not zero is flaky, and we could > attempt an invalid divide by 0 in fanout_demux_cpu() > > Note bug was prese

Re: [PATCH v5] NET: Add ezchip ethernet driver

2015-06-21 Thread David Miller
From: Noam Camus Date: Tue, 16 Jun 2015 17:35:42 +0300 > From: Noam Camus > > Simple LAN device for debug or management purposes. > Device supports interrupts for RX and TX(completion). > Device does not have DMA ability. > > Signed-off-by: Noam Camus > Signed-off-by: Tal Zilcer > Acked-by:

Re: [PATCH 07/11] IB/cma: Helper functions to access port space IDRs

2015-06-21 Thread Haggai Eran
On 16/06/2015 01:36, Hefty, Sean wrote: >> Add helper functions to access the IDRs by port-space and port number. >> >> Pass around the port-space enum in cma.c instead of using pointers to >> port-space IDRs. > > What is the motivation for this change? In the next patch ("IB/cma: Add net_dev and

Re: [PATCH] net: inet_diag: export IPV6_V6ONLY sockopt

2015-06-21 Thread Eric Dumazet
On Sun, 2015-06-21 at 03:47 +0200, Phil Sutter wrote: > > > 1) This certainly should not compile on current linux trees. > >Always submit such patches on net-next. > > It cleanly applies to net.git. A very old one, because there is no ipv6only field anymore after commit 9fe516ba3fb29b6f6a75