Hello Dave, In mlx5 the RX processing is broken down into two stages: 1) Hand to kernel SKBs of completed RX packets - @mlx5e_poll_rx_cq() 2) Allocate and post to HW new RX buffers - @mlx5e_post_rx_wqes()
Would handling of TX completions in between stages (1) and (2) be OK? On 21 June 2015 at 20:21, David Miller <da...@davemloft.net> wrote: > From: Or Gerlitz <ogerl...@mellanox.com> > Date: Wed, 17 Jun 2015 18:26:22 +0300 > >> From: Achiad Shochat <ach...@mellanox.com> >> >> For better round trip latency, handle rx completions before >> tx completions. >> >> Signed-off-by: Achiad Shochat <ach...@mellanox.com> >> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> >> Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> > > I completely disagree with this change. > > TX completions should always be handled first because they free up resources > and therefore increase the likelyhood that RX processing will not fail due > to lack of resources (memory, etc.). > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in -- To unsubscribe from this list: send the line "unsubscribe netdev" in
