On Sun, 2015-06-21 at 03:47 +0200, Phil Sutter wrote: > > > 1) This certainly should not compile on current linux trees. > > Always submit such patches on net-next. > > It cleanly applies to net.git.
A very old one, because there is no ipv6only field anymore after commit 9fe516ba3fb29b6f6a752ffd93342fdee500ec01 ("inet: move ipv6only in sock_common") back in linux 3.17 inet6_sk(sk)->ipv6only can not possibly compile today, I am pretty sure of this. # git grep -n ipv6only -- include include/linux/ipv6.h:285:#define __ipv6_only_sock(sk) (sk->sk_ipv6only) include/linux/ipv6.h:297:static inline int inet_v6_ipv6only(const struct sock *sk) include/linux/ipv6.h:299: /* ipv6only field is at same position for timewait and other sockets */ include/linux/ipv6.h:324:#define tcp_twsk_ipv6only(__sk) 0 include/linux/ipv6.h:325:#define inet_v6_ipv6only(__sk) 0 include/net/inet_timewait_sock.h:58:#define tw_ipv6only __tw_common.skc_ipv6only include/net/sock.h:186: unsigned char skc_ipv6only:1; include/net/sock.h:325:#define sk_ipv6only __sk_common.skc_ipv6only So always make sure your tree is not one year old before submitting a patch. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in