Hi Michael, >> pdev = bus->host_pci; >> mutex_init(&bus->sprom_mutex); >> - err = device_create_file(&pdev->dev, &dev_attr_ssb_sprom); >> - if (err) >> - goto out; >> - >> -out: >> - return err; >> + return device_create_file(&pdev->dev, &dev_attr_ssb_sprom); >> } > > >I don't really think this change adds any value, but if you insist on >it you get my acked-by.
Yes You are right, But By this change code looks simpler. Thats why i suggested the changes. Thanks Maninder
