> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more
> iterations before integrating.
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I menti
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more iterations before integrating.
>
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I menti
On Wed, 21 Oct 2020 09:20:47 GMT, Chris Hegarty wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> further test update from Daniel
>
> test/jdk/java/net/UnixDomainSocketAddress/Len
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more iterations before integrating.
>
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I menti
On Wed, 21 Oct 2020 16:38:16 GMT, Chris Hegarty wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more iterations before integrating.
>
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I menti
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more iterations before integrating.
>
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I menti
On Fri, 23 Oct 2020 03:18:27 GMT, Eric Liu
wrote:
> A small improvement to avoid extra string copy.
>
> [Tests]
> Jtreg hotspot::hotspot_all_no_apps, jdk::jdk_core and langtools::tier1.
> No new failure found.
src/java.base/unix/native/libnet/NetworkInterface.c line 232:
> 230: // if it i
On Fri, 23 Oct 2020 03:18:27 GMT, Eric Liu
wrote:
> A small improvement to avoid extra string copy.
>
> [Tests]
> Jtreg hotspot::hotspot_all_no_apps, jdk::jdk_core and langtools::tier1.
> No new failure found.
LGTM
-
Marked as reviewed by michaelm (Reviewer).
PR: https://git.ope
On Sat, 24 Oct 2020 08:12:57 GMT, Alan Bateman wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> - fixed 32 bit Linux build error
>> - test updates from Chris
>
> src/
On Mon, 7 Sep 2020 12:05:07 GMT, Michael McMahon wrote:
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more iterations before integrating.
>
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Mic
…nnelConnectionSetup.java UnixSocketChannelReadWrite.java
-
Commit messages:
- 825: Bad copyright headers in SocketChannelCompare.java
SocketChannelConnectionSetup.java UnixSocketChannelReadWrite.java
Changes: https://git.openjdk.java.net/jdk/pull/912/files
Webrev: https://web
On Wed, 28 Oct 2020 18:48:51 GMT, Michael McMahon wrote:
> …nnelConnectionSetup.java UnixSocketChannelReadWrite.java
This pull request has now been integrated.
Changeset: 3f20612e
Author: Michael McMahon
URL: https://git.openjdk.java.net/jdk/commit/3f20612e
Stats: 3 lines i
On Tue, 3 Nov 2020 09:42:05 GMT, Daniel Fuchs wrote:
>> I'm not sure, as the system properties don't affect implicit binding, but I
>> would have liked to have a place to "explain" all aspects of binding of Unix
>> domain sockets/server-sockets. Maybe, I could add a paragraph at the end,
>> ju
On Tue, 3 Nov 2020 09:09:18 GMT, Daniel Fuchs wrote:
>> Minor spec changes from spec approved in initial CSR
>
> src/java.base/share/classes/java/net/doc-files/net-properties.html line 246:
>
>> 244: Unix domain sockets
>> 245: There are a number of system (and networking) properties that affect
On Tue, 3 Nov 2020 09:25:52 GMT, Michael McMahon wrote:
>> src/java.base/share/classes/java/net/doc-files/net-properties.html line 250:
>>
>>> 248: Automatic binding of a server socket occurs when {@link
>>> 249: java.nio.channels.ServerSocket
Minor spec changes from spec approved in initial CSR
-
Commit messages:
- update to net-properties.html
- 8255758: JEP 380 spec clarifications
Changes: https://git.openjdk.java.net/jdk/pull/1021/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1021&range=00
Issue: htt
On Fri, 6 Nov 2020 18:09:01 GMT, Patrick Concannon
wrote:
>> Marked as reviewed by chegar (Reviewer).
>
>> /csr
>
> Link to CSR: https://bugs.openjdk.java.net/browse/JDK-8255993
I wonder if the spec should be a little more specific than just "seeded" which
I think is fine for the first senten
On Wed, 11 Nov 2020 16:45:49 GMT, Daniel Fuchs wrote:
> The HTTP/1.1 Header Parser of the new HttpClient currently assumes that all
> headers (names and value) are US-ASCII and as a result mis-decode any byte
> whose value is > 127; For instance, 0x80 (128) gets decoded as a U+FF80
> (65408) i
> Minor spec changes from spec approved in initial CSR
Michael McMahon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains five additional
commits si
On Sun, 15 Nov 2020 08:32:28 GMT, Alan Bateman wrote:
> The clarification to the SecurityException looks good.
>
> The API docs specify that bind(null) will "bind to an automatically assigned
> socket address". Would it be better to lead with that phrase in the
> properties doc rather than swi
On Mon, 16 Nov 2020 14:42:02 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
> Minor spec changes from spec approved in initial CSR
Michael McMahon has updated the pull request incrementally with two additional
commits since the last revision:
- update from Alan's comment Nov 17
- minor change suggested by Daniel
-
Changes:
- al
On Tue, 17 Nov 2020 11:25:22 GMT, Alan Bateman wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Mon, 2 Nov 2020 22:04:56 GMT, Michael McMahon wrote:
> Minor spec changes from spec approved in initial CSR
This pull request has now been integrated.
Changeset: 9d0ee66f
Author: Michael McMahon
URL: https://git.openjdk.java.net/jdk/commit/9d0ee66f
Stats: 70 lines in 3 fi
On Mon, 16 Nov 2020 15:54:18 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review our code for JDK-8252304: 'Seed an
>> HttpRequest.Builder from an existing HttpRequest'?
>>
>> This RFR proposes a new factory method for creating a new `HttpRequest`
>> builder from an existi
On Wed, 18 Nov 2020 17:45:25 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review our code for JDK-8252304: 'Seed an
>> HttpRequest.Builder from an existing HttpRequest'?
>>
>> This RFR proposes a new factory method for creating a new `HttpRequest`
>> builder from an existi
On Mon, 23 Nov 2020 10:44:12 GMT, Chris Hegarty wrote:
>> 8255675: Typo in java.net.HttpURLConnection
>
> Marked as reviewed by chegar (Reviewer).
What is the effect if this change is integrated as is (from the master branch)?
The normal procedure is to merge from a separate branch.
--
On Wed, 2 Dec 2020 17:21:08 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find below a fix that fixes an issue in Http2TestServerConnection -
>> where the
>> connection will be closed by the test server if the test server receives a
>> RESET from the client
>> after the stream has been closed.
On Fri, 4 Dec 2020 15:52:28 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find below a fix that fixes an issue in Http2TestServerConnection -
>> where the
>> connection will be closed by the test server if the test server receives a
>> RESET from the client
>> after the stream has been closed.
On Mon, 7 Dec 2020 15:32:54 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for JDK-8254996: 'make
> jdk.net.UnixDomainPrincipal a record class'?
>
> `jdk.net.UnixDomainPrincipal` is a simple immutable data class that requires
> boilerplate methods for access. How
On Fri, 4 Dec 2020 17:41:47 GMT, Daniel Fuchs wrote:
> The timeout tests extending AbstractConnectTimeout have been relaxed to
> accept a
> ConnectException wrapping NoRouteToHostException.
> These test have been observed failing intermittently with ConnectException
> wrapping
> java.nio.channe
On Mon, 7 Dec 2020 17:11:28 GMT, Conor Cleary wrote:
>> The KeepAliveStreamCleaner in sun.net.ww.http package had been previously
>> seen to fail with an IllegalMonitorStateException. This failure was caused
>> by the use of `wait()` in a non synchronized block. This failure was
>> mitigated t
On Thu, 17 Dec 2020 14:51:44 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find an almost trivial fix for:
> 8258582: HttpClient: the HttpClient doesn't explicitly shutdown its default
> executor when stopping.
>
> The HttpClient should shutdown his executor when stopping, when the executor
> was
ves only the first IP address resolved, not all the IP addresses resolved.
>> - Depending on when the implier/implied SocketPermission hostname is
>> resolved, the resolved addresses order differs, and the internally saved IP
>> address mismatches, resulting on So
On Wed, 27 Jan 2021 14:47:08 GMT, Claes Redestad wrote:
> 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager
> installed
Marked as reviewed by michaelm (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2263
On Tue, 2 Feb 2021 15:55:40 GMT, Julia Boes wrote:
> This change clarifies the InetSocketAddress::toString specification, which
> was recently updated to reflect an implementation change [1]. The
> specification is not changed, but it is enhanced with two examples and some
> more verbiage, as
On Tue, 2 Feb 2021 15:55:40 GMT, Julia Boes wrote:
> This change clarifies the InetSocketAddress::toString specification, which
> was recently updated to reflect an implementation change [1]. The
> specification is not changed, but it is enhanced with two examples and some
> more verbiage, as
ves only the first IP address resolved, not all the IP addresses resolved.
>> - Depending on when the implier/implied SocketPermission hostname is
>> resolved, the resolved addresses order differs, and the internally saved IP
>> address mismatches, resulting on So
ves only the first IP address resolved, not all the IP addresses resolved.
>> - Depending on when the implier/implied SocketPermission hostname is
>> resolved, the resolved addresses order differs, and the internally saved IP
>> address mismatches, resulting on So
ves only the first IP address resolved, not all the IP addresses resolved.
>> - Depending on when the implier/implied SocketPermission hostname is
>> resolved, the resolved addresses order differs, and the internally saved IP
>> address mismatches, resulting on So
On Fri, 19 Feb 2021 16:20:01 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a fix for:
>> 8262027: Improve how HttpConnection detects a closed channel when
>> taking/returning a connection to the pool
>>
>> While writing a new test to verify that it was possible to handle proxy
>> *an
On Fri, 19 Feb 2021 18:58:21 GMT, Daniel Fuchs wrote:
>> test/jdk/java/net/httpclient/ProxyServer.java line 390:
>>
>>> 388: clientSocket.shutdownInput();
>>> 389: close();
>>> 390: return;
>>
>> I realise it is
On Mon, 22 Feb 2021 16:44:40 GMT, Daniel Fuchs wrote:
>> Right, I was mistaken. It actually is related to this change. You are
>> testing what happens *if* the proxy closes the connection. Though that
>> wouldn't be normal behavior for a proxy. If you are sending 407 to the
>> client then you
On Tue, 23 Feb 2021 17:20:13 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a fix for:
>> 8262027: Improve how HttpConnection detects a closed channel when
>> taking/returning a connection to the pool
>>
>> While writing a new test to verify that it was possible to handle proxy
>> *an
On Wed, 24 Feb 2021 10:24:06 GMT, Conor Cleary wrote:
> A number of net tests use a
> **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)**
> to verify either the functionality of this
On Wed, 3 Mar 2021 10:55:12 GMT, Julia Boes wrote:
> Small fix to add logging to catch blocks where it was previously missing.
Marked as reviewed by michaelm (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2808
ves only the first IP address resolved, not all the IP addresses resolved.
>> - Depending on when the implier/implied SocketPermission hostname is
>> resolved, the resolved addresses order differs, and the internally saved IP
>> address mismatches, resulting on So
On Tue, 9 Mar 2021 12:32:38 GMT, Chris Hegarty wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> src/java.base/share/classes/java/net/In
On Tue, 9 Mar 2021 19:56:25 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the
Hi,
The fix for the reported bug in Utils.CONTEXT_RESTRICTED caused a couple of
regression failures, which turned out to be another bug exposed by this fix
where HTTP/1.1 CONNECT requests with authentication were filtering out proxy
authentication headers wrongly. This was because the HttpReque
On Mon, 15 Mar 2021 13:21:25 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> The fix for the reported bug in Utils.CONTEXT_RESTRICTED caused a couple of
>> regression failures, which turned out to be another bug exposed by this fix
>> where HTTP/1.1 CONNECT requests with authentication were filtering ou
. This was because the HttpRequestImpl created
> for the repeated CONNECT was putting the system headers in the user headers
> area of the HttpRequestImpl. The fix for that is to supply the user and
> system headers direct to the place where the new HttpRequestImpl is created.
>
>
Could I get the following simple fix reviewed please?
Thanks,
Michael.
-
Commit messages:
- Initial fix
Changes: https://git.openjdk.java.net/jdk/pull/3113/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3113&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8
> Could I get the following simple fix reviewed please?
>
> Thanks,
> Michael.
Michael McMahon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request c
On Mon, 22 Mar 2021 09:40:43 GMT, Chris Hegarty wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
> Could I get the following simple fix reviewed please?
>
> Thanks,
> Michael.
Michael McMahon has updated the pull request incrementally with one additional
commit since the last revision:
fix whitespace error
-
Changes:
- all: https://git.openjdk.java.net/j
On Tue, 16 Mar 2021 14:19:09 GMT, Julia Boes wrote:
> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
> by wrapping it in an unmodifiable view.
Changes requested by michaelm (Reviewer).
src/jdk.httpserver/share/classes/sun/net/httpserver/UnmodifiableHeaders.java
l
On Mon, 22 Mar 2021 16:23:27 GMT, Daniel Fuchs wrote:
>> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
>> by wrapping it in an unmodifiable view.
>
> src/jdk.httpserver/share/classes/sun/net/httpserver/UnmodifiableHeaders.java
> line 34:
>
>> 32: public class Unm
On Mon, 22 Mar 2021 11:56:58 GMT, Julia Boes wrote:
>> src/jdk.httpserver/share/classes/sun/net/httpserver/UnmodifiableHeaders.java
>> line 60:
>>
>>> 58: map.forEach((k, v) -> headers.add(k, v.get(0)));
>>> 59: return headers.getFirst(key);
>>> 60: }
>>
>> Shou
. This was because the HttpRequestImpl created
> for the repeated CONNECT was putting the system headers in the user headers
> area of the HttpRequestImpl. The fix for that is to supply the user and
> system headers direct to the place where the new HttpRequestImpl is created.
>
>
On Mon, 15 Mar 2021 14:57:33 GMT, Michael McMahon wrote:
>> test/jdk/java/net/httpclient/AuthFilter.java line 57:
>>
>>> 55: Headers reqh = e.getRequestHeaders();
>>> 56: if (reqh.containsKey("authorization")) {
>>>
On Tue, 23 Mar 2021 11:06:16 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated test to test proxy authorization
>
> test/jdk/java/net/httpclient/AuthF
. This was because the HttpRequestImpl created
> for the repeated CONNECT was putting the system headers in the user headers
> area of the HttpRequestImpl. The fix for that is to supply the user and
> system headers direct to the place where the new HttpRequestImpl is created.
>
>
On Fri, 12 Mar 2021 21:04:59 GMT, Michael McMahon wrote:
> Hi,
>
> The fix for the reported bug in Utils.CONTEXT_RESTRICTED caused a couple of
> regression failures, which turned out to be another bug exposed by this fix
> where HTTP/1.1 CONNECT requests with authentication wer
> Could I get the following simple fix reviewed please?
>
> The bug is jdk.internal.net.http.AuthenticationFilter throws an NPE wrapped
> in an IOException if it receives a HTTP response containing a
> WWW-Authenticate header with no value.
>
> Thanks,
> Michael.
Mic
On Mon, 22 Mar 2021 10:31:19 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix whitespace error
>
> test/jdk/java/net/httpclient/EmptyAuthenticate.java li
On Mon, 22 Mar 2021 09:26:08 GMT, Michael McMahon wrote:
> Could I get the following simple fix reviewed please?
>
> The bug is jdk.internal.net.http.AuthenticationFilter throws an NPE wrapped
> in an IOException if it receives a HTTP response containing a
> WWW-Authenticate
On Mon, 29 Mar 2021 09:09:00 GMT, Julia Boes wrote:
>> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
>> by wrapping it in an unmodifiable view.
>
> Julia Boes has updated the pull request incrementally with two additional
> commits since the last revision:
>
> -
On Wed, 31 Mar 2021 10:51:40 GMT, Julia Boes wrote:
>> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
>> by wrapping it in an unmodifiable view.
>
> Julia Boes has updated the pull request incrementally with one additional
> commit since the last revision:
>
> m
Hi,
Could I get the following small test fix reviewed please? The test is timing
out on Mac probably because it is running on a system with a proxy that is not
bypassed for loopback connections. The test already sets NO_PROXY explicitly
for one part of the test. It needs to do the equivalent fo
On Tue, 6 Apr 2021 15:17:53 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following small test fix reviewed please? The test is timing
> out on Mac probably because it is running on a system with a proxy that is
> not bypassed for loopback connections. The test alread
On Wed, 7 Apr 2021 17:07:44 GMT, Daniel Fuchs wrote:
>> Julia Boes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> assign unmodHeaders instead of original headers
>
> Marked as reviewed by dfuchs (Reviewer).
Latest changes LGTM.
--
On Mon, 12 Apr 2021 15:21:05 GMT, Conor Cleary wrote:
> ### Description
> `Inet6Address/B6206527.java` test creates two instances of ServerSocket, both
> of which are explicity bound to a Link-Local address. Neither of the
> ServerSocket instances are explicitly closed meaning there is no guara
On Tue, 13 Apr 2021 10:30:18 GMT, Conor Cleary wrote:
>> ### Description
>> `Inet6Address/B6206527.java` test creates two instances of ServerSocket,
>> both of which are explicity bound to a Link-Local address. Neither of the
>> ServerSocket instances are explicitly closed meaning there is no g
Hi,
Could I get the following trivial doc changes reviewed please, caused by:
- broken tags in MethodHandles referring to package.html instead of
package-summary.html
- references to a package level #unixdomain anchor that no longer exists.
- a tag missing a "../" in SocketChannel
Thanks,
On Wed, 14 Apr 2021 14:03:01 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following trivial doc changes reviewed please, caused by:
>
> - broken tags in MethodHandles referring to package.html instead of
> package-summary.html
>
> - references to a package
On Wed, 14 Apr 2021 15:27:36 GMT, Alan Bateman wrote:
>> Hi,
>>
>> Could I get the following trivial doc changes reviewed please, caused by:
>>
>> - broken tags in MethodHandles referring to package.html instead of
>> package-summary.html
>>
>> - references to a package level #unixdomain anc
On Wed, 28 Apr 2021 11:29:18 GMT, Julia Boes wrote:
>> Add two static factory methods to com.sun.net.httpserver.Filter that
>> facilitate the creation of pre- and post-processing Filters:
>>
>> `public static Filter beforeResponse(String description,
>> Consumer filterImpl) {}`
>> `public sta
On Wed, 28 Apr 2021 13:20:23 GMT, Julia Boes wrote:
>> Add two static factory methods to com.sun.net.httpserver.Filter that
>> facilitate the creation of pre- and post-processing Filters:
>>
>> `public static Filter beforeResponse(String description,
>> Consumer filterImpl) {}`
>> `public sta
Vote: Yes
On 12/05/2021 11:58, Chris Hegarty wrote:
I hereby nominate Daniel Fuchs to Membership in the Networking
Group.
Daniel is a Reviewer in the JDK project, and a long term contributor to
the Java platform. Daniel has been actively participating in the
evolution and maintenance of the net
On Mon, 17 May 2021 09:53:06 GMT, Julia Boes wrote:
> The tests for `afterHandler` filters expect the filter operation to happen
> before the assertion. Very rarely this is not the case, the calling thread
> reads the response before the filter operation is executed, so the test value
> is not
On Wed, 19 May 2021 09:19:56 GMT, Julia Boes wrote:
>> The filter operation `Consumer` that is passed to the factory methods can
>> throw an unchecked exception. This change adds a note on the exception
>> handling in that case. It also adds a clarification to
>> `Filter::afterHandler` on the
On Wed, 2 Jun 2021 11:06:46 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull reques
Yes, it does seem that for local RPC a regular (unix domain) socket
should suffice
rather than a websocket.
Also, just to point out that Unix domain socket (channels) have been in
the JDK
since Java 16.
- Michael.
On 11/06/2021 10:22, Daniel Fuchs wrote:
Hi Christos,
The HttpClient doesn't
Hi,
This fixes a problem where the listener methods of a WebSocket client were
being invoked by the Selector manager thread, which is problematic, because if
the implementation of any of these methods tries to do any blocking work, this
impacts other http activity, and if the blocking work is a
On Wed, 16 Jun 2021 09:07:49 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> This fixes a problem where the listener methods of a WebSocket client were
>> being invoked by the Selector manager thread, which is problematic, because
>> if the implementation of any of these methods tries to do any blocking
resume this is used by other tests, but that implementation is not used by
> this change. 2) The WebSocketServer is based on the existing
> DummyWebSocketServer class which is used by other tests. I can't see any easy
> way to refactor/combine these implementations.
>
> Thanks,
resume this is used by other tests, but that implementation is not used by
> this change. 2) The WebSocketServer is based on the existing
> DummyWebSocketServer class which is used by other tests. I can't see any easy
> way to refactor/combine these implementations.
>
> Thanks,
resume this is used by other tests, but that implementation is not used by
> this change. 2) The WebSocketServer is based on the existing
> DummyWebSocketServer class which is used by other tests. I can't see any easy
> way to refactor/combine these implementations.
>
> Thanks
On Wed, 16 Jun 2021 13:53:38 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find below a test-only change to fix some intermittent failures
> observed with the httpclient/websocket tests:
> these tests intermittently and randomly fail with ENOMEM ("No buffer space
> available").
>
> Some machines
On Wed, 16 Jun 2021 07:56:11 GMT, Michael McMahon wrote:
> Hi,
>
> This fixes a problem where the listener methods of a WebSocket client were
> being invoked by the Selector manager thread, which is problematic, because
> if the implementation of any of these methods tries to
On Thu, 17 Jun 2021 09:17:24 GMT, Julia Boes wrote:
> This cleanup-only change fixes the indentation of all members from 8 to 4
> spaces and removes whitespace in method invocations (example: `foo ()` ->
> `foo()`). It also removes superfluous type parameters on lines 83, 168, 206.
Marked as r
On Wed, 16 Jun 2021 22:10:56 GMT, Mark Sheppard wrote:
>> JDK-8265369 [macos-aarch64] java/net/MulticastSocket/Promiscuous.java failed
>> with "SocketException: Cannot allocate memory"
>>
>> The test java/net/MulticastSocket/Promiscuous.java has been observed to fail
>> on a regular basis on m
On Thu, 17 Jun 2021 12:37:59 GMT, Michael McMahon wrote:
>> Mark Sheppard has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8265369 [macos-aarch64] java/net/MulticastSocket/Promiscuous.java
>> failed
On Thu, 17 Jun 2021 21:31:48 GMT, Mark Sheppard wrote:
>> JDK-8265369 [macos-aarch64] java/net/MulticastSocket/Promiscuous.java failed
>> with "SocketException: Cannot allocate memory"
>>
>> The test java/net/MulticastSocket/Promiscuous.java has been observed to fail
>> on a regular basis on m
On Thu, 17 Jun 2021 16:23:08 GMT, Mahendra Chhipa
wrote:
>> …HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented review comments
test/jdk/sun/ne
On Wed, 23 Jun 2021 12:10:54 GMT, Mahendra Chhipa
wrote:
>> …HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented reviw comments.
Marked as revie
On Wed, 23 Jun 2021 18:02:02 GMT, Julia Boes wrote:
>> `com.sun.net.httpserver.Headers` normalizes its keys to adhere to the
>> following format: First character uppercase, all other characters lowercase,
>> for example `"foo" -> "Foo"`. This behaviour is not consistent across the
>> mutator m
On Fri, 2 Jul 2021 11:58:46 GMT, Julia Boes wrote:
>> `com.sun.net.httpserver.HttpServer::createContext` specifies
>> `IllegalArgumentException` to be thrown if a context already exists for the
>> path provided. The implementation class`sun.net.httpserver.ServerImpl` does
>> not comply with th
501 - 600 of 1041 matches
Mail list logo
