On Thu, 17 Jun 2021 12:37:59 GMT, Michael McMahon <micha...@openjdk.org> wrote:
>> Mark Sheppard has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8265369 [macos-aarch64] java/net/MulticastSocket/Promiscuous.java >> failed with "SocketException: Cannot allocate memory" >> amendments as per suggestion from Chris Hegarty > > src/java.base/unix/native/libnet/PlainDatagramSocketImpl.c line 2112: > >> 2110: res = setsockopt(fd, IPPROTO_IPV6, (join ? ADD_MEMBERSHIP : >> DRP_MEMBERSHIP), >> 2111: (char *) &mname6, sizeof (mname6)); >> 2112: > > Seems to be an extraneous space after sizeof here. A general question. Is "__APPLE__" the preferred macro name or MACOSX? Not a big deal but MACOSX looks slightly more common. [Seems github has removed the underscores from APPLE] ------------- PR: https://git.openjdk.java.net/jdk17/pull/44
