On Wed, 19 May 2021 09:19:56 GMT, Julia Boes <jb...@openjdk.org> wrote:
>> The filter operation `Consumer` that is passed to the factory methods can
>> throw an unchecked exception. This change adds a note on the exception
>> handling in that case. It also adds a clarification to
>> `Filter::afterHandler` on the relation of the filter operation and the
>> client receiving the response.
>
> Julia Boes has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add bug id to test
Changes requested by michaelm (Reviewer).
src/jdk.httpserver/share/classes/com/sun/net/httpserver/Filter.java line 214:
> 212: * before the {@code operation} is invoked. More specifically, the
> response
> 213: * will typically be sent before the filter {@code operation} is
> executed.
> 214: *
I think I'd prefer "may be" rather than "will typically be" here as well. Best
not to make any claim about what is more likely to happen.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4085
