On Wed, 21 Oct 2020 09:20:47 GMT, Chris Hegarty <che...@openjdk.org> wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> further test update from Daniel
>
> test/jdk/java/net/UnixDomainSocketAddress/LengthTest.java line 55:
>
>> 53: catch (IOException | UnsupportedOperationException e) {
>> 54: supported = false;
>> 55: out.println("Unix domain channels not supported. Test not
>> run.");
>
> `SkipException` can be used to avoid the boolean and the subsequent checks in
> all test scenario methods. e.g.
>
> throw new org.testng.SkipException("Unix domain channels not supported");
>
> This pattern can be used in all tests at are optional - based on platform
> support.
>
> Additionally, if UOE is thrown from SocketChannel.open(UNIX), then I assume
> that ServerSocketChannel.open(UNIX) should also throw UOE. This can be
> asserted in the catch.
Actually, tests of the address class should pass on all platforms. The check
dated back to when the test needed to know the exact maximum length of an
address on the platform. I'll just remove the check.
-------------
PR: https://git.openjdk.java.net/jdk/pull/52
