Thanks Alan .
The linktime section-gc found a couple of other potentially unused
functions / variables in libnet ;
example output of --print-gc-sections for the libnet product - build (linux
s390x) :
/bin/ld: Removing unused section '.bss.my_gconf_init_func' in file
'/builddir/support/
On 21/11/2019 10:16, Baesken, Matthias wrote:
Should I remove the others too (would open another jira-issue for
this, or are there concerns ) ?
As far as I checked, the other findings are all unreferenced /
unused these days .
If they are definitely unused then go ahead but you might n
Hi,
Please find below a fix for:
8233296: MulticastSocket getOption/setOption inverts the value
of IP_MULTICAST_LOOP
https://bugs.openjdk.java.net/browse/JDK-8233296
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8233296/webrev.00/
I am not sure whether a CSR was strictly needed bu
Daniel,
> On 21 Nov 2019, at 14:34, Daniel Fuchs wrote:
>
> Hi,
>
> Please find below a fix for:
>
> 8233296: MulticastSocket getOption/setOption inverts the value
> of IP_MULTICAST_LOOP
> https://bugs.openjdk.java.net/browse/JDK-8233296
>
> webrev:
> http://cr.openjdk.java.net/~dfuch
Hello,
Could you please review the following fix for the bug. The bug consists
in a deadlock introduced by the fix for the bug JDK-8032832, which
introduced locking on the thread context class loader in the method
"sun.net.www.protocol.http.NegotiateAuthentication.isSupported(HttpCallerInfo)".
Hi Anton,
That looks fine to me.
best regards,
-- daniel
On 21/11/2019 15:28, Anton Litvinov wrote:
Hello,
Could you please review the following fix for the bug. The bug consists
in a deadlock introduced by the fix for the bug JDK-8032832, which
introduced locking on the thread context cla
> On 21 Nov 2019, at 15:28, Anton Litvinov wrote:
>
> Hello,
>
> Could you please review the following fix for the bug. The bug consists in a
> deadlock introduced by the fix for the bug JDK-8032832, which introduced
> locking on the thread context class loader in the method
> "sun.net.www
On 21/11/2019 15:02, Chris Hegarty wrote:
The source changes look good.
A few minor comments on the test.
You probably don’t need this anymore? ( InetAddress.getLoopbackAddress() does
not throw )
63 SetLoopbackOption() throws Exception {
64 }
You could also push the main entry
> On 21 Nov 2019, at 16:46, Daniel Fuchs wrote:
>
> On 21/11/2019 15:02, Chris Hegarty wrote:
>> The source changes look good.
>> A few minor comments on the test.
>> You probably don’t need this anymore? ( InetAddress.getLoopbackAddress()
>> does not throw )
>> 63 SetLoopbackOption() t
On 21/11/2019 16:47, Chris Hegarty wrote:
I was kinda suggesting that the explicit no-args constructor is not needed (
but maybe I have missed something? ). Either way ( I’ll leave it to you ), you
have my Review.
Oh - I though you meant the `throws Exception` that the constructor
was declari
Simone,
> On 19 Nov 2019, at 20:28, Simone Bordet wrote:
>
> Hi,
>
> Google Chrome is about to support a new attribute called `SameSite` in
> cookies.
> https://blog.chromium.org/2019/10/developers-get-ready-for-new.html.
> I guess other browsers will soon follow.
>
> The specification
> (htt
Hi,
On Thu, Nov 21, 2019 at 6:44 PM Chris Hegarty wrote:
> I’m still doing some background reading, but it seems at the very minimum
> that the less-than-fresh java.net.HttpCookie would need to know about, and
> support, the SameSite attribute. Currently attributes are modelled through a
> pai
On 21/11/2019 14:34, Daniel Fuchs wrote:
Hi,
Please find below a fix for:
8233296: MulticastSocket getOption/setOption inverts the value
of IP_MULTICAST_LOOP
https://bugs.openjdk.java.net/browse/JDK-8233296
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8233296/webrev.00/
I think I
13 matches
Mail list logo
