On 21/11/2019 14:34, Daniel Fuchs wrote:
Hi,

Please find below a fix for:

8233296: MulticastSocket getOption/setOption inverts the value
         of IP_MULTICAST_LOOP
https://bugs.openjdk.java.net/browse/JDK-8233296

webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8233296/webrev.00/
I think I would cast to boolean rather than Boolean (because it's boolean on the LHS) to make it a bit clearer. The rest looks good.

I see Joe has just approved the CSR and agrees with the suggestion that this should be back-ported to ensure future use of this API doesn't create a migration issue.

-Alan.

Reply via email to