Daniel,
> On 21 Nov 2019, at 14:34, Daniel Fuchs <daniel.fu...@oracle.com> wrote:
>
> Hi,
>
> Please find below a fix for:
>
> 8233296: MulticastSocket getOption/setOption inverts the value
> of IP_MULTICAST_LOOP
> https://bugs.openjdk.java.net/browse/JDK-8233296
>
> webrev:
> http://cr.openjdk.java.net/~dfuchs/webrev_8233296/webrev.00/
The source changes look good.
A few minor comments on the test.
You probably don’t need this anymore? ( InetAddress.getLoopbackAddress() does
not throw )
63 SetLoopbackOption() throws Exception {
64 }
You could also push the main entry point to the bottom, out of the way. I guess
it is just for quickly running locally.
> I am not sure whether a CSR was strictly needed but since
> this is a very confusing issue I'd prefer to have the behavioral
> changes properly documented, so I filed a CSR.
> The fine points are documented there.
I agree, it is confusing. Thanks for writing it up.
>
> CSR:
> https://bugs.openjdk.java.net/browse/JDK-8234582
I added myself as a reviewer on the CSR.
-Chris.
