> On 21 Nov 2019, at 16:46, Daniel Fuchs <daniel.fu...@oracle.com> wrote:
>
> On 21/11/2019 15:02, Chris Hegarty wrote:
>> The source changes look good.
>> A few minor comments on the test.
>> You probably don’t need this anymore? ( InetAddress.getLoopbackAddress()
>> does not throw )
>> 63 SetLoopbackOption() throws Exception {
>> 64 }
>> You could also push the main entry point to the bottom, out of the way. I
>> guess it is just for quickly running locally.
>
> Done.
>
> http://cr.openjdk.java.net/~dfuchs/webrev_8233296/webrev.01/
I was kinda suggesting that the explicit no-args constructor is not needed (
but maybe I have missed something? ). Either way ( I’ll leave it to you ), you
have my Review.
-Chris.
