On 21/11/2019 15:02, Chris Hegarty wrote:
The source changes look good.

A few minor comments on the test.

You probably don’t need this anymore? ( InetAddress.getLoopbackAddress() does 
not throw )

   63     SetLoopbackOption() throws Exception {
   64     }

You could also push the main entry point to the bottom, out of the way. I guess 
it is just for quickly running locally.


Done.

http://cr.openjdk.java.net/~dfuchs/webrev_8233296/webrev.01/


CSR:
https://bugs.openjdk.java.net/browse/JDK-8234582

best regards,

-- daniel

Reply via email to