On Mon, 7 Feb 2022 09:14:51 GMT, Daniel Jeliński wrote:
>> Clean up of various issues related to error handling and memory management
>
> Daniel Jeliński has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Initialize return value in all cases
On Mon, 7 Feb 2022 09:14:51 GMT, Daniel Jeliński wrote:
>> Clean up of various issues related to error handling and memory management
>
> Daniel Jeliński has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Initialize return value in all cases
On Mon, 7 Feb 2022 09:14:51 GMT, Daniel Jeliński wrote:
>> Clean up of various issues related to error handling and memory management
>
> Daniel Jeliński has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Initialize return value in all cases
On Wed, 19 Jan 2022 08:15:46 GMT, Daniel Jeliński wrote:
>> Why?
>> No users of `enumInterfaces` rely on the value returned in the second
>> parameter when `enumInterfaces` returns a negative result. The same is true
>> for `getAllInterfacesAndAddresses`.
>> The second parameter was NULL-initia
> Clean up of various issues related to error handling and memory management
Daniel Jeliński has updated the pull request incrementally with one additional
commit since the last revision:
Initialize return value in all cases
-
Changes:
- all: https://git.openjdk.java.net/jdk/pu
On Wed, 26 Jan 2022 20:09:36 GMT, Daniel Jeliński wrote:
>> src/java.base/windows/native/libnet/NetworkInterface_winXP.c line 253:
>>
>>> 251:
>>> 252: ret = enumInterfaces(env, netifPP);
>>> 253: if (ret < 0) {
>>
>> Why did we remove handling for -2 here when `enumInterfaces` might r
On Wed, 26 Jan 2022 18:25:19 GMT, Daniel Fuchs wrote:
>> Daniel Jeliński has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> commit
On Wed, 19 Jan 2022 08:15:24 GMT, Daniel Jeliński wrote:
>> Clean up of various issues related to error handling and memory management
>
> Daniel Jeliński has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> br
On Wed, 12 Jan 2022 12:34:35 GMT, Daniel Jelinski wrote:
>> src/java.base/windows/native/libnet/NetworkInterface.c line 216:
>>
>>> 214: break;
>>> 215: }
>>> 216: return -1;
>>
>> *netifPP = NULL;
>>
>> and a similar NULL out value for all return -1 in this f
> Clean up of various issues related to error handling and memory management
Daniel Jelinski has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains 12 addition
On Wed, 12 Jan 2022 11:01:03 GMT, Mark Sheppard wrote:
>> Daniel Jelinski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unused / incorrect exit code -2 from enumInterfaces
>
> src/java.base/windows/native/libnet/NetworkInterface
> Clean up of various issues related to error handling and memory management
Daniel Jelinski has updated the pull request incrementally with one additional
commit since the last revision:
Remove redundant initialization
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/60
On Wed, 12 Jan 2022 08:09:59 GMT, Daniel Jelinski wrote:
>> Clean up of various issues related to error handling and memory management
>
> Daniel Jelinski has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Remove unused / incorrect exit code -
On Mon, 10 Jan 2022 19:58:56 GMT, Mark Sheppard wrote:
>> In my experiments the `enumInterfaces` succeeded in IPv6-only environment.
>> The function only fails with -2 when a new interface is added during
>> enumeration.
>> I could modify the function to stop returning -2 if you think it makes
> Clean up of various issues related to error handling and memory management
Daniel Jelinski has updated the pull request incrementally with one additional
commit since the last revision:
Remove unused / incorrect exit code -2 from enumInterfaces
-
Changes:
- all: https://git.o
On Mon, 10 Jan 2022 07:37:24 GMT, Daniel Jelinski wrote:
>> src/java.base/windows/native/libnet/NetworkInterface_winXP.c line 256:
>>
>>> 254:
>>> 255: ret = enumInterfaces(env, netifPP);
>>> 256: if (ret == -1) {
>>
>> this change is questionable: enumInterfaces returns -2 to allows
On Sat, 8 Jan 2022 19:00:52 GMT, Mark Sheppard wrote:
>> Daniel Jelinski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address problems reported by clang-tidy
>
> src/java.base/windows/native/libnet/NetworkInterface_winXP.c line 271:
>
On Sat, 8 Jan 2022 09:11:05 GMT, Daniel Jelinski wrote:
>> Clean up of various issues related to error handling and memory management
>
> Daniel Jelinski has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Address problems reported by clang-tid
On Sat, 8 Jan 2022 18:17:29 GMT, Mark Sheppard wrote:
>> Daniel Jelinski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address problems reported by clang-tidy
>
> src/java.base/windows/native/libnet/NetworkInterface_winXP.c line 256:
>
On Sat, 8 Jan 2022 09:11:05 GMT, Daniel Jelinski wrote:
>> Clean up of various issues related to error handling and memory management
>
> Daniel Jelinski has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Address problems reported by clang-tid
On Sat, 8 Jan 2022 09:11:05 GMT, Daniel Jelinski wrote:
>> Clean up of various issues related to error handling and memory management
>
> Daniel Jelinski has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Address problems reported by clang-tid
On Sat, 8 Jan 2022 09:11:05 GMT, Daniel Jelinski wrote:
>> Clean up of various issues related to error handling and memory management
>
> Daniel Jelinski has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Address problems reported by clang-tid
On Sat, 8 Jan 2022 09:11:05 GMT, Daniel Jelinski wrote:
>> Clean up of various issues related to error handling and memory management
>
> Daniel Jelinski has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Address problems reported by clang-tid
> Clean up of various issues related to error handling and memory management
Daniel Jelinski has updated the pull request incrementally with one additional
commit since the last revision:
Address problems reported by clang-tidy
-
Changes:
- all: https://git.openjdk.java.net/jdk
On Thu, 28 Oct 2021 07:20:38 GMT, Daniel Jeliński wrote:
>> Clean up of various issues related to error handling and memory management
>
> Daniel Jeliński has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Restore support for IPv6-only operati
On Thu, 28 Oct 2021 07:20:38 GMT, Daniel Jeliński wrote:
>> Clean up of various issues related to error handling and memory management
>
> Daniel Jeliński has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Restore support for IPv6-only operati
On Thu, 28 Oct 2021 07:20:38 GMT, Daniel Jeliński wrote:
>> Clean up of various issues related to error handling and memory management
>
> Daniel Jeliński has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Restore support for IPv6-only operati
On Thu, 28 Oct 2021 14:27:15 GMT, Daniel Fuchs wrote:
>> Just to clarify, no tests were run. The failure was reported by JTReg
>> itself. As of now building Java on Windows requires IPv4.
>>
>> On a side note, Microsoft created a completely new set of network
>> interface-related APIs in Windo
On Thu, 28 Oct 2021 14:27:15 GMT, Daniel Fuchs wrote:
> I still need to review it though
Each commit tries to fix one function (memory allocation / deallocation /
return values); it may be easier to review them one by one.
> I assume we're talking about using `GetIfTable2` and `GetIfEntry2`
Y
On Thu, 28 Oct 2021 11:15:16 GMT, Daniel Jeliński wrote:
> Just to clarify, no tests were run. The failure was reported by JTReg itself.
> As of now building Java on Windows requires IPv4.
Understood. I'm satisfied that you manually tested the results on your machine
- and if that change passe
On Thu, 28 Oct 2021 07:20:38 GMT, Daniel Jeliński wrote:
>> Clean up of various issues related to error handling and memory management
>
> Daniel Jeliński has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Restore support for IPv6-only operati
On Thu, 28 Oct 2021 07:20:38 GMT, Daniel Jeliński wrote:
>> Clean up of various issues related to error handling and memory management
>
> Daniel Jeliński has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Restore support for IPv6-only operati
On Thu, 28 Oct 2021 07:20:38 GMT, Daniel Jeliński wrote:
>> Clean up of various issues related to error handling and memory management
>
> Daniel Jeliński has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Restore support for IPv6-only operati
> Clean up of various issues related to error handling and memory management
Daniel Jeliński has updated the pull request incrementally with one additional
commit since the last revision:
Restore support for IPv6-only operation
-
Changes:
- all: https://git.openjdk.java.net/jdk
On Sat, 23 Oct 2021 10:26:34 GMT, Daniel Jeliński wrote:
> Clean up of various issues related to error handling and memory management
Hi, I wasn't able to run the test yet; need to find a machine where I could run
this test without worrying about restoring it to a working state.
However, lookin
On Sat, 23 Oct 2021 10:26:34 GMT, Daniel Jeliński wrote:
> Clean up of various issues related to error handling and memory management
Hi Daniel - it looks like your changeset is reverting all the changes that were
made by [JDK-8046500](https://bugs.openjdk.java.net/browse/JDK-8046500), to fix
Clean up of various issues related to error handling and memory management
-
Commit messages:
- Fix memory leak
- Fixup getAllInterfacesAndAddresses
- Fixup getAddrsFromAdapter
- Fixup enumAddresses_win
- Fixup enumAddresses_win_ipaddrtable
- Remove special handling for GetIfTab
37 matches
Mail list logo
