On Thu, 28 Oct 2021 14:27:15 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Just to clarify, no tests were run. The failure was reported by JTReg >> itself. As of now building Java on Windows requires IPv4. >> >> On a side note, Microsoft created a completely new set of network >> interface-related APIs in Windows Vista. It looks like they could simplify >> our getByXXX methods, and possibly we could also use the same method to >> extract both IPv4 and IPv6 addresses. Do you think we could replace the >> pre-Vista code and start using the new functions? > >> Just to clarify, no tests were run. The failure was reported by JTReg >> itself. As of now building Java on Windows requires IPv4. > > Understood. I'm satisfied that you manually tested the results on your > machine - and if that change passes the tier1, tier2 in our CI I believe I'd > be happy (I still need to review it though). > >> On a side note, Microsoft created a completely new set of network >> interface-related APIs in Windows Vista. It looks like they could simplify >> our getByXXX methods, and possibly we could also use the same method to >> extract both IPv4 and IPv6 addresses. Do you think we could replace the >> pre-Vista code and start using the new functions? > > Yes - I saw that there were newer versions of some of these APIs - I was > wondering too if using them would simplify our code. On the one hand it would > be very good to simplify the code and use more modern API. On the other hand > that would probably deserve more testing - possibly setting up some machines > with special configurations to make sure we're not introducing new > regressions. Let me think on it and seek other's opinions... > > I assume we're talking about using > [GetIfTable2](https://docs.microsoft.com/en-us/windows/win32/api/netioapi/nf-netioapi-getiftable2) > and `GetIfEntry2` or are there even newer APIs? But that wouldn't dispense > us of calling `GetAdaptersAddresses` too - would it? @dfuch were you able to review this? Anything I could help with? ------------- PR: https://git.openjdk.java.net/jdk/pull/6090
