On Thu, 28 Oct 2021 14:27:15 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:

> I still need to review it though

Each commit tries to fix one function (memory allocation / deallocation / 
return values); it may be easier to review them one by one.

> I assume we're talking about using `GetIfTable2` and `GetIfEntry2`

Yes, that's what I was talking about.
And yes, looks like `GetAdaptersAddresses` is still the best method to retrieve 
adapter-to-address mapping. For a moment I thought 
[GetUnicastIpAddressEntry](https://docs.microsoft.com/en-us/windows/win32/api/Netioapi/nf-netioapi-getunicastipaddressentry)
 might be able to find adapter by IP address, but apparently that is not the 
case.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6090

Reply via email to