On Sat, 8 Jan 2022 18:17:29 GMT, Mark Sheppard <mshep...@openjdk.org> wrote:
>> Daniel Jelinski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address problems reported by clang-tidy
>
> src/java.base/windows/native/libnet/NetworkInterface_winXP.c line 256:
>
>> 254:
>> 255: ret = enumInterfaces(env, netifPP);
>> 256: if (ret == -1) {
>
> this change is questionable: enumInterfaces returns -2 to allows processing
> to continue with IPv6 data ... this change will prohibit that policy
In my experiments the `enumInterfaces` succeeded in IPv6-only environment. The
function only fails with -2 when a new interface is added during enumeration.
I could modify the function to stop returning -2 if you think it makes sense.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6090
