On Mon, 11 Oct 2021 09:42:12 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my changes (and CSR) to drop support for pre JDK
> 1.4 `DatagramSocketImpl` implementations?
>
> These changes propose to drop support for `DatagramSocketImpls` that were
>
mented.
> Should this set of changes update the `joinGroup` and `leaveGroup` methods in
> order to preserve this behaviour?
>
> CSR: https://bugs.openjdk.java.net/browse/JDK-8274633
>
> Kind regards,
>
> Patrick
Patrick Concannon has updated the pull request with a new targ
mented.
> Should this set of changes update the `joinGroup` and `leaveGroup` methods in
> order to preserve this behaviour?
>
> CSR: https://bugs.openjdk.java.net/browse/JDK-8274633
>
> Kind regards,
>
> Patrick
Patrick Concannon has updated the pull request with a new targ
On Tue, 12 Oct 2021 11:15:55 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/net/DatagramSocketImpl.java line 105:
>>
>>> 103: *
>>> 104: * @implSpec the default implementation of this method always
>>> throws {@code SocketException}
>>> 105: *
>>
>> The implementat
On Tue, 12 Oct 2021 11:20:01 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Tue, 12 Oct 2021 07:10:56 GMT, Vyom Tewari wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
mented.
> Should this set of changes update the `joinGroup` and `leaveGroup` methods in
> order to preserve this behaviour?
>
> CSR: https://bugs.openjdk.java.net/browse/JDK-8274633
>
> Kind regards,
>
> Patrick
Patrick Concannon has updated the pull request with a new targ
Hi,
Could someone please review my changes (and CSR) to drop support for pre JDK
1.4 `DatagramSocketImpl` implementations?
These changes propose to drop support for `DatagramSocketImpls` that were
compiled with JDK 1.3 or older, which do not have support for connected
sockets, for peeking at r
On Tue, 6 Jul 2021 14:41:18 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my patch for Inserting missing commas in
> copyright headers from files in java.net. These commas were mistakenly left
> out of PR https://github.com/openjdk/jdk/pull/4574.
&g
Hi,
Could someone please review my patch for Inserting missing commas in copyright
headers from files in java.net. These commas were mistakenly left out of PR
https://github.com/openjdk/jdk/pull/4574.
Kind regards,
Patrick
-
Commit messages:
- 8269917: Insert missing commas in c
On Wed, 23 Jun 2021 12:06:41 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my changes for the removal of the legacy
> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>
> In JDK 13, JEP 353 provided a drop in replacem
e mechanisms they use to enable them to
> mitigate compatibility issues) have been deemed no longer necessary, they now
> represent a maintenance burden. This patch looks at removing them from the
> JDK.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with
e mechanisms they use to enable them to
> mitigate compatibility issues) have been deemed no longer necessary, they now
> represent a maintenance burden. This patch looks at removing them from the
> JDK.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incremen
On Fri, 25 Jun 2021 11:37:50 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/net/DatagramSocket.java line 1398:
>>
>>> 1396: DatagramSocketImpl impl =
>>> factory.createDatagramSocketImpl();
>>> 1397: Objects.requireNonNull(impl,
>>> 1398:
On Thu, 24 Jun 2021 15:06:49 GMT, Daniel Fuchs wrote:
>>> I've created an issue to track this:
>>> https://bugs.openjdk.java.net/browse/JDK-8269288
>>
>> Thanks. So are you keeping the Objects.requireNonNull here? If so then it
>> should probably be the 2-arg version so that the message is cle
e mechanisms they use to enable them to
> mitigate compatibility issues) have been deemed no longer necessary, they now
> represent a maintenance burden. This patch looks at removing them from the
> JDK.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with
On Wed, 23 Jun 2021 15:09:28 GMT, Alan Bateman wrote:
>> @AlanBateman
>>
>> `protected DatagramSocket(DatagramSocketImpl impl)` throws NPE if `impl` is
>> `null`.
>> (this is covered by the blanket statement for NPE)
>>
>> Do we really need to specify anything else since the global
>> `setD
e mechanisms they use to enable them to
> mitigate compatibility issues) have been deemed no longer necessary, they now
> represent a maintenance burden. This patch looks at removing them from the
> JDK.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incremen
On Wed, 23 Jun 2021 13:09:53 GMT, Alan Bateman wrote:
> I assume DatagramSocket L1043-L1049 (declaration/init of
> USE_PLAINDATAGRAMSOCKET) can be removed too.
USE_PLAINDATAGRAMSOCKET removed as requested. See 49125e7
> src/java.base/share/classes/sun/nio/ch/NioSocketImpl.java line 69:
>
>> 6
e mechanisms they use to enable them to
> mitigate compatibility issues) have been deemed no longer necessary, they now
> represent a maintenance burden. This patch looks at removing them from the
> JDK.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with
Hi,
Could someone please review my changes for the removal of the legacy
`PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
In JDK 13, JEP 353 provided a drop in replacement for the legacy
`PlainSocketImpl` implementation. Since JDK 13, the `PlainSocketImpl`
implementation was no
On Wed, 16 Jun 2021 10:42:56 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my change to the test
> `test/jdk/java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java`?
> The test is missing `/othervm` from its @run jtreg test t
Hi,
Could someone please review my change to the test
`test/jdk/java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java`?
The test is missing `/othervm` from its @run jtreg test tag, which risks
polluting other tests that run in that VM.
Currently, any test that runs without
On Tue, 1 Jun 2021 16:44:38 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
This pull request has now been i
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a re
On Thu, 3 Jun 2021 05:51:59 GMT, Alan Bateman wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a re
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a re
On Wed, 2 Jun 2021 09:13:44 GMT, Chris Hegarty wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268056: Reverted changes to URLDecoder; reformatted change to FileTime
>
> src/ja
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional commit si
On Tue, 1 Jun 2021 16:58:12 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Tue, 1 Jun 2021 17:46:10 GMT, Alan Bateman wrote:
>> Sorry about that. I've changed it now. See 2f179b5
>
> This still looks a bit messy because you've got 3 different styles in the one
> switch statement. It's okay to drop FileTime from the patch if you want as
> it's not worth spending tim
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a re
On Tue, 1 Jun 2021 16:56:39 GMT, Alan Bateman wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268056: Reverted changes to URLDecoder; reformatted change to FileTime
>
> src/ja
On Tue, 1 Jun 2021 16:56:36 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268056: Reverted changes to URLDecoder; reformatted change to FileTime
>
> src/ja
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional commit si
Hi,
Could someone please review my code for updating the code in the `java.net` and
`java.nio` packages to make use of the switch expressions?
Kind regards,
Patrick
-
Commit messages:
- 8268056: Update java.net and java.nio to use switch expressions
Changes: https://git.openjdk.j
On Tue, 9 Mar 2021 11:07:07 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
This pull request ha
On Tue, 9 Mar 2021 18:13:24 GMT, Daniel Fuchs wrote:
>> Now that DatagramSocket has been updated by JDK-8237352 to support joining
>> multicast group, this sentence in the API class level documentation of
>> MulticastSocket is obsolete and should be removed:
>>
>> "A MulticastSocket is a (UDP)
On Tue, 9 Mar 2021 18:22:17 GMT, Chris Hegarty wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8263233: Refactored equals method further
>
> src/java.base/share/classes/java/net/
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional
On Tue, 9 Mar 2021 13:01:10 GMT, Michael McMahon wrote:
>> src/java.base/share/classes/java/net/InterfaceAddress.java line 107:
>>
>>> 105:
>>> 106: if (Objects.equals(address, cmp.address) &&
>>> 107: Objects.equals(broadcast, cmp.broadcast) &&
>>
>> This could be
On Tue, 9 Mar 2021 12:44:10 GMT, Alan Bateman wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8263233: Small refactor of equals method in java/net/InterfaceAddress;
>> removed
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional
Hi,
Could someone please review my code for updating the code in the `java.net` and
`java.nio` packages to make use of the `instanceof` pattern variable?
Kind regards,
Patrick
-
Commit messages:
- 8263233: Update java.net and java.nio to use instanceof pattern variable
Changes: h
On Tue, 2 Mar 2021 10:15:13 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my changeset that fixes the "no comment" warnings
> generated by `javadoc -Xdoclint` for `java.base/jdk.net`?
>
> CSR: https://bugs.openjdk.java.net/browse/JDK-8262938
Hi,
Could someone please review my changeset that fixes the "no comment" warnings
generated by `javadoc -Xdoclint` for `java.base/jdk.net`?
Kind regards,
Patrick
-
Commit messages:
- 8252831: Correct "no comment" warnings in jdk.net module
Changes: https://git.openjdk.java.net/jd
On Wed, 24 Feb 2021 20:42:52 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a change that fixes "no comment" warnings generated by
> `javadoc -Xdoclint` for `java.base/java.net`
src/java.base/share/classes/java/net/HttpRetryException.java line 48:
> 46:
> 47: /**
> 48: * the U
On Wed, 3 Feb 2021 11:03:51 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my proposed changeset for JDK-8235139: '`Remove
> the socket impl factory mechanism`' ?
>
> These changes propose to deprecate (for the eventual removal) the
ntains some verbiage about the potential
> issues that setting factories can have, and alludes to their possible
> future removal.
>
> The CSR for this issue can be viewed here:
> https://bugs.openjdk.java.net/browse/JDK-8261228
>
> Kind regards,
> Patrick
Patrick Conc
ntains some verbiage about the potential
> issues that setting factories can have, and alludes to their possible
> future removal.
>
> The CSR for this issue can be viewed here:
> https://bugs.openjdk.java.net/browse/JDK-8261228
>
> Kind regards,
> Patrick
Patrick Concan
On Thu, 4 Feb 2021 15:20:31 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
ntains some verbiage about the potential
> issues that setting factories can have, and alludes to their possible
> future removal.
>
> The CSR for this issue can be viewed here:
> https://bugs.openjdk.java.net/browse/JDK-8261228
>
> Kind regards,
> Patrick
Patrick Concan
ntains some verbiage about the potential
> issues that setting factories can have, and alludes to their possible
> future removal.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev exc
On Wed, 3 Feb 2021 11:35:07 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Wed, 3 Feb 2021 14:48:15 GMT, Alan Bateman wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
ntains some verbiage about the potential
> issues that setting factories can have, and alludes to their possible
> future removal.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excl
Hi,
Could someone please review my proposed changeset for JDK-8235139: '`Remove the
socket impl factory mechanism`' ?
These changes propose to deprecate (for the eventual removal) the API points
for statically configuring a system-wide factory for the `Socket`,
`ServerSocket`, and `DatagramSoc
On Tue, 2 Feb 2021 12:27:08 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my proposed change for JDK-8235140: '`Investigate
> deprecation of the Socket/ServerSocket impl factory mechanism`' ?
>
> This fix proposes to deprecate (for the even
Hi,
Could someone please review my proposed change for JDK-8235140: '`Investigate
deprecation of the Socket/ServerSocket impl factory mechanism`' ?
This fix proposes to deprecate (for the eventual removal) the API points for
statically configuring a system-wide factory for the `Socket/SocketSer
on caused by not correctly waiting for the result of an
> asynchronous operation. This fix rectifies this issue and adds additional
> checks to ensure correct result is received.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base du
On Wed, 20 Jan 2021 11:52:17 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my fix for JDK-8259628:
> '`jdk/net/ExtendedSocketOption/AsynchronousSocketChannelNAPITest.java` fails
> intermittently' ?
>
> `AsynchronousSocketChannelNAPITes
on caused by not correctly waiting for the result of an
> asynchronous operation. This fix rectifies this issue and adds additional
> checks to ensure correct result is received.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally wi
on caused by not correctly waiting for the result of an
> asynchronous operation. This fix rectifies this issue and adds additional
> checks to ensure correct result is received.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base du
on caused by not correctly waiting for the result of an
> asynchronous operation. This fix rectifies this issue and adds additional
> checks to ensure correct result is received.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base du
Hi,
Could someone please review my fix for JDK-8259628:
'`jdk/net/ExtendedSocketOption/AsynchronousSocketChannelNAPITest.java` fails
intermittently' ?
`AsynchronousSocketChannelNAPITest` is failing intermittently on Linux due to a
race condition caused by not correctly waiting for the result o
On Mon, 7 Dec 2020 15:32:54 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for JDK-8254996: 'make
> jdk.net.UnixDomainPrincipal a record class'?
>
> `jdk.net.UnixDomainPrincipal` is a simple immutable data class that requires
>
ated API doc change, please refer
> to the specdiff attached to the CSR.
>
> CSR : https://bugs.openjdk.java.net/browse/JDK-8257823
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev e
ated API doc change, please refer
> to the specdiff attached to the CSR.
>
> CSR : https://bugs.openjdk.java.net/browse/JDK-8257823
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev e
Hi,
Could someone please review my code for JDK-8254996: 'make
jdk.net.UnixDomainPrincipal a record class'?
`jdk.net.UnixDomainPrincipal` is a simple immutable data class that requires
boilerplate methods for access. However, these methods and fields are
susceptible to trivial mistakes and add
On Fri, 4 Dec 2020 11:22:34 GMT, Kartik Ohri
wrote:
> @pconcannon, If everything is in order, can you please approve the changes on
> Github. I'll then issue the integrate command. Thanks.
Hi @amCap1712, you will have to /integrate first, and then afterwards I will
sponsor
-
PR:
On Wed, 2 Dec 2020 16:28:44 GMT, Kartik Ohri
wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/Http1HeaderParser.java
>> line 119:
>>
>>> 117: while (canContinueParsing(input)) {
>>> 118: switch (state) {
>>> 119: case INITIAL ->
On Wed, 2 Dec 2020 09:42:09 GMT, Kartik Ohri
wrote:
>> Hi!
>> Kindly review this patch to replace switch statements with switch
>> expressions (where it makes sense) in the http client modules. The rationale
>> is to improve readability of the code.
>> Regards,
>> Kartik
>
> Kartik Ohri has re
On Mon, 30 Nov 2020 13:04:11 GMT, Kartik Ohri
wrote:
>> Hi!
>> Kindly review this patch to replace switch statements with switch
>> expressions (where it makes sense) in the http client modules. The rationale
>> is to improve readability of the code.
>> Regards,
>> Kartik
>
> Kartik Ohri has r
: message` i.e. `8257401: Use switch
expressions in jdk.internal.net.http and java.net.http`
If you need any help with this please let me know.
Kind regards,
Patrick
> On 25 Nov 2020, at 16:48, Patrick Concannon
> wrote:
>
> Hi Kartik,
>
> Thanks for running the tests. I’m n
a different
> issue and not related to this patch.
>
> I do not have access to any other machine so I could not run the tests on
> Windows, macOS and so on.
>
> Thanks.
>
> Regards,
> Kartik.
>
> On Mon, Nov 23, 2020 at 11:37 PM Patrick Concannon
> wro
Hi Kartik,
Thanks for submitting the patch. Once you’ve run the tier2 tests, I’d be happy
to sponsor it for you.
-Patrick
> On 23 Nov 2020, at 09:09, Chris Hegarty wrote:
>
> Hi Kartik,
>
>> On 21 Nov 2020, at 12:01, Kartik Ohri wrote:
>>
>> Hi!
>> I would like to submit this patch https:
On Wed, 4 Nov 2020 14:51:07 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review our code for JDK-8252304: 'Seed an
> HttpRequest.Builder from an existing HttpRequest'?
>
> This RFR proposes a new factory method for creating a new `HttpRequest`
can be used to build a new request equivalent to the given
> request, but with different attributes. For instance, it will allow the user
> to take an existing request and add or change a particular header, provide a
> new `URI`, etc.
>
>
> Kind regards,
> Patrick & Chris
On Tue, 17 Nov 2020 16:50:46 GMT, Daniel Fuchs wrote:
>> Would it be enough to check in each test case that if we are examining a
>> request with headers, it contains at least one called `testName1`? i.e.
>> if(!request.headers().map().isEmpty())
>> assertTrue(request.headers
On Tue, 17 Nov 2020 18:28:46 GMT, Daniel Fuchs wrote:
>> Ah! Good catch - I believe the code is buggy. It should have been
>> `!name.equalsIgnoreCase(...)`.
>
> Patrick - can you add a test case with exactly **that** use case? I know you
> have similar tests which remove `"testName1"`, but it w
On Mon, 16 Nov 2020 17:23:42 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
can be used to build a new request equivalent to the given
> request, but with different attributes. For instance, it will allow the user
> to take an existing request and add or change a particular header, provide a
> new `URI`, etc.
>
>
> Kind regards,
> Patrick
can be used to build a new request equivalent to the given
> request, but with different attributes. For instance, it will allow the user
> to take an existing request and add or change a particular header, provide a
> new `URI`, etc.
>
>
> Kind regards,
> Patrick & Chris
On Mon, 16 Nov 2020 17:29:20 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
On Fri, 13 Nov 2020 17:16:21 GMT, Daniel Fuchs wrote:
>> test/jdk/java/net/httpclient/HttpRequestNewBuilderTest.java line 171:
>>
>>> 169: while (iter1.hasNext() && iter2.hasNext())
>>> 170: assertEquals(iter1.next(), iter2.next());
>>> 171: }
>>
>> This code doesn't see
can be used to build a new request equivalent to the given
> request, but with different attributes. For instance, it will allow the user
> to take an existing request and add or change a particular header, provide a
> new `URI`, etc.
>
>
> Kind regards,
> Patrick & Chris
can be used to build a new request equivalent to the given
> request, but with different attributes. For instance, it will allow the user
> to take an existing request and add or change a particular header, provide a
> new `URI`, etc.
>
>
> Kind regards,
> Patrick & Chris
can be used to build a new request equivalent to the given
> request, but with different attributes. For instance, it will allow the user
> to take an existing request and add or change a particular header, provide a
> new `URI`, etc.
>
>
> Kind regards,
> Patrick & Chris
On Mon, 2 Nov 2020 17:14:28 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my fix for JDK-8253005: 'Add `@throws
> IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
>
> The method `HttpEchange.sendResponseHeaders` th
can be used to build a new request equivalent to the given
> request, but with different attributes. For instance, it will allow the user
> to take an existing request and add or change a particular header, provide a
> new `URI`, etc.
>
>
> Kind regards,
> Patrick & Chris
can be used to build a new request equivalent to the given
> request, but with different attributes. For instance, it will allow the user
> to take an existing request and add or change a particular header, provide a
> new `URI`, etc.
>
>
> Kind regards,
> Patrick & Chris
On Thu, 5 Nov 2020 17:17:14 GMT, Chris Hegarty wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
On Fri, 6 Nov 2020 12:49:48 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8253005: Restructured test to use @BeforeTest/@AfterTest
>
>
dds an `@throws IOException` to its
> specification and a description of the conditions under which the exception
> is thrown.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev exc
dds an `@throws IOException` to its
> specification and a description of the conditions under which the exception
> is thrown.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request incrementally with one
additional commit since the last revision:
On Fri, 6 Nov 2020 10:49:10 GMT, Daniel Fuchs wrote:
>> Oh, ok. So the whole purpose of the catch block is to gracefully terminate
>> things (and trigger error reporting) if the test fails - which it should
>> never do ;-) Ok, thanks. [ It's almost like the code would be more easily
>> under
On Thu, 5 Nov 2020 17:30:32 GMT, Chris Hegarty wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8252304: Added read to TestHandler to ensure requestBody consumed before
>> clos
On Thu, 5 Nov 2020 17:23:36 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8252304: Added read to TestHandler to ensure requestBody consumed before
>> clos
dds an `@throws IOException` to its
> specification and a description of the conditions under which the exception
> is thrown.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev exc
1 - 100 of 293 matches
Mail list logo
