On Fri, 6 Nov 2020 10:49:10 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Oh, ok. So the whole purpose of the catch block is to gracefully terminate >> things (and trigger error reporting) if the test fails - which it should >> never do ;-) Ok, thanks. [ It's almost like the code would be more easily >> understood if written without expectThrows, in this particular case ] > >> // unexpected exception thrown, return error to client > > The comment is a bit misleading. Maybe it should say: > > // expectThrows triggered an assertion, return error > message to the client. Comment changed as requested. See https://github.com/openjdk/jdk/pull/1014/commits/8ff6d9b4fcbc0f57f136ff0e7df0d371664badb2 ------------- PR: https://git.openjdk.java.net/jdk/pull/1014
