> Hi, > > Could someone please review our code for JDK-8252304: 'Seed an > HttpRequest.Builder from an existing HttpRequest'? > > This RFR proposes a new factory method for creating a new `HttpRequest` > builder from an existing `HttpRequest`. > This method can be used to build a new request equivalent to the given > request, but with different attributes. For instance, it will allow the user > to take an existing request and add or change a particular header, provide a > new `URI`, etc. > > > Kind regards, > Patrick & Chris
Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 19 additional commits since the last revision: - 8252304: Changed wording of first and second sentence of API spec for newBuilder - Merge remote-tracking branch 'origin/master' into JDK-8252304 - 8252304: Fixed typo in newBuilder example; updated filter test cases to check for value to remove - Merge remote-tracking branch 'origin/master' into JDK-8252304 - 8252304: Added more test cases to check header filter - Merge remote-tracking branch 'origin/master' into JDK-8252304 - Merge remote-tracking branch 'origin/master' into JDK-8252304 - 8252304: BiPredicate parameter added to newBuilder - Merge remote-tracking branch 'origin/master' into JDK-8252304 - Merge remote-tracking branch 'origin/master' into JDK-8252304 - ... and 9 more: https://git.openjdk.java.net/jdk/compare/ed570ce3...b1378a35 ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/1059/files - new: https://git.openjdk.java.net/jdk/pull/1059/files/68ea89e1..b1378a35 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1059&range=10 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1059&range=09-10 Stats: 702 lines in 44 files changed: 165 ins; 304 del; 233 mod Patch: https://git.openjdk.java.net/jdk/pull/1059.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1059/head:pull/1059 PR: https://git.openjdk.java.net/jdk/pull/1059
