On Wed, 23 Jun 2021 15:09:28 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> @AlanBateman >> >> `protected DatagramSocket(DatagramSocketImpl impl)` throws NPE if `impl` is >> `null`. >> (this is covered by the blanket statement for NPE) >> >> Do we really need to specify anything else since the global >> `setDatagramSocketImplFactory` method has been deprecated? I mean - though >> we still support it at the moment, using a `DatagramSocketImplFactory` is >> not recommended, and hopefully only old legacy code would be using that. > > Creating an issue to update > DatagramSocketImplFactory.createDatagramSocketImpl to say that returning null > leads to undefined behavior or DatagramSocket constructors throwing an error > is fine, I wasn't suggesting we have to fix it here. I've created an issue to track this: https://bugs.openjdk.java.net/browse/JDK-8269288 ------------- PR: https://git.openjdk.java.net/jdk/pull/4574
