[SPAM?] Re: index format locale bug

2016-08-27 Thread Eike Rathke
Hi Derek, On Friday, 2016-08-26 17:46:09 -0500, Derek Martin wrote: > On Fri, Aug 26, 2016 at 01:50:40AM +0200, Eike Rathke wrote: > > Alias for the configuration I meant. If both are used the last one wins. > > Simple. > > Yes, I know what you meant. Do you run Mutt because it is easy to > con

Re: index format locale bug

2016-08-26 Thread Damien Riegel
My two cents: please break the config, change variable name to attribution_locale and be done with it. Mutt configuration is already insane in terms of complexity, and already has a fair share of badly named options. Make option's names consistent with what they do. There is an UPDATING file, and

Re: index format locale bug

2016-08-26 Thread Derek Martin
Eike, On Fri, Aug 26, 2016 at 01:50:40AM +0200, Eike Rathke wrote: > Hi, > > On Tuesday, 2016-08-23 12:18:42 -0500, Derek Martin wrote: > > > On Tue, Aug 23, 2016 at 11:04:57AM +0200, Eike Rathke wrote: > > > Well, I think removing the $locale variable was a stupid change ;-) > > > Whether to ad

Re: index format locale bug

2016-08-25 Thread Eike Rathke
Hi, On Tuesday, 2016-08-23 12:18:42 -0500, Derek Martin wrote: > On Tue, Aug 23, 2016 at 11:04:57AM +0200, Eike Rathke wrote: > > Well, I think removing the $locale variable was a stupid change ;-) > > Whether to add $attribution_locale I don't really care, fine for me > > as long as $locale is a

Re: index format locale bug

2016-08-25 Thread Eike Rathke
Hi, On Wednesday, 2016-08-24 08:51:01 -0700, Kevin J. McCarthy wrote: > We've merely reduced the effect of the (proposed alias) $locale. Other > places it used to affect, such as the index dates, will now be > controlled by the user's locale environment variables. I suspect that > most users wh

Re: index format locale bug

2016-08-24 Thread Derek Martin
On Wed, Aug 24, 2016 at 08:51:01AM -0700, Kevin J. McCarthy wrote: > I like the idea of just getting it done and over with, but sympathize > with Eike, who has multiple environments. Will deprecating and removing > a $locale alias over one major release really make the problem worse? Does Mutt ha

Re: index format locale bug

2016-08-24 Thread Kevin J. McCarthy
On Wed, Aug 24, 2016 at 02:37:30AM +0200, Vincent Lefevre wrote: > On 2016-08-23 11:06:22 -0700, Kevin J. McCarthy wrote: > > I think even keeping a $locale alias is still better with the changes > > made. $locale no longer affects the index or various other output, so > > even goofed-up, it cause

Re: index format locale bug

2016-08-23 Thread Vincent Lefevre
On 2016-08-23 14:57:16 -0500, Derek Martin wrote: > On Tue, Aug 23, 2016 at 02:13:45PM +0200, Vincent Lefevre wrote: > > I agree, except that I would keep the bang. The reason is that the > > default $attribution value is in English ("On %d, %n wrote:"), so > > that by default, one expects that the

Re: index format locale bug

2016-08-23 Thread Vincent Lefevre
On 2016-08-23 11:06:22 -0700, Kevin J. McCarthy wrote: > I think even keeping a $locale alias is still better with the changes > made. $locale no longer affects the index or various other output, so > even goofed-up, it causes much fewer problems. Perhaps we could create > the alias but not docum

Re: index format locale bug

2016-08-23 Thread Derek Martin
On Tue, Aug 23, 2016 at 02:13:45PM +0200, Vincent Lefevre wrote: > I agree, except that I would keep the bang. The reason is that the > default $attribution value is in English ("On %d, %n wrote:"), so > that by default, one expects that the date is in English too. But actually, why is the default

Re: index format locale bug

2016-08-23 Thread Derek Martin
On Tue, Aug 23, 2016 at 02:24:56PM -0400, Nathan Stratton Treadway wrote: > I don't have a strong preference regarding the original question, but > definitely would argue against the "create it but don't document it" > approach in general. It's very confusing as a user to find a config > file (eit

Re: index format locale bug

2016-08-23 Thread Nathan Stratton Treadway
On Tue, Aug 23, 2016 at 11:06:22 -0700, Kevin J. McCarthy wrote: > I think even keeping a $locale alias is still better with the changes > made. $locale no longer affects the index or various other output, so > even goofed-up, it causes much fewer problems. Perhaps we could create > the alias but

Re: index format locale bug

2016-08-23 Thread Kevin J. McCarthy
On Tue, Aug 23, 2016 at 12:18:42PM -0500, Derek Martin wrote: > Ultimately, all this is why I changed my mind and agreed with Kevin's > change. Thanks Derek. It was pointed out to me off-list that I might have been a bit hasty to make a decision on re-creating a $locale alias, without giving a ch

Re: index format locale bug

2016-08-23 Thread Derek Martin
On Tue, Aug 23, 2016 at 11:04:57AM +0200, Eike Rathke wrote: > Well, I think removing the $locale variable was a stupid change ;-) > Whether to add $attribution_locale I don't really care, fine for me > as long as $locale is an alias for $attribution_locale. Aliases are bad. They make the code n

Re: index format locale bug

2016-08-23 Thread Kevin J. McCarthy
On Tue, Aug 23, 2016 at 11:04:57AM +0200, Eike Rathke wrote: > On Monday, 2016-08-22 20:17:14 -0700, Kevin J. McCarthy wrote: > > > Please everyone, don't be shy to let me know if you think this is a > > stupid change. > > Well, I think removing the $locale variable was a stupid change ;-) > Whet

Re: index format locale bug

2016-08-23 Thread Vincent Lefevre
On 2016-08-23 11:16:21 +0200, Eike Rathke wrote: > Btw, apart from that, having a default > date_format="!%a, %b %d, %Y at %I:%M:%S%p %Z" > that embeds as many en-US specifics as possible was always stupid ;-) > Probably one of the first changes I did to the default configuration was > set date_for

Re: index format locale bug

2016-08-23 Thread Eike Rathke
Hi, On Tuesday, 2016-08-23 11:04:57 +0200, Eike Rathke wrote: > Users who not used $locale will experience > a change only if their environment is not 'C' or 'en_US' and > $date_format does not start with "!". Btw, apart from that, having a default date_format="!%a, %b %d, %Y at %I:%M:%S%p %Z" t

Re: index format locale bug

2016-08-23 Thread Eike Rathke
Hi Kevin, On Monday, 2016-08-22 20:17:14 -0700, Kevin J. McCarthy wrote: > Please everyone, don't be shy to let me know if you think this is a > stupid change. Well, I think removing the $locale variable was a stupid change ;-) Whether to add $attribution_locale I don't really care, fine for me

Re: index format locale bug

2016-08-22 Thread Kevin J. McCarthy
On Mon, Aug 22, 2016 at 12:00:08AM -0500, Derek Martin wrote: > > On Sat, Aug 20, 2016 at 03:08:34PM -0700, Kevin J. McCarthy wrote: > > On Sat, Aug 20, 2016 at 07:21:15AM -0700, Kevin J. McCarthy wrote: > > > I'll post a patch for this (based on your patch) later on today, so you > > > can see mo

Re: index format locale bug

2016-08-21 Thread Derek Martin
On Sat, Aug 20, 2016 at 03:08:34PM -0700, Kevin J. McCarthy wrote: > On Sat, Aug 20, 2016 at 07:21:15AM -0700, Kevin J. McCarthy wrote: > > I'll post a patch for this (based on your patch) later on today, so you > > can see more concretely what I'm proposing. > > I need to clean up and test these

Re: index format locale bug

2016-08-20 Thread Kevin J. McCarthy
On Sat, Aug 20, 2016 at 07:21:15AM -0700, Kevin J. McCarthy wrote: > I'll post a patch for this (based on your patch) later on today, so you > can see more concretely what I'm proposing. I need to clean up and test these more, but just to show concretely what I'm proposing, here are two patches.

Re: index format locale bug

2016-08-20 Thread Kevin J. McCarthy
On Sat, Aug 20, 2016 at 12:55:31AM -0500, Derek Martin wrote: > On Fri, Aug 19, 2016 at 06:29:41PM -0700, Kevin J. McCarthy wrote: > > Would it make sense to create a setting *just* for attributions, > > $attribution_locale, and then remove the $locale setting? This would > > then make it cleaner

Re: index format locale bug

2016-08-19 Thread Derek Martin
On Fri, Aug 19, 2016 at 06:29:41PM -0700, Kevin J. McCarthy wrote: > Would it make sense to create a setting *just* for attributions, > $attribution_locale, and then remove the $locale setting? This would > then make it cleaner to change the attribution in a send-hook without > having your index d

Re: index format locale bug

2016-08-19 Thread Derek Martin
On Fri, Aug 19, 2016 at 03:22:32PM -0700, Kevin J. McCarthy wrote: > So this is now setting LC_ALL. Is there a reason this wasn't done > before? Are there subtle bugs that may ensue because of this? I have > no idea, so I'd like to hear from everyone familiar with locales issues. No. Programs

Re: index format locale bug

2016-08-19 Thread Kevin J. McCarthy
On Fri, Aug 19, 2016 at 03:22:32PM -0700, Kevin J. McCarthy wrote: > So this is now setting LC_ALL. Is there a reason this wasn't done > before? Are there subtle bugs that may ensue because of this? I have > no idea, so I'd like to hear from everyone familiar with locales issues. Sorry, after t

Re: index format locale bug

2016-08-19 Thread Kevin J. McCarthy
On Fri, Aug 19, 2016 at 04:22:16PM -0500, Derek Martin wrote: > I have a patch that I believe does what's needed. It passed all my > testing, including running with my default config, setting locale, > unsetting locale, adding or removing a ! to the date format in > index_format. Thanks Derek! F

index format locale bug

2016-08-19 Thread Derek Martin
Kevin, I have a patch that I believe does what's needed. It passed all my testing, including running with my default config, setting locale, unsetting locale, adding or removing a ! to the date format in index_format. Note that: - The default locale is now "" allowing it to be set from OS sett