Hi, On Tuesday, 2016-08-23 12:18:42 -0500, Derek Martin wrote:
> On Tue, Aug 23, 2016 at 11:04:57AM +0200, Eike Rathke wrote: > > Well, I think removing the $locale variable was a stupid change ;-) > > Whether to add $attribution_locale I don't really care, fine for me > > as long as $locale is an alias for $attribution_locale. > > Aliases are bad. They make the code needlessly more complex, and can > lead to confusion when things don't quite work as expected. Alias for the configuration I meant. If both are used the last one wins. Simple. > As I said > originally, if we're keeping both, adding the new variable is worse > than just leaving locale but fixing the bug. Ok, stick with $locale then, even better. > > Also the change to not switch back and forth the locale for LC_TIME > > is good. But making $locale a) not work, and b) complain everytime > > a hook uses it is ugly and unnecessary. > > With the new behavior, it's clear that the ONLY reason to set this is > if you want to change the dates in your attributions. But that's exactly how I use it and it is broken now, I can't use the same configuration with different mutt versions. > In every other > case, you should (and now must) configure your operating system > properly to get what you want. This is The Right Thing™. My only > nitpick is the new variable name is too long. ;-) > > The new setting is clearly unnecessary, except for the send-hook case. > If you're already using it there, Actually I use it with reply-hook to change attribution. > it's a simple matter to: > > sed 's/locale/attribution_locale/g' It is not. See above, different mutt versions. > Or something similar. This should take you all of about 10s to fix, > permanently, so this argument is pretty bogus. The solution is bogus and doesn't fit the problem. > > Since $locale always only worked in LC_TIME context and defaulted to 'C' > > regardless of the users' environment, users who cared set it to their > > locale, > > But this is senseless. Just set your locale properly at the OS level > and the setting is superfluous. Don't tell me, I didn't. I just wanted to point out that those users likely will not notice a difference with the code change when keeping the $locale variable. > The average user should never even > need to know this setting exists. Most users will be able to (and > should) remove it from their config entirely. > > > But forcing the pile of existing muttrc reply-hook "~f '...'" 'set > > locale="..."; set attribution="..."' to change is awkward, > > especially if the same configuration is used on several machines of > > which some run mutt tip and some don't. > > This, by itself, is never a good reason to avoid making an otherwise > justifiable change. Old stuff breaks when you cross major milestones. I'm using mutt since ~20 years. Config things broke rarely. Only alternates and some. Renaming a configuration variable is not a justified change in this case because keeping the name won't break anything. The name may not exactly match the purpose the variable is used for now, but it's used in almost the same context (modulo changes to index dates that likey won't get much noticed). > That's a fact of continued development. If you don't want old stuff > to break, don't run new code. Haha. Very funny. Eike -- OpenPGP/GnuPG encrypted mail preferred in all private communication. Key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/ Care about Free Software, support the FSFE https://fsfe.org/support/?erack Use LibreOffice! https://www.libreoffice.org/
signature.asc
Description: PGP signature
