On Sat, Aug 20, 2016 at 12:55:31AM -0500, Derek Martin wrote: > On Fri, Aug 19, 2016 at 06:29:41PM -0700, Kevin J. McCarthy wrote: > > Would it make sense to create a setting *just* for attributions, > > $attribution_locale, and then remove the $locale setting? This would > > then make it cleaner to change the attribution in a send-hook without > > having your index dates change every time you send an email. > > If you're going to just trade locale for attribution_locale, it > doesn't seem worth making the change to me.... If you're going to > keep both that seems worse, not better. :)
I was proposing removing $locale (which affects dates everywhere), but adding a $attribution_locale so that reply attribution date formats can still be customized by a send-hook. The advantages are: * We can remove the setlocale() calls around the strftime() calls (except for the case where we have to set it to "C"). Yes, your patch does this, but additionally: * We don't have to create a new way to propogate changes to $locale into a setlocale() call. Just refreshing it in the index loop won't be enough (e.g. various hooks could change it) * We properly rely on LANG/locale environment variables. No situations like with Matthias where his $locale setting was goofed. It also forces people to remove the setting from their .muttrc. I'll post a patch for this (based on your patch) later on today, so you can see more concretely what I'm proposing. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
