[Mesa-dev] [PATCH] st/va: remove assert for single slice

2017-02-01 Thread Nayan Deshmukh
we anyway allow for multiple slices Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/va/picture_mpeg12.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture_mpeg12.c b/src/gallium/state_trackers/va/picture_mpeg12.c index 812e9e5..4d9c45f 100644

Re: [Mesa-dev] [PATCH] st/va: remove assert for single slice

2017-02-02 Thread Nayan Deshmukh
On Thu, Feb 2, 2017 at 3:34 PM, Christian König wrote: > Am 01.02.2017 um 13:59 schrieb Nayan Deshmukh: >> >> we anyway allow for multiple slices >> >> Signed-off-by: Nayan Deshmukh >> --- >> src/gallium/state_trackers/va/picture_mpeg12.c | 1 - >&g

Re: [Mesa-dev] [PATCH] st/va: remove assert for single slice

2017-02-10 Thread Nayan Deshmukh
On Fri, Feb 10, 2017 at 5:09 PM, Christian König wrote: > Sorry for the delay, as noted in the other mail I was on sick leave for a > while. > > > Am 03.02.2017 um 05:52 schrieb Nayan Deshmukh: >> >> On Thu, Feb 2, 2017 at 3:34 PM, Christian König >> wrote: >&

[Mesa-dev] [PATCH v2] st/va: remove assert for single slice

2017-02-10 Thread Nayan Deshmukh
we anyway allow for multiple slices v2: do not remove assert to check for buf->size Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/va/picture_mpeg12.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture_mpeg12.c b/src/gall

Re: [Mesa-dev] [PATCH] st/va: remove assert for single slice

2017-02-10 Thread Nayan Deshmukh
Hi Andy, I am attaching the patches. Does it cause any difference in the corruption in this video? https://drive.google.com/drive/folders/0BxP5-S1t9VEEbkR4dWhTUFozV2s Regards, Nayan On Fri, Feb 10, 2017 at 11:15 PM, Andy Furniss wrote: > Nayan Deshmukh wrote: > >>>> A

Re: [Mesa-dev] [PATCH] st/va: remove assert for single slice

2017-02-11 Thread Nayan Deshmukh
On Sat, Feb 11, 2017 at 12:00 AM, Andy Furniss wrote: > Nayan Deshmukh wrote: >> >> Hi Andy, >> >> I am attaching the patches. >> Does it cause any difference in the corruption in this video? >> >> https://drive.google.com/drive/folders/0BxP5-S1t9V

Re: [Mesa-dev] [PATCH] docs/releasing.html: reword "distro breaking changes" hunk

2017-02-20 Thread Nayan Deshmukh
Reviewed-by: Nayan Deshmukh On Tue, Feb 21, 2017 at 12:57 AM, Emil Velikov wrote: > From: Emil Velikov > > Suggested-by: Eric Engestrom > Signed-off-by: Emil Velikov > --- > docs/releasing.html | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)

[Mesa-dev] [PATCH] vl: u_upload_alloc might fail to allocate buffer in bicubic filter

2017-02-22 Thread Nayan Deshmukh
Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_bicubic_filter.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_bicubic_filter.c b/src/gallium/auxiliary/vl/vl_bicubic_filter.c index 570f153..275dd2a 100644 --- a/src/gallium

Re: [Mesa-dev] [PATCH] vl: u_upload_alloc might fail to allocate buffer in bicubic filter

2017-02-22 Thread Nayan Deshmukh
; Marek > > On Wed, Feb 22, 2017 at 9:25 AM, Nayan Deshmukh > wrote: >> Signed-off-by: Nayan Deshmukh >> --- >> src/gallium/auxiliary/vl/vl_bicubic_filter.c | 8 +--- >> 1 file changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/src

Re: [Mesa-dev] [PATCH] vl: u_upload_alloc might fail to allocate buffer in bicubic filter

2017-02-22 Thread Nayan Deshmukh
Can you please push the patch. On Thu, Feb 23, 2017 at 1:46 AM, Marek Olšák wrote: > OK sounds good. > > Reviewed-by: Marek Olšák > > Marek > > On Wed, Feb 22, 2017 at 9:16 PM, Nayan Deshmukh > wrote: >> On Thu, Feb 23, 2017 at 1:34 AM, Marek Olšák wrote: >>

[Mesa-dev] [PATCH 3/3] st/va: flush the context before calling flush_frontbuffer

2016-09-13 Thread Nayan Deshmukh
so that the texture is rendered to back buffer before calling flush_frontbuffer and can be copied to a different buffer in the function Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/va/surface.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 1/3] vl/dri3: handle the case of different GPU(v4)

2016-09-13 Thread Nayan Deshmukh
) v4: Use PIPE_BIND_SAMPLER_VIEW for back buffer in case when a seprate linear buffer is used (Michel) Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 62 --- 1 file changed, 49 insertions(+), 13 deletions(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 2/3] st/vdpau: flush the context before calling flush_frontbuffer

2016-09-13 Thread Nayan Deshmukh
so that the texture is rendered to back buffer before calling flush_frontbuffer and can be copied to a different buffer in the function Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/presentation.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a

Re: [Mesa-dev] [PATCH] st/vdpau: fix argument type to vlVdpOutputSurfaceDMABuf

2016-09-14 Thread Nayan Deshmukh
Hi Ilia, You also need to change the arguments in gallium/include/st/vdpau_dmabuf.h. Regards, Nayan. On Thu, Sep 15, 2016 at 3:56 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/gallium/state_trackers/vdpau/output.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[Mesa-dev] [PATCH v2] st/va: flush the context before calling flush_frontbuffer(v2)

2016-09-16 Thread Nayan Deshmukh
so that the texture is rendered to back buffer before calling flush_frontbuffer and can be copied to a different buffer in the function v2: change comment style Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/va/surface.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: handle the case of different GPU(v4)

2016-09-16 Thread Nayan Deshmukh
Hi Michel, Thanks for the review. On Fri, Sep 16, 2016 at 1:47 PM, Christian König wrote: > Am 16.09.2016 um 10:07 schrieb Michel Dänzer: > >> On 14/09/16 02:34 PM, Nayan Deshmukh wrote: >> >>> In case of prime when rendering is done on GPU other then the >>&

[Mesa-dev] [PATCH] vl/dri3: handle the case of different GPU(v4.1)

2016-09-16 Thread Nayan Deshmukh
) v4: Use PIPE_BIND_SAMPLER_VIEW for back buffer in case when a seprate linear buffer is used (Michel) v4.1: remove empty line Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 61 --- 1 file changed, 48 insertions(+), 13 deletions(-) diff

Re: [Mesa-dev] [PATCH] vl/dri3: handle the case of different GPU(v4.1)

2016-09-17 Thread Nayan Deshmukh
Hi Leo, Could you push the patches? I don't have the push access. Regards, Nayan. On Fri, Sep 16, 2016 at 7:44 PM, Leo Liu wrote: > This Patch is Reviewed-by: Leo Liu > > > On 09/16/2016 08:51 AM, Nayan Deshmukh wrote: > >> In case of prime when rendering is

[Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v4.1

2016-09-18 Thread Nayan Deshmukh
v2: avoid dividing by zero when calculating lanczos v4 (chk): rebase on master v4.1: fix the indexing in temp array Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/vl/vl_lanczos_filter.c | 445 +++ src/gallium

[Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

2016-09-18 Thread Nayan Deshmukh
This series implements lanczos interpolation filter. Andy, I have made some changes to the code. Can you test the patches. I hope the artifacts are reduced this time. Nayan Deshmukh (2): vl: add a lanczos interpolation filter v4.1 st/vdapu: use lanczos filter for scaling v4 src/gallium

[Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-18 Thread Nayan Deshmukh
HIGH_QUALITY_SCALING_L2 to HIGH_QUALTIY_SCALING_L7 uses lanczos filter with number representing the size of the sinc window. v3: avoid L8 and L9 to allow for other scaling algrithms v4 (chk): rebased on master Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c

Re: [Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

2016-09-18 Thread Nayan Deshmukh
Hi Andy, Thanks for testing the patches!! On Mon, Sep 19, 2016 at 5:24 AM, Andy Furniss wrote: > Andy Furniss wrote: > >> Nayan Deshmukh wrote: >> >>> This series implements lanczos interpolation filter. >>> >>> Andy, I have made some changes to t

Re: [Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

2016-09-19 Thread Nayan Deshmukh
Hi Andy, On Mon, Sep 19, 2016 at 3:27 PM, Andy Furniss wrote: > Nayan Deshmukh wrote: > >> Hi Andy, >> >> Thanks for testing the patches!! >> >> On Mon, Sep 19, 2016 at 5:24 AM, Andy Furniss >> wrote: >> >> Andy Furniss wrote: >>

Re: [Mesa-dev] [PATCH] vl/dri3: handle the case of different GPU(v4.1)

2016-09-19 Thread Nayan Deshmukh
Hi Leo, On Tue, Sep 20, 2016 at 1:56 AM, Leo Liu wrote: > > > On 09/17/2016 07:33 AM, Nayan Deshmukh wrote: > > Hi Leo, > > Could you push the patches? I don't have the push access. > > > > Can you rebase all your reviewed patches, and add RB to

[Mesa-dev] [PATCH 1/3] vl/dri3: handle the case of different GPU(v4.2)

2016-09-19 Thread Nayan Deshmukh
) v4: Use PIPE_BIND_SAMPLER_VIEW for back buffer in case when a seprate linear buffer is used (Michel) v4.1: remove empty line v4.2: destroy the context and handle the case when create_context fails (Emil) Signed-off-by: Nayan Deshmukh Reviewed-by: Leo Liu Acked-by: Michel Dänzer --- src

[Mesa-dev] [PATCH 2/3] st/vdpau: flush the context before calling flush_frontbuffer

2016-09-19 Thread Nayan Deshmukh
so that the texture is rendered to back buffer before calling flush_frontbuffer and can be copied to a different buffer in the function Signed-off-by: Nayan Deshmukh Reviewed-by: Michel Dänzer --- src/gallium/state_trackers/vdpau/presentation.c | 7 +-- 1 file changed, 5 insertions(+), 2

[Mesa-dev] [PATCH 3/3] st/va: flush the context before calling flush_frontbuffer(v2)

2016-09-19 Thread Nayan Deshmukh
so that the texture is rendered to back buffer before calling flush_frontbuffer and can be copied to a different buffer in the function v2: change comment style Signed-off-by: Nayan Deshmukh Reviewed-by: Michel Dänzer --- src/gallium/state_trackers/va/surface.c | 6 +- 1 file changed, 5

Re: [Mesa-dev] [PATCH v2] st/vdpau: fix argument type to vlVdpOutputSurfaceDMABuf

2016-09-19 Thread Nayan Deshmukh
It hasn't been committed yet. Ilia, Christian can someone push this. Regards, Nayan. On Thu, Sep 15, 2016 at 12:55 PM, Christian König wrote: > Am 15.09.2016 um 01:16 schrieb Ilia Mirkin: > >> Signed-off-by: Ilia Mirkin >> > > Reviewed-by: Christian König . > > > --- >> >> v1 -> v2: adjust typ

Re: [Mesa-dev] [PATCH 3/3] st/va: flush the context before calling flush_frontbuffer(v2)

2016-09-20 Thread Nayan Deshmukh
Thanks for the push Christian. Cheers, Nayan. On Tue, Sep 20, 2016 at 2:49 PM, Christian König wrote: > I've just pushed this version of the patchset. > > Thanks for the help, > Christian. > > > Am 20.09.2016 um 06:52 schrieb Nayan Deshmukh: > >> so that the

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: handle the case of different GPU(v4.2)

2016-09-20 Thread Nayan Deshmukh
r this question. Maybe Michel can answer this. Cheers, Nayan > Cheers > > Mike > > On Tue, 20 Sep 2016 at 05:52 Nayan Deshmukh > wrote: > >> In case of prime when rendering is done on GPU other then the >> server GPU, use a seprate linear buffer for each back buff

Re: [Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

2016-09-21 Thread Nayan Deshmukh
Hi Andy, On Wed, Sep 21, 2016 at 9:30 PM, Andy Furniss wrote: > Andy Furniss wrote: > >> Andy Furniss wrote: >> >>> Andy Furniss wrote: >>> Andy Furniss wrote: bz2 compressed vid showing the issue - > > https://drive.google.com/open?id=0BxP5-S1t9VEEUE5sbUFBV20zSms >

[Mesa-dev] [PATCH] intel/i965: fix resource leak

2016-09-25 Thread Nayan Deshmukh
CovID: 1373370 Signed-off-by: Nayan Deshmukh --- src/intel/tools/disasm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/disasm.c b/src/intel/tools/disasm.c index e527615..a747a0a 100644 --- a/src/intel/tools/disasm.c +++ b/src/intel/tools/disasm.c

[Mesa-dev] [PATCH v2] intel/i965: fix resource leak

2016-09-25 Thread Nayan Deshmukh
CovID: 1373370 v2: fix indentation Signed-off-by: Nayan Deshmukh --- src/intel/tools/disasm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/tools/disasm.c b/src/intel/tools/disasm.c index e527615..4ac7b90 100644 --- a/src/intel/tools/disasm.c +++ b/src/intel

Re: [Mesa-dev] [PATCH v2] intel/i965: fix resource leak

2016-09-25 Thread Nayan Deshmukh
Hi Lionel, Thanks for the review. Can you please push the patch. Regards, Nayan. On Sun, Sep 25, 2016 at 10:18 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Reviewed-by: Lionel Landwerlin > > > On 25/09/16 16:06, Nayan Deshmukh wrote: > >>

Re: [Mesa-dev] [PATCH] vl/dri3: handle the case of different GPU(v4.1)

2016-09-30 Thread Nayan Deshmukh
Hi Axel, On 1 Oct 2016 02:34, "Axel Davy" wrote: > > On 16/09/2016 14:51, Nayan Deshmukh wrote: >> >> >> bool flushed; >> + bool is_different_gpu; >> }; >> > > I get a warning when I build about incompatible pointer type a

[Mesa-dev] [PATCH] vl/dri3: fix warning about incompatible pointer type

2016-09-30 Thread Nayan Deshmukh
Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_dri3.c index 191a64b..2929928 100644 --- a/src/gallium/auxiliary/vl

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

2016-08-08 Thread Nayan Deshmukh
g on the first 2 problem for now and look at the third problem a little later. Regards, Nayan. > Regards, > Christian. > > > Am 04.08.2016 um 19:22 schrieb Nayan Deshmukh: > > Hi Andy, > > > On Thu, Aug 4, 2016 at 8:48 PM, Andy Furniss wrote: > >> Nayan De

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

2016-08-09 Thread Nayan Deshmukh
nterlacing. Am I right? Regards, Nayan. Regards, > Christian. > > > Am 08.08.2016 um 16:32 schrieb Nayan Deshmukh: > > Hi Christian, > > I am more than happy to solve these problems, the Lanczos filtering was > getting a little stale > anyway because I was not able

[Mesa-dev] [PATCH] st/vdpau: change the order in which filters are applied

2016-08-11 Thread Nayan Deshmukh
Apply the median and matrix filter before the compostioning we apply the deinterlacing first to avoid the extra overhead in processing the past and the future surfaces in deinterlacing. Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c | 23 +-- 1

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

2016-08-11 Thread Nayan Deshmukh
Hi Christian, I have a sent a patch which deals with the order in which filter are applied. I will send a patch probably by tomorrow which we use temporary surfaces. Regards, Nayan. On Wed, Aug 10, 2016 at 12:49 AM, Christian König wrote: > Am 09.08.2016 um 19:21 schrieb Nayan Deshmukh: >

[Mesa-dev] [PATCH] st/vdpau: change the order in which filters are applied

2016-08-11 Thread Nayan Deshmukh
Apply the median and matrix filter before the compostioning we apply the deinterlacing first to avoid the extra overhead in processing the past and the future surfaces in deinterlacing. Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c | 25 +++-- 1

[Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

2016-08-12 Thread Nayan Deshmukh
get_sampler_view_components() and iterate over VL_MAX_SURFACES (Christian) Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/src/gallium/state_trackers/vdpau/mixer.c b/src

[Mesa-dev] [PATCH] st/vdpau: use temporary buffers while applying filters

2016-08-16 Thread Nayan Deshmukh
We temporary buffers so that we don't read and write to the same surface at the same time. Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c | 54 ++-- 1 file changed, 45 insertions(+), 9 deletions(-) diff --git a/src/gallium/state_tra

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

2016-08-16 Thread Nayan Deshmukh
Hi Andy, On Tue, Aug 16, 2016 at 3:20 PM, Andy Furniss wrote: > Christian König wrote: >> >> Am 12.08.2016 um 16:02 schrieb Nayan Deshmukh: >>> >>> Apply the median and matrix filter before the compostioning >>> we apply the deinterlacing first to avoi

Re: [Mesa-dev] [PATCH] st/vdpau: use temporary buffers while applying filters

2016-08-16 Thread Nayan Deshmukh
Hi, I sent out the patch in a hurry and later noticed that the coding style is off at some places especially the ifs. I will send a new patch with fixes once the patch before this is verified by Andy. Regards, Nayan. On Tue, Aug 16, 2016 at 2:53 PM, Nayan Deshmukh wrote: > We temporary buff

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

2016-08-16 Thread Nayan Deshmukh
Hi Andy, Thanks for testing. On Tue, Aug 16, 2016 at 9:14 PM, Andy Furniss wrote: > Nayan Deshmukh wrote: >> >> Hi Andy, > > >> You are right :( It messes up chroma but only in case of sharpen at >> least for me. > > > Retested and denoise is also affe

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

2016-08-16 Thread Nayan Deshmukh
Hi Christian, On Tue, Aug 16, 2016 at 11:02 PM, Christian König wrote: > Am 16.08.2016 um 19:29 schrieb Nayan Deshmukh: >> >> Hi Andy, >> >> Thanks for testing. >> >> On Tue, Aug 16, 2016 at 9:14 PM, Andy Furniss wrote: >>> >>> Naya

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

2016-08-16 Thread Nayan Deshmukh
Hi Christian, On Tue, Aug 16, 2016 at 11:32 PM, Christian König wrote: > Am 16.08.2016 um 19:50 schrieb Nayan Deshmukh: >> >> Hi Christian, >> >> >> >> On Tue, Aug 16, 2016 at 11:02 PM, Christian König >> wrote: >>> >>> A

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

2016-08-18 Thread Nayan Deshmukh
ximum of 3 planes multiplied by two fields. > > > Ahh, thanks. > > >> >> Regards, >> Christian. >> >> Am 17.08.2016 um 11:11 schrieb Andy Furniss: >>> >>> Nayan Deshmukh wrote: >>> >>>> Sorry for the misleading language. W

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

2016-08-23 Thread Nayan Deshmukh
Regards, > Christian. > > > Am 18.08.2016 um 18:58 schrieb Nayan Deshmukh: >> >> Hi Christian, >> >> I tried using 3 instances of the filter with original height & width, >> height/2 & width and height/2 and width/2. >> I am applying the 3 fil

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

2016-08-25 Thread Nayan Deshmukh
ping On Mon, Aug 22, 2016 at 7:49 PM, Nayan Deshmukh wrote: > Hi Christian, > > I checked the height/width of the surface. I get a luma channel with > the original size. The Cb and Cr > channel with height/2 and width/2. I had tested videos with 4:2:0 > chroma format. B

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

2016-08-25 Thread Nayan Deshmukh
> Christian. > > > Am 25.08.2016 um 11:58 schrieb Nayan Deshmukh: >> >> ping >> >> On Mon, Aug 22, 2016 at 7:49 PM, Nayan Deshmukh >> wrote: >>> >>> Hi Christian, >>> >>> I checked the height/width of the surface. I get a l

[Mesa-dev] [PATCH] st/vdpau: use temporary buffers while applying filters

2016-08-25 Thread Nayan Deshmukh
We use temporary buffers so that we don't read and write to the same surface at the same time. We don't need to use linear layout now. Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c | 87 ++-- 1 file changed, 59 insertions(+), 28

Re: [Mesa-dev] [PATCH] st/vdpau: Revert "change the order in which filters are applied(v3)"

2016-08-26 Thread Nayan Deshmukh
Reviewed-by: Nayan Deshmukh On Fri, Aug 26, 2016 at 1:27 PM, Christian König wrote: > From: Christian König > > This reverts commit 09dff7ae2e179d5a3490481762c6bd3d50430c9f. > > Turned out this can cause some artifacts in the output. Let's revert > it for now until

[Mesa-dev] [PATCH v2] st/vdpau: use temporary buffers while applying filters

2016-08-26 Thread Nayan Deshmukh
Use temporary buffers so that we don't read and write to the same surface at the same time. We don't need to use linear layout now. v2: rebase the patch against reverted change Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c | 75 -

Re: [Mesa-dev] simple gallium clean-up task

2016-08-26 Thread Nayan Deshmukh
On Fri, Aug 26, 2016 at 6:48 AM, Rob Clark wrote: > On Thu, Aug 25, 2016 at 8:00 PM, Brian Paul wrote: >> If someone is looking for a simple task in gallium... >> >> In commit 0135bd44 Marek introduced some new enum types in p_defines.h >> >> In p_context.h we should replace several instances of

Re: [Mesa-dev] [PATCH v2] st/vdpau: use temporary buffers while applying filters

2016-08-29 Thread Nayan Deshmukh
Hi Christian, Should I start working on using DRI rather than delayed rendering to render directly to the surface? Also, I will need some direction to get started. Regards, Nayan. On Mon, Aug 29, 2016 at 3:26 PM, Christian König wrote: > Am 26.08.2016 um 11:53 schrieb Nayan Deshmukh: >&g

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-08-31 Thread Nayan Deshmukh
will look into the error tonight. My hardware has PRIME configuration. So is my hardware suitable for it? Just wanted to make sure. Regards, Nayan. On Wed, Aug 31, 2016 at 2:22 PM, Christian König wrote: > From: Nayan Deshmukh > > HIGH_QUALITY_SCALING_L2 to HIGH_QUALTIY_SCALING_

[Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-08-31 Thread Nayan Deshmukh
HIGH_QUALITY_SCALING_L2 to HIGH_QUALTIY_SCALING_L7 uses lanczos filter with number representing the size of the sinc window. v3: avoid L8 and L9 to allow for other scaling algrithms v4 (chk): rebased on master Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c

[Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v4

2016-08-31 Thread Nayan Deshmukh
v2: avoid dividing by zero when calculating lanczos v4 (chk): rebase on master Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/vl/vl_lanczos_filter.c | 445 +++ src/gallium/auxiliary/vl/vl_lanczos_filter.h

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-01 Thread Nayan Deshmukh
Thanks, Michel you saved a lot of my time. Christian, I will get in touch with Leo and get started on this task. Regards, Nayan. On Thu, Sep 1, 2016 at 2:08 PM, Christian König wrote: > Am 01.09.2016 um 05:28 schrieb Michel Dänzer: > >> On 31/08/16 06:53 PM, Nayan Deshmukh wrot

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-01 Thread Nayan Deshmukh
t refer to similar implement > in glx and egl from loader_dri3_helper.c by grep "is_different_gpu" > > > Regards, > Leo > > > > On 09/01/2016 05:18 AM, Nayan Deshmukh wrote: > > Thanks, Michel you saved a lot of my time. > > Christian, I will get i

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-05 Thread Nayan Deshmukh
wrote: > > On 02/09/16 12:58 AM, Leo Liu wrote: > > On 09/01/2016 11:54 AM, Nayan Deshmukh wrote: > > I saw the code in dri3_glx.c and I could somewhat relate some basic > code structure to the vl_winsys_dri3.c. But I am new to this and not aware > of the > terminology th

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-06 Thread Nayan Deshmukh
ystem. > we have to dig more into it. > > Regards, > Leo > > > > On 09/05/2016 03:51 AM, Nayan Deshmukh wrote: > > Hi Leo, > > I have tested your patch with my mplayer and it gives error when I try to > increase the size of the window. It gives the followi

[Mesa-dev] [PATCH] vl/dri3: handle the case of different GPU

2016-09-07 Thread Nayan Deshmukh
use a linear buffer in case of back buffer Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_dri3.c index

Re: [Mesa-dev] [PATCH] vl/dri3: handle the case of different GPU

2016-09-07 Thread Nayan Deshmukh
Hi Michel, Sorry for the bad patch. I'll fix the coding style in the next patch. On Thu, Sep 8, 2016 at 9:03 AM, Michel Dänzer wrote: > On 08/09/16 02:48 AM, Nayan Deshmukh wrote: > > use a linear buffer in case of back buffer > > > > Signed-off-by: Nayan Deshmukh

[Mesa-dev] [PATCH v2] vl/dri3: handle the case of different GPU

2016-09-09 Thread Nayan Deshmukh
use a linear buffer in case of back buffer v2: Use a seprate linear buffer for each back buffer Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 82 --- 1 file changed, 63 insertions(+), 19 deletions(-) diff --git a/src/gallium

Re: [Mesa-dev] [PATCH v2] vl/dri3: handle the case of different GPU

2016-09-09 Thread Nayan Deshmukh
On Fri, Sep 9, 2016 at 7:03 PM, Emil Velikov wrote: > Hi Nayan, > > Just a couple of fly-by comments. As always don't read too much into them. > > On 9 September 2016 at 14:17, Nayan Deshmukh > wrote: > > use a linear buffer in case of back buffer > > >

[Mesa-dev] [PATCH v3] vl/dri3: handle the case of different GPU

2016-09-09 Thread Nayan Deshmukh
) Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 63 --- 1 file changed, 50 insertions(+), 13 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_dri3.c index 3d596a6..3607f86 100644

Re: [Mesa-dev] [PATCH v3] vl/dri3: handle the case of different GPU

2016-09-12 Thread Nayan Deshmukh
Hi Michel, On Mon, Sep 12, 2016 at 7:02 PM, Leo Liu wrote: > > > On 09/12/2016 04:31 AM, Michel Dänzer wrote: > >> On 10/09/16 12:49 AM, Nayan Deshmukh wrote: >> >>> In case of prime when rendering is done on GPU other then the >>> server GPU, use a

[Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-24 Thread Nayan Deshmukh
Suggested-by: Leo Liu Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_winsys.h | 4 ++ src/gallium/auxiliary/vl/vl_winsys_dri3.c | 89 +++ 2 files changed, 83 insertions(+), 10 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys.h b/src

[Mesa-dev] [PATCH 3/3] st/vdpau: remove the delayed rendering hack

2016-10-24 Thread Nayan Deshmukh
the hack was introduced to avoid an extra copying but now with dri3 we don't need it anymore Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/bitmap.c| 2 - src/gallium/state_trackers/vdpau/device.c| 50 - src/gallium/state_trackers/vdpau/mi

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-24 Thread Nayan Deshmukh
will won't work if we fallback to DRI2 on runtime I will send a v2 to take care of this. Regards, Nayan. > Regards, > Christian. > > > Am 24.10.2016 um 15:55 schrieb Nayan Deshmukh: > >> Suggested-by: Leo Liu >> Signed-off-by: Nayan Deshmukh >> --- >&

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-24 Thread Nayan Deshmukh
ing it as I am not able to reproduce it on my system. It may be the case of a single GPU which is causing the problem. Regards, Nayan. > Regards, > Leo > > > On 10/24/2016 11:27 AM, Nayan Deshmukh wrote: > > > > > > On Mon, Oct 24, 2016 at 8:48 PM, Christian König &g

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-25 Thread Nayan Deshmukh
On Tue, Oct 25, 2016 at 11:08:12AM -0400, Leo Liu wrote: > > > On 10/25/2016 02:01 AM, Nayan Deshmukh wrote: > > Hi Leo, > > > > On Mon, Oct 24, 2016 at 03:18:19PM -0400, Leo Liu wrote: > > > There are a couple of other issues from a brief test:

[Mesa-dev] [PATCH] st/vdpau: use dri3 to direclty send the buffer to X(v1.1)

2016-10-25 Thread Nayan Deshmukh
this avoids an extra copy which occurs in case of dri2 v1.1: fallback to dri2 if dri3 fails to initialize Suggested-by: Christian König Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/presentation.c | 58 ++--- 1 file changed, 32 insertions(+), 26

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-25 Thread Nayan Deshmukh
Hi Andy, It seems that you have compiled mesa with DRI3 enabled but vl_dri3_screen_create returns runs when called in device.c and hence VDPAU fallbacks to using DRI2. BTW I have sent in the v1.1 for patch 2 which play the video using dri2 in case of a fallback. Regards, Nayan. _

[Mesa-dev] [PATCH] st/vdpau: remove the delayed rendering hack(v1.1)

2016-10-25 Thread Nayan Deshmukh
the hack was introduced to avoid an extra copying but now with dri3 we don't need it anymore v1.1: rebasing Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/bitmap.c| 2 - src/gallium/state_trackers/vdpau/device.c| 50 - src/gallium/state_tra

[Mesa-dev] [PATCH 2/3] st/vdpau: use dri3 to direclty send the buffer to X

2016-10-27 Thread Nayan Deshmukh
this avoids an extra copy which occurs in case of dri2 Suggested-by: Christian König Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/presentation.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/state_trackers/vdpau/presentation.c b/src/gallium

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Tue, Oct 25, 2016 at 11:11:13PM +0100, Andy Furniss wrote: > Nayan Deshmukh wrote: > > Hi Andy, > > > > It seems that you have compiled mesa with DRI3 enabled but > > vl_dri3_screen_create returns > > runs when called in device.c and hence VDPAU fallbacks t

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
s/runs/null/ On Wed, Oct 26, 2016 at 01:57:12AM +0530, Nayan Deshmukh wrote: > Hi Andy, > > It seems that you have compiled mesa with DRI3 enabled but > vl_dri3_screen_create returns > runs when called in device.c and hence VDPAU fallbacks to using DRI2. > > BTW I have

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 11:52:13AM +0100, Andy Furniss wrote: > Andy Furniss wrote: > > Michel Dänzer wrote: > > > On 26/10/16 08:07 PM, Andy Furniss wrote: > > > > > > > > The bad = Starting with DRI3 (which is default) I still get trashed > > > > rendering full screen. Windowed including re-sizi

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: > > > On 10/24/2016 09:55 AM, Nayan Deshmukh wrote: > > Suggested-by: Leo Liu > > Signed-off-by: Nayan Deshmukh > > --- > > src/gallium/auxiliary/vl/vl_winsys.h | 4 ++ > > src/gal

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 10:17 PM, Leo Liu wrote: > > > On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: > >> On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: >> >>> >>> On 10/24/2016 09:55 AM, Nayan Deshmukh wrote: >>> >>>

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 10:50 PM, Nayan Deshmukh wrote: > > > On Thu, Oct 27, 2016 at 10:17 PM, Leo Liu wrote: > >> >> >> On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: >> >>> On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: >>>

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 11:07 PM, Leo Liu wrote: > > > On 10/27/2016 01:20 PM, Nayan Deshmukh wrote: > > > > On Thu, Oct 27, 2016 at 10:17 PM, Leo Liu wrote: > >> >> >> On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: >> >>> On Thu, Oct 27,

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-10-27 Thread Nayan Deshmukh
On Fri, Oct 28, 2016 at 7:00 AM, Michel Dänzer wrote: > On 28/10/16 03:08 AM, Marek Olšák wrote: > > On Thu, Oct 27, 2016 at 5:23 PM, Emil Velikov > wrote: > >> On 17 October 2016 at 10:37, Marek Olšák wrote: > >>> Reverting the whole commit is too much. You can just remove the PIPE > BIND > >>

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-10-28 Thread Nayan Deshmukh
On Fri, Oct 28, 2016 at 2:14 PM, Michel Dänzer wrote: > On 28/10/16 03:58 PM, Nayan Deshmukh wrote: > > On Fri, Oct 28, 2016 at 7:00 AM, Michel Dänzer > <mailto:mic...@daenzer.net>> wrote: > > > > On 28/10/16 03:08 AM, Marek Olšák wrote: > >

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-10-28 Thread Nayan Deshmukh
On Fri, Oct 28, 2016 at 2:43 PM, Michel Dänzer wrote: > On 28/10/16 06:04 PM, Nayan Deshmukh wrote: > > On Fri, Oct 28, 2016 at 2:14 PM, Michel Dänzer > <mailto:mic...@daenzer.net>> wrote: > > > > On 28/10/16 03:58 PM, Nayan Deshmukh wrote: > > &g

Re: [Mesa-dev] [PATCH] Revert "st/vdpau: use linear layout for output surfaces"

2016-10-31 Thread Nayan Deshmukh
Hi Guys, This not in master yet, I have tested it on my system(I+A) and it works fine. Regards, Nayan On Sat, Oct 1, 2016 at 1:57 PM, Christian König wrote: > Am 01.10.2016 um 00:06 schrieb Marek Olšák: > >> On Fri, Sep 30, 2016 at 11:23 PM, Dave Airlie wrote: >> >>> On 1 October 2016 at 06:1

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-11-02 Thread Nayan Deshmukh
Hi Leo, To support clipping of the output texture I was trying to send a xcb_xfixes_region as the fifth argument (i.e valid-area) to xcb_present_pixmap but it still displays the entire surface. Am I missing something? Regards, Nayan ___ mesa-dev mailing

[Mesa-dev] [PATCH 0/3] Use dri3 in vdpau to send handle of texture to X

2016-11-04 Thread Nayan Deshmukh
Hi all, This is re-send of the previous series. It contains the updated patches in response to Leo, Christian and Emil's comments. Please Review. Regards, Nayan Nayan Deshmukh (3): vl/dri3: use external texture as back buffers(v2) st/vdpau: use dri3 to direclty send the buffer to X

[Mesa-dev] [PATCH 2/3] st/vdpau: use dri3 to direclty send the buffer to X(v1.1)

2016-11-04 Thread Nayan Deshmukh
this avoids an extra copy which occurs in case of dri2 v1.1: fallback to dri2 if dri3 fails to initialize Suggested-by: Christian König Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/presentation.c | 58 ++--- 1 file changed, 32 insertions(+), 26

[Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v2)

2016-11-04 Thread Nayan Deshmukh
dri3 allows us to send handle of a texture directly to X so this patch allows a state tracker to directly send its texture to X to be used as back buffer and avoids extra copying v2: use clip width/height to display a portion of the surface Suggested-by: Leo Liu Signed-off-by: Nayan Deshmukh

[Mesa-dev] [PATCH 3/3] st/vdpau: remove the delayed rendering hack(v1.1)

2016-11-04 Thread Nayan Deshmukh
the hack was introduced to avoid an extra copying but now with dri3 we don't need it anymore v1.1: rebasing Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/bitmap.c| 2 - src/gallium/state_trackers/vdpau/device.c| 50 - src/gallium/state_tra

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v2)

2016-11-04 Thread Nayan Deshmukh
On Fri, Nov 04, 2016 at 12:20:51PM -0400, Leo Liu wrote: > Hi Nayan, > > With this patch, the resizing corruption is fixed, thanks for that. > > Still a few comments below. > > > On 11/04/2016 03:08 AM, Nayan Deshmukh wrote: > > dri3 allows us to send handle of

[Mesa-dev] [PATCH v3] vl/dri3: use external texture as back buffers(v3)

2016-11-04 Thread Nayan Deshmukh
variables handle vaapi path Suggested-by: Leo Liu Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_winsys.h | 4 + src/gallium/auxiliary/vl/vl_winsys_dri3.c | 117 ++ 2 files changed, 108 insertions(+), 13 deletions(-) diff --git a/src/gallium

Re: [Mesa-dev] [PATCH v3] vl/dri3: use external texture as back buffers(v3)

2016-11-04 Thread Nayan Deshmukh
Hi Leo, Thanks for the reference patch. There are only a number of output surfaces taking turns as the mixer render targets, so we probably can use the same pixmap corresponding to each of output surface texture. The mixer renders to a VdpOutputSurface which is provided to it by the ap

Re: [Mesa-dev] [PATCH v3] vl/dri3: use external texture as back buffers(v3)

2016-11-07 Thread Nayan Deshmukh
On Mon, Nov 7, 2016 at 8:31 PM, Leo Liu wrote: > > > On 11/05/2016 02:44 AM, Nayan Deshmukh wrote: > >> Hi Leo, >> >> Thanks for the reference patch. >> >> There are only a number of output surfaces taking turns as the >> mixer render

Re: [Mesa-dev] [PATCH] anv: Add missing error-checking to anv_block_pool_init

2016-11-20 Thread Nayan Deshmukh
Reviewed-by: Nayan Deshmukh On Sun, Nov 20, 2016 at 4:41 PM, Mun Gwan-gyeong wrote: > When the allocation fails on u_vector_init(), it returns 0 > This fixes u_vector_init failure path on anv_block_pool_init > > CID 1394319 > > Signed-off-by: Mun Gwan-gyeong > --

  1   2   3   >