From: Nanley Chery
Mesa unconditionally sets this driver flag to true in
_mesa_init_extensions(). There is therefore no need for
the driver to communicate support for this extension.
Replace the driver capability flag with ::dummy_true.
Signed-off-by: Nanley Chery
Reviewed-by: Chad Versace
From: Nanley Chery
Make API context and version checks done by the helper functions pass
unconditionally while meta is in progress. This transparently makes
extension checks solely dependent on struct gl_extensions while in meta.
v2. Use 8-bit wide datatype instead GLuint.
Signed-off-by
From: Nanley Chery
Rename the following types and variables:
* struct extension -> struct mesa_extension,
like the mesa_format type.
* extension_table -> _mesa_extension_table,
like the _mesa_extension_override_{enables,disables} structs.
Suggested-by: Marek Olšák
Suggested-by
From: Nanley Chery
Stop leaks into GLES contexts in _mesa_target_can_be_compressed().
v2. Remove OpenGL 3.1 requirement (Marek, Chad)
Signed-off-by: Nanley Chery
---
src/mesa/main/glformats.c | 3 +--
src/mesa/main/teximage.c | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff
From: Nanley Chery
This variable existed to enable 0 as a valid error value for
name_to_offset(). Since o(extension_sentinel) is also a valid
error value, save space and replace this mysterious variable
with a less mysterious one (extension_sentinel).
v2. Reword git comment and update function
From: Nanley Chery
Replace the open-coded check for extension support with
the helper function that determines this support.
v2. Don't check for pre-1.2 desktop GL contexts
Signed-off-by: Nanley Chery
---
src/mesa/main/glformats.c | 3 +--
src/mesa/main/texcompress.c | 3 +--
2
From: Nanley Chery
Stop leaks into GLES 1 contexts in _mesa_get_compressed_formats()
and lookup_view_class().
The extension spec lists GLES 2.0.25 and 3.0.2 dependencies,
so update the extension table accordingly.
v2. Remove references to pre-1.2 desktop GL contexts
Signed-off-by: Nanley
From: Nanley Chery
Generate functions which determine if an extension is supported in the
current context. Initially, enums were going to be explicitly used with
_mesa_extension_supported(). The idea to embed the function and enums
into generated helper functions was suggested by Kristian
From: Nanley Chery
All gl_extensions structs are zero-initialized by default.
There is therefore no need to memset the structs to 0. Also,
remove the open-coded memset in _mesa_init_extensions().
v2. Drop the hunk that zero-initializes the global structs (Marek)
Signed-off-by: Nanley Chery
From: Nanley Chery
Stop leaks into GLES contexts in _mesa_base_tex_format() and
lookup_view_class().
Stop allowing compressed sRGB formats as valid formats in GLES3
contexts. These formats are only exposed to contexts advertising
EXT_texture_sRGB.
v2. Remove references to pre-1.2 desktop GL
On Wed, Nov 11, 2015 at 2:07 PM, Chad Versace
wrote:
> On Fri 30 Oct 2015, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > Simplify future updates to the extension struct array by removing
> > the sentinel.
> >
> > Signed-off-by: Nanley Chery
>
On Wed, Nov 11, 2015 at 3:00 PM, Chad Versace
wrote:
> On Fri 30 Oct 2015, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > Make API context and version checks done by the helper functions pass
> > unconditionally while meta is in progress. This transparently makes
From: Nanley Chery
Hopefully fixes the MSVC build error reported by Roland.
Signed-off-by: Nanley Chery
---
I'm not sure why the array size being unknown is an issue. Please let
me know if this fixes the build issue.
src/mesa/main/extensions.c | 2 +-
src/mesa/main/extensions.h
On Thu, Nov 12, 2015 at 3:17 PM, Brian Paul wrote:
> On 11/12/2015 04:03 PM, Nanley Chery wrote:
>
>> From: Nanley Chery
>>
>> Hopefully fixes the MSVC build error reported by Roland.
>>
>> Signed-off-by: Nanley Chery
>> ---
>>
>> I&#
location.
Cc: "17.0"
Cc: Iago Toral
Cc: Jason Ekstrand
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index
Commit 968ffd6c868af7226e8f889573eef709888151cb stored the last subpass
index of all the attachments but that of the depth-stencil attachment.
This could cause depth buffers used in multiple subpasses not to be in
the requested final layout. Fix this error.
Cc: "17.0"
Signed-off-by: Na
: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index 63911f2c8e..cba876b58e 100644
--- a/src/intel/vulkan/genX_cmd_buffer.c
+++ b/src
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
index 2cf972bb61..759d2ae944 100644
--- a/src/intel/vulkan/anv_blorp.c
+++ b/src/intel/vulkan
ng;
> in ISL and is only used to refer to single-sample color compression.
> It's also much shorter which is nice.
This patch is,
Reviewed-by: Nanley Chery
> ---
> src/intel/isl/isl.h | 4 ++--
> src/intel/isl/isl_format.c | 8 +
On Wed, Feb 01, 2017 at 10:11:42PM -0800, Jason Ekstrand wrote:
> This improves the performance of Dota 2 on my Sky Lake Skull Canyon
> machine by about 2-3%.
> ---
> src/intel/vulkan/anv_private.h | 1 +
> src/intel/vulkan/gen8_cmd_buffer.c | 155
> -
>
On Wed, Feb 01, 2017 at 05:43:53PM -0800, Jason Ekstrand wrote:
> In order to get good performance numbers for this, I had to hack up the
> driver to whack wm_prog_data::uses_kill to true to emulate a discard and
> used the Sascha "shadowmapping" demo. Setting uses_kill to true dropped
> the frame
On Tue, Jan 31, 2017 at 06:51:12PM -0800, Jason Ekstrand wrote:
> ---
> src/intel/isl/isl_surface_state.c | 32
> 1 file changed, 32 insertions(+)
>
> diff --git a/src/intel/isl/isl_surface_state.c
> b/src/intel/isl/isl_surface_state.c
> index b735478..c7b220b 10
On Thu, Feb 02, 2017 at 12:28:02PM -0800, Jason Ekstrand wrote:
> On Thu, Feb 2, 2017 at 11:09 AM, Nanley Chery wrote:
>
> > On Tue, Jan 31, 2017 at 06:51:12PM -0800, Jason Ekstrand wrote:
> > > ---
> > > src/intel/isl/isl_surface_state.c | 32
On Thu, Feb 02, 2017 at 12:53:33PM -0800, Jason Ekstrand wrote:
> On Thu, Feb 2, 2017 at 10:55 AM, Nanley Chery wrote:
>
> > On Wed, Feb 01, 2017 at 10:11:42PM -0800, Jason Ekstrand wrote:
> > > This improves the performance of Dota 2 on my Sky Lake Skull Canyon
>
On Thu, Feb 02, 2017 at 01:37:56PM -0800, Nanley Chery wrote:
> On Thu, Feb 02, 2017 at 12:53:33PM -0800, Jason Ekstrand wrote:
> > On Thu, Feb 2, 2017 at 10:55 AM, Nanley Chery wrote:
> >
> > > On Wed, Feb 01, 2017 at 10:11:42PM -0800, Jason Ekstrand wrote:
> > >
On Thu, Feb 02, 2017 at 01:55:30PM -0800, Jason Ekstrand wrote:
> On Thu, Feb 2, 2017 at 1:45 PM, Nanley Chery wrote:
>
> > On Thu, Feb 02, 2017 at 01:37:56PM -0800, Nanley Chery wrote:
> > > On Thu, Feb 02, 2017 at 12:53:33PM -0800, Jason Ekstrand wrote:
> > > >
On Thu, Feb 02, 2017 at 03:10:21PM -0800, Jason Ekstrand wrote:
> On Thu, Feb 2, 2017 at 3:01 PM, Nanley Chery wrote:
>
> > On Thu, Feb 02, 2017 at 01:55:30PM -0800, Jason Ekstrand wrote:
> > > On Thu, Feb 2, 2017 at 1:45 PM, Nanley Chery
> > wrote:
> > >
&
On Thu, Feb 02, 2017 at 08:15:30AM -0800, Nanley Chery wrote:
Polite ping.
> Signed-off-by: Nanley Chery
> ---
> src/intel/vulkan/anv_blorp.c | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/a
On Thu, Feb 02, 2017 at 01:38:45PM -0800, Jason Ekstrand wrote:
> Perf numbers in the commit message would be nice
>
How's the following?
Reclaims about 1.95% FPS for Dota 2 on some configurations.
> Reviewed-by: Jason Ekstrand
Thanks!
>
> On Thu, Feb 2, 2017 at 8
On Fri, Feb 03, 2017 at 12:27:18PM -0800, Jason Ekstrand wrote:
> On Thu, Feb 2, 2017 at 1:45 PM, Nanley Chery wrote:
>
> > On Thu, Feb 02, 2017 at 01:37:56PM -0800, Nanley Chery wrote:
> > > On Thu, Feb 02, 2017 at 12:53:33PM -0800, Jason Ekstrand wrote:
> > > >
On Wed, Feb 01, 2017 at 08:07:22PM -0800, Jason Ekstrand wrote:
> The only mechanism Vulkan provides for disabling stencil writes is to set
This isn't the only mechanism for explicitly disabling stencil writes.
Stencil writes can also be disabled by disabling stencil testing (as can
be seen in thi
On Tue, Feb 07, 2017 at 12:25:18PM -0800, Jason Ekstrand wrote:
> On Tue, Feb 7, 2017 at 12:13 PM, Nanley Chery wrote:
>
> > On Wed, Feb 01, 2017 at 08:07:22PM -0800, Jason Ekstrand wrote:
> > > The only mechanism Vulkan provides for disabling stencil writes is to set
> &
On Wed, Feb 08, 2017 at 01:31:54PM +0100, Juan A. Suarez Romero wrote:
> In pre-Broadwell devices, as B4G4R4A4 is not supported natively, we
> workaround it by using a format with a more complex swizzle, that uses
> blue in alpha component.
>
> Signed-off-by: Juan A. Suarez Romero
> ---
> src/in
-by: Juan A. Suarez Romero
> ---
> src/intel/isl/isl_surface_state.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
This patch is,
Reviewed-by: Nanley Chery
>
> diff --git a/src/intel/isl/isl_surface_state.c
> b/src/intel/isl/isl_surface_state.c
> inde
On Wed, Feb 08, 2017 at 06:42:44PM +0100, Juan A. Suarez Romero wrote:
> On Wed, 2017-02-08 at 09:27 -0800, Nanley Chery wrote:
> > On Wed, Feb 08, 2017 at 01:31:54PM +0100, Juan A. Suarez Romero wrote:
> > > In pre-Broadwell devices, as B4G4R4A4 is not supported natively, we
&
flect the new performance data? You could alternatively
omit the current data if you'd prefer.
With that change, this patch is
Reviewed-by: Nanley Chery
> --Jason
>
>
> > --Jason
> >
> >
> > On Tue, Feb 7, 2017 at 2:28 PM, Nanley Chery
> > wrote:
>
On Thu, Feb 02, 2017 at 01:26:05PM -0800, Jason Ekstrand wrote:
> In order to get good performance numbers for this, I had to hack up the
> driver to whack wm_prog_data::uses_kill to true to emulate a discard and
> used the Sascha "shadowmapping" demo. Setting uses_kill to true dropped
> the frame
On Thu, Feb 09, 2017 at 09:41:11AM +0100, Juan A. Suarez Romero wrote:
> On Wed, 2017-02-08 at 10:53 -0800, Nanley Chery wrote:
> > On Wed, Feb 08, 2017 at 06:42:44PM +0100, Juan A. Suarez Romero wrote:
> > > On Wed, 2017-02-08 at 09:27 -0800, Nanley Chery wrote:
> > > &
On Wed, Feb 08, 2017 at 06:27:52PM -0800, Jason Ekstrand wrote:
> On Wed, Feb 8, 2017 at 5:34 PM, Nanley Chery wrote:
>
> > On Thu, Feb 02, 2017 at 01:26:05PM -0800, Jason Ekstrand wrote:
> > > In order to get good performance numbers for this, I had to hack up the
On Wed, Feb 08, 2017 at 09:38:52PM -0800, Jason Ekstrand wrote:
> On Wed, Feb 8, 2017 at 8:11 PM, Jason Ekstrand wrote:
>
> > On Wed, Feb 8, 2017 at 6:27 PM, Jason Ekstrand
> > wrote:
> >
> >> On Wed, Feb 8, 2017 at 5:34 PM, Nanley Chery
> >> wrote
On Wed, Feb 01, 2017 at 05:43:54PM -0800, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/genX_pipeline.c | 34 ++
> 1 file changed, 18 insertions(+), 16 deletions(-)
This patch is
Reviewed-by: Nanley Chery
>
> diff --git a/src/intel/vulkan/genX_
On Wed, Feb 01, 2017 at 05:43:55PM -0800, Jason Ekstrand wrote:
> This seemed to help Dota 2 by a percent or two.
I wasn't able to reproduce this on SKL, could you qualify this with "on
BDW"?
> ---
> src/intel/vulkan/genX_pipeline.c | 133
> +--
> 1 file chan
On Fri, Feb 10, 2017 at 12:44:02AM +, Emil Velikov wrote:
> On 24 January 2017 at 00:55, Nanley Chery wrote:
> > Cc: "13.0 17.0"
> Nanley please take a look at the nominations page [1] and especially
> at the note in the end ;-)
> That said, I've picked th
On Thu, Feb 09, 2017 at 11:38:31AM -0800, Jason Ekstrand wrote:
> On Thu, Feb 9, 2017 at 10:33 AM, Nanley Chery wrote:
>
> > On Wed, Feb 08, 2017 at 06:27:52PM -0800, Jason Ekstrand wrote:
> > > On Wed, Feb 8, 2017 at 5:34 PM, Nanley Chery
> > wrote:
> > >
&
On Fri, Feb 10, 2017 at 10:59:38AM -0800, Jason Ekstrand wrote:
> On Thu, Feb 9, 2017 at 5:32 PM, Nanley Chery wrote:
>
> > On Wed, Feb 01, 2017 at 05:43:55PM -0800, Jason Ekstrand wrote:
> > > This seemed to help Dota 2 by a percent or two.
> >
> > I wasn'
/genX_pipeline.c | 42
> 9 files changed, 221 insertions(+), 2 deletions(-)
This patch is,
Reviewed-by: Nanley Chery
>
> diff --git a/src/intel/vulkan/TODO b/src/intel/vulkan/TODO
> index 38acc0d..f8b73a1 100644
> --- a/src/intel/vulkan/TODO
> +++ b/src/intel/vu
On Fri, Feb 10, 2017 at 10:59:38AM -0800, Jason Ekstrand wrote:
> On Thu, Feb 9, 2017 at 5:32 PM, Nanley Chery wrote:
>
> > On Wed, Feb 01, 2017 at 05:43:55PM -0800, Jason Ekstrand wrote:
> > > This seemed to help Dota 2 by a percent or two.
> >
> > I wasn'
On Thu, Feb 09, 2017 at 05:32:55PM -0800, Nanley Chery wrote:
> On Wed, Feb 01, 2017 at 05:43:55PM -0800, Jason Ekstrand wrote:
> > This seemed to help Dota 2 by a percent or two.
>
> I wasn't able to reproduce this on SKL, could you qualify this with "on
> BDW"?
On Fri, Feb 10, 2017 at 11:02:19AM -0800, Jason Ekstrand wrote:
> It's a bit hard to measure because it almost gets lost in the noise,
> but this seemed to help Dota 2 by a percent or two on my Broadwell
> GT3e desktop.
>
> Reviewed-by: Lionel Landwerlin
> ---
> src/intel/vulkan/genX_pipeline.c
On Fri, Feb 10, 2017 at 02:55:42PM -0800, Nanley Chery wrote:
> On Fri, Feb 10, 2017 at 11:02:19AM -0800, Jason Ekstrand wrote:
> > It's a bit hard to measure because it almost gets lost in the noise,
> > but this seemed to help Dota 2 by a percent or two on my Broadw
On Fri, Feb 10, 2017 at 03:21:38PM -0800, Jason Ekstrand wrote:
> On Fri, Feb 10, 2017 at 2:55 PM, Nanley Chery wrote:
>
> > On Fri, Feb 10, 2017 at 11:02:19AM -0800, Jason Ekstrand wrote:
> > > It's a bit hard to measure because it almost gets lost in the noise,
>
On Fri, Feb 10, 2017 at 03:31:32PM -0800, Jason Ekstrand wrote:
> On Fri, Feb 10, 2017 at 3:18 PM, Nanley Chery wrote:
>
> > On Fri, Feb 10, 2017 at 02:55:42PM -0800, Nanley Chery wrote:
> > > On Fri, Feb 10, 2017 at 11:02:19AM -0800, Jason Ekstrand wrote:
> > >
On Fri, Feb 10, 2017 at 09:26:52PM -0800, Jason Ekstrand wrote:
> On Fri, Feb 10, 2017 at 5:29 PM, Nanley Chery wrote:
>
> > On Fri, Feb 10, 2017 at 03:31:32PM -0800, Jason Ekstrand wrote:
> > > On Fri, Feb 10, 2017 at 3:18 PM, Nanley Chery
> > wrote:
> > >
&
On Fri, Feb 10, 2017 at 05:04:48PM -0800, Jason Ekstrand wrote:
> On Fri, Feb 10, 2017 at 4:47 PM, Nanley Chery wrote:
>
> > On Fri, Feb 10, 2017 at 03:21:38PM -0800, Jason Ekstrand wrote:
> > > On Fri, Feb 10, 2017 at 2:55 PM, Nanley Chery
> > wrote:
> > >
&
tel/vulkan/genX_pipeline.c | 175
> +++
> 1 file changed, 141 insertions(+), 34 deletions(-)
>
This patch is,
Reviewed-by: Nanley Chery
> diff --git a/src/intel/vulkan/genX_pipeline.c
> b/src/intel/vulkan/genX_pipeline.c
> index 71b9
On Fri, Feb 10, 2017 at 11:02:21AM -0800, Jason Ekstrand wrote:
> This improves the performance of Dota 2 on my Sky Lake Skull Canyon
> machine by about 2-3%.
>
This patch looks good. Could we compare our setup and testing in the
office? I can't reproduce these numbers.
-Nanley
> Reviewed-by: L
On Mon, Feb 13, 2017 at 08:45:47PM -0800, Jason Ekstrand wrote:
> On Mon, Feb 13, 2017 at 6:13 PM, Jason Ekstrand
> wrote:
>
> > On Mon, Feb 13, 2017 at 5:00 PM, Nanley Chery
> > wrote:
> >
> >> On Fri, Feb 10, 2017 at 11:02:21AM -0800, Jason Ekstrand wrote:
On Tue, Feb 14, 2017 at 09:37:20AM -0800, Jason Ekstrand wrote:
> On Tue, Feb 14, 2017 at 9:35 AM, Connor Abbott wrote:
>
> > On Tue, Feb 14, 2017 at 12:33 PM, Jason Ekstrand
> > wrote:
> > > On Tue, Feb 14, 2017 at 9:23 AM, Connor Abbott
> > wrote:
> > >>
> > >> Even though we supported both c
On Tue, Feb 14, 2017 at 10:53:37AM -0800, Jason Ekstrand wrote:
> On Tue, Feb 14, 2017 at 10:35 AM, Nanley Chery
> wrote:
>
> > On Mon, Feb 13, 2017 at 08:45:47PM -0800, Jason Ekstrand wrote:
> > > On Mon, Feb 13, 2017 at 6:13 PM, Jason Ekstrand
> > > wrote:
&
mattering anytime soon.
This patch is
Reviewed-by: Nanley Chery
>
> diff --git a/src/intel/genxml/gen8.xml b/src/intel/genxml/gen8.xml
> index 970e637..32ed764 100644
> --- a/src/intel/genxml/gen8.xml
> +++ b/src/intel/genxml/gen8.xml
> @@ -3200,4 +3200,25 @@
>
On Tue, Feb 14, 2017 at 02:18:56PM -0800, Nanley Chery wrote:
> On Fri, Feb 10, 2017 at 11:02:16AM -0800, Jason Ekstrand wrote:
> > Reviewed-by: Lionel Landwerlin
> > ---
> > src/intel/genxml/gen8.xml | 21 +
> > 1 file changed, 21 insertions(+)
&
On Fri, Feb 10, 2017 at 11:02:20AM -0800, Jason Ekstrand wrote:
> Reviewed-by: Lionel Landwerlin
> ---
> src/intel/genxml/gen9.xml | 28
> 1 file changed, 28 insertions(+)
>
I know this is already upstream, but thought I might as well chime in -
this looks good to m
Depth buffers aren't allowed to be used as storage images.
Fixes: 055ff2ec521 ("anv: Replace anv_image_has_hiz() with ISL_AUX_USAGE_HIZ")
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_image.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/s
surf_usage is only useful to image views that may use HiZ buffers.
Storage image views don't use HiZ buffers.
v2: Update commit message and add an assertion.
Fixes: 055ff2ec521 ("anv: Replace anv_image_has_hiz() with ISL_AUX_USAGE_HIZ")
Signed-off-by: Nanley Chery
---
s
This function supersedes layout_to_hiz_usage().
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_image.c | 149 +
src/intel/vulkan/anv_private.h | 4 ++
2 files changed, 153 insertions(+)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 57 ++
1 file changed, 15 insertions(+), 42 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index 5171e6f587..60230bf14b 100644
--- a/src
x27;t sample the depth buffer through HiZ.
* Patches 11-18: Allow HiZ on input attachment-capable depth/stencil
buffers.
This series increases the average frame rate on a release candidate of a
proprietary Vulkan benchmark by an average of 9.94% over 3 runs on my
SKL GT4.
Nanley Cher
Validate the inputs and actually verify that this image has a depth
buffer.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 1 +
src/intel/vulkan/anv_image.c | 7 +++
src/intel/vulkan/anv_private.h | 7 +--
3 files changed, 9 insertions(+), 6 deletions(-)
diff --git
Cc:
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_pass.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c
index 2df18260d3..a8b24703bc 100644
--- a/src/intel/vulkan/anv_pass.c
+++ b/src
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_descriptor_set.c | 10 ++
src/intel/vulkan/anv_private.h| 5 +
2 files changed, 15 insertions(+)
diff --git a/src/intel/vulkan/anv_descriptor_set.c
b/src/intel/vulkan/anv_descriptor_set.c
index 7853ec7dd9..369698174e
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_image.c | 31 +--
1 file changed, 13 insertions(+), 18 deletions(-)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index a17c398993..dd646a7027 100644
--- a/src/intel/vulkan/anv_image.c
We will be using the image layout. Store the full struct directly from
the user.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 24
src/intel/vulkan/anv_cmd_buffer.c | 4 ++--
src/intel/vulkan/anv_pass.c| 21 ++---
src
Don't allocate space for resolve attachments if the subpass has none.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_pass.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c
index 399ccb3970..5bd205d2f0 1
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index 60230bf14b..2cb4468696 100644
--- a/src/intel/vulkan
These are needed to transition input attachments.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 85 ++
1 file changed, 85 insertions(+)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 8 ++--
src/intel/vulkan/anv_private.h | 15 +++
2 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
index cbb49022c0..fa1f370717 100644
--- a
This will be used to sample a depth input attachment without having to
pass through the HiZ buffer.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_image.c | 22 +-
src/intel/vulkan/anv_private.h | 6 ++
2 files changed, 27 insertions(+), 1 deletion(-)
diff
We'll loop through this array when performing automatic layout
transitions.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_pass.c| 6 +-
src/intel/vulkan/anv_private.h | 7 +++
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_pass.c
Due to recent commits, the sampler now bypasses the auxiliary HiZ buffer
when reading from a depth image subresource that is in the general
layout. Remove this unneeded resolve.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 17 +
1 file changed, 1
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 54 +-
1 file changed, 12 insertions(+), 42 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index 502bf691d1..017511ed70 100644
--- a/src
On Fri, Feb 24, 2017 at 06:02:16PM -0800, Jason Ekstrand wrote:
> seems reasonable
>
> Reviewed-by: Jason Ekstrand
>
Thanks for the review! I've updated this patch a bit in the series I
just sent out.
-Nanley
> On Wed, Feb 22, 2017 at 4:33 PM, Nanley Chery wrote:
>
&
following buggy CTS tests to fail:
* dEQP-VK.renderpass.attachment_allocation.input_output.93
* dEQP-VK.renderpass.attachment_allocation.input_output.92
Upstream is currently evaluating a bug fix for the tests.
Signed-off-by: Nanley Chery
---
Thanks to Eero, for pointing out the anv FINISHME
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index 1c31082136..b5eda3a13d 100644
--- a/src/intel/vulkan/genX_cmd_buffer.c
+++ b/src/intel
On Mon, Feb 27, 2017 at 08:41:56PM -0800, Jason Ekstrand wrote:
> On Feb 27, 2017 5:21 PM, "Nanley Chery" wrote:
>
> Signed-off-by: Nanley Chery
> ---
> src/intel/vulkan/genX_cmd_buffer.c | 57 ++
>
> 1 file changed,
On Mon, Feb 27, 2017 at 08:48:48PM -0800, Jason Ekstrand wrote:
> On Feb 27, 2017 5:20 PM, "Nanley Chery" wrote:
>
> Validate the inputs and actually verify that this image has a depth
> buffer.
>
> Signed-off-by: Nanley Chery
> ---
> src/intel/vulkan/anv_b
layout transitions. This is because the isl_aux_usage enum has no
equivalent to VK_IMAGE_LAYOUT_UNDEFINED - a value that allows us to
avoid resolve operations.
-Nanley
> On Feb 27, 2017 5:20 PM, "Nanley Chery" wrote:
>
> Signed-off-by: Nanley Chery
> ---
> src/intel/vulk
a HiZ resolve
^
If you replace "is in" with "enters", your statement is correct.
> because we are ignoring the HiZ buffer anyway.
>
-Nanley
> On Feb 27, 2017 5:22 PM, "Nanley Chery" wrote:
>
> > Due to recent commits, the sampler now b
On Mon, Feb 27, 2017 at 09:22:13PM -0800, Jason Ekstrand wrote:
> On Feb 27, 2017 5:21 PM, "Nanley Chery" wrote:
>
> We'll loop through this array when performing automatic layout
> transitions.
>
> Signed-off-by: Nanley Chery
> ---
> src/intel/vulka
anley
> On Feb 27, 2017 5:22 PM, "Nanley Chery" wrote:
>
> > Signed-off-by: Nanley Chery
> > ---
> > src/intel/vulkan/genX_cmd_buffer.c | 7 +++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/src/intel/vulkan/genX_cmd_buffer
On Tue, Feb 28, 2017 at 08:07:35AM -0800, Jason Ekstrand wrote:
> On Tue, Feb 28, 2017 at 8:02 AM, Nanley Chery wrote:
>
> > On Mon, Feb 27, 2017 at 08:48:48PM -0800, Jason Ekstrand wrote:
> > > On Feb 27, 2017 5:20 PM, "Nanley Chery" wrote:
> > >
>
On Tue, Feb 28, 2017 at 09:28:15AM -0800, Jason Ekstrand wrote:
> On Tue, Feb 28, 2017 at 8:48 AM, Nanley Chery wrote:
>
> > On Mon, Feb 27, 2017 at 09:22:13PM -0800, Jason Ekstrand wrote:
> > > On Feb 27, 2017 5:21 PM, "Nanley Chery" wrote:
> > >
On Tue, Feb 28, 2017 at 09:33:26AM -0800, Jason Ekstrand wrote:
> On Tue, Feb 28, 2017 at 9:29 AM, Nanley Chery wrote:
>
> > On Tue, Feb 28, 2017 at 08:07:35AM -0800, Jason Ekstrand wrote:
> > > On Tue, Feb 28, 2017 at 8:02 AM, Nanley Chery
> > wrote:
> > >
&
On Tue, Feb 28, 2017 at 08:26:56AM -0800, Jason Ekstrand wrote:
> On Mon, Feb 27, 2017 at 5:20 PM, Nanley Chery wrote:
>
> > This function supersedes layout_to_hiz_usage().
> >
> > Signed-off-by: Nanley Chery
> > ---
> >
On Tue, Feb 28, 2017 at 10:38:12AM -0800, Jason Ekstrand wrote:
> On Tue, Feb 28, 2017 at 10:32 AM, Nanley Chery
> wrote:
>
> > On Tue, Feb 28, 2017 at 08:26:56AM -0800, Jason Ekstrand wrote:
> > > On Mon, Feb 27, 2017 at 5:20 PM, Nanley Chery
> > wrote:
> >
From: Nanley Chery
The ASTC spec was revised as follows:
Revision 2, April 28, 2015 - added CompressedTex{Sub,}Image3D to
commands accepting ASTC format tokens in the New Tokens section [...].
Support only exists in the HDR submode:
Add a second new column "3D Tex." whic
From: Nanley Chery
According to the spec, Tex*Storage* commands are supported if the GL
implementation has support for immutable textures.
Signed-off-by: Nanley Chery
---
src/mesa/main/texformat.c | 56 +++
1 file changed, 56 insertions(+)
diff
From: Nanley Chery
The following patches add missing functionality to my prior ASTC patch series
needed to advertise support for the extension. The missing first patch was an
oversight, while the second patch is due to the release of a newer spec
revision.
The series will be injected into my
From: Nanley Chery
The ASTC spec was revised as follows:
Revision 2, April 28, 2015 - added CompressedTex{Sub,}Image3D to
commands accepting ASTC format tokens in the New Tokens section [...].
Support only exists in the HDR submode:
Add a second new column "3D Tex." whic
From: Nanley Chery
All compressed formats return GL_FALSE. Remove all switch cases for
compressed formats. Compressed formats should be at the bottom of
the switch statement, so ordering is still preserved.
Cc: Jason Ekstrand
Signed-off-by: Nanley Chery
---
src/mesa/main/formats.c | 47
From: Nanley Chery
Add the classes of compressed formats as layouts. This will make determining if
a texture is an ASTC format simpler.
Cc: Jason Ekstrand
Signed-off-by: Nanley Chery
---
src/mesa/main/format_info.py | 4 +++-
src/mesa/main/formats.c | 6 ++
src/mesa/main/formats.h
101 - 200 of 1409 matches
Mail list logo
