rg-textures are supported in GLES 2.0 if EXT_texture_rg, so let's make
sure the enums are accepted.
Fixes: 510b6424607 "mesa/main: do not allow rg-textures enums before gles3"
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108936
Signed-off-by: Erik Faye-Lund
---
Whoops,
Thanks, pushed :)
On Tue, 2018-12-04 at 15:03 -0500, Marek Olšák wrote:
> Reviewed-by: Marek Olšák
>
> Marek
>
> On Tue, Dec 4, 2018 at 6:51 AM Erik Faye-Lund <
> erik.faye-l...@collabora.com> wrote:
> > rg-textures are supported in GLES 2.0 if EXT_texture_rg,
On Tue, 2018-12-04 at 10:33 -0800, Mark Janes wrote:
> Tested-by: Mark Janes
>
> Erik Faye-Lund writes:
>
> > rg-textures are supported in GLES 2.0 if EXT_texture_rg, so let's
> > make
> > sure the enums are accepted.
> >
> > Fixes: 510b642
Nice :)
For the series:
Reviewed-by: Erik Faye-Lund
On Tue, 2018-12-04 at 14:57 -0500, Marek Olšák wrote:
> From: Marek Olšák
>
> tested by piglit.
>
> v2: rebase
>
> Reviewed-by: Ilia Mirkin (v1)
> ---
> docs/relnotes/19.0.0.html| 1 +
> src/mes
esident": 322,
> "CopyTexImage1D": 323,
> "CopyTexImage2D": 324,
> "CopyTexSubImage1D": 325,
> "CopyTexSubImage2D": 326,
> -"TexSubImage1D": 332,
> -"TexSubImage2D": 333,
> -"AreTexturesR
On Wed, 2018-11-21 at 12:04 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Otherwise the incorrect ones will be used, effecitvely breaking the
> ABI.
>
> Note: some entries in static_data.py list a suffixed API, while (for
> ES*
> at least) we expect the one w/o suffix.
>
> Signed-off-by:
oid.
>
> We might want to merge this back in GLVND.
>
> Signed-off-by: Emil Velikov
>
Ideally, this would go upstream first, before we copy it. But either
way:
Reviewed-by: Erik Faye-Lund
___
mesa-dev mailing list
mes
For patch 14-16:
Reviewed-by: Erik Faye-Lund
On Wed, 2018-11-21 at 12:04 +, Emil Velikov wrote:
> From: Emil Velikov
>
> With the previous scripts API from the following was incorrectly
> exported. Drop them from the list, since they're no longer around.
>
> GL_
Reviewed-by: Erik Faye-Lund
On Wed, 2018-11-21 at 12:04 +, Emil Velikov wrote:
> From: Emil Velikov
>
> As of earlier commit, everyone has switched to the new script for the
> ES
> dispatch.
>
> Signed-off-by: Emil Velikov
> ---
> src/ma
On Wed, 2018-11-21 at 12:04 +, Emil Velikov wrote:
> From: Emil Velikov
>
> We haven't have one in years, so just drop the code.
>
> Signed-off-by: Emil Velikov
> ---
> src/mapi/mapi_abi.py | 80
>
> 1 file changed, 6 insertions(+), 74 deletion
Reviewed-by: Erik Faye-Lund
On Wed, 2018-11-21 at 12:04 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Signed-off-by: Emil Velikov
> ---
> src/mapi/shared-glapi/SConscript | 28 +---
> 1 file changed, 21 insertions(+), 7 deletions(-)
>
&g
On Wed, 2018-11-21 at 12:04 +, Emil Velikov wrote:
> The output produced functionally identical, with the following
> changes:
> - A cosmetic: swapped ABI compatible types [ GLclampf -> GLfloat,
> etc ]
> - B cosmetic: renamed parameters [ zNear -> n, etc ]
> - C dropped gl_dispatch_stub dec
On Wed, 2018-12-05 at 21:46 -0600, Jason Ekstrand wrote:
> On Wed, Dec 5, 2018 at 7:05 PM Jordan Justen <
> jordan.l.jus...@intel.com> wrote:
> > On 2018-12-05 15:44:18, Jason Ekstrand wrote:
> > > On Wed, Dec 5, 2018 at 5:32 PM Jordan Justen <
> > jordan.l.jus...@intel.com>
> > > wrote:
> > > > -M
Reviewed-by: Erik Faye-Lund
On Wed, 2018-12-05 at 15:32 -0800, Jordan Justen wrote:
> This documents a process for using GitLab Merge Requests as an second
> way to submit code changes for Mesa. Only one of the two methods is
> allowed for each patch series.
>
> We will *n
Patches 1-3:
Reviewed-by: Erik Faye-Lund
On Thu, 2018-12-06 at 16:35 -0800, Mark Janes wrote:
> This series provides Intel shader compilation debug information via
> KHR_debug. Previously, shader assembly and related compilation
> artifacts were dumped to stderr. Tools associating co
ges to fix properly, so let's just
restore the previous behavior by enabling floating-point filtering
unconditionally for now.
Signed-off-by: Erik Faye-Lund
Fixes: fcf9fcee3c8 "mesa/main: do not require float-texture filtering for es3"
---
src/gallium/drivers/virgl/virgl_screen.c | 5
On Mon, 2018-12-10 at 11:04 -0600, Jason Ekstrand wrote:
> The Vulkan working group recently discovered that we made a mistake
> in
> assuming that PCI domains are 16-bit even though they can potentially
> be
> 32-bit values. To fix this, the next spec update will chang the
chang -> change
> ty
On Mon, 2018-12-10 at 18:23 +0100, Mathias Fröhlich wrote:
> Hi Erik,
>
> Not sure if this is our problem as I think that I only saw simple
> bindings with a zero instance divisor while debugging supertux kart.
>
> But at least I think that this is a problem in virglrenderer. The
> glVertexBindin
On Tue, 2018-12-11 at 10:37 +0100, Mathias Fröhlich wrote:
> Hey,
>
> On Tuesday, 11 December 2018 10:19:47 CET Erik Faye-Lund wrote:
> > On Mon, 2018-12-10 at 18:23 +0100, Mathias Fröhlich wrote:
> > > Hi Erik,
> > >
> > > Not sure if this is our
n.
Reviewed-by: Erik Faye-Lund
> ---
> src/mesa/main/glformats.c | 11 ---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
> index 3a91600..785d720 100644
> --- a/src/mesa/main/glformats.c
On Mon, 2018-12-10 at 16:31 -0500, Ilia Mirkin wrote:
> On Mon, Dec 10, 2018 at 4:28 PM Nick Kreeger
> wrote:
> > This change enables GLES2 chagnes to render
> >
> > This change enables GLES2 to render float/half-float textures to a
> > framebuffer when the appropriate OES extensions are availabl
On Mon, 2018-12-10 at 16:36 -0500, Nick Kreeger wrote:
> In GLES2 - if extensions are present, float and half-float textures
> can
> be used for rendering. This change enables the svga driver to handle
> rendering these types.
> ---
> src/gallium/drivers/svga/svga_screen.c | 6 --
> 1 file cha
On Tue, 2018-12-11 at 11:42 +0100, Mathias Fröhlich wrote:
> Erik,
>
> > Yeah, in both D3D11 and D3D12, InstanceDataStepRate is per element,
> > not
> > per input slot. So I guess this is the most flexible way of
> > describing
> > this, and we'll have to duplicate the bindings in cases like these
e divisor isn't specified per element,
but rather per binding. But let's save that for another day.
This is the result of discussions in this thread:
https://lists.freedesktop.org/archives/mesa-dev/2018-November/210411.html
https://lists.freedesktop.org/archives/mesa-dev/2018-December/21080
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_context.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/virgl/virgl_context.c
b/src/gallium/drivers/virgl/virgl_context.c
index f0ee64c1457..b03e9508c61 100644
--- a/src/gallium
e divisor isn't specified per element,
but rather per binding. But let's save that for another day.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_context.c | 29 ++-
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/vir
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_context.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/virgl/virgl_context.c
b/src/gallium/drivers/virgl/virgl_context.c
index b03e9508c61..df6d9b83ffb 100644
--- a/src/gallium
This just has one member for now; the handle. But this is about to
change.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_context.c | 28 +++
src/gallium/drivers/virgl/virgl_context.h | 2 ++
2 files changed, 21 insertions(+), 9 deletions(-)
diff --git a
On Tue, 2018-12-11 at 15:26 +0100, Erik Faye-Lund wrote:
> Virglrenderer does the wrong thing when given an instance divisor;
> it tries to use the element-index rather than the binding-index as
> the argument to glVertexBindingDivisor(). This worked fine as long
> as there was a 1:1
On Wed, 2018-12-12 at 09:27 +0200, Tapani Pälli wrote:
>
> On 12/12/18 8:42 AM, Tapani Pälli wrote:
> >
> > On 12/12/18 5:05 AM, Nick Kreeger wrote:
> > > This change enables GLES2 to render float/half-float textures to
> > > a
> > > framebuffer when the appropriate OES extensions are available.
a supporter of tring this out! With or
without any bots or anything :)
Acked-by: Erik Faye-Lund
> I know some people are somewhat skeptical as to how well it will work
> but they won't be able to see until we actually start experimenting
> with it which we can't do until we al
On Wed, 2018-12-12 at 06:18 +0100, Mathias Fröhlich wrote:
> Erik,
>
> On Tuesday, 11 December 2018 15:29:49 CET Erik Faye-Lund wrote:
> > On Tue, 2018-12-11 at 15:26 +0100, Erik Faye-Lund wrote:
> > > Virglrenderer does the wrong thing when given an instance
> > &g
On Thu, 2018-11-15 at 13:45 +0100, Gert Wollny wrote:
> @@ -457,14 +458,15 @@ st_framebuffer_create(struct st_context *st,
> * format such that util_format_srgb(visual->color_format) can be
> supported
> * by the pipe driver. We still need to advertise the capability
> here.
> *
> -
On Thu, 2018-11-15 at 13:45 +0100, Gert Wollny wrote:
> From: Gert Wollny
>
> Dear all,
>
> after the RFC and Ilias comments I reworked the series another
> time.
> Changes with respect to the RFC are
> - renaming the new CAP
> - reordering of the patches that no double checking of
>
On Thu, 2018-12-13 at 10:46 -0800, Eric Anholt wrote:
> Dylan Baker writes:
>
> > [ Unknown signature status ]
> > In the autotools discussion I've come to realize that we also need
> > to talk about
> > the -DDEBUG guard. It seems that there are two different uses, and
> > thus two
> > different
On Thu, 2018-12-13 at 18:07 +0100, Axel Davy wrote:
> On 13/12/2018 17:57, Mathias Fröhlich wrote:
> > Hi,
> > Initially it seemed to me that I am about the only one sticking
> > with mailing lists.
> > And I personally feel like a too small contributor to really try to
> > influence your
> > decis
On Thu, 2018-12-13 at 21:27 +0100, Gert Wollny wrote:
> IMHO allowing MRs is a good thing, so
> Acked-by: Gert Wollny
>
> I've added a little remark below.
>
> Best,
> Gert
>
> Am Mittwoch, den 05.12.2018, 15:32 -0800 schrieb Jordan Justen:
> > +You should periodically check to see i
Sounds perfect, thanks! ___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Erik Faye-Lund
On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote:
> From: Emil Velikov
>
> With Windows in mind, using forward slash isn't the right thing to
> do.
> Even if it just works, we might want to fix it.
>
> As here, use __fil
Acked-by: Erik Faye-Lund
On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote:
> This reverts commit f1998e15ffccf260552bf559abe1a733a8ce990e.
>
> This changes the ABI, such that glGetnTexImageARB entry-point from
> the
> GLAPI gets removed. Thus accessing many functions by off
Reviewed-by: Erik Faye-Lund
On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Port glvnd commit 37fc6caa4b8 ("Fix typo in _LIBRARY_FEATURE_NAMES.")
> from Michal Srb.
>
> Signed-off-by: Emil Velikov
> ---
> src/egl/generate/gen
Reviewed-by: Erik Faye-Lund
On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Currently various parts of mesa use the glapi_table differently.
>
> Some use _glapi_get_proc_offset() to get the offset, while others
> directly reference the s
On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote:
> From: Emil Velikov
>
> The helper will also be used by the new Khronos gl.xml aware
> generator.
>
> v2: Move existing one, instead of duplicating it.
>
> Suggested-by: Kyle Brenneman
> Signed-off-by: Emil Velikov
> ---
> src/egl/Makef
Common.py \
> + new/gen_gldispatch_mapi.py \
> es1api/ABI-check \
> es2api/ABI-check \
> mapi_abi.py \
Nit: I would add this in some later commit, when this actually becomes
used. Right now, I believe it's just cruft...
But regardless:
Reviewed-by: E
I assume this will be kicked out of the branch before we merge? I mean,
either works, it just seems a bit pointless to keep patches to aid
comparisons in our tree.
On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Makes it easier to compare the newly generated heade
Reviewed-by: Erik Faye-Lund
On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Otherwise the incorrect ones will be used, effectively breaking the
> ABI.
>
> Note: some entries in static_data.py list a suffixed API, while (for
> ES*
> at le
Reviewed-by: Erik Faye-Lund
On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Strictly speaking we can rework the rest of the code so we do not
> need
> those. That said, this will require a series on it's own so let's
> carr
Reviewed-by: Erik Faye-Lund
On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote:
> There is no need for the noop functions, the public_stubs and
> public_entries table or table size defines. Remove those.
>
> Pretty much all of this is applicable to GLVND, although it
> requi
Reviewed-by: Erik Faye-Lund
On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote:
> From: Emil Velikov
>
> This way we can reuse the latter, which is already present in the
> headers that we use. Thus we can drop the manual typedef we generate.
>
> We might want to merge
For 16 and 17:
Reviewed-by: Erik Faye-Lund
On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote:
> From: Emil Velikov
>
> v2: use ${foo})_py naming (Dylan)
>
> Cc: Dylan Baker
> Cc: Eric Engestrom
> Signed-off-by: Emil Velikov
> ---
> src/mapi/es1api/meson
On Mon, 2018-12-17 at 16:13 -0600, Jason Ekstrand wrote:
> On Mon, Dec 17, 2018 at 2:13 PM Jason Ekstrand
> wrote:
> > On Mon, Dec 17, 2018 at 1:53 PM Eric Anholt
> > wrote:
> > > Jason Ekstrand writes:
> > >
> > > > I don't know if it was actually in the doc that Jordan wrote up
> > > but it's
On Wed, 2019-01-02 at 10:16 -0600, Jason Ekstrand wrote:
> On Wed, Jan 2, 2019 at 9:43 AM Ilia Mirkin
> wrote:
> > Have a look at the first 4 patches in the series from Jonathan
> > Marek
> > to address some of these issues:
> >
> > https://patchwork.freedesktop.org/series/54295/
> >
> > Not sur
On Thu, 2019-01-03 at 11:58 -0600, Jason Ekstrand wrote:
> On Thu, Jan 3, 2019 at 3:39 AM Erik Faye-Lund <
> erik.faye-l...@collabora.com> wrote:
> > On Wed, 2019-01-02 at 10:16 -0600, Jason Ekstrand wrote:
> > > On Wed, Jan 2, 2019 at 9:43 AM Ilia Mirkin
> > &g
On Fri, 2019-01-04 at 09:40 -0600, Jason Ekstrand wrote:
> On Fri, Jan 4, 2019 at 4:07 AM Erik Faye-Lund <
> erik.faye-l...@collabora.com> wrote:
> > On Thu, 2019-01-03 at 11:58 -0600, Jason Ekstrand wrote:
> > > On Thu, Jan 3, 2019 at 3:39 AM Erik Faye-Lund <
>
7f68d81e1 "glsl: apply align layout qualifier rules to block
offsets"
With that added:
Reviewed-by: Erik Faye-Lund
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Wed, 2018-10-17 at 14:58 +0300, Danylo Piliaiev wrote:
> This series implement VK_KHR_draw_indirect_count and
> VK_EXT_conditional_rendering extensions.
> They are implemented together because they are highly interweaved.
>
> There are already tests in VK_CTS for VK_KHR_draw_indirect_count and
ch I have no idea when will be merged. I don't think this will
> prevent merging my patches but still I would be more confident if CI
> have ALL tests.
>
> And yes, I also was quite slow with my patches.
>
> On 1/8/19 11:13 AM, Erik Faye-Lund wrote:
> > On Wed, 20
Reviewed-by: Erik Faye-Lund
On Thu, 2019-01-10 at 11:23 +, Rhys Perry wrote:
> Fixes: 393b59e0772e7bf0426bdf61c740752c4e09dde1
> ('nir: Rework nir_lower_constant_initializers() to handle
> functions')
> ---
> src/compiler/nir/nir_lower_constant_initializers.c |
On Thu, Feb 22, 2018 at 2:23 PM, Thierry Reding
wrote:
> On Wed, Feb 21, 2018 at 05:01:02PM +, Emil Velikov wrote:
>> Hi Thierry,
>>
>> On 21 February 2018 at 15:30, Thierry Reding
>> wrote:
>> > +static const char *
>> > +tegra_screen_get_name(struct pipe_screen *pscreen)
>> > +{
>> > + r
On Feb 1, 2018 04:35, "Dave Airlie" wrote:
From: Dave Airlie
In order to deal with conversions properly we need to extract
non-64bit sources from vectors instead of expanding them as
the 64-bit code does.
We need non-64bit sources for the 32->64 conversion functions.
Signed-off-by: Dave Airli
On Wed, Aug 16, 2017 at 8:32 PM, Karol Herbst wrote:
> Fixes 'KHR-GL45.copy_image.functional' on Nouveau
>
> Signed-off-by: Karol Herbst
> ---
> src/mesa/main/format_utils.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/format_utils.c b/src/mesa/main
On Thu, Aug 17, 2017 at 7:22 PM, Jason Ekstrand wrote:
> These helpers are much nicer than just using assert because they don't
> kill your process. Instead, it longjmps back to spirv_to_nir(), cleans
> up all the temporary memory, and nicely returns NULL. While crashing is
> completely OK in th
On Wed, Aug 23, 2017 at 6:19 PM, Marek Olšák wrote:
> On Wed, Aug 23, 2017 at 3:08 PM, Nicolai Hähnle wrote:
>>
>> Here's another question: What does "low precision" mean on a texture
>> instruction? Are the offsets low precision or is it the output? Maybe we can
>> punt on this for now -- at lea
On Sat, Sep 2, 2017 at 2:55 AM, Jan Vesely wrote:
> Denotes native half precision float operations capability
>
> Signed-off-by: Jan Vesely
> ---
> I can change the spelling to HALVES, but simplified english sounded more
> appropriate.
>
> src/gallium/docs/source/screen.rst | 1 +
>
On Mon, Sep 4, 2017 at 4:13 PM, Jan Vesely wrote:
> On Sat, 2017-09-02 at 22:21 +0200, Erik Faye-Lund wrote:
>> On Sat, Sep 2, 2017 at 2:55 AM, Jan Vesely wrote:
>> > Denotes native half precision float operations capability
>> >
>> > Signed-off-by: Jan Ve
The extension is written against both GL 1.2 and GLES 2.0, so let's
also enable it on GLES 2.0.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/extensions_table.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/extensions_table.h b/src/mesa
n spec, it doesn't enable online compression on gles2. And from testing, it seems like mesa does the right thing. I'll double check, though...
-ilia
On Thu, Oct 18, 2018 at 11:05 AM Erik Faye-Lund
wrote:
>
> The extension is written against both GL 1.2 and GLES 2.0, so let'
On Thu, 2018-10-18 at 14:31 -0400, Ilia Mirkin wrote:
> On Thu, Oct 18, 2018 at 2:26 PM Erik Faye-Lund
> wrote:
> > On Oct 18, 2018 18:21, Ilia Mirkin wrote:
> >
> > Have you verified that this works OK on GLES2? This extension
> > enables
> > online compres
/mesa/commit/?h=amd-extension-pack&id=c9c0ffc2d40f0119fb31bf0515f321cd877090dd
> bptc:
> https://cgit.freedesktop.org/~mareko/mesa/commit/?h=amd-extension-pack&id=111255b6f8b85119da2c5d29dc19abc422fd7a12
>
> and no time to test them.
>
> Marek
>
> On Thu, Oct 18, 2018 at 11:05 AM Erik
From: Marek Olšák
The spec was modified to support GLES.
Tested-by: Erik Faye-Lund
---
This replaces this patch:
https://patchwork.freedesktop.org/patch/257423/
docs/relnotes/18.3.0.html| 1 +
src/mesa/main/extensions_table.h | 2 +-
src/mesa/main/glformats.c| 11
ng this revealed a
porting-bug, where I tried to use glGetTexLevelParameteriv on gles2,
which isn't supported. I'll send out and updated version of the piglit
patches for that also.
> On Thu, Oct 25, 2018 at 6:59 AM Erik Faye-Lund
> wrote:
> >
> > From: M
On Tue, 2018-10-30 at 18:28 +0800, Zhaowei YUan wrote:
> I don't think it's fine, usually, freeing an NULL pointer will cause
> unexpected errors. It's better to check this for the robustness.
>
From http://pubs.opengroup.org/onlinepubs/009695399/functions/free.html
:
"If ptr is a null pointer,
On Fri, 2018-10-26 at 13:14 +0200, Erik Faye-Lund wrote:
> On Thu, 2018-10-25 at 10:45 -0400, Ilia Mirkin wrote:
> > Please confirm that this passes the piglit tests you sent to the
> > list
> > when run with ES2 forced, i.e. not ES3.
> > (MESA_GLES_VERSION_OVERRIDE=2.
Ping?
(Added Timothy the the CC-list, as he's the most recent person to
modify the parser, it seems)
On Wed, 2018-08-29 at 13:59 +0200, Erik Faye-Lund wrote:
> Ping?
>
> On on., aug. 22, 2018 at 7:34 PM, Erik Faye-Lund <
> erik.faye-l...@collabora.com> wrote:
> > T
On Tue, 2018-10-30 at 07:44 -0400, Ilia Mirkin wrote:
> On Thu, Oct 25, 2018 at 6:59 AM Erik Faye-Lund
> wrote:
> >
> > From: Marek Olšák
> >
> > The spec was modified to support GLES.
> >
> > Tested-by: Erik Faye-Lund
>
On Tue, 2018-10-30 at 08:20 -0400, Ilia Mirkin wrote:
> On Tue, Oct 30, 2018 at 7:59 AM Erik Faye-Lund
> wrote:
> >
> > On Tue, 2018-10-30 at 07:44 -0400, Ilia Mirkin wrote:
> > > On Thu, Oct 25, 2018 at 6:59 AM Erik Faye-Lund
> > > wrote
While enabling this, one bug was discorvered due to a failing dEQP test
(see the last patch).
This makes 2068 dEQP-GLE31 tests go from NotSupported to Pass on i965.
No piglit regressions observed.
Erik Faye-Lund (5):
glsl: add has_implicit_conversions()-helper
glsl
EXT_shader_implicit_conversions adds support for implicit conversions
for GLES 3.1 and above.
This is essentially a subset of ARB_gpu_shader5, and augments
OES_gpu_shader5.
Signed-off-by: Erik Faye-Lund
---
src/compiler/glsl/glsl_parser_extras.cpp | 1 +
src/compiler/glsl/glsl_parser_extras.h
rays.uint_to_float_vertex
-
dEQP-GLES31.functional.shaders.implicit_conversions.es32.invalid.arrays.uint_to_float_fragment
Signed-off-by: Erik Faye-Lund
---
src/compiler/glsl/ast_to_hir.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/compiler/glsl/ast_to_hi
This makes the code a bit easier to read, as well as reduces repetition,
especially when we add support for EXT_shader_implicit_conversions.
Signed-off-by: Erik Faye-Lund
---
src/compiler/glsl/ast_to_hir.cpp | 3 +--
src/compiler/glsl/glsl_parser_extras.h | 7 +++
src/compiler
have a variable ready with this, so let's just
return it if the builtin-search failed.
Signed-off-by: Erik Faye-Lund
---
src/compiler/glsl/ast_function.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/glsl/ast_function.cpp
b/src/compiler/glsl/ast_functio
This makes the code a bit easier to read, as well as will reduce
repetition when we add support for EXT_shader_implicit_conversions.
Signed-off-by: Erik Faye-Lund
---
src/compiler/glsl/ast_to_hir.cpp | 2 +-
src/compiler/glsl/glsl_parser_extras.h | 5 +
src/compiler/glsl_types.cpp
On Wed, 2018-10-31 at 15:46 +0200, Tapani Pälli wrote:
>
> On 10/30/18 7:11 PM, Erik Faye-Lund wrote:
> > In GLES, we currently either need an exact match with a local
> > function,
> > or an exact match with a builtin.
> >
> > However, if we add suppo
e. I thought I mentioneded this in the commit
message, but perhaps you want that to be more explicit than the "In
GLES, "-introduction?
How about I simply add something like "This fallback should only affect
GLES." at the end of the commit message?
> On Wed, Oct 31, 201
On Thu, 2018-11-01 at 07:49 +0200, Tapani Pälli wrote:
>
> On 10/31/18 7:03 PM, Ilia Mirkin wrote:
> > On Wed, Oct 31, 2018 at 12:37 PM Erik Faye-Lund
> > wrote:
> > >
> > > On Wed, 2018-10-31 at 12:01 -0400, Ilia Mirkin wrote:
> > > > I had to do
On Fri, 2018-11-02 at 15:40 +, Emil Velikov wrote:
> On Tue, 30 Oct 2018 at 17:11, Erik Faye-Lund
> wrote:
> > EXT_shader_implicit_conversions is a useful extension that adds
> > implicit
> > conversions to OpenGL ES 3.1. Since it's tested excensively in
>
On Fri, 2018-11-02 at 15:57 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Cc: Erik Faye-Lund
> Signed-off-by: Emil Velikov
> ---
> Ff| 2 ++
> docs/relnotes/19.0.0.html | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
> crea
The extension spec has been updated to include GLES 3 support, so let's
enable it there.
Signed-off-by: Erik Faye-Lund
---
This patch can be tested with this piglit-series:
https://patchwork.freedesktop.org/series/52039/
src/mapi/glapi/gen/NV_conditional_render.xml | 4 ++--
src/mesa
ort conditional
> render but not ARB_occlusion_query? (I don't think that's really
> possible given that the feature is basically designed for occlusion
> queries...)
I don't think so, no.
> On Mon, Nov 5, 2018 at 12:26 PM Erik Faye-Lund
> wrote:
> > The e
On Nov 6, 2018 13:51, "Juan A. Suarez Romero" wrote:On Tue, 2018-11-06 at 10:32 +, Emil Velikov wrote:
> On Fri, 2 Nov 2018 at 16:06, Erik Faye-Lund
> wrote:
> > On Fri, 2018-11-02 at 15:40 +, Emil Velikov wrote:
> > > On Tue, 30 Oct 2018 at 17:1
On Tue, 2018-11-06 at 19:27 +0900, Hyunjun Ko wrote:
> Since 1285f71d3e landed, it needs to provide apps with proper sample
> position for MSAA.
>
> Currently no way to query this to hw, these are taken from blob
> driver.
>
> Fixes: dEQP-
> GLES31.functional.texture.multisample.samples_#.sample_
The _mesa_has_ARB_pipeline_statistics_query(ctx)-helper will already
check the GLES-version according to the extension-table, so if this
extension would ever be back-ported to ES, we only need to update the
table to support this.
This shouln't have any functional effect.
Signed-off-by: Erik
ranteed by either
ARB_occlusion_query nor ARB_occlusion_query2. But it should be trivial
to implement for any driver supporting ARB_occlusion_query2, as it can
simply be implemented as GL_ANY_SAMPLES_PASSED.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/extensions_table.h | 2 +-
1 file changed, 1
These enums all have the same values as their non-prefixed versions, and
there's several aliases for some of them. So let's switch to the
non-prefixed versions for simplicity.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/queryobj.c | 66 --
According to the extension spec, this was initially released in 2011,
so let's set this to the correct value.
The value of 2001 could be a copy-paste mistake, as ARB_occlusion_query
which this is based on was released then.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/extensions_table.
fixing this are also
included.
Erik Faye-Lund (13):
mesa/main: correct requirement for EXT_occlusion_query_boolean
mesa/main: correct year for EXT_occlusion_query_boolean
mesa/main: use non-prefixed enums for consistency
mesa/main: simplify pipeline-statistics query validation
mes
his
behavior.
This shouldn't cause any functional change, as all drivers that support
ARB_occlusion_query2 should in practice enable either
ARB_occlusion_query2 or EXT_occlusion_query_boolean under all APIs that
export this symbol.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/queryobj.c |
of GL_TRANSFORM_FEEDBACK_STREAM_OVERFLOW and
GL_TRANSFORM_FEEDBACK_OVERFLOW into errors on ES 3, as required by the
spec.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/queryobj.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c
in
his
behavior.
This shouldn't cause any functional change, as all drivers that support
ES3_compatibility should in practice enable either ES3_compatibility or
EXT_occlusion_query_boolean under all APIs that export this symbol.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/queryobj.c | 4
is
required by the spec.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/queryobj.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c
index 96b1c6bb30a..74977210f2d 100644
--- a/src/mesa/main/queryobj.c
+++ b/src/mesa/m
501 - 600 of 764 matches
Mail list logo
