Re: [Mesa-dev] [PATCH 3/3] i965/tex_image: Avoid the ASTC LDR workaround on gen9lp

age: Flush certain subnormal ASTC channel values" Cc: Eero Tamminen Cc: Scott D Phillips --- src/mesa/drivers/dri/i965/intel_tex_image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c b/src/mesa/drivers/dri/i965/intel_te

Re: [Mesa-dev] [PATCH 1/5] i965: Hard code scratch_ids_per_subslice for Cherryview

Hi, Tested SynMark CSDof and GfxBench Aztec Ruins GL & GLES / normal & high versions, which were earlier GPU hanging. With this patch hangs are gone. Tested-by: Eero Tamminen On 07.03.2018 10:16, Jordan Justen wrote: Ken suggested that we might be underallocating scratch space o

Re: [Mesa-dev] [PATCH 1/5] i965: Hard code scratch_ids_per_subslice for Cherryview

Hi, Tested SynMark CSDof and GfxBench Aztec Ruins GL & GLES / normal & high versions, which were earlier GPU hanging. With this patch hangs are gone. Tested-by: Eero Tamminen On 07.03.2018 10:16, Jordan Justen wrote: Ken suggested that we might be underallocating scratch space o

Re: [Mesa-dev] [PATCH shaderdb 3/3] run: shader program file created via GetProgramBinary

Hi, On 13.02.2018 03:26, Dongwon Kim wrote: extraction of linked binary program to a file using glGetProgramBinary. This file is intended to be loaded by glProgramBinary in the graphic application running on the target system. A new option, '--out=' is available to be used for specifying the ou

Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: compress individual cache entries

Hi, On 01.03.2017 07:25, Timothy Arceri wrote: This reduces the cache size for Deus Ex from ~160M to ~30M for radeonsi. I'm also seeing the following improvements in minimum fps in the Shadow of Mordor benchmark: no-cache:~10fps with-cache-no-compression: ~15fps with-cach

Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: compress individual cache entries

Hi, On 02.03.2017 00:19, Timothy Arceri wrote: ... 2) Do were care about compression ratio? Yes. We currently have a default 1GB limit for the cache (users can override this). As well as games like Deus Ex having a large footprint, the Dolphin devs have reported reaching multiple GBs (uncompres

Re: [Mesa-dev] [PATCH] anv: change BLOCK_POOL_MEMFD_SIZE to exactly 2GB

Hi, On 07.03.2017 17:08, Jason Ekstrand wrote: Interesting... This must only affect android for some weird reason because 32-bit builds have been working on regular Linux for some time now. There are couple of issues... From "ftruncate" manual page: int ftruncate(int fd, off_t length);

Re: [Mesa-dev] [PATCH 3/6] configure.ac: Use PKG_CHECK_VAR for wayland-scanner.

Hi, On 07.03.2017 21:37, Frank Binns wrote: On 07/03/17 19:22, Frank Binns wrote: On 07/03/17 17:57, Emil Velikov wrote: On 7 March 2017 at 17:29, Frank Binns wrote: Hi, On 06/03/17 19:06, Matt Turner wrote: Available since pkg-config-0.28 and pkgconf-0.8.10. The removal of the AC_PATH_PR

Re: [Mesa-dev] [PATCH] anv: change BLOCK_POOL_MEMFD_SIZE to exactly 2GB

HI, On 09.03.2017 13:28, Tapani Pälli wrote: ... We had some discussion today with Eero and came to conclusion that maybe that 2GB is actually too big for 32bit system anyway and should consider to have even smaller block pool size in this case? Or should I just send a patch that adds '- 1' to f

Re: [Mesa-dev] [libdrm PATCH] intel: Make unsynchronized GTT mappings work on systems with snooping.

Hi, On 11.03.2017 03:14, Kenneth Graunke wrote: On systems without LLC, drm_intel_gem_bo_map_unsynchronized() has had the surprising behavior of doing a synchronized GTT mapping. This is obviously not what the user of the API wanted. Eric left a comment indicating a valid concern: if the CPU an

Re: [Mesa-dev] [libdrm PATCH] intel: Make unsynchronized GTT mappings work on systems with snooping.

Hi, On 14.03.2017 12:48, Eero Tamminen wrote: On 11.03.2017 03:14, Kenneth Graunke wrote: On systems without LLC, drm_intel_gem_bo_map_unsynchronized() has had the surprising behavior of doing a synchronized GTT mapping. This is obviously not what the user of the API wanted. Eric left a

Re: [Mesa-dev] [PATCH] i965: add 2xMSAA and 16xMSAA to DRI configs for Gen9.

Hi, On 25.08.2017 00:30, Kenneth Graunke wrote: On Thursday, August 24, 2017 4:16:39 AM PDT kevin.rogo...@intel.com wrote: From: Kevin Rogovin Special thanks to Eero Tamminen for reporting rasterizer numbers being twice what it should be for 2xMSAA under a benchmark. Signed-off-by: Kevin

Re: [Mesa-dev] [PATCH] i965: Set "Subslice Hashing Mode" to 16x16 on Apollolake.

Hi, On 28.08.2017 17:33, Andres Gomez wrote: Kenneth, would we want this patch in 17.1 or we shouldn't bother ? See this for more extensive info on its impact: https://bugs.freedesktop.org/show_bug.cgi?id=102272 (It's just performance. While it improves some cases, it regresses other

Re: [Mesa-dev] [PATCH] mesa/mtypes: repack gl_texture_object.

Hi, On 03.09.2017 14:22, Thomas Helland wrote: 2017-09-03 13:18 GMT+02:00 Dave Airlie : From: Dave Airlie reduces size from 1144 to 1128. Signed-off-by: Dave Airlie --- src/mesa/main/mtypes.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/mty

Re: [Mesa-dev] [PATCH 12/23] intel: Add simple logging façade for Android

Hi, On 02.09.2017 11:17, Chad Versace wrote: I'm bringing up Vulkan in the Android container of Chrome OS (ARC++). On Android, stdio goes to /dev/null. On Android, remote gdb is even more painful than the usual remote gdb. On Android, nothing works like you expect and debugging is hell. I need

Re: [Mesa-dev] [PATCH 2/3] mesa: replace date/time macros with MESA_GIT_SHA1

Hi, On 05.09.2017 17:23, Emil Velikov wrote: From: Emil Velikov Former is non-deterministic and compilers throw a warning about it. Cc: Rob Herring Signed-off-by: Emil Velikov --- I think the patch is a good idea, although kind of split about it. Any arguments for/against would be appreciat

Re: [Mesa-dev] [PATCH] mesa/mtypes: repack gl_texture_object.

Hi, On 05.09.2017 19:52, Emil Velikov wrote: On 5 September 2017 at 16:50, Brian Paul wrote: There's lots of opportunities along these lines in gl_texture_image. And since we often have many gl_texture_images per gl_texture_object, and we often have many textures, it'll probably have consider

Re: [Mesa-dev] [PATCH 12/17] i965: Replace exit(1) with abort() when command submission fails.

Hi, On 06.09.2017 03:09, Kenneth Graunke wrote: Calling exit(1) when execbuffer fails is not necessarily safe. When running Piglit tests with a Mesa that submitted invalid commands to the GPU, I discovered the following problem: 1. do_flush_locked fails and calls exit(1)...invoking atexit handl

Re: [Mesa-dev] [PATCH 12/23] intel: Add simple logging façade for Android

Hi, On 06.09.2017 23:25, Chad Versace wrote: On Mon 04 Sep 2017, Eero Tamminen wrote: On 02.09.2017 11:17, Chad Versace wrote: I'm bringing up Vulkan in the Android container of Chrome OS (ARC++). On Android, stdio goes to /dev/null. On Android, remote gdb is even more painful than the

Re: [Mesa-dev] [RFC] NIR serialization

Hi, On 12.09.2017 09:55, Jordan Justen wrote: On 2017-09-11 21:44:32, Timothy Arceri wrote: On 12/09/17 14:23, Ian Romanick wrote: On 09/08/2017 01:59 AM, Kenneth Graunke wrote: We shouldn't use SPIR-V for the shader cache. The compilation process for GLSL is: GLSL -> GLSL IR -> NIR -> i965

Re: [Mesa-dev] [PATCH 0/5] anv: Add a NIR cache

Hi, On 10/13/18 3:08 AM, Jason Ekstrand wrote: This patch series adds a simple NIR shader cache that sits right after spirv_to_nir and brw_preprocess_nir and before linking. This should help alleviate some of the added overhead of link-time optimization since most of the NIR-level optimization

Re: [Mesa-dev] [PATCH] intel/compiler: Print message descriptor as immediate source

Hi, Toni had a working assembler in early 2017, but he had to stop working on it because nobody reviewed the patches needed for the disassembler. Maybe his patch series for the disassembly output still has something useful for your assembler: * i965 shader disassembly label support: htt

Re: [Mesa-dev] [PATCH 00/11] intel/fs: Add a generic SEND opcode and use it on

Hi, On 3.11.2018 2.06, Jason Ekstrand wrote: This patch series is something we've talked about doing for a while and haven't gotten around to yet. It implements a generic SEND opcode and then reworks a bunch of the current SEND instructions such as texturing to use that instead of piles of shad

Re: [Mesa-dev] [PATCH 1/5] i965/icl: Fix L3 configurations

Hi, On 16.11.2018 10.33, Francisco Jerez wrote: Kenneth Graunke writes: [...] Perhaps we'll get both configs working, and then will want to be able to select between them. I question whether the additional URB is truly that valuable - how large are the actual gains? - considering that we hav

Re: [Mesa-dev] Loop unrolling and if statement opts

Hi, Have you considered partial loop unrolling support? I.e. when loop counter is known, but too high for full unroll, doing partial loop unrolling (e.g. unroll 4x times) and dividing loop counter by same amount (if it didn't divide evenly, need to unroll remainder outside of loop). This is

Re: [Mesa-dev] Loop unrolling and if statement opts

Hi, On 11.07.2018 12:00, Timothy Arceri wrote: On 11/07/18 18:20, Eero Tamminen wrote: Have you considered partial loop unrolling support? I.e. when loop counter is known, but too high for full unroll, doing partial loop unrolling (e.g. unroll 4x times) and dividing loop counter by same

Re: [Mesa-dev] [PATCH v2 2/3] nir: Add a discard optimization pass

Hi, On 06.07.2018 00:28, Jason Ekstrand wrote: On Thu, Jul 5, 2018 at 2:18 PM, Jason Ekstrand > wrote: [...] >> Optimizing for the latter case is an essentially >> heuristic assumption that needs to be verified experimentally.  Have you >> t

Re: [Mesa-dev] [PATCH v2 2/2] i965, anv: Use INTEL_DEBUG for disk_cache driver flags

Hi, Should this fix also: https://bugs.freedesktop.org/show_bug.cgi?id=106382 ? - Eero On 23.07.2018 07:27, Jordan Justen wrote: Since various options within INTEL_DEBUG could impact code generation, we need to set the disk cache driver_flags parameter based on the INTEL_DEBUG

Re: [Mesa-dev] Workflow Proposal

Hi, On 6.10.2021 23.00, Jordan Justen wrote: Bas Nieuwenhuizen writes: On Wed, Oct 6, 2021 at 8:49 PM Jordan Justen wrote: I guess I missed where it was suggested that Marge should remove Reviewed-by tags. I don't think Marge should ever remove something from the commit message. AFAIU this

Re: [Mesa-dev] Workflow Proposal

Hi, On 7.10.2021 19.51, Daniel Stone wrote: On Thu, 7 Oct 2021 at 09:38, Eero Tamminen wrote: This sounds horrible from the point of view of trying to track down somebody who knows about what's & why's of some old commit that is later on found to cause issues... But why wo

Re: [Mesa-dev] Workflow Proposal

Hi, On 7.10.2021 16.00, Alyssa Rosenzweig wrote: I would love to see this be the process across Mesa. We already don't rewrite commit messages for freedreno and i915g, and I only have to do the rebase (busy-)work for my projects in other areas of the tree. Likewise for Panfrost. At least, I d

Re: revenge of CALLOC_STRUCT

Hi, Valgrind should be able to report mismatching alloc & free calls, and I think one can also annotate which functions are alloc & free ones. AFAIK Valgrind does not work on Windows, but you could Valgrind Windows Mesa version on Linux using Wine. - Eero On 26.12.2021 12.37, Jose

Re: glxsync - explicit frame synchronization sample implementation

Hi, Different window managers do resizes differently. See for example: https://gitlab.gnome.org/GNOME/mutter/-/issues/60 On which window managers did you test this? - Eero On 30.12.2021 7.20, Michael Clark wrote: Dear Mesa Developers, I have been using GLFW for tiny cross-p

Re: [Mesa-dev] [PATCH] Integrate precise trig into configuration infrastructure

Hi, The known cases where this workaround caused slowdown were fixed, so why not just unconditionally enable it? Or is there still some case where workaround causes a measurable slowdown? - Eero On 11.05.2016 23:32, Gurchetan Singh wrote: With this change, to enable precise SIN an

Re: [Mesa-dev] [PATCH] Integrate precise trig into configuration infrastructure

Hi, On 12.05.2016 11:05, Kenneth Graunke wrote: On Thursday, May 12, 2016 11:15:58 AM PDT Eero Tamminen wrote: The known cases where this workaround caused slowdown were fixed, so why not just unconditionally enable it? Or is there still some case where workaround causes a measurable

Re: [Mesa-dev] [PATCH] Integrate precise trig into configuration infrastructure

Hi, On 12.05.2016 20:11, Matt Turner wrote: On Thu, May 12, 2016 at 4:49 AM, Eero Tamminen wrote: Multiply is faster instruction than sin/cos, and depending on what else the shader does, good scheduler may be able to hide latency of additional multiply, so I don't think it's quit

[Mesa-dev] GfxBench & CSDof failures

Hi, Mesa built from following (last evening) commit: commit 76dfed8ae2d5c6c509eb2661389be3c6a25077df Author: Rob Clark AuthorDate: Thu Mar 15 18:42:44 2018 -0400 Commit: Rob Clark CommitDate: Tue Mar 27 08:36:37 2018 -0400 nir: mako all the intr

Re: [Mesa-dev] GfxBench & CSDof failures

Hi, On 28.03.2018 13:27, Eero Tamminen wrote: Mesa built from following (last evening) commit: commit 76dfed8ae2d5c6c509eb2661389be3c6a25077df Author: Rob Clark AuthorDate: Thu Mar 15 18:42:44 2018 -0400 Commit: Rob Clark CommitDate: Tue Mar 27 08

Re: [Mesa-dev] [PATCH] i965: annotate brw_oa.py's --header and --code as required

Hi, On 20.03.2018 19:06, Dylan Baker wrote: Quoting Emil Velikov (2018-03-20 09:29:00) [snip] gens = [] for xml_file in args.xml_files: @@ -617,7 +610,7 @@ def main(): """)) -c("#include \"" + os.path.basename(args.header) + "\"") +c("#include \"" + os.path.

Re: [Mesa-dev] [PATCH] dri3: Prevent multiple freeing of buffers.

Hi, I tested this on KBL GT2. Compiz crashes during 3h test run dropped from 30 to none. There were couple of percent changes in few synthetic tests, but I think that's just because Compiz is now running properly. -> looks good! - Eero Tested-by: Eero Tamminen On 06

Re: [Mesa-dev] [PATCH v2] dri3: Prevent multiple freeing of buffers.

Hi, Tested on KBL GT2. Before the patch, there are few dozen compiz segfaults during ~3 hours of testing. With the patched version there are no segfaults. Tested-by: Eero Tamminen - Eero On 10.04.2018 10:44, Sergii Romantsov wrote: Commit 3160cb86aa92 adds optimization with flag

Re: [Mesa-dev] renderdoc-traces: like shader-db for runtime

Hi, On 20.6.2019 22.26, Eric Anholt wrote: Hey folks, I wanted to show you this follow-on to shader-db I've been working on: https://gitlab.freedesktop.org/anholt/renderdoc-traces For x86 development I've got a collection of ad-hoc scripts to capture FPS numbers from various moderately interes

Re: [Mesa-dev] renderdoc-traces: like shader-db for runtime

Hi, On 24.6.2019 19.36, Elie Tournier wrote: Great topic. For the past few days, I was looking at a CI for Mesa: https://gitlab.freedesktop.org/hopetech/tracie OK, it's in a very very alpha stage. ;) My idea was to use apitrace to dump and replay traces then compare images with reference image

Re: [Mesa-dev] 19.2 release train going off the rails

Hi, On 3.9.2019 20.27, Matt Turner wrote: What is going on with the 19.2 RCs? I know that we said we would push the releases back a week to let some feature work land, but the last blocker of the feature tracker [0] landed on the 14th and RC1 wasn't until the 20th. Now another two weeks have pas

Re: [Mesa-dev] Mesa CI with trace regression testing

Hi, On 27.9.2019 4.32, Eric Anholt wrote: Alexandros Frantzis writes: The last couple of months we (at Collabora) have been working on a prototype for a Mesa testing system based on trace replays that supports correctness regression testing and, in the future, performance regression testing.

Re: [Mesa-dev] Merging experimental r600/nir code

Hi, On 13.2.2020 10.38, Timur Kristóf wrote: I think the question about PGO is this: are the profiles of the users' applications gonna be the same as the profile that is collected from the benchmarks? Eg. if the test benchmark uses different draw calls or triggers different shader compiler code

Re: [Mesa-dev] Profile-guides optimizations

Hi, On 13.2.2020 20.44, Dylan Baker wrote: I actually spent a bunch of time toying with PGO a couple of years ago. I got the guidance all working and was able to train it, but what we found was that it made the specific workloads we threw at it much faster, but it made every real world use case

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

Hi, On 28.2.2020 10.48, Dave Airlie wrote: Yes, we could federate everything back out so everyone runs their own builds and executes those. Tinderbox did something really similar to that IIRC; not sure if Buildbot does as well. Probably rules out pre-merge testing, mind. Why? does gitlab not s

Re: [Mesa-dev] [PATCH 2/2] meson: upgrade minimum meson version

Hi, On 6.4.2019 11.44, Khaled Emara wrote: Sorry, I though LTS distros used old versions of mesa. Got it. Those *provide* older Mesa version, so naturally people want to build latest Mesa on them (especially if they've just bought HW that isn't supported by distro version of Mesa). Building w

Re: [Mesa-dev] [PATCH 2/2] meson: upgrade minimum meson version

ally talked about removing these deprecation warnings in cases where the minimum version doesn't have the recommended replacement, but that's hard. Dylan Quoting Eero Tamminen (2019-04-08 04:16:49) Hi, On 6.4.2019 11.44, Khaled Emara wrote: Sorry, I though LTS distros used old versions o

Re: [Mesa-dev] [PATCH 2/2] meson: upgrade minimum meson version

on to the distro, and what's available in it. Dylan? - Eero Regards //Ernst Den tis 9 apr. 2019 kl 13:00 skrev Eero Tamminen : Hi, On 9.4.2019 0.22, Dylan Baker wrote: It would be nice if people wouldn't try to build bleeding edge mesa on a 12 year old distro :D. Un

Re: [Mesa-dev] Mesa 19.1.0 release plan

Hi, On 15.4.2019 17.15, Juan A. Suarez Romero wrote: Here is the tentative release plan for 19.1.0. As many of you are well aware, it's time to the next branch point. The calendar is already updated, so these are the tentative dates: Apr 30 2019 - Feature freeze/Release candidate 1 May 07

Re: [Mesa-dev] Mesa 19.1.0 release plan

Hi, On 16.4.2019 11.38, Juan A. Suarez Romero wrote: On Mon, 2019-04-15 at 18:57 +0300, Eero Tamminen wrote: On 15.4.2019 17.15, Juan A. Suarez Romero wrote: Here is the tentative release plan for 19.1.0. As many of you are well aware, it's time to the next branch point. The calend

Re: [Mesa-dev] Mesa/DRI applications freezing randomly

Hi, (Please add answers to the bug you create about this) On 17.4.2019 16.22, Augusto Mecking Caringi wrote: Recently applications using Mesa/DRI libraries started fo freeze randomly in my system... I'm running Fedora 29 x86_64: - Kernel: x86_64 Linux 5.0.7-200.fc29.x86_64 - X.Org X Server 1.2

Re: [Mesa-dev] GLU and GLUT issues migrated to gitlab

Hi, On 14.5.2019 20.06, Adam Jackson wrote: On Mon, 2019-05-13 at 12:14 -0400, Adam Jackson wrote: Not, I hope, that anyone is likely to notice, but I've moved the open GLU and GLUT bugs from bugzilla to gitlab and closed the components in bugzilla. I say "moved" but really glut only had one op

<    1   2   3