[Mesa-dev] [PATCH 5/5] i965/gen9: Allocate YF/YS tiled buffer objects

still need to know buffer alignment value for its use in kernel when resolving the relocation. Using drm_intel_bo_alloc_for_render() for YF/YS tiled buffers satisfy both the above conditions. Signed-off-by: Anuj Phogat Cc: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c

[Mesa-dev] [PATCH 2/5] i965/gen9: Plugin the code for selecting YF/YS tiling on skl+

brw_miptree_choose_tr_mode() actually choose TRMODE. (Ben) Few cosmetic changes. V4: Get rid of brw_miptree_choose_tr_mode(). Take care of all tile resource modes {Yf, Ys, none} for all generations at one place. Signed-off-by: Anuj Phogat Cc: Ben Widawsky --- src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 1/5] i965: Make a helper function intel_miptree_set_alignment()

Signed-off-by: Anuj Phogat Cc: Ben Widawsky --- Jenkins showed no piglit regressions with this series. src/mesa/drivers/dri/i965/brw_tex_layout.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c b/src/mesa

[Mesa-dev] [PATCH 3/5] i965: Make a helper function intel_miptree_release_levels()

Signed-off-by: Anuj Phogat Cc: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_tex_layout.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c b/src/mesa/drivers/dri/i965/brw_tex_layout.c index c0ef5cc..c185e41

[Mesa-dev] [PATCH 4/5] i965: Make a helper function intel_miptree_can_use_tr_mode()

Signed-off-by: Anuj Phogat Cc: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_tex_layout.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c b/src/mesa/drivers/dri/i965/brw_tex_layout.c index c185e41

[Mesa-dev] [PATCH 4/5] i965/gen9: Add XY_FAST_COPY_BLT support to intelEmitCopyBlit()

() Move overlap computation inside intel_miptree_blit(). V4: Use _mesa_regions_overlap() function. Simplify horizontal and vertical alignment computations. Signed-off-by: Anuj Phogat Cc: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_blit.c | 295 ++- src/mesa

[Mesa-dev] [PATCH 5/5] i965/skl: Extract the blit command setup in to a helper

Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/intel_blit.c | 93 ++ 1 file changed, 61 insertions(+), 32 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_blit.c b/src/mesa/drivers/dri/i965/intel_blit.c index 800ed7e..987b5f5 100644 --- a/src

[Mesa-dev] [PATCH 2/5] mesa/st: Use global function _mesa_regions_overlap()

Signed-off-by: Anuj Phogat Cc: Ben Widawsky --- src/mesa/state_tracker/st_cb_drawpixels.c | 30 +++--- 1 file changed, 3 insertions(+), 27 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_drawpixels.c b/src/mesa/state_tracker/st_cb_drawpixels.c index a6a98c8

[Mesa-dev] [PATCH 1/5] mesa: Add a new helper function _mesa_regions_overlap()

Signed-off-by: Anuj Phogat Cc: Ben Widawsky --- Jenkins showed no piglit regressions with this series. src/mesa/main/blit.c | 26 ++ src/mesa/main/blit.h | 6 ++ 2 files changed, 32 insertions(+) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c index

[Mesa-dev] [PATCH 3/5] mesa/swrast: Use global function _mesa_regions_overlap()

Signed-off-by: Anuj Phogat --- src/mesa/swrast/s_copypix.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/mesa/swrast/s_copypix.c b/src/mesa/swrast/s_copypix.c index 68c83e4..8fde0c2 100644 --- a/src/mesa/swrast/s_copypix.c +++ b/src/mesa/swrast

[Mesa-dev] [PATCH] i965: Remove break after return

Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/intel_blit.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_blit.c b/src/mesa/drivers/dri/i965/intel_blit.c index 987b5f5..068565c 100644 --- a/src/mesa/drivers/dri/i965/intel_blit.c +++ b/src/mesa

[Mesa-dev] [PATCH] i965: Check for miptree pitch alignment before using intel_miptree_map_movntdqa()

I don't know where this alignment restriction came from. We have an assert() in intel_miptree_map_movntdqa() which expects the pitch to be 16 byte aligned. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH] meta: Use is_power_of_two() helper function

Signed-off-by: Anuj Phogat --- src/mesa/drivers/common/meta_blit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/common/meta_blit.c b/src/mesa/drivers/common/meta_blit.c index bb21642..9cace2b 100644 --- a/src/mesa/drivers/common/meta_blit.c +++ b

[Mesa-dev] [PATCH 2/3] mesa: Turn need_rgb_to_luminance_conversion() in to a global function

This will be used by _mesa_meta_pbo_GetTexSubImage() in a later patch. Signed-off-by: Anuj Phogat --- src/mesa/main/readpix.c | 11 ++- src/mesa/main/readpix.h | 3 +++ 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c

[Mesa-dev] [PATCH 1/3] mesa: Use helper function need_rgb_to_luminance_conversion()

Signed-off-by: Anuj Phogat --- src/mesa/main/readpix.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index 9166a50..cba9db8 100644 --- a/src/mesa/main/readpix.c +++ b/src/mesa/main/readpix.c @@ -421,7 +421,7

[Mesa-dev] [PATCH 3/3] meta: Abort meta path if ReadPixels need rgb to luminance conversion

After recent addition of pbo testing in piglit test getteximage-luminance, it fails on i965. This patch makes a sub test pass. Signed-off-by: Anuj Phogat Cc: --- src/mesa/drivers/common/meta_tex_subimage.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/drivers/common

[Mesa-dev] [PATCH 0.5/3] mesa: Handle integer formats in need_rgb_to_luminance_conversion()

Signed-off-by: Anuj Phogat --- src/mesa/main/readpix.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index df46f83..9166a50 100644 --- a/src/mesa/main/readpix.c +++ b/src/mesa/main/readpix.c @@ -54,7 +54,10

Re: [Mesa-dev] [PATCH 1/3] mesa: Use helper function need_rgb_to_luminance_conversion()

On Thu, Jun 11, 2015 at 2:44 AM, Tapani Pälli wrote: > > > On 06/11/2015 02:54 AM, Anuj Phogat wrote: >> >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/main/readpix.c | 11 --- >> 1 file changed, 4 insertions(+), 7 deletions(-) >> >&

[Mesa-dev] [PATCH v2 3/3] meta: Abort meta path if ReadPixels need rgb to luminance conversion

After recent addition of pbo testing in piglit test getteximage-luminance, it fails on i965. This patch makes a sub test pass. Signed-off-by: Anuj Phogat Cc: Cc: Tapani Palli --- src/mesa/drivers/common/meta_tex_subimage.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa

Re: [Mesa-dev] [PATCH 3/3] meta: Abort meta path if ReadPixels need rgb to luminance conversion

On Thu, Jun 11, 2015 at 1:41 AM, Tapani Pälli wrote: > > > On 06/11/2015 02:54 AM, Anuj Phogat wrote: >> >> After recent addition of pbo testing in piglit test getteximage-luminance, >> it fails on i965. This patch makes a sub test pass. >> >> Signed-off-b

[Mesa-dev] [PATCH] meta: Abort texture upload if pixels == null and no pixel unpack buffer set

in case of glTex{Sub}Image{1,2,3}D(). Texture has already been allocated at this point and we have no data to upload. With out this patch, with create_pbo = true, we end up creating a temporary pbo and then uploading uninitialzed texture data. Signed-off-by: Anuj Phogat Cc: Neil Roberts

Re: [Mesa-dev] [PATCH 0.5/3] mesa: Handle integer formats in need_rgb_to_luminance_conversion()

On Thu, Jun 11, 2015 at 10:05 AM, Tapani Pälli wrote: > Reviewed-by: Tapani Pälli > > > On 06/11/2015 07:58 PM, Anuj Phogat wrote: >> >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/main/readpix.c | 5 - >> 1 file changed, 4 insertions(+), 1 de

Re: [Mesa-dev] [PATCH] meta: Abort texture upload if pixels == null and no pixel unpack buffer set

ture's buffer is busy instead of allocating a PBO we > might as well just directly allocate some new storage for the texture > and abandon the old storage. That would be a separate patch though and > either way I think this patch makes sense. > > Anuj Phogat writes: > >>

Re: [Mesa-dev] [PATCH] i965: Don't create a temp PBO when uploading data from glTexImage*

false /*allocate_storage*/, > - tex_busy, unpack); > + false /*create_pbo*/, > + unpack); > if (ok) >return; > > -- > 1.9.3 > > _

Re: [Mesa-dev] [PATCH] glsl: fix compile error message

case GLSL_TYPE_INT: > -- > 2.1.0 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev Reviewed-by: Anuj Phogat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 07/14] mesa: Set green, blue channels to zero only for formats with these components

Signed-off-by: Anuj Phogat --- src/mesa/drivers/common/meta.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 214a68a..fceb25d 100644 --- a/src/mesa/drivers/common/meta.c +++ b/src/mesa

[Mesa-dev] [PATCH 05/14] meta: Abort meta pbo path if readpixels need signed-unsigned conversion

Without this patch, piglit test fbo_integer_readpixels_sint_uint fails, when forced to use the meta pbo path. Signed-off-by: Anuj Phogat Cc: --- src/mesa/drivers/common/meta_tex_subimage.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/common/meta_tex_subimage.c b/src

[Mesa-dev] [PATCH 09/14] meta: Use _mesa_unpack_format_to_base_format() to handle integer formats

_mesa_base_tex_format() doesn't handle GL_*_INTEGER formats. Signed-off-by: Anuj Phogat --- src/mesa/drivers/common/meta.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index fceb25d..c9e58d8 1

[Mesa-dev] [PATCH 10/14] mesa: Add a helper function _mesa_need_luminance_to_rgb_conversion()

Signed-off-by: Anuj Phogat Cc: --- src/mesa/main/readpix.c | 18 ++ src/mesa/main/readpix.h | 4 2 files changed, 22 insertions(+) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index 1038983..c98975f 100644 --- a/src/mesa/main/readpix.c +++ b/src/mesa

[Mesa-dev] [PATCH 12/14] meta: Fix reading luminance texture as rgba in _mesa_meta_pbo_GetTexSubImage()

After recent addition of pbo testing in piglit test getteximage-luminance, it fails on i965. This patch makes a sub test pass. This patch adds additional clear color operation which I think is better than falling back to software path. Signed-off-by: Anuj Phogat Cc: --- src/mesa/drivers

[Mesa-dev] [PATCH 01/14] mesa: Turn get_readpixels_transfer_ops() in to a global function

This utility function is utilized in a later patch. Signed-off-by: Anuj Phogat Cc: --- Jenkins showed no piglit regressions with this series. src/mesa/main/readpix.c | 14 -- src/mesa/main/readpix.h | 6 ++ 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 14/14] meta: Use _mesa_need_rgb_to_luminance_conversion() in decompress_texture_image()

Signed-off-by: Anuj Phogat --- src/mesa/drivers/common/meta.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 6108d98..e123500 100644 --- a/src/mesa/drivers/common/meta.c +++ b/src/mesa/drivers

[Mesa-dev] [PATCH 06/14] meta: Don't do fragment color clamping in case of ReadPixels

Without this patch, piglit test arb_color_buffer_float-readpixels fails, when forced to use the meta pbo path. Signed-off-by: Anuj Phogat Cc: --- src/mesa/drivers/common/meta_tex_subimage.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/drivers/common/meta_tex_subimage.c b

[Mesa-dev] [PATCH 08/14] mesa: Add a helper function _mesa_unpack_format_to_base_format()

Signed-off-by: Anuj Phogat --- src/mesa/main/glformats.c | 44 src/mesa/main/glformats.h | 3 +++ 2 files changed, 47 insertions(+) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index ac69fab..cac243c 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH 03/14] mesa: Fix conditions to test signed, unsigned integer format

Signed-off-by: Anuj Phogat Cc: --- src/mesa/main/readpix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index caa2648..a9416ef 100644 --- a/src/mesa/main/readpix.c +++ b/src/mesa/main/readpix.c @@ -160,10 +160,12

[Mesa-dev] [PATCH 13/14] mesa: Change the signature of _mesa_need_rgb_to_luminance_conversion()

This allows us to handle cases when texImage->_BaseFormat doesn't match _mesa_format_get_base_format(texImage->Format). _BaseFormat is what we care about in this function. Signed-off-by: Anuj Phogat --- src/mesa/drivers/common/meta_tex_subimage.c | 4 +++- src/mesa/mai

[Mesa-dev] [PATCH 11/14] meta: Use _mesa_need_luminance_to_rgb_conversion() in decompress_texture_image()

Signed-off-by: Anuj Phogat --- src/mesa/drivers/common/meta.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index c9e58d8..6108d98 100644 --- a/src/mesa/drivers/common/meta.c +++ b/src/mesa

[Mesa-dev] [PATCH 04/14] mesa: Add a mesa utility function _mesa_need_signed_unsigned_int_conversion()

This utility function is used in a later patch. Signed-off-by: Anuj Phogat Cc: --- src/mesa/main/readpix.c | 32 ++-- src/mesa/main/readpix.h | 4 2 files changed, 22 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/readpix.c b/src/mesa/main

[Mesa-dev] [PATCH 02/14] meta: Fix transfer operations check in meta pbo path for readpixels

Without this patch, arb_color_buffer_float-readpixels test fails, when forced to use meta pbo path. Signed-off-by: Anuj Phogat Cc: --- src/mesa/drivers/common/meta_tex_subimage.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/common

Re: [Mesa-dev] What branch to get patch 47790

Adding Topi to Cc. On Tue, Jun 16, 2015 at 3:08 PM, Meng, David wrote: > Hi: > I am new to this email list. I would like to get a help from you. > > I found a patch with number of 47790 which supports Intel Broadwell(BDW) > system gen8 GPU. The author is Topi Pohjolainen. The description is i

Re: [Mesa-dev] [PATCH] i965/skl: Fix aligning mt->total_width to the block size

the 2nd mipmap. This occurs when the alignment > -- > 1.9.3 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev Reviewed-by: Anuj Phogat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 03/14] mesa: Fix conditions to test signed, unsigned integer format

fficient to decide if the format is one of the integer formats. GL_INT, GL_SHORT or GL_BYTE types can be used with both normalized fixed point formats and integer formats. So, add a check to ensure the integer format." > On Jun 16, 2015 11:15, "Anuj Phogat" wrote:

Re: [Mesa-dev] [PATCH 03/14] mesa: Fix conditions to test signed, unsigned integer format

On Thu, Jun 18, 2015 at 7:09 AM, Iago Toral wrote: > On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: >> Signed-off-by: Anuj Phogat >> Cc: >> --- >> src/mesa/main/readpix.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/src/

Re: [Mesa-dev] [PATCH v2] glsl: guard gl_NumSamples enablement on ARB_sample_shading

"gl_DepthRange"); > add_uniform(array(vec4_t, VERT_ATTRIB_MAX), "gl_CurrentAttribVertMESA"); > add_uniform(array(vec4_t, VARYING_SLOT_MAX), "gl_CurrentAttribFragMESA"); > -- > 2.3.6 > Reviewed-by: Anuj Phogat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] i965/gen9: Implement Push Constant Buffer workaround

ion a bit more readable, but to > keep this easily cherry-pickable I am doing this fix first. If we decide not > to > merge the cleanup patch then I can revisit this. > > Anuj ran this on his SKL and said there were no fixes on regressions. There is > some hope it fixes BXT is

Re: [Mesa-dev] [PATCH 03/14] mesa: Fix conditions to test signed, unsigned integer format

On Thu, Jun 18, 2015 at 11:41 PM, Iago Toral wrote: > On Thu, 2015-06-18 at 09:19 -0700, Anuj Phogat wrote: >> On Thu, Jun 18, 2015 at 7:09 AM, Iago Toral wrote: >> > On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: >> >> Signed-off-by: Anuj Phogat >> &g

Re: [Mesa-dev] [PATCH 05/14] meta: Abort meta pbo path if readpixels need signed-unsigned conversion

On Tue, Jun 16, 2015 at 9:21 PM, Jason Ekstrand wrote: > > On Jun 16, 2015 11:15, "Anuj Phogat" wrote: >> >> Without this patch, piglit test fbo_integer_readpixels_sint_uint fails, >> when >> forced to use the meta pbo path. >> >> Signed-off-

Re: [Mesa-dev] [PATCH] i965/gen8: Use HALIGN_16 for single sample mcs buffers

layout_flags |= MIPTREE_LAYOUT_FORCE_HALIGN16; >> } else if (brw->gen >= 9 && num_samples > 1) { >>layout_flags |= MIPTREE_LAYOUT_FORCE_HALIGN16; >> -- >> 2.4.4 >> >> ___ >> mesa-

Re: [Mesa-dev] [PATCH 4/5] i965/gen9: Add XY_FAST_COPY_BLT support to intelEmitCopyBlit()

On Wed, Jun 10, 2015 at 3:34 PM, Anuj Phogat wrote: > This patch enables using XY_FAST_COPY_BLT only for Yf/Ys tiled buffers. > It can be later turned on for other tiling patterns (X,Y) too. > > V3: Flush in between sequential fast copy blits. > Fix src/dst alignment requireme

Re: [Mesa-dev] [PATCH 02/14] meta: Fix transfer operations check in meta pbo path for readpixels

On Thu, Jun 18, 2015 at 5:26 AM, Iago Toral wrote: > On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: >> Without this patch, arb_color_buffer_float-readpixels test fails, when >> forced to use meta pbo path. >> >> Signed-off-by: Anuj Phogat >> Cc: &

Re: [Mesa-dev] [PATCH 03/14] mesa: Fix conditions to test signed, unsigned integer format

On Sun, Jun 21, 2015 at 11:25 PM, Iago Toral wrote: > On Fri, 2015-06-19 at 13:32 -0700, Anuj Phogat wrote: >> On Thu, Jun 18, 2015 at 11:41 PM, Iago Toral wrote: >> > On Thu, 2015-06-18 at 09:19 -0700, Anuj Phogat wrote: >> >> On Thu, Jun 18, 2015 at 7:09 AM, Iag

Re: [Mesa-dev] [PATCH 2/5] i965/gen9: Plugin the code for selecting YF/YS tiling on skl+

On Mon, Jun 22, 2015 at 2:53 PM, Ben Widawsky wrote: > On Wed, Jun 10, 2015 at 03:30:47PM -0700, Anuj Phogat wrote: >> Buffers with Yf/Ys tiling end up using meta upload / download >> paths or the blitter for cases where they used tiled_memcpy paths >> in case of Y tiling.

Re: [Mesa-dev] [PATCH 5/5] i965/gen9: Allocate YF/YS tiled buffer objects

On Mon, Jun 22, 2015 at 5:13 PM, Ben Widawsky wrote: > On Wed, Jun 10, 2015 at 03:30:50PM -0700, Anuj Phogat wrote: >> In case of I915_TILING_{X,Y} we need to pass tiling format to libdrm >> using drm_intel_bo_alloc_tiled(). But, In case of YF/YS tiled buffers >> libdrm ne

Re: [Mesa-dev] [PATCH 2/2] i965: Split out gen8 push constant state upload

TCH(0); > + OUT_BATCH(0); > + ADVANCE_BATCH(); > +} > + > +void > +brw_upload_constant_state(struct brw_context *brw, > + const struct brw_stage_state *stage_state, > + bool active, unsigned opcode) > +{ > + /* Disable if the shader stage is inactive or there are no push > constants. */ > + active = active && stage_state->push_const_size != 0; > + > + if (brw->gen >= 8) > + gen8_upload_constant_state(brw, stage_state, active, opcode); > + else > + gen7_upload_constant_state(brw, stage_state, active, opcode); > +} > + > > static void > upload_vs_state(struct brw_context *brw) > -- > 2.4.2 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev LGTM. Reviewed-by: Anuj Phogat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2 5/5] i965/gen9: Allocate YF/YS tiled buffer objects

ments. Remove some redundant code now when there are no min/max buffer size. Signed-off-by: Anuj Phogat Cc: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 62 +-- 1 file changed, 58 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH] mesa : NULL check InfoLog

hProg->InfoLog, sh->InfoLog); >} > >delete_shader(ctx, shader); > -- > 1.9.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev Rev

Re: [Mesa-dev] [PATCH] i965: Drop brw->depthstencil.stencil_offset from gen8_depth_state.c.

NULL, false, /* no stencil for now */ >true, /* hiz */ >surface_width, >surface_height, > -- > 1.7.10.4 > > ___ > mesa-dev maili

Re: [Mesa-dev] [PATCH v3 04/18] mesa: return bool instead of GLboolean in compressedteximage_only_format()

case GL_COMPRESSED_SRGB8_ALPHA8_ASTC_12x12_KHR: > - return GL_TRUE; > + return true; > default: > - return GL_FALSE; > + return false; > } > } > > -- > 2.4.2 > > ___ > mes

Re: [Mesa-dev] [PATCH v3 11/18] mesa/macros: add power-of-two assertions for alignment macros

static inline uintptr_t > +ROUND_DOWN_TO(uintptr_t value, uintptr_t alignment) > +{ > + assert(is_power_of_two(alignment)); Here as well. > + return ((value) & ~(alignment - 1)); > +} > > > /** Cross product of two 3-element vectors */ > -- > 2.4.2 > >

Re: [Mesa-dev] [PATCH v3 12/18] mesa/macros: move ALIGN_NPOT to macros.h

On Mon, Jun 22, 2015 at 4:02 PM, Nanley Chery wrote: > From: Nanley Chery > > Aligning with a non-power-of-two number is a general task that can be used in > various places. This commit is required for the next one. > > Signed-off-by: Nanley Chery > --- > src/mesa/drivers/dri/i965/intel_upload.

Re: [Mesa-dev] [PATCH v3 13/18] i965: use ALIGN_NPOT for setting ASTC mipmap layouts

igned int i, j; >_mesa_get_format_block_size(dst_mt->format, &i, &j); > - height = ALIGN(height, j) / j; > - width = ALIGN(width, i); > + height = ALIGN_NPOT(height, j) / j; > + width = ALIGN_NPOT(width, i); > } > > /* If it&#x

Re: [Mesa-dev] [PATCH] mesa: remove unnecessary checks in _mesa_readpixels_needs_slow_path

return get_readpixels_transfer_ops(ctx, rb->Format, format, type, > uses_blit) != 0; > -- > 1.9.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > ht

Re: [Mesa-dev] [PATCH] i965/gen9: use an unreserved surface alignment value

_ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev Good find Nanley. We had no known issues with value 0 but it's always nice to avoid undefined behavior :). Reviewed-by: Anuj Phogat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2 05/14] meta: Abort meta pbo path if readpixels need signed-unsigned conversion

tatic function. (Iago) Bump up the comment and the commit message. (Jason) Signed-off-by: Anuj Phogat Reviewed-by: Jason Ekstrand Cc: Iago Toral Cc: --- src/mesa/drivers/common/meta_tex_subimage.c | 25 + 1 file changed, 25 insertions(+) diff --git a/src/mesa/drivers/c

Re: [Mesa-dev] [PATCH] i965/gen9: use an unreserved surface alignment value

On Thu, Jun 25, 2015 at 12:37 AM, Pohjolainen, Topi wrote: > On Wed, Jun 24, 2015 at 05:57:13PM -0700, Anuj Phogat wrote: >> On Wed, Jun 24, 2015 at 3:51 PM, Nanley Chery wrote: >> > From: Nanley Chery >> > >> > Although the horizontal and vertical alignment

Re: [Mesa-dev] [PATCH] i965/skl: Use more compact hiz dimensions

> + z_height *= 2; > + break; > + default: > + unreachable("unsupported sample count"); > + } > } > > const unsigned vertical_align = 8; /* 'j' in the docs */ > -- > 2.4.4 > > __

Re: [Mesa-dev] [PATCH] i965: Remove special case for layered drawbuffer attachments.

>mt_layer == 0); > > surf[0] = SET_FIELD(surftype, BRW_SURFACE_TYPE) | > SET_FIELD(format, BRW_SURFACE_FORMAT); > -- > 2.4.0 > > ___ > mesa-dev mailing list > mesa-dev@lis

Re: [Mesa-dev] [PATCH v3 11/18] mesa/macros: add power-of-two assertions for alignment macros

t all other places which expect the current behavior. I'll leave it up to you. FYI gallium also have a helper function util_is_power_of_two() which returns true for 0. > Thanks, > Nanley > > On Wed, Jun 24, 2015 at 3:22 PM, Anuj Phogat wrote: >> On Mon, Jun 22, 2015 at 4:02 PM,

Re: [Mesa-dev] [PATCH] mesa/macros: move ALIGN_NPOT to macros.h

gnment. > + */ > +static inline uintptr_t > +ALIGN_NPOT(uintptr_t value, int32_t alignment) > +{ > + assert(alignment > 0); > + return (value + alignment - 1) / alignment * alignment; > +} > + > +/** > * Align a value down to an alignment value > * > * If \

[Mesa-dev] [PATCH v2 02/14] meta: Fix transfer operations check in meta pbo path for readpixels

heck only for glReadPixles. Without this patch, arb_color_buffer_float-readpixels test fails, when forced to use meta pbo path. V2: Add a comment and bump up the commit message. Signed-off-by: Anuj Phogat Cc: Cc: Iago Toral Cc: Jason Ekstrand --- src/mesa/drivers/common/meta_tex_su

Re: [Mesa-dev] [PATCH 02/14] meta: Fix transfer operations check in meta pbo path for readpixels

On Fri, Jun 19, 2015 at 4:48 PM, Anuj Phogat wrote: > On Thu, Jun 18, 2015 at 5:26 AM, Iago Toral wrote: >> On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: >>> Without this patch, arb_color_buffer_float-readpixels test fails, when >>> forced to use meta pbo

Re: [Mesa-dev] [PATCH 2/5] i965/gen9: Plugin the code for selecting YF/YS tiling on skl+

On Mon, Jun 22, 2015 at 5:23 PM, Anuj Phogat wrote: > On Mon, Jun 22, 2015 at 2:53 PM, Ben Widawsky wrote: >> On Wed, Jun 10, 2015 at 03:30:47PM -0700, Anuj Phogat wrote: >>> Buffers with Yf/Ys tiling end up using meta upload / download >>> paths or the blitte

Re: [Mesa-dev] [PATCH 1/3] i965: Rename brw_upload_item_data to brw_alloc_item_data

item_data(cache, item, data); > + item->offset = brw_alloc_item_data(cache, data_size); > } > > /* Set up the memory containing the key and aux_data */ > -- > 1.9.3 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev Reviewed-by: Anuj Phogat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] i965: Only write program to cache when it doesn't exist yet

> mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev Sounds like a right thing to do. It's worth waiting to see comments from other people before pushing it upstream. Reviewed-by: Anuj Phogat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] i965: Stop aux data compare preventing program binary re-use

On Thu, Jun 25, 2015 at 5:45 AM, Topi Pohjolainen wrote: > Items in the program cache consist of three things: key, the data > representing the instructions and auxiliary data representing > uniform storage. The data consisting of instructions is stored into > a drm buffer object while the key and

Re: [Mesa-dev] [PATCH v3 17/18] i965: refactor miptree alignment calculation code

> + mt->align_h *= 4; > + } > + } else if (mt->format == MESA_FORMAT_S_UINT8) { > + mt->align_w = 8; > + mt->align_h = brw->gen >= 7 ? 8 : 4; > + } else if (brw->gen >= 9 && mt->tr_mode != INTEL_MIPTREE_TRMODE_NONE) { > + /* XY

Re: [Mesa-dev] [PATCH v3 15/18] i965: change the meaning of cpp for compressed textures

t_block_size(mt->format, &bw, &bh); > assert(y % bh == 0); > y /= bh; > + x /= bw; > > base = intel_miptree_map_raw(brw, mt) + mt->offset; > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h > b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h > index bde6daa..7101afa 100644 > --- a/s

Re: [Mesa-dev] [PATCH v3 16/18] i965: enable ASTC support for Skylake

if (ctx->API == API_OPENGL_CORE) >ctx->Extensions.ARB_base_instance = true; > if (ctx->API != API_OPENGL_CORE) > -- > 2.4.2 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.fr

Re: [Mesa-dev] [PATCH v3 10/18] i965/surface_formats: add support for 2D ASTC surface formats

MESA_FORMAT_ASTC_10x8_RGBA: > + case MESA_FORMAT_ASTC_10x10_RGBA: > + case MESA_FORMAT_ASTC_12x10_RGBA: > + case MESA_FORMAT_ASTC_12x12_RGBA: { > + GLuint brw_fmt = brw_format_for_mesa_format(mesa_format); > + > + /* Process this textur

Re: [Mesa-dev] [PATCH] i965/surface_formats: add support for 2D ASTC surface formats

_FORMAT_BIT comment. > update SF table - ASTC is actually supported in Gen8. > > Reviewed-by: Anuj Phogat > Signed-off-by: Nanley Chery > --- > src/mesa/drivers/dri/i965/brw_defines.h | 32 + > src/mesa/drivers/dri/i965/brw_surface_formats.c | 87 >

Re: [Mesa-dev] [PATCH] mesa: reset the source packing when creating temp transfer image

ng list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev Reviewed-by: Anuj Phogat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/skl: Set the pulls bary bit in 3DSTATE_PS_EXTRA

(prog_data->uses_omask) >dw1 |= GEN8_PSX_OMASK_TO_RENDER_TARGET; > > + if (brw->gen >= 9 && prog_data->pulls_bary) > + dw1 |= GEN9_PSX_SHADER_PULLS_BARY; > + > if (_mesa_active_fragment_shader_has_a

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen9: Allocate YF/YS tiled buffer objects

On Tue, Jul 7, 2015 at 2:35 AM, Kenneth Graunke wrote: > On Tuesday, June 23, 2015 01:23:05 PM Anuj Phogat wrote: >> In case of I915_TILING_{X,Y} we need to pass tiling format to libdrm >> using drm_intel_bo_alloc_tiled(). But, In case of YF/YS tiled buffers >> libdrm ne

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen9: Allocate YF/YS tiled buffer objects

On Tue, Jul 7, 2015 at 12:11 PM, Anuj Phogat wrote: > On Tue, Jul 7, 2015 at 2:35 AM, Kenneth Graunke wrote: >> On Tuesday, June 23, 2015 01:23:05 PM Anuj Phogat wrote: >>> In case of I915_TILING_{X,Y} we need to pass tiling format to libdrm >>> using drm_intel_bo_all

Re: [Mesa-dev] [PATCH 2/5] i965/gen9: Plugin the code for selecting YF/YS tiling on skl+

On Tue, Jul 7, 2015 at 2:47 AM, Kenneth Graunke wrote: > On Wednesday, June 10, 2015 03:30:47 PM Anuj Phogat wrote: >> Buffers with Yf/Ys tiling end up using meta upload / download >> paths or the blitter for cases where they used tiled_memcpy paths >> in case of Y tiling.

[Mesa-dev] [PATCH] i965: Fix 32 bit build warnings in intel_get_yf_ys_bo_size()

63:1: note: expected 'uint64_t *' but argument is of type 'long unsigned int *' Reported-by: Kenneth Graunke Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/d

Re: [Mesa-dev] [PATCH 1/5] i965: Push miptree tiling request into flags

nt Yf/Ys changes > Fix non-msrt MCS allocation (was only happening in gen8 case before) > > Cc: Anuj Phogat > Cc: Chad Versace > Signed-off-by: Ben Widawsky > --- > src/mesa/drivers/dri/i965/brw_tex_layout.c | 21 ++-- > src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH 2/5] i965/miptree: Cleanup some of the miptree map logic

On Tue, Jul 14, 2015 at 9:56 AM, Ben Widawsky wrote: > At the crux of this change is moving whether or not we can even use the > hardware > blitter into the can_blit_slice check. Fundamentally this makes sense as > blitting a slice is a subset in functionality of being able to use the blitter > a

[Mesa-dev] [PATCH V2 12/14] meta: Fix reading luminance texture as rgba in _mesa_meta_pbo_GetTexSubImage()

-off-by: Anuj Phogat Cc: --- src/mesa/drivers/common/meta_tex_subimage.c | 36 +++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/common/meta_tex_subimage.c b/src/mesa/drivers/common/meta_tex_subimage.c index 13f8292..f4d5ac3 100644 --- a

Re: [Mesa-dev] [PATCH v2 02/14] meta: Fix transfer operations check in meta pbo path for readpixels

; > On Fri, 2015-06-26 at 13:15 -0700, Anuj Phogat wrote: >> Currently used ctx->_ImageTransferState check is not sufficient >> because it doesn't include the read color clamping enabled with >> GL_CLAMP_READ_COLOR. So, use the helper function >> _mesa_get_readpi

[Mesa-dev] [PATCH] Revert "i965/gen9: Plugin the code for selecting YF/YS tiling on skl+"

. It'll be better to add the Yf/Ys tiling selection code later, when we are ready to use it. Cc: Kenneth Graunke Cc: Ben Widawsky Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_tex_layout.c | 110 + 1 file changed, 17 insertions(+), 93 deletions(-)

Re: [Mesa-dev] [PATCH 01/14] meta: handle subimages in _mesa_meta_setup_texture_coords()

t; - 0, 0, 1, /* width, height never > used here */ > + 0, 0, /* xoffset, yoffset */ > + srcWidth, srcHeight, /* img size */ > + srcWidth, srcHeight, srcDepth, > verts[0].tex, > verts[1].tex, > verts[2].tex, > -- > 1.9.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev Reviewed-by: Anuj Phogat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH 16/18] i965: Prevent coordinate overflow in intel_emit_linear_blit

s by > 4 (versus the current 8bpp pixels). We also have to be more careful > doing the last line just in case it may exceed the coordinate limit. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90734 > Signed-off-by: Chris Wilson > Cc: Kenneth Graunke &g

Re: [Mesa-dev] [Mesa-stable] [PATCH 16/18] i965: Prevent coordinate overflow in intel_emit_linear_blit

On Sat, Jul 18, 2015 at 1:24 AM, Chris Wilson wrote: > On Fri, Jul 17, 2015 at 05:12:54PM -0700, Anuj Phogat wrote: >> On Mon, Jul 6, 2015 at 3:33 AM, Chris Wilson >> wrote: >> > + do { >> > + /* The pitch given to the GPU must be DWORD aligned, and >

Re: [Mesa-dev] [PATCH 05/14] meta: Abort meta pbo path if readpixels need signed-unsigned conversion

On Mon, Jul 20, 2015 at 5:10 AM, Iago Toral wrote: > On Fri, 2015-06-19 at 13:40 -0700, Anuj Phogat wrote: >> On Tue, Jun 16, 2015 at 9:21 PM, Jason Ekstrand wrote: >> > >> > On Jun 16, 2015 11:15, "Anuj Phogat" wrote: >> >> >> >> Wit

Re: [Mesa-dev] [PATCH 6/6] mesa: check for identity matrix in _mesa_LoadMatrixf()

State |= ctx->CurrentStack->DirtyFlag; > + } > + } > + else { > + _math_matrix_loadf(ctx->CurrentStack->Top, m); > + ctx->NewState |= ctx->CurrentStack->DirtyFlag; > + } > } > > > -- > 1.9.1 > > __

Re: [Mesa-dev] [PATCH] swrast: remove unneeded & operators in _swrast_choose_texture_sample_func()

pler->MinFilter == GL_LINEAR) { > -return &sample_linear_2d_array; > +return sample_linear_2d_array; > } > else { > assert(sampler->MinFilter == GL_NEAREST); > -return &sample_nearest_2d_array; > +return sample_nearest_2d_array; > } >default: > _mesa_problem(ctx, > "invalid target in > _swrast_choose_texture_sample_func"); > - return &null_sample_func; > + return null_sample_func; >} > } > } > -- > 1.9.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev Reviewed-by: Anuj Phogat ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 07/14] mesa: Set green, blue channels to zero only for formats with these components

On Tue, Jul 21, 2015 at 12:50 AM, Iago Toral wrote: > On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/drivers/common/meta.c | 13 ++--- >> 1 file changed, 10 insertions(+), 3 deletions(-) >> >&g

Re: [Mesa-dev] [PATCH 05/14] meta: Abort meta pbo path if readpixels need signed-unsigned conversion

On Tue, Jul 21, 2015 at 1:36 AM, Iago Toral wrote: > On Tue, 2015-07-21 at 08:13 +0200, Iago Toral wrote: >> On Mon, 2015-07-20 at 10:56 -0700, Anuj Phogat wrote: >> > On Mon, Jul 20, 2015 at 5:10 AM, Iago Toral wrote: >> > > On Fri, 2015-06-19 at 13:40 -0700, Anu

Re: [Mesa-dev] [PATCH 06/14] meta: Don't do fragment color clamping in case of ReadPixels

On Tue, Jul 21, 2015 at 1:18 AM, Iago Toral wrote: > On Tue, 2015-07-21 at 09:24 +0200, Iago Toral wrote: >> On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: >> > Without this patch, piglit test arb_color_buffer_float-readpixels >> > fails, when forc

  1   2   3   4   5   6   7   8   9   10   >