As functions are inlined, and nir_lower_global_vars_to_local gets
run, all global variables are lowered to local variables.
---
Jason Enkstrand already confirmed that global support is not needed
on the bug open for the nir/vec4 support:
https://bugs.freedesktop.org/show_bug.cgi?id=89580#c9
So th
On 30/06/15 01:27, Jason Ekstrand wrote:
> On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev wrote:
>> From: Alejandro Piñeiro
>>
>> The new virtual method is more flexible, it has a signature:
>>
>> dst_reg *make_reg_for_system_value(int location, con
On 30/06/15 01:34, Jason Ekstrand wrote:
> On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev wrote:
>> From: Alejandro Piñeiro
>>
>> Similar to other variable setups, system values will initialize the
>> corresponding register inside a 'nir_system_values
and ir paths.
BR
> --Jason
>
> On Fri, Jun 26, 2015 at 1:07 AM, Eduardo Lima Mitev wrote:
>> From: Alejandro Piñeiro
>>
>> This sets up the basic structure and placeholders for the implementation of
>> texture operations, which will be added incrementally in
ther headers (like
glsl/glsl_types.h) have.
BR
[1]
https://github.com/Igalia/mesa/commit/e81ce150ef931e50b6cb1aae0b42a79f448863f5
[2] https://bugs.freedesktop.org/show_bug.cgi?id=89580#c7
> --Jason
>
> On Fri, Jun 26, 2015 at 1:07 AM, Eduardo Lima Mitev wrote:
>> From: Alejandro
On 13/07/15 14:05, Jason Ekstrand wrote:
> On Mon, Jul 13, 2015 at 3:00 AM, Alejandro Piñeiro
> wrote:
>> On 01/07/15 01:37, Jason Ekstrand wrote:
>>> If we can avoid duplication in the texturing code, that would be
>>> really nice. Could we do this as a ref
ackend
instruction opcode:
http://lists.freedesktop.org/archives/mesa-dev/2015-July/088696.html
So probably it would be better to wait for his change, and avoid the
need of that mapping on the vec4 path too. That would remove the need of
the helper function and the cpp renaming.
That sounds
Ping. Any possibility of a patch review? FWIW, the patch itself is
pretty small.
On 26/06/15 13:47, Alejandro Piñeiro wrote:
> As functions are inlined, and nir_lower_global_vars_to_local gets
> run, all global variables are lowered to local variables.
> ---
>
> Jason Enkstrand al
On 10/10/15 16:54, Jason Ekstrand wrote:
> On Sat, Oct 10, 2015 at 4:24 AM, Alejandro Piñeiro
> wrote:
>> vec4 port of fs_cmod_propagation.
>>
>> Shader-db results:
>> total instructions in shared programs: 6241226 -> 6224469 (-0.27%)
>> instructions in
On 13/10/15 03:10, Matt Turner wrote:
> On Mon, Oct 12, 2015 at 4:25 PM, Matt Turner wrote:
>> On Sat, Oct 10, 2015 at 4:24 AM, Alejandro Piñeiro
>> wrote:
>>> vec4 port of fs_cmod_propagation.
>>>
>>> Shader-db results:
>>> total instruc
On 13/10/15 23:36, Matt Turner wrote:
> On Tue, Oct 13, 2015 at 1:49 AM, Alejandro Piñeiro
> wrote:
>> On 13/10/15 03:10, Matt Turner wrote:
>>> Looks like this is causing an intermittent failure on HSW in our
>>> Jenkins system (but I'm not able to repr
On 14/10/15 10:15, Francisco Jerez wrote:
> Alejandro Piñeiro writes:
>
>> On 13/10/15 23:36, Matt Turner wrote:
>>> On Tue, Oct 13, 2015 at 1:49 AM, Alejandro Piñeiro
>>> wrote:
>>>> On 13/10/15 03:10, Matt Turner wrote:
>>>>> Looks l
---
This patch implements the idea proposed by Francisco Jerez. With this
change, even adding the new condition pointed by Matt Turner on the
"2/5 i965/vec4: adding vec4_cmod_propagation optimization", the shader-db
numbers remain the same. So this patch would go before the optimization
(so in thi
This include the same tests coming from test_fs_cmod_propagation, (non
vector glsl types included) plus some new with vec4 types, inspired on
the regressions found while the optimization was a work in progress.
Additionally, the check of number of instructions after the
optimization was changed fr
On 15/10/15 14:38, Francisco Jerez wrote:
> Alejandro Piñeiro writes:
>
>> ---
>>
>> This patch implements the idea proposed by Francisco Jerez. With this
>> change, even adding the new condition pointed by Matt Turner on the
>> "2/5 i965/vec4: adding
On 15/10/15 18:19, Matt Turner wrote:
> On Sat, Oct 10, 2015 at 4:24 AM, Alejandro Piñeiro
> wrote:
>> This series implements a vec4 equivalent to fs_cmod_propagation optimization.
>>
>> The last two commits are not really needed for the optimization, are just
>&
vec4_live_variables tracks now each flag channel independently, so
vec4_dead_code_eliminate can update the writemask of null registers,
based on which component are alive at the moment. This would allow
vec4_cmod_propagation to optimize out several movs involving null
registers.
v2: added support
Just realized that I sent this email with extra comments off-list.
Sending to the list now. Additionally, just a gentle reminder that this
is the only patch pending to be reviewed in this series, that have
already 5 patches reviewed.
Thanks in advance.
On 19/10/15 19:38, Alejandro Piñeiro wrote
Detected by Matt Turner while reviewing commit
a59359ecd22154cc2b3f88bb8c599f21af8a3934
---
src/mesa/drivers/dri/i965/brw_fs_dead_code_eliminate.cpp | 2 +-
src/mesa/drivers/dri/i965/brw_vec4_dead_code_eliminate.cpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/
Commit f17b78 added an alternative reads_flag(channel) that returned
if the instruction was reading a specific channel flag. By mistake it
only took into account the predicate, but when the opcode is
VS_OPCODE_UNPACK_FLAGS_SIMD4X2 there isn't any predicate, but the flag
are used.
That mistake caus
Equivalent to commit 4eebeb but with sel operations. In this case
we select the PredCtrl based on the writemask.
This change allows cmod propagation to optimize out several
instructions.
Shader-db numbers:
total instructions in shared programs: 6235835 -> 6228008 (-0.13%)
instructions in affected
On 23/10/15 17:46, Kenneth Graunke wrote:
> On Friday, October 23, 2015 04:04:35 PM Alejandro Piñeiro wrote:
>> Commit f17b78 added an alternative reads_flag(channel) that returned
>> if the instruction was reading a specific channel flag. By mistake it
>> only took into accou
Gentle ping. FWIW, this patch is a really small one.
PS: I already pinged Matt about this, but probably Friday evening is not
the best time for reminders ;)
On 22/10/15 22:25, Alejandro Piñeiro wrote:
> Detected by Matt Turner while reviewing commit
> a59359ecd22154cc2b3f88bb8c599f21af
Gentle ping.
PS: I also pinged Matt about this, but (again) probably Friday evening
is not the best time for reminders ;)
On 23/10/15 16:17, Alejandro Piñeiro wrote:
> Equivalent to commit 4eebeb but with sel operations. In this case
> we select the PredCtrl based on the writemask.
&g
On 04/11/15 20:13, Matt Turner wrote:
> On Fri, Oct 23, 2015 at 7:17 AM, Alejandro Piñeiro
> wrote:
>> Equivalent to commit 4eebeb but with sel operations. In this case
> That commit sha doesn't exist. I suspect you meant commit 8ac3b525c.
Yes, probably that sha was the on
On 04/11/15 23:49, Matt Turner wrote:
> On Wed, Nov 4, 2015 at 1:01 PM, Alejandro Piñeiro
> wrote:
>> On 04/11/15 20:13, Matt Turner wrote:
>>> On Fri, Oct 23, 2015 at 7:17 AM, Alejandro Piñeiro
>>> wrote:
>>>> Equivalent to commit 4eebeb but with se
Before 4.5, the default framebuffer was not allowed for
GetFramebufferParameter, so it should return INVALID_OPERATION for any
call using the default framebuffer.
4.5 included new pnames, and some of them are allowed for the default
framebuffer. For the rest, INVALID_OPERATION. From OpenGL 4.5 spe
Current implementation returns the value for the currently bound read
framebuffer. GetNamedFramebufferParameteriv allows to get it for any
given framebuffer. GetFramebufferParameteriv would be also interested
on that method
It was refactored by allowing to pass a given framebuffer. If NULL is
pass
4.5 added new pnames allowed for GetFramebufferParameter, and
GetNamedFramebufferParameter.
From OpenGL 4.5 spec, section 9.2.3 "Framebuffer Object Queries" (quoting
the paragraph with only the new pnames, not all the supported):
"pname may also be one of DOUBLEBUFFER,
IMPLEMENTATION_COLOR
On 11/02/17 08:52, Kenneth Graunke wrote:
> Now that we have OES_tessellation_shader, the same situation can occur
> in ES too, not just GL core profile.
>
> Having a TCS but no TES may confuse drivers - i965 crashes, for example.
>
> This prevents regressions in
> ES31-CTS.core.tessellation_shader
I sent a nitpick for the first one, but in any case, series:
Reviewed-by: Alejandro Piñeiro
On 11/02/17 08:52, Kenneth Graunke wrote:
> Now that we have OES_tessellation_shader, the same situation can occur
> in ES too, not just GL core profile.
>
> Having a TCS but no TES may con
---
src/mesa/main/formatquery.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c
index 29df958..598d34d 100644
--- a/src/mesa/main/formatquery.c
+++ b/src/mesa/main/formatquery.c
@@ -718,8 +718,8 @@ _me
Gentle ping for a really trivial patch.
On 11/02/17 17:21, Alejandro Piñeiro wrote:
> ---
> src/mesa/main/formatquery.c | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c
> inde
]->var->data.atomic.buffer_index is wrong,
and that it should use the shader program instead. Probably is just
enough to add more info on the comment "/* XXX Get rid of buffer_index
*/" here [2], but I preferred to ask first.
Thanks in advance
BR
[1]
https://github.com/Igalia/m
atomic buffer index in the unused var->data.index
> to avoid the extra memory of putting back the atmoic buffer index field.
>
> V2: store buffer index in var->data.index and uniform slot in
> var->data.location to avoid issues when linking more than 2 shaders.
> Also some
Splitted in two. The emission is moved to a new vec4_visitor
method, vec4_visitor::emit_texture, ir order to be reused
on the nir path.
---
v3: removed shadow_compare and has_nonconstant_offset booleans, as
pointed on the v2 review.
src/mesa/drivers/dri/i965/brw_vec4.h | 14 +
src/mes
Uses the nir structure to get all the info needed (sources,
dest reg, etc), and then it uses the common
vec4_visitor::emit_texture to emit the final code.
---
v3: added glsl_type_for_nir_alu_type helper as suggested (it could be reused
on fs too in the future). Setting with more detail the number
On 28/07/15 23:49, Jason Ekstrand wrote:
> On Mon, Jul 27, 2015 at 3:37 PM, Alejandro Piñeiro
> wrote:
>> Uses the nir structure to get all the info needed (sources,
>> dest reg, etc), and then it uses the common
>> vec4_visitor::emit_texture to emit the final code
Looks good to me.
Reviewed-by: Alejandro Piñeiro
On 23/09/16 05:05, Timothy Arceri wrote:
> It makes more sense to have this here where we store the other values
> from xfb qualifiers. The struct it was previously part of is now only
> used to store values to come from the api.
>
On 05/08/16 12:20, Alejandro Piñeiro wrote:
> On 05/08/16 01:53, Timothy Arceri wrote:
>> On Thu, 2016-08-04 at 18:36 +0200, Alejandro Piñeiro wrote:
>>> Hi,
>>>
>>> these days I have been trying to fix a test that uses transform
>>> feedback
>>
On 11/08/16 15:56, Andres Gomez wrote:
> On Tue, 2016-06-07 at 15:25 +1000, Dave Airlie wrote:
>> From: Dave Airlie
>>
>> This writes the subroutine indicies to the program storage for
>> a stage. This API is intended to be used by drivers to update
>> the uniform storage before uploading to the h
On 12/08/16 02:14, Timothy Arceri wrote:
> On Thu, 2016-08-11 at 17:10 +0200, Alejandro Piñeiro wrote:
>> On 05/08/16 12:20, Alejandro Piñeiro wrote:
>>> On 05/08/16 01:53, Timothy Arceri wrote:
>>>> On Thu, 2016-08-04 at 18:36 +0200, Alejandro Piñeiro wrote:
>
Reviewed-by: Alejandro Piñeiro
On 17/08/16 16:15, Kenneth Graunke wrote:
> The first simply picks the bany_inequal[234] opcodes based on the SSA
> def's number of components. The latter implicitly compares with zero
> to achieve the same semantics of GLSL's any()
Reviewed-by: Alejandro Piñeiro
On 17/08/16 16:15, Kenneth Graunke wrote:
> Previously, the scalar TCS backend was generating:
>
> mov(8) g17<1>UD 0xUD{ align1 WE_all 1Q compacted };
> and(8) g17.2<1>UD g0.2<0,1,0>UD 0x0001e000UD { align1 W
Reviewed-by: Alejandro Piñeiro
On 17/08/16 16:15, Kenneth Graunke wrote:
> The "Barrier Count" field goes in 14:9 of m0.2. The vec4 backend
> correctly shifts by 9, but the scalar backend only shifted by 8.
>
> It's not like this changed - I think I just made a typo
t; + key.tes_primitive_mode = tes->info.TessEval.PrimitiveMode;
> + key.quads_workaround = brw->gen < 9 &&
> + tes->info.TessEval.PrimitiveMode == GL_QUADS &&
> + tes->info.TessEval.Spacing == GL_EQU
Before this commit, GetProgramInterfaceiv for pname ACTIVE_RESOURCES
and all the _SUBROUTINE_UNIFORM programInterface were
returning the count of resources on the shader program using that
interface, instead of the number of active uniform resources. This would get a
wrong value (for example) if th
On 22/08/16 10:03, Tapani Pälli wrote:
>
> On 08/19/2016 09:31 PM, Alejandro Piñeiro wrote:
>> Before this commit, GetProgramInterfaceiv for pname ACTIVE_RESOURCES
>> and all the _SUBROUTINE_UNIFORM programInterface were
>> returning the count of resources on the s
Before this commit, GetProgramInterfaceiv for pname ACTIVE_RESOURCES
and all the _SUBROUTINE_UNIFORM programInterface were
returning the count of resources on the shader program using that
interface, instead of the num of uniform resources. This would get a
wrong value (for example) if the shader h
Both ARB_shader_subroutine and the GL core spec doesn't list any
error when the program is not linked.
We left a error generation for the uniform location, in order to be
consistent with other methods from the spec that generate them.
---
On 23/08/16 10:14, Tapani Pälli wrote:
> IMO it looks lik
On 24/08/16 11:13, Tapani Pälli wrote:
> Reviewed-by: Tapani Pälli
Thanks for the review.
>
> (one small coding-style suggestion below)
I will not use this suggestion. Reason below.
>
> On 08/23/2016 06:33 PM, Alejandro Piñeiro wrote:
>> Before this commit, GetProgram
Reviewed-by: Alejandro Piñeiro
On 25/08/16 14:24, Francesco Ansanelli wrote:
> Signed-off-by: Francesco Ansanelli
> ---
> src/mesa/main/program_resource.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/main/program_resource.c
> b/src/mesa/main/progr
t;> -Emil
>> ___
>> mesa-dev mailing list
>> mesa-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
> ___
> mesa-dev mailing list
> mesa-
On 26/08/16 08:38, Alejandro Piñeiro wrote:
> On 25/08/16 22:38, Ian Romanick wrote:
>> On 08/25/2016 08:19 AM, Emil Velikov wrote:
>>> On 25 August 2016 at 13:24, Francesco Ansanelli wrote:
>>>> Signed-off-by: Francesco Ansanelli
>>>> ---
>>>&
om_program_interface(GLenum programInterface)
> case GL_COMPUTE_SUBROUTINE_UNIFORM:
>return MESA_SHADER_COMPUTE;
> default:
> - assert(!"unexpected programInterface value");
> + unreachable("unexpected programInterface value");
> }
>
gt; EGLBoolean
> _eglInitContext(_EGLContext *ctx, _EGLDisplay *dpy, _EGLConfig *conf,
>
With that fixed:
Reviewed-by: Alejandro Piñeiro
--
Alejandro Piñeiro
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
resumably), which failed the dst >= 1.0 comparison.
>> The blue channel would then fall through to the dst < 1.0 && src >= 0
>> comparison, which was true, since src.b == 0. This produced a factor
>> of 0.0 instead of 1.0.
>>
>> To work around this, comp
On 09/09/16 07:33, Francisco Jerez wrote:
> Alejandro Piñeiro writes:
>
>> On 02/09/16 23:13, Kenneth Graunke wrote:
>>> On Friday, August 26, 2016 10:49:18 PM PDT Kenneth Graunke wrote:
>>>> This fixes a numerical precision issue that was causing two
After commit "i965: Fix calculation of the image height at start level", it is
not needed. This commit removes the "warning: unused variable ‘i’" warning.
---
src/mesa/drivers/dri/i965/intel_tex_image.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c
Forgotten on commit "i965: Fix calculation of the image height at start level".
Thanks to Ilia Mirkin for point it.
Fixes the following regressions on Haswell and Broadwell:
ES2-CTS.gtf.GL2ExtensionTests.egl_image_external.TestSimpleUnassociated (crash
back to pass)
ES2-CTS.gtf.GL2ExtensionTests
Reviewed-by: Alejandro Piñeiro
On 12/09/16 01:24, Timothy Arceri wrote:
> ---
> src/egl/main/eglcurrent.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/egl/main/eglcurrent.c b/src/egl/main/eglcurrent.c
> index 345f4cc..2a225bc 100644
&g
I forgot to CC Jason, that made the review of the original commit.
Sorry for the noise.
On 11/09/16 00:07, Alejandro Piñeiro wrote:
> Forgotten on commit "i965: Fix calculation of the image height at start
> level".
>
> Thanks to Ilia Mirkin for point it.
>
> Fix
Nitpick: I found the commit message hard to understand until I read the
summary.
On 03/11/16 11:47, Timothy Arceri wrote:
> Since we started releasing GLSL IR after linking the only time we can
> print GLSL IR is during linking. When regenerating variants only NIR
> will be available.
> ---
> src
On 04/11/16 22:27, Timothy Arceri wrote:
> On Fri, 2016-11-04 at 18:43 +0100, Alejandro Piñeiro wrote:
>> Nitpick: I found the commit message hard to understand until I read
>> the
>> summary.
> Ok I'll duplicate some of the summary in the commit message.
Ok,
On 05/11/16 19:57, Chris Wilson wrote:
> Currently we signal the availabilty of the query result using an
typo: availability (this also affects commit message)
> unordered pipe-control write. As it is unordered, it may be executed
> before the write of the query result itself - and so an observer m
On 19/11/16 08:48, Chris Wilson wrote:
> On Sat, Nov 05, 2016 at 11:48:57PM +0100, Alejandro Piñeiro wrote:
>> On 05/11/16 19:57, Chris Wilson wrote:
>>> Currently we signal the availabilty of the query result using an
>> typo: availability (this also affects commit mes
TS.program_interface_query.subroutines-compute).
So:
Reviewed-by: Alejandro Piñeiro
Thanks.
>
> Idealy we could probably completely remove
> NumSubroutineUniforms and just compute its value when needed
> from the resource list but this works for now.
>
> Cc: Alejandro Piñeiro
> Cc
On 29/11/16 02:38, Timothy Arceri wrote:
> On Mon, 2016-11-28 at 08:38 -0200, Alejandro Piñeiro wrote:
>> On 26/11/16 21:31, Timothy Arceri wrote:
>>> 07fe2d565b introduced a big hack in order to return
>>> NumSubroutineUniforms when querying ACTIVE_RESOURCES for
>>
The FIXME suggest that the check should be removed.
This change helps the following test:
GL45-CTS.texture_cube_map_array.color_depth_attachments
to pass consistently on Skylake GT3e. Without this patch, on
Skylake GT3e that test has a ~76% pass rate, with some random
intel_do_flush_locked errors
On 06/12/16 22:26, Anuj Phogat wrote:
> On Tue, Dec 6, 2016 at 10:58 AM, Alejandro Piñeiro
> wrote:
>> The FIXME suggest that the check should be removed.
>>
> Only if we see any performance or feature benefits in doing that.
> Last I checked I didn't see any perform
On 07/12/16 09:36, Alejandro Piñeiro wrote:
> On 06/12/16 22:26, Anuj Phogat wrote:
>> On Tue, Dec 6, 2016 at 10:58 AM, Alejandro Piñeiro
>> wrote:
>>> The FIXME suggest that the check should be removed.
>>>
>> Only if we see any performance or feature be
On 06/12/16 22:26, Anuj Phogat wrote:
> On Tue, Dec 6, 2016 at 10:58 AM, Alejandro Piñeiro
> wrote:
>> The FIXME suggest that the check should be removed.
>>
> Only if we see any performance or feature benefits in doing that.
> Last I checked I didn't see any perform
On 08/12/16 10:59, Eduardo Lima Mitev wrote:
> From OpenGL 4.5 Core Profile spec, section 18.3.2 (Copying Between Images),
> page 517 of the PDF:
>
>"An INVALID_OPERATION error is generated if either object is a texture
> and the texture is not complete (as defined in section 8.17), if the
f they don't apply to block members, then how
> should members be named?
Makes sense, although in a really convoluted way, as it seems very
interpretative. But that goes back to the lack of clearness of the spec.
Perhaps (I hope?) all this work would help to clarify it.
> Unfortu
On 17/12/16 17:57, Kenneth Graunke wrote:
> On Saturday, December 17, 2016 5:41:35 PM PST Alejandro Piñeiro wrote:
>> On 17/12/16 03:35, Kenneth Graunke wrote:
>>> This fixes 555 dEQP tests (using the nougat-cts-dev branch), Piglit's
>>> arb_program_interface_q
On 17/12/16 17:57, Kenneth Graunke wrote:
> On Saturday, December 17, 2016 5:41:35 PM PST Alejandro Piñeiro wrote:
>> On 17/12/16 03:35, Kenneth Graunke wrote:
>>> This fixes 555 dEQP tests (using the nougat-cts-dev branch), Piglit's
>>> arb_program_interface_q
lgtm
Reviewed-by: Alejandro Piñeiro
On 17/12/16 03:46, Kenneth Graunke wrote:
> stage_mask is a bitmask of shader stages, so the proper comparison would
> be (1 << MESA_SHADER_VERTEX), not MESA_SHADER_VERTEX itself.
>
> But we only care for structure types, and VS inputs canno
typo on the subject: "Eliminate"
On 20/12/16 00:45, Timothy Arceri wrote:
> Reviewed-by: Timothy Arceri
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
silent, flush, incomplete_tex and incomplete_fbo flags were not
documented (see src/mesa/main.debug.c for more info).
FP is not checked anymore.
v2 (Brian Paul):
* MESA_DEBUG accepts a comma-separated list of parameters.
* Clarify how MESA_DEBUG behaves with mesa debug and release builds.
* Up
Fixes:
GL44-CTS.texture_barrier_ARB.same-texel-rw-multipass
On Haswell, Broadwell and Skylake (note that in order to execute that
test, it is needed to override GL and GLSL versions).
On gen6 this test was already working without this change. It keeps
working after it.
This commit replaces the c
e only place we have this problem in
> the GL driver. We should probably fix it in brw_emit_pipe_control.
>
> On Jun 30, 2016 12:00 AM, "Alejandro Piñeiro" <mailto:apinhe...@igalia.com>> wrote:
>
> Fixes:
> GL44-CTS.texture_barrier_ARB.same-texel-rw-mul
On 30/06/16 23:16, Francisco Jerez wrote:
> Alejandro Piñeiro writes:
>
>> Fixes:
>> GL44-CTS.texture_barrier_ARB.same-texel-rw-multipass
>>
>> On Haswell, Broadwell and Skylake (note that in order to execute that
>> test, it is needed to override GL and GLS
On 30/06/16 15:28, Brian Paul wrote:
> On 06/29/2016 09:50 AM, Alejandro Piñeiro wrote:
>> silent, flush, incomplete_tex and incomplete_fbo flags were not
>> documented (see src/mesa/main.debug.c for more info).
>>
>> FP is not checked anymore.
>>
>> v2 (B
Looks good to me:
Reviewed-by: Alejandro Piñeiro
On 01/07/16 07:07, Francisco Jerez wrote:
> Shouldn't cause any functional changes at this point, but we have
> forgotten to apply this workaround several times in the past, make
> sure it doesn't happen again.
> ---
>
Looks good to me:
Reviewed-by: Alejandro Piñeiro
Note: I think that patches 3-4 should be reviewed by a more seasoned
developer (specially patch 3).
On 01/07/16 07:07, Francisco Jerez wrote:
> There were two places in the driver doing a pipe control VF cache
> flush, one of them was m
For the case (both src or dst) where we had a texobject, but the
texobject target was not the same that the method target, this spec
paragraph was appplied:
/* Section 18.3.2 (Copying Between Images) of the OpenGL 4.5 Core
* Profile spec says:
*
* "An INVALID_VALUE error is generated if
lai Hähnle
>
> On 01.07.2016 19:03, Alejandro Piñeiro wrote:
>> For the case (both src or dst) where we had a texobject, but the
>> texobject target was not the same that the method target, this spec
>> paragraph was appplied:
>>
>> /* Section 18.3.2 (Copying
g.
I will start to look to this problem, but any idea/feedback to get it
solved would be welcome.
BR
[1]
https://cgit.freedesktop.org/piglit/commit/?id=8cb75a1bc1cbdec0e0c8f9a9b10631a369df2f5b
On 30/06/16 23:16, Francisco Jerez wrote:
> Alejandro Piñeiro writes:
>
&
Forget the previous email. It was an error on the test. The texture
barrier works fine.
Sorry for the noise.
BR
On 08/07/16 15:58, Alejandro Piñeiro wrote:
> Hi, today I was updating the piglit test, as I got a detailed review.
> While testing the changes, I found that there are some para
Without this commit, a image is considered valid if the level of the
texture bound to the image is complete, something we can check as mesa
save independently if it is "base incomplete" of "mipmap incomplete".
But, from the OpenGL 4.3 Core Specification, section 8.25 ("Texture
Image Loads and Stor
On 14/07/16 21:24, Francisco Jerez wrote:
> Alejandro Piñeiro writes:
>
>> Without this commit, a image is considered valid if the level of the
>> texture bound to the image is complete, something we can check as mesa
>> save independently if it is "base inco
From the OpenGL 4.3 Core Specification, section 8.25 ("Texture
Image Loads and Stores"):
"An access is considered invalid if:
the texture bound to the selected image unit is incomplete;"
This fixes:
GL44-CTS.shader_image_load_store.incomplete_textures
v2: use _mesa_is_texture_complete, mai
Don't know if there are still some missing patches to be submitted to
master, but this patch caused regressions on skylake on the following
CTS tests:
*
GL44-CTS.texture_cube_map_array.image_texture_size.texture_size_compute_sh
*
GL44-CTS.texture_cube_map_array.image_texture_size.textu
On 16/07/16 16:29, Jason Ekstrand wrote:
>
> On Jul 16, 2016 3:59 AM, "Alejandro Piñeiro" <mailto:apinhe...@igalia.com>> wrote:
> >
> > Don't know if there are still some missing patches to be submitted to
> > master, but this patch caused regre
Hi,
On 15/07/16 22:46, Francisco Jerez wrote:
> Alejandro Piñeiro writes:
>
>> On 14/07/16 21:24, Francisco Jerez wrote:
>>> Alejandro Piñeiro writes:
>>>
>>>> Without this commit, a image is considered valid if the level of the
>>>> te
Is this the correct version of the patch? It uses nir_lower_io with 4
parameters, while nir_lower_io on master uses 3 (and afaik, it has been
using 3 for a while).
FWIW, this patch doesn't apply cleanly with current master mesa.
BR
On 19/07/16 08:33, Timothy Arceri wrote:
> Rather than trying to
Reviewed-by: Alejandro Piñeiro
On 19/07/16 08:33, Timothy Arceri wrote:
> We will use this for output varyings. To make component
> packing simpler we will just treat all varyings as vec4s.
> ---
> src/mesa/drivers/dri/i965/brw_fs.cpp | 13 +
> src/mesa/d
wed-by: Alejandro Piñeiro
> ---
> src/mesa/drivers/dri/i965/brw_fs.h | 1 -
> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 22 ++
> src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 10 ++
> src/mesa/drivers/dri/i965/brw_nir.c | 8 --
I miss a little explanation on the commit message (like on commit 8),
but that is just personal preference (and in general I personally tend
to be too verbose on the commit messages).
Either if you add a little explanation or not:
Reviewed-by: Alejandro Piñeiro
On 19/07/16 08:33, Timothy
of becoming an
add-more-comments-pain-in-the-neck, probably it is worth to expand a
little the comment below.
> +
> + locations[idx + 1][var->data.index] = location + offset;
> +}
> +
> location += type_size(var->type);
>
1 - 100 of 940 matches
Mail list logo
