Re: [Mesa-dev] [PATCH v3 19/48] i965/fs/nir: Don't stomp 64-bit values to D in get_nir_src

2017-10-30 Thread Iago Toral
On Fri, 2017-10-27 at 12:21 -0700, Jason Ekstrand wrote: > On Thu, Oct 26, 2017 at 11:53 PM, Iago Toral > wrote: > > On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > > > > > --- > > > > >  src/intel/compiler/brw_fs_nir.cpp | 33 +-- > > > > > > > -- > > >

Re: [Mesa-dev] [PATCH v3 20/48] intel/fs: Protect opt_algebraic from OOB BROADCAST indices

2017-10-30 Thread Iago Toral
On Fri, 2017-10-27 at 12:28 -0700, Jason Ekstrand wrote: > On Fri, Oct 27, 2017 at 12:09 AM, Iago Toral > wrote: > > On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > > > > > --- > > > > >  src/intel/compiler/brw_fs.cpp | 10 -- > > > > >  1 file changed, 8 insertions(+), 2 dele

Re: [Mesa-dev] [PATCH v3 29/48] intel/cs: Rework the way thread local ID is handled

2017-10-30 Thread Iago Toral
On Fri, 2017-10-27 at 12:37 -0700, Jason Ekstrand wrote: > On Fri, Oct 27, 2017 at 2:11 AM, Iago Toral > wrote: > > On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > > > > > Previously, brw_nir_lower_intrinsics added the param and then > > emitted > > > > > a > > > > > load_uniform int

Re: [Mesa-dev] [PATCH v3 23/48] intel/fs: Assign constant locations if they haven't been assigned

2017-10-30 Thread Iago Toral
On Fri, 2017-10-27 at 12:43 -0700, Jason Ekstrand wrote: > On Fri, Oct 27, 2017 at 12:35 AM, Iago Toral > wrote: > > This sounds good to me, but I guess it is not really fixing > > anything, > > > > right? I ask because the subject claims that this patch does > > something > > > > that the origi

Re: [Mesa-dev] [PATCH mesa] meson: wire up egl/android

2017-10-30 Thread Tomasz Figa
Hi everyone, On Sat, Oct 28, 2017 at 2:38 AM, Dylan Baker wrote: > Whooo! Thanks for doing this! > > Quoting Eric Engestrom (2017-10-27 07:40:17) >> Cc: Rob Herring >> Cc: Tomasz Figa >> Signed-off-by: Eric Engestrom >> --- >> Completely untested! >> It's a step in the right direction though;

[Mesa-dev] [PATCH] i965: Don't flag BRW_NEW_SURFACES unless some push constants are dirty.

2017-10-30 Thread Kenneth Graunke
Due to a gaffe on my part, we were re-emitting all binding table entries on every single draw call. The push_constant_packets atom listens to BRW_NEW_DRAW_CALL, but skips emitting 3DSTATE_CONSTANT_XS for each stage unless stage_state->push_constants_dirty is true. However, it flagged BRW_NEW_SURF

[Mesa-dev] [Bug 103513] [build failure] radv_shader.c:683:2: error: format not a string literal and no format arguments [-Werror=format-security]

2017-10-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103513 Bug ID: 103513 Summary: [build failure] radv_shader.c:683:2: error: format not a string literal and no format arguments [-Werror=format-security] Product: Mesa V

[Mesa-dev] [PATCH] radv: Fix -Wformat-security issue

2017-10-30 Thread Alex Smith
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103513 Fixes: de889794134e ("radv: Implement VK_AMD_shader_info") Signed-off-by: Alex Smith --- src/amd/vulkan/radv_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/rad

Re: [Mesa-dev] [PATCH] radv: Fix -Wformat-security issue

2017-10-30 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen Won't be in a position to push till the evening though. On 30 Oct 2017 09:38, "Alex Smith" wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103513 Fixes: de889794134e ("radv: Implement VK_AMD_shader_info") Signed-off-by: Alex Smith --- src/amd/vul

Re: [Mesa-dev] [PATCH] radv: Fix -Wformat-security issue

2017-10-30 Thread Samuel Pitoiset
Pushed, thanks! On 10/30/2017 09:38 AM, Alex Smith wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103513 Fixes: de889794134e ("radv: Implement VK_AMD_shader_info") Signed-off-by: Alex Smith --- src/amd/vulkan/radv_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [Bug 103513] [build failure] radv_shader.c:683:2: error: format not a string literal and no format arguments [-Werror=format-security]

2017-10-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103513 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [PATCH mesa] i965: remove unused variable

2017-10-30 Thread Eric Engestrom
Fixes: 2c873060d3578c7004c0 "i965: Delete unused brw_vs_prog_data::nr_attributes field." Cc: Kenneth Graunke Signed-off-by: Eric Engestrom --- src/intel/compiler/brw_vec4.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/intel/compiler/brw_vec4.cpp b/src/intel/compiler/brw_vec

Re: [Mesa-dev] [PATCH mesa] i965: remove unused variable

2017-10-30 Thread Eduardo Lima Mitev
I saw it this morning as well. Thanks for fixing it. Reviewed-by: Eduardo Lima Mitev On 10/30/2017 11:37 AM, Eric Engestrom wrote: > Fixes: 2c873060d3578c7004c0 "i965: Delete unused >brw_vs_prog_data::nr_attributes field." > Cc: Kenneth Graunke > Signed-off-by: Eric Engestrom > --- > s

[Mesa-dev] [Bug 103505] RX 480, newest mesa, VULKAN Does not start

2017-10-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103505 --- Comment #4 from Valentin Novikov --- (In reply to Matias N. Goldberg from comment #3) > Sounds similar to this bug 99591: > https://bugs.freedesktop.org/show_bug.cgi?id=99591 > > Try export LD_BIND_NOW=1 before running the Vulkan applicatio

Re: [Mesa-dev] [PATCH v3 39/48] nir: Add a new subgroups lowering pass

2017-10-30 Thread Iago Toral
On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > This commit pulls nir_lower_read_invocations_to_scalar along with > most > of the guts of nir_opt_intrinsics (which mostly does subgroup > lowering) > into a new nir_lower_subgroups pass.  There are various other bits of > subgroup lowering

Re: [Mesa-dev] [PATCH v2] wayland-drm: static inline wayland_drm_buffer_get

2017-10-30 Thread Eric Engestrom
On Tuesday, 2017-10-24 17:14:20 +0100, Emil Velikov wrote: > From: Emil Velikov > > The function is effectively a direct function call into > libwayland-server.so. > > Thus GBM no longer depends on the wayland-drm static library, making the > build more straight forward. And the resulting binary

Re: [Mesa-dev] [PATCH v3 43/48] nir/lower_subgroups: Lower ballot intrinsics to the specified bit size

2017-10-30 Thread Iago Toral
On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > Ballot intrinsics return a bitfield of subgroups.  In GLSL and some > SPIR-V extensions, they return a uint64_t.  In SPV_KHR_shader_ballot, > they return a uvec4.  Also, some back-ends would rather pass around > 32-bit values because it's e

Re: [Mesa-dev] [PATCH v3 44/48] nir, intel/compiler: Use a fixed subgroup size

2017-10-30 Thread Iago Toral
On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > The GL_ARB_shader_ballot spec says that gl_SubGroupSizeARB is > declared > as a uniform. I was a bit surprised that we can change this so easily, then realized that the name for this built-in is a bit misleading since this doesn't really r

Re: [Mesa-dev] [PATCH 08/25] gallium/u_threaded: mark queries flushed only for non-deferred flushes

2017-10-30 Thread Marek Olšák
On Mon, Oct 30, 2017 at 2:57 AM, Marek Olšák wrote: > On Sun, Oct 22, 2017 at 9:07 PM, Nicolai Hähnle wrote: >> From: Nicolai Hähnle >> >> The driver uses (and must use) the flushed flag of queries as a hint that >> it does not have to check for synchronization with currently queued up >> comman

Re: [Mesa-dev] [PATCH v3 00/48] nir, intel: Prerequisites for subgroups

2017-10-30 Thread Iago Toral
I posted comments in patches 39 and 43, but otherwise patches 39-48 are: Reviewed-by: Iago Toral Quiroga Iago On Fri, 2017-10-27 at 13:57 +0200, Iago Toral wrote: > I dropped a few more comments on patches 18-20, 23, 25, 29-31, 34 and > 38 but nothing major in general. > > I have doubts that p

Re: [Mesa-dev] [PATCH] etnaviv: Don't flush on transfer when UNSYNCHRONIZED

2017-10-30 Thread Lucas Stach
Am Samstag, den 28.10.2017, 16:01 +0200 schrieb Wladimir J. van der Laan: > Structure code to only flush when we will potentially call cpu_prep. This > prevents spurious flushes in applications that heavily rely on u_uploader. > > > Signed-off-by: Wladimir J. van der Laan > --- >  src/gallium/dri

Re: [Mesa-dev] [PATCH 0/3] Gallium: Signed VBO offsets to fix SPECviewperf stability

2017-10-30 Thread Dieter Nützel
Hello Marek, running with this since it appears. Which SPECviewperf version (self compiled) are you using? I've read that 'latest' versions are Windows only. Only have a _very_ old 32-bit self compiled version here, currently...;-) BTW Do have a pointer to your OpenGL 3.1 Compatibility tree ha

Re: [Mesa-dev] [PATCH v2] etnaviv: Allow clearing constant buffer using buffer==NULL user_buffer==NULL

2017-10-30 Thread Lucas Stach
Am Samstag, den 28.10.2017, 16:16 +0200 schrieb Wladimir J. van der Laan: > Prevents an assertion when using GALLIUM_HUD with ioquake3, > when cso_restore_constant_buffer_slot0 restores an empty > constant buffer in slot 0. > > > Signed-off-by: Wladimir J. van der Laan > --- >  src/gallium/driver

Re: [Mesa-dev] [PATCH v2] wayland-drm: static inline wayland_drm_buffer_get

2017-10-30 Thread Emil Velikov
On 30 October 2017 at 12:02, Eric Engestrom wrote: > On Tuesday, 2017-10-24 17:14:20 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> The function is effectively a direct function call into >> libwayland-server.so. >> >> Thus GBM no longer depends on the wayland-drm static library, making t

Re: [Mesa-dev] [PATCH v2] wayland-drm: static inline wayland_drm_buffer_get

2017-10-30 Thread Eric Engestrom
On Monday, 2017-10-30 13:39:00 +, Emil Velikov wrote: > On 30 October 2017 at 12:02, Eric Engestrom wrote: > > On Tuesday, 2017-10-24 17:14:20 +0100, Emil Velikov wrote: > >> From: Emil Velikov > >> > >> The function is effectively a direct function call into > >> libwayland-server.so. > >> >

[Mesa-dev] [PATCH] st/program: fix compute shader nir references

2017-10-30 Thread Rob Clark
In case the IR is NIR, the driver takes reference to the nir_shader. Also, because there are no variants, we need to clone the shader, instead of sharing the reference with gl_program, which would result in a double free in _mesa_delete_program(). Signed-off-by: Rob Clark --- src/mesa/state_trac

[Mesa-dev] [PATCH] gallium: fix typos in README.portability

2017-10-30 Thread Ben Crocker
Cc: "17.2" Signed-off-by: Ben Crocker --- src/gallium/README.portability | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/README.portability b/src/gallium/README.portability index cf6cc36afb..cdc02bb36d 100644 --- a/src/gallium/README.portability +++ b/src/ga

[Mesa-dev] [ANNOUNCE] mesa 17.2.4

2017-10-30 Thread Andres Gomez
Mesa 17.2.4 is now available. In this release we have: In Mesa Core we have included a change to prevent KOTOR from breaking when in combination with the ATI fragment shader extension. Additionally, NIR has also received a correction. Mesa's state tracker has gotten a patch to avoid leaks in ce

[Mesa-dev] [ANNOUNCE] mesa 17.3.0-rc2

2017-10-30 Thread Emil Velikov
The second release candidate for Mesa 17.3.0 is now available. Alex Smith (1): radv: Update code pointer correctly if a variant is already created Bas Nieuwenhuizen (1): radv: Fix truncation issue hexifying the cache uuid for the disk cache. Daniel Stone (1): meson: wayland-egl

[Mesa-dev] [AppVeyor] mesa master #5987 failed

2017-10-30 Thread AppVeyor
Build mesa 5987 failed Commit 6997d222f5 by Emil Velikov on 10/30/2017 3:24 PM: docs/release-calendar: update - 17.3.0-rc2 is out\n\nSigned-off-by: Emil Velikov Configure your notification preferences ___

Re: [Mesa-dev] Mesa 17.2.4 release candidate

2017-10-30 Thread Emil Velikov
On 28 October 2017 at 21:35, Andres Gomez wrote: > On Fri, 2017-10-27 at 14:14 -0400, Ilia Mirkin wrote: >> On Fri, Oct 27, 2017 at 1:43 PM, Andres Gomez wrote: >> > Rejected (6) >> > >> > >> > Ilia Mirkin (1): >> > glsl: fix derived cs variables >> > >> > Reason: Commit is too

Re: [Mesa-dev] Mesa 17.2.4 release candidate

2017-10-30 Thread Ilia Mirkin
On Mon, Oct 30, 2017 at 11:29 AM, Emil Velikov wrote: > On 28 October 2017 at 21:35, Andres Gomez wrote: >> On Fri, 2017-10-27 at 14:14 -0400, Ilia Mirkin wrote: >>> On Fri, Oct 27, 2017 at 1:43 PM, Andres Gomez wrote: >>> > Rejected (6) >>> > >>> > >>> > Ilia Mirkin (1): >>> >

[Mesa-dev] [AppVeyor] mesa master #5988 completed

2017-10-30 Thread AppVeyor
Build mesa 5988 completed Commit fc7816fd4e by Emil Velikov on 10/30/2017 3:32 PM: Revert "foo"\n\nThis reverts commit 27d5a7bce09aef83d3349cca5f3777007b3b94b6.\n\nI fat fingered it, failing to reset the checkout before applying the\nsequential commit.

Re: [Mesa-dev] [PATCH] Android: move drivers' symlinks to /vendor (v2)

2017-10-30 Thread Emil Velikov
On 27 October 2017 at 20:54, Mauro Rossi wrote: > Having moved gallium_dri.so library to /vendor/lib/dri > also symlinks need to be coherently created using TARGET_OUT_VENDOR instead > of TARGET_OUT > or all non Intel drivers will not be loaded with Android N and earlier, > thus causing SurfaceFl

Re: [Mesa-dev] [PATCH v3 19/43] i965/fs: Support push constants of 16-bit types

2017-10-30 Thread Chema Casanova
El 30/10/17 a las 07:44, Pohjolainen, Topi escribió: > On Sun, Oct 29, 2017 at 11:17:11PM +0100, Chema Casanova wrote: >> On 29/10/17 19:55, Pohjolainen, Topi wrote: >>> On Thu, Oct 12, 2017 at 08:38:08PM +0200, Jose Maria Casanova Crespo wrote: We enable the use of 16-bit values in push const

[Mesa-dev] [PATCH] radv: bail out when binding the same index buffer

2017-10-30 Thread Samuel Pitoiset
DOW3 appears to hit this path. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 9 + src/amd/vulkan/radv_private.h| 5 + 2 files changed, 14 insertions(+) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 12fd70f512..00ed

Re: [Mesa-dev] [PATCH v2] etnaviv: Allow clearing constant buffer using buffer==NULL user_buffer==NULL

2017-10-30 Thread Wladimir J. van der Laan
On Mon, Oct 30, 2017 at 02:21:07PM +0100, Lucas Stach wrote: > I would prefer the shorter expression (!cb->buffer && !cb->user_buffer) > here, which seems more consistent with the rest of the codebase. Well, I mimiced the style from other assertion in the function which compares explicitly with N

[Mesa-dev] [PATCH 00/19] GC7000 preparation

2017-10-30 Thread Wladimir J. van der Laan
This is the entire patch set needed for GC7000 support in Mesa, except the implementation of texture descriptors. There is a DRM kernel interface issue to resolve there [1]. I'm sending this early to get some eyes on it, and because it is quite a large patch-set and will be challenging to keep thi

[Mesa-dev] [PATCH 02/19] etnaviv: Const-correctness etnaviv_emit.h

2017-10-30 Thread Wladimir J. van der Laan
The relocation structure is never changed by submitting it. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_emit.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_emit.h b/src/gallium/drivers/etnaviv/etnaviv

[Mesa-dev] [PATCH 01/19] etnaviv: Update from rnndb

2017-10-30 Thread Wladimir J. van der Laan
Updated as of etnav_viv commit 8255e4b. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 2 +- src/gallium/drivers/etnaviv/etnaviv_format.c | 9 +- src/gallium/drivers/etnaviv/etnaviv_state.c | 2 +- src/gallium/drivers/etnaviv/etnaviv

[Mesa-dev] [PATCH 04/19] etnaviv: Emit SCALE for vertex attributes

2017-10-30 Thread Wladimir J. van der Laan
This is used by HALTI2+ (GC3000+) when drawing with DRAW_INSTANCED. It is also necessary when switching between integer and floating point vertex element formats. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 5 + src/gallium/drivers/etnaviv/et

[Mesa-dev] [PATCH 05/19] etnaviv: Use only DRAW_INSTANCED on GC3000+

2017-10-30 Thread Wladimir J. van der Laan
The blob does this, as DRAW_INSTANCED can replace fully all the other draw commands - the other path is only there for compatibility and will go away (or at least rot to become buggy due to dis-use) in newer hardware. Preparation for GC7000 support. Signed-off-by: Wladimir J. van der Laan --- s

[Mesa-dev] [PATCH 08/19] etnaviv: GC7000: Split off RS blit functions

2017-10-30 Thread Wladimir J. van der Laan
Prepare for BLT-based blitting path by moving RS-based blitting to its own implementation file. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/Makefile.sources | 1 + src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 553 +-- src/gallium/driver

[Mesa-dev] [PATCH 03/19] etnaviv: Put HALTI level in specs

2017-10-30 Thread Wladimir J. van der Laan
The HALTI level is an indication of the gross architecture of the GPU. It determines for significant part what feature level the GPU has, what state (especially frontend state) is there, and where it is located. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_inte

[Mesa-dev] [PATCH 06/19] etnaviv: GC7000: Support BLT as recipient for etna_stall

2017-10-30 Thread Wladimir J. van der Laan
When the BLT is involved as source or target, add an extra BLT enable/disable sequence around the sync sequence. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/gallium/

[Mesa-dev] [PATCH 07/19] etnaviv: GC7000: Add etnaviv_blt

2017-10-30 Thread Wladimir J. van der Laan
Add a low-level library for using the BLT engine from the etnaviv driver. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/Makefile.sources | 2 + src/gallium/drivers/etnaviv/etnaviv_blt.c| 219 +++ src/gallium/drivers/etnaviv/etnaviv_blt.h

[Mesa-dev] [PATCH 09/19] etnaviv: GC7000: BLT engine blitting support

2017-10-30 Thread Wladimir J. van der Laan
Add an implemenation of key clear_blit functions using the BLT engine that replaced the RS on GC7000. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/Makefile.sources | 1 + src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 7 +- src/gallium/drivers/etnaviv/e

[Mesa-dev] [PATCH 10/19] etnaviv: GC7000: No RS align when using BLT

2017-10-30 Thread Wladimir J. van der Laan
RS align is not necessary and might even be harmful when using the BLT engine for blitting. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 15 + src/gallium/drivers/etnaviv/etnaviv_surface.c | 41 + src/gallium/driver

[Mesa-dev] [PATCH 11/19] etnaviv: GC7000: Update context reset for ..HALTI5

2017-10-30 Thread Wladimir J. van der Laan
Update context reset for HALTI3..HALTI5, sorting states for the HALTI version that has them. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_context.c | 37 +++ 1 file changed, 32 insertions(+), 5 deletions(-) diff --git a/src/gallium/driv

[Mesa-dev] [PATCH 12/19] etnaviv: GC7000: Update screen specs for HALTI5

2017-10-30 Thread Wladimir J. van der Laan
- This core must load shaders from memory (AFAIK) - Yet another new location for UNIFORMS Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/etnaviv/

[Mesa-dev] [PATCH 14/19] etnaviv: GC7000: Make point sprites work on HALTI5

2017-10-30 Thread Wladimir J. van der Laan
Track varying component offset of the point size output, as well as provide the offset of the point coord input. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_compiler.c | 7 ++- src/gallium/drivers/etnaviv/etnaviv_compiler.h | 1 + src/gallium/drivers/etnav

[Mesa-dev] [PATCH 17/19] etnaviv: GC7000: Move active_samplers_bits to texture

2017-10-30 Thread Wladimir J. van der Laan
This needs to be shared between texture_plain and texture_desc. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_emit.c| 12 src/gallium/drivers/etnaviv/etnaviv_texture.c | 6 ++ src/gallium/drivers/etnaviv/etnaviv_texture.h | 11 +++

[Mesa-dev] [PATCH 13/19] etnaviv: GC7000: State changes for HALTI3..5

2017-10-30 Thread Wladimir J. van der Laan
Update state objects to add new state, and emit function to emit new state. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 247 +++-- src/gallium/drivers/etnaviv/etnaviv_internal.h | 4 + src/gallium/drivers/etnaviv/etnaviv_stat

[Mesa-dev] [PATCH 15/19] etnaviv: GC7000: Track dirty sampler views

2017-10-30 Thread Wladimir J. van der Laan
Need this to efficiently emit texture descriptor invalidations. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_context.c | 1 + src/gallium/drivers/etnaviv/etnaviv_context.h | 1 + src/gallium/drivers/etnaviv/etnaviv_emit.c| 1 + src/gallium/drivers/etnaviv/e

[Mesa-dev] [PATCH 19/19] etnaviv: GC7000: Split off current texture code

2017-10-30 Thread Wladimir J. van der Laan
Prepare for two texture handling paths, the descriptor-based path will be added in a future commit. These are structured so that the texture implementation handles its own state emission. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/Makefile.sources | 2 + src/

[Mesa-dev] [PATCH 18/19] etnaviv: GC7000: Move etna_coalesce to emit header file

2017-10-30 Thread Wladimir J. van der Laan
Want to be able to emit state from the texture implementation. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 83 -- src/gallium/drivers/etnaviv/etnaviv_emit.h | 83 ++ 2 files changed, 83 insertion

[Mesa-dev] [PATCH 16/19] etnaviv: GC7000: Factor out incompatible texture handling logic

2017-10-30 Thread Wladimir J. van der Laan
This will be shared with the texture descriptor path. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_texture.c | 40 +-- src/gallium/drivers/etnaviv/etnaviv_texture.h | 5 2 files changed, 30 insertions(+), 15 deletions(-) diff --gi

Re: [Mesa-dev] [PATCH] st/program: fix compute shader nir references

2017-10-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Oct 30, 2017 at 3:36 PM, Rob Clark wrote: > In case the IR is NIR, the driver takes reference to the nir_shader. > Also, because there are no variants, we need to clone the shader, > instead of sharing the reference with gl_program, which would result > in

Re: [Mesa-dev] [PATCH 0/3] Gallium: Signed VBO offsets to fix SPECviewperf stability

2017-10-30 Thread Marek Olšák
I use SPECviewperf from the phoronix test suite. See the gl31 branch in my repo. Marek On Mon, Oct 30, 2017 at 2:18 PM, Dieter Nützel wrote: > Hello Marek, > > running with this since it appears. > Which SPECviewperf version (self compiled) are you using? > I've read that 'latest' versions are

Re: [Mesa-dev] [PATCH v2] wayland-drm: static inline wayland_drm_buffer_get

2017-10-30 Thread Dylan Baker
Quoting Eric Engestrom (2017-10-30 07:12:32) > On Monday, 2017-10-30 13:39:00 +, Emil Velikov wrote: > > On 30 October 2017 at 12:02, Eric Engestrom > > wrote: > > > On Tuesday, 2017-10-24 17:14:20 +0100, Emil Velikov wrote: > > >> From: Emil Velikov > > >> > > >> The function is effectively

Re: [Mesa-dev] Mesa 17.2.4 release candidate

2017-10-30 Thread Andres Gomez
On Mon, 2017-10-30 at 11:39 -0400, Ilia Mirkin wrote: > On Mon, Oct 30, 2017 at 11:29 AM, Emil Velikov > wrote: > > On 28 October 2017 at 21:35, Andres Gomez wrote: > > > On Fri, 2017-10-27 at 14:14 -0400, Ilia Mirkin wrote: > > > > On Fri, Oct 27, 2017 at 1:43 PM, Andres Gomez wrote: > > > > >

Re: [Mesa-dev] [PATCH v2] wayland-drm: static inline wayland_drm_buffer_get

2017-10-30 Thread Dylan Baker
for the meson bits: Reviewed-by: Dylan Baker Please do make sure that Daniel or someone else with wayland expertise looks at this tool, I am not qualified to review that. Dylan Quoting Emil Velikov (2017-10-27 16:50:25) > On 24 October 2017 at 17:14, Emil Velikov wrote: > > From: Emil Velikov

Re: [Mesa-dev] [PATCH mesa] i965: remove unused variable

2017-10-30 Thread Kenneth Graunke
On Monday, October 30, 2017 3:37:40 AM PDT Eric Engestrom wrote: > Fixes: 2c873060d3578c7004c0 "i965: Delete unused >brw_vs_prog_data::nr_attributes field." > Cc: Kenneth Graunke > Signed-off-by: Eric Engestrom > --- > src/intel/compiler/brw_vec4.cpp | 3 --- > 1 file changed, 3 deletion

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] radv: Disallow indirect outputs for GS on GFX9 as well.

2017-10-30 Thread Andres Gomez
On Fri, 2017-10-27 at 19:50 +0200, Bas Nieuwenhuizen wrote: > On Fri, Oct 27, 2017 at 5:03 PM, Andres Gomez wrote: [...] > > In any case, I was wondering whether it would be interesting to bring > > them both to the 17.2 stable queue and whether we would also want > > Timothy's preceding patch:

[Mesa-dev] [PATCH 02/33] intel: common: silence compiler warning

2017-10-30 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 395ff02908a..55e7305117c 100644 --- a/src/intel/common/gen_decoder.c +++ b/src/intel/common

[Mesa-dev] [PATCH 06/33] intel: decoder: move field name copy

2017-10-30 Thread Lionel Landwerlin
This should be inside the function that actually decodes fields. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index ef39c1c14db..833

[Mesa-dev] [PATCH 00/33] intel: UI for aubinator

2017-10-30 Thread Lionel Landwerlin
Hi all, This is a proposal for a tool to help debug intel driver through aubdumps. Having gone through implementing (& mostly debugging) the ycbcr extension for anv, I wished I had a better tool than the text output of aubinator. This is the current state of about 1 & 1/2 month of experimenting w

[Mesa-dev] [PATCH 03/33] intel: decoder: build sorted linked lists of fields

2017-10-30 Thread Lionel Landwerlin
The xml files don't always have fields in order. This might confuse our parsing of the commands. Let's have the fields in order. To do this, the easiest way it to use a linked list. It also helps a bit with the iterator. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 52 ++

[Mesa-dev] [PATCH 01/33] intel: common: expose gen_spec fields

2017-10-30 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 13 - src/intel/common/gen_decoder.h | 13 + 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 85880143f00..395ff02908

[Mesa-dev] [PATCH 08/33] intel: decoder: don't read qword outside instruction/struct limit

2017-10-30 Thread Lionel Landwerlin
We used to print invalid data when the last field was being clamped to 32bits due to Dword Length of the whole instruction. Here is an example where the decoder read part of the next instruction instead of stopping at the 32bit limit: 0x000ce0b4: 0x1002: MI_STORE_DATA_IMM 0x000ce0b4: 0x1000

[Mesa-dev] [PATCH 10/33] intel: decoder: expose helper to test header fields

2017-10-30 Thread Lionel Landwerlin
These fields are of little importance as they're used to recognize instructions. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 6 +++--- src/intel/common/gen_decoder.h | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/s

[Mesa-dev] [PATCH 05/33] intel: decoder: reorder iterator init function

2017-10-30 Thread Lionel Landwerlin
Making the next change more readable. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 040201541ff..ef39c1c1

[Mesa-dev] [PATCH 09/33] aubinator: print number of dwords per instruction

2017-10-30 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 48d4456cc16..2c4eaab1701 100644 --- a/src/intel/tools/aubinator.c +++ b/src/intel/tools/aubin

[Mesa-dev] [PATCH 04/33] intel: common: print out all dword with field spanning multiple dwords

2017-10-30 Thread Lionel Landwerlin
For example, we were skipping Dword 3 in this PIPE_CONTROL : 0x000ce130: 0x7a04: PIPE_CONTROL DWord Length: 4 0x000ce134: 0x0010 : Dword 1 Flush LLC: false Destination Address Type: 0 (PPGTT) LRI Post Sync Operation: 0 (No LRI Operation) Store Data Index: 0 Comma

[Mesa-dev] [PATCH 13/33] intel: decoder: pack iterator variable declarations

2017-10-30 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 6a6a1f0aca4..cd18580aea8 100644 --- a/src/intel/common/gen_decoder.c +

[Mesa-dev] [PATCH 11/33] intel: decoder: add destructor for gen_spec

2017-10-30 Thread Lionel Landwerlin
This makes use of ralloc to simplify the destruction. We can also store instructions in hash tables. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 176 +++-- src/intel/common/gen_decoder.h | 15 ++-- 2 files changed, 90 insertions(+),

[Mesa-dev] [PATCH 15/33] intel: error-decode: implement a rolling window of programs

2017-10-30 Thread Lionel Landwerlin
If we have more programs than what we can store, aubinator_error_decode will assert. Instead let's have a rolling window of programs. v2: Fix overflowing issues (Eric Engestrom) Signed-off-by: Lionel Landwerlin Reviewed-by: Eric Engestrom --- src/intel/tools/aubinator_error_decode.c | 24 +

[Mesa-dev] [PATCH 16/33] intel: decoder: remove unused platform field

2017-10-30 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 2562aa56175..050926f5642 100644 --- a/src/intel/common/gen_decoder.c +++ b/src/intel/common/gen_decoder.c

[Mesa-dev] [PATCH 17/33] intel: common: make intel utils available from C++

2017-10-30 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.h | 9 + src/intel/common/gen_device_info.h | 8 src/intel/tools/gen_disasm.h | 8 3 files changed, 25 insertions(+) diff --git a/src/intel/common/gen_decoder.h b/src/intel/common/gen_decoder.h

[Mesa-dev] [PATCH 12/33] intel: decoder: simplify creation of struct when 0-allocated

2017-10-30 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 4 1 file changed, 4 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 0bf705fa9e1..6a6a1f0aca4 100644 --- a/src/intel/common/gen_decoder.c +++ b/src/intel/common/gen_decoder.

[Mesa-dev] [PATCH 21/33] intel: decoder: extract field value computation

2017-10-30 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 59 ++ 1 file changed, 37 insertions(+), 22 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index a63c09cd37e..b0bd161fef3 100644 --- a/src/inte

[Mesa-dev] [PATCH 20/33] intel: decoder: rename field() to field_value()

2017-10-30 Thread Lionel Landwerlin
We would like to avoid collisions with variables named field. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decod

[Mesa-dev] [PATCH 14/33] intel: decoder: extract instruction/structs length

2017-10-30 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 7 +++ src/intel/common/gen_decoder.h | 1 + 2 files changed, 8 insertions(+) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index cd18580aea8..2562aa56175 100644 --- a/src/intel/common/gen_de

[Mesa-dev] [PATCH 29/33] intel: decoder: change group_get_length() to take first dword

2017-10-30 Thread Lionel Landwerlin
This is a first step in not accessing the dwords through pointers. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c| 27 +-- src/intel/common/gen_decoder.h| 2 +- src/intel/tools/aubinator.c | 4 ++--

[Mesa-dev] [PATCH 25/33] intel: compiler: abstract printing

2017-10-30 Thread Lionel Landwerlin
This is required to have output redirected to something else than a file descriptor (stdout). Signed-off-by: Lionel Landwerlin --- src/intel/compiler/brw_compile_clip.c | 5 +- src/intel/compiler/brw_compile_sf.c | 5 +- src/intel/compiler/brw_disasm.c | 645 +

[Mesa-dev] [PATCH 31/33] intel: decoder: decouple decoding from memory pointers

2017-10-30 Thread Lionel Landwerlin
We want to introduce a reader interface for accessing memory, so that later on we can use different ways of storing the content of the GTT address space that don't involve a pointer to a linear buffer. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c| 75 ++

[Mesa-dev] [PATCH 07/33] intel: decoder: split out getting the next field and decoding it

2017-10-30 Thread Lionel Landwerlin
Due to the new way we handle fields, we need *not* to forget the first field when decoding instructions. The issue was that the advance function was called first and skipped the first field. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 31 +--

[Mesa-dev] [PATCH 24/33] intel: decoder: enable decoding a single field

2017-10-30 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 37 + src/intel/common/gen_decoder.h | 14 ++ 2 files changed, 51 insertions(+) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 1d57d350855..bd

[Mesa-dev] [PATCH 19/33] intel: decoder: rename internal function to free name

2017-10-30 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 94e7e15399f..91076e901fe 100644 --- a/src/intel/common/gen_decoder.c +++ b/src/intel/

[Mesa-dev] [PATCH 22/33] intel: decoder: expose missing find_enum()

2017-10-30 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/common/gen_decoder.h b/src/intel/common/gen_decoder.h index 658dd7f7b09..81b5beb5baf 100644 --- a/src/intel/common/gen_decoder.h +++ b/src/intel/common/gen_decoder.h

Re: [Mesa-dev] Mesa 17.2.4 release candidate

2017-10-30 Thread Ilia Mirkin
On Mon, Oct 30, 2017 at 12:43 PM, Andres Gomez wrote: > On Mon, 2017-10-30 at 11:39 -0400, Ilia Mirkin wrote: >> On Mon, Oct 30, 2017 at 11:29 AM, Emil Velikov >> wrote: >> > On 28 October 2017 at 21:35, Andres Gomez wrote: >> > > On Fri, 2017-10-27 at 14:14 -0400, Ilia Mirkin wrote: >> > > > O

[Mesa-dev] [PATCH 23/33] intel: decoder: group enum related declarations

2017-10-30 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 8 src/intel/common/gen_decoder.h | 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index b0bd161fef3..1d57d350855 100644 --- a/src/

[Mesa-dev] [PATCH 30/33] intel: decoder: change find_instruction() to take first dword

2017-10-30 Thread Lionel Landwerlin
Another step into decoupling memory access from pointers. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c| 4 ++-- src/intel/common/gen_decoder.h| 2 +- src/intel/tools/aubinator.c | 2 +- src/intel/tools/aubinator_error_decod

[Mesa-dev] [PATCH 28/33] intel: genxml: rename output urb offset field

2017-10-30 Thread Lionel Landwerlin
"Output Read Offset" is a bit non-sensical, let's just make this match "Output Length". Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml| 6 +++--- src/intel/genxml/gen8.xml | 6 +++--- src/intel/genxml/gen9.xml | 6 +++--

[Mesa-dev] [PATCH 18/33] intel: decoder: simplify field_is_header()

2017-10-30 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 7 --- src/intel/common/gen_decoder.h | 3 ++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 050926f5642..94e7e15399f 100644 --- a/src/i

[Mesa-dev] [PATCH 27/33] intel: genxml: be consistent about register offset naming

2017-10-30 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml | 8 src/intel/genxml/gen4.xml | 2 +- src/intel/genxml/gen45.xml | 2 +- src/intel/genxml/gen5.xml | 2 +- src/intel/genxml/gen6.xml | 2 +- src/intel/genxml/gen7.xml

[Mesa-dev] [PATCH 32/33] intel: decoder: add function to query shader length

2017-10-30 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/disasm.c | 34 ++ src/intel/tools/gen_disasm.h | 2 ++ 2 files changed, 36 insertions(+) diff --git a/src/intel/tools/disasm.c b/src/intel/tools/disasm.c index e2f5c11f6f5..c038949d9ec 100644 --- a/src/inte

[Mesa-dev] [Bug 103496] svga_screen.c:26:46: error: git_sha1.h: No such file or directory

2017-10-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103496 --- Comment #1 from Brian Paul --- Hi Vinson, can you re-test with ToT? The scons build is working for me, testing at 134a40d2a67. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.__

Re: [Mesa-dev] create src/wsi

2017-10-30 Thread Dylan Baker
So I think the consensus is this is okay? Emil, is the autotools right here? Quoting Dylan Baker (2017-10-20 18:00:13) > This very short series creates a new src/wsi folder, and moves wayland-drm > into > it. Basically wsi stuff is scattered about, and is needed by multiple > components > withi

Re: [Mesa-dev] [PATCH v3 19/43] i965/fs: Support push constants of 16-bit types

2017-10-30 Thread Pohjolainen, Topi
On Mon, Oct 30, 2017 at 05:10:53PM +0100, Chema Casanova wrote: > El 30/10/17 a las 07:44, Pohjolainen, Topi escribió: > > On Sun, Oct 29, 2017 at 11:17:11PM +0100, Chema Casanova wrote: > >> On 29/10/17 19:55, Pohjolainen, Topi wrote: > >>> On Thu, Oct 12, 2017 at 08:38:08PM +0200, Jose Maria Casa

  1   2   >