On Mon, Oct 30, 2017 at 11:29 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 28 October 2017 at 21:35, Andres Gomez <ago...@igalia.com> wrote: >> On Fri, 2017-10-27 at 14:14 -0400, Ilia Mirkin wrote: >>> On Fri, Oct 27, 2017 at 1:43 PM, Andres Gomez <ago...@igalia.com> wrote: >>> > Rejected (6) >>> > ============ >>> > >>> > Ilia Mirkin (1): >>> > glsl: fix derived cs variables >>> > >>> > Reason: Commit is too big for stable at this point. >>> >>> The issue it fixes in regular compute shaders is slightly difficult to >>> hit (but there are piglits that do now), however the issue it hits >>> with ARB_compute_variable_group_size is fairly trivial to encounter. >>> >>> It seems silly to put out releases with known bugs when a fix is >>> easily available and apply-able, with negligible risk of messing >>> things up. >>> >>> Note that this all only affects nouveau and radeonsi, as those are the >>> only drivers that make use of the lowering. >> >> Ilia, I understood by your answer [1] when I asked about your opinion >> regarding 17.2.4 inclusion that it was OK to omit in this series but >> that it should definitely be included in 17.3. >> >> Maybe I didn't make it clear that I was asking for the 17.2 queue and I >> misunderstood your answer (?). >> >> Let's leave it as it is for this release and will see if we can include >> it for the next one. >> > I'm inclined to agree with Andres - let's leave the patch out of 17.2.x. > > 17.3.x on the other hand is still fairly fresh, so I've pulled the > patch for 17.3.0-rc2.
In that case you should definitely remove GL_ARB_compute_variable_group_size support from that release series. [As an aside, I have to say this is quite infuriating. I really don't get what problem you're solving with the stable releases if you don't accept direct bug fixes.] -ilia _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
