Re: [Mesa-dev] [PATCH v2 01/18] anv: Add the pci_id into the shader cache UUID

On 03/14/2017 04:26 AM, Jason Ekstrand wrote: This prevents a user from using a cache created on one hardware generation on a different one. Of course, with Intel hardware, this requires moving their drive from one machine to another but it's still possible and we should prevent it. Reviewed-

Re: [Mesa-dev] [PATCH 1/3] genxml/pack: Allow hex values in the XML

All 3 patches (assuming Dylan's fine with patch 1) are: Reviewed by: Iago Toral Quiroga On Wed, 2017-04-19 at 17:17 -0700, Jason Ekstrand wrote: > --- >  src/intel/genxml/gen_pack_header.py | 3 ++- >  1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/intel/genxml/gen_pack_hea

[Mesa-dev] [PATCH] ac: fix build after LLVM 5.0 SVN r300718

From: Christoph Haag Signed-off-by: Christoph Haag --- src/amd/common/ac_llvm_helper.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/amd/common/ac_llvm_helper.cpp b/src/amd/common/ac_llvm_helper.cpp index d9ea4b162e..69d65ddffe 100644 --- a/src/amd/common/ac_llvm

Re: [Mesa-dev] [PATCH v5 0/3] asynchronous pbo transfer with glthread

On Thu, 20 Apr 2017 12:29:11 +0900 Michel Dänzer wrote: > On 20/04/17 01:54 AM, Gregory Hainaut wrote: > > Hello, > > > > Please find the latest version that include a small fix for hash deletion. I > > think the series is good now. Please review/ack it. > > I'm afraid I have to NACK it. As dis

[Mesa-dev] [PATCH v2] ac: fix build after LLVM 5.0 SVN r300718

v2: previously getWithDereferenceableBytes() exists, but addAttr() doesn't take that type Signed-off-by: Christoph Haag --- src/amd/common/ac_llvm_helper.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/amd/common/ac_llvm_helper.cpp b/src/amd/common/ac_llvm_helper.cpp index d9ea

Re: [Mesa-dev] [PATCH v2] ac: fix build after LLVM 5.0 SVN r300718

On 20.04.2017 10:34, Christoph Haag wrote: v2: previously getWithDereferenceableBytes() exists, but addAttr() doesn't take that type Signed-off-by: Christoph Haag Reviewed-by: Nicolai Hähnle --- src/amd/common/ac_llvm_helper.cpp | 4 1 file changed, 4 insertions(+) diff --git a/sr

Re: [Mesa-dev] [PATCH v2] ac: fix build after LLVM 5.0 SVN r300718

Thanks for this Tested-and-reviewed-by: Mike Lothian On Thu, 20 Apr 2017 at 09:48 Nicolai Hähnle wrote: > On 20.04.2017 10:34, Christoph Haag wrote: > > v2: previously getWithDereferenceableBytes() exists, but addAttr() > doesn't take that type > > > > Signed-off-by: Christoph Haag > > Review

Re: [Mesa-dev] [RFC 1/2] Revert "mapi: rewrite u_current_init() function without u_thread_self()"

On 20 April 2017 at 00:36, Timothy Arceri wrote: > On 19/04/17 20:32, Emil Velikov wrote: >> >> On 19 April 2017 at 08:45, Timothy Arceri wrote: >>> >>> This reverts commit 458c7490c29ef2960a33a089f65490e044da5d27. >>> >>> The commit did not revert cleanly so this was fixed up by hand. >>> >>> u_

[Mesa-dev] [PATCH 1/2] i965/vec4: set swizzle when loading an uniform

It was setting XYWZ swizzle to all uniforms, no matter if they were a vector or not. Signed-off-by: Samuel Iglesias Gonsálvez Cc: curroje...@riseup.net --- src/intel/compiler/brw_vec4_nir.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/compiler/brw_vec4_nir.cpp b/src/intel/com

[Mesa-dev] [PATCH 2/2] i965/vec4: load dvec3/4 uniforms first in the push constant buffer

Reorder the uniforms to load first the dvec4-aligned variables in the push constant buffer and then push the vec4-aligned ones. This fixes a bug were the dvec3/4 might be loaded one part on a GRF and the rest in next GRF, so the region parameters to read that could break the HW rules. Signed-off-

[Mesa-dev] [Bug 100708] Trine 2 doesn't start on radeonsi on mesa 17

https://bugs.freedesktop.org/show_bug.cgi?id=100708 --- Comment #4 from Marek Olšák --- That commit is unlikely to cause any issues with X11. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.

Re: [Mesa-dev] [PATCH v5 0/3] asynchronous pbo transfer with glthread

On Thu, Apr 20, 2017 at 10:28 AM, gregory hainaut wrote: > On Thu, 20 Apr 2017 12:29:11 +0900 > Michel Dänzer wrote: > >> On 20/04/17 01:54 AM, Gregory Hainaut wrote: >> > Hello, >> > >> > Please find the latest version that include a small fix for hash deletion. >> > I >> > think the series is

[Mesa-dev] [Bug 100708] Trine 2 doesn't start on radeonsi on mesa 17

https://bugs.freedesktop.org/show_bug.cgi?id=100708 --- Comment #5 from Nikita Krupenko --- (In reply to Michel Dänzer from comment #3) > Nikita, can you try if it still happens with Mesa Git master? It doesn't compile: Requested 'libdrm >= 2.4.79' but version of libdrm is 2.4.75 Requested 'lib

Re: [Mesa-dev] [PATCH 3/3] egl/android: Dequeue buffers inside EGL calls (v2)

On 04/19/2017 10:00 AM, Tomasz Figa wrote: Android buffer queues can be abandoned, which results in failing to dequeue next buffer. Currently this would fail somewhere deep within the DRI stack calling loader's getBuffers*(), without any error reporting to the client app. However Android framew

[Mesa-dev] [PATCH] docs/features: mark KHR_no_error as started

The OpenGL extension KHR_no_error is exposed since commit d42d150ad26e29d9e894ba9f9e28f8134e2e5393 by Timothy Arceri. Therefore it should be marked as "started" in the features.txt Signed-off-by: Kai Wasserbäch --- Hey, this is a rather trivial "patch" (doesn't really deserve that designation),

[Mesa-dev] [Bug 100708] Trine 2 doesn't start on radeonsi on mesa 17

https://bugs.freedesktop.org/show_bug.cgi?id=100708 --- Comment #6 from Vedran Miletić --- (In reply to Nikita Krupenko from comment #5) > Requested 'libdrm >= 2.4.79' but version of libdrm is 2.4.75 > Requested 'libdrm_amdgpu >= 2.4.79' but version of libdrm_amdgpu is 2.4.75 Can you ask Mageia

Re: [Mesa-dev] [PATCH 0/3] Fix window surface handling in Android EGL code

Went through these changes and everything looks good to me, only one typo (that causes compilation to fail) spotted on the 3rd patch. With these changes default wallpaper works properly \o/ For the series: Reviewed-by: Tapani Pälli On 04/19/2017 10:00 AM, Tomasz Figa wrote: This series aims

[Mesa-dev] [PATCH] docs/envvars: order INTEL_DEBUG envvars by name

It helps to find the envvar you are looking for. Signed-off-by: Samuel Iglesias Gonsálvez --- docs/envvars.html | 58 +++ 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/docs/envvars.html b/docs/envvars.html index a064f569c8b..0

Re: [Mesa-dev] [PATCH] Adding support for EXT_sRGB for Opengl ES

On 04/07/2017 07:20 AM, Harish Krupo wrote: This addes support for the GL_EXT_sRGB extension for OpengGL ES 1.0 and above. With this patch this test passes in dEQP: dEQP-GLES2.capability.extensions.uncompressed_texture_formats.GL_EXT_sRGB When searching for possible other cases these changes w

Re: [Mesa-dev] [PATCH] docs/envvars: order INTEL_DEBUG envvars by name

s/order/sort :) Reviewed-by: Iago Toral Quiroga On Thu, 2017-04-20 at 14:02 +0200, Samuel Iglesias Gonsálvez wrote: > It helps to find the envvar you are looking for. > > Signed-off-by: Samuel Iglesias Gonsálvez > --- >  docs/envvars.html | 58 +++ > ---

[Mesa-dev] [PATCH] RFC: mesa: remove MESA_VERBOSE env variable

From: Emil Velikov The env variable was useful in the early days of mesa development, when tools such at Apitrace were not available. Nowadays, out of the 12 options only a third are used. With nearly all instances printing the API state. And even then not all entry points are annotated, thus on

[Mesa-dev] [PATCH 1/2] c11/threads: implement thrd_current on Windows

From: Emil Velikov Earlier commit removed the implementation due to a subtle bug, in the existing code. Namely: One was comparing directly the thread handle/IDs rather than using thrd_equal(). As the pseudo-handles never matched things went south. That bug was resolved with commit 458c7490c29 "

[Mesa-dev] [PATCH 2/2] mapi: use the C11 thrd_current/thrd_equal

From: Emil Velikov As of earlier commit the implementations do the correct thing, so there's no need to have the PTHREAD/WIN32 specifics in the current code. Cc: Brian Paul Cc: José Fonseca Signed-off-by: Emil Velikov --- There's an open question about how lightweight GetCurrentThread + GetTh

Re: [Mesa-dev] [PATCH] docs/envvars: order INTEL_DEBUG envvars by name

On Thu, 2017-04-20 at 16:11 +0200, Iago Toral wrote: > s/order/sort :) > Right! I unconsciously got it wrong with the similar word in Spanish ('ordenar'), which also has the meaning of 'to sort'. > Reviewed-by: Iago Toral Quiroga > Thanks! Sam > > On Thu, 2017-04-20 at 14:02 +0200, Samuel

Re: [Mesa-dev] [RFC PATCH 03/26] glsl: introduce new base types for bindless samplers/images

On 04/20/2017 12:47 AM, Samuel Pitoiset wrote: On 04/19/2017 11:14 AM, Nicolai Hähnle wrote: On 19.04.2017 09:51, Samuel Pitoiset wrote: On 04/18/2017 11:26 PM, Nicolai Hähnle wrote: On 18.04.2017 21:49, Dave Airlie wrote: On 19 April 2017 at 05:30, Samuel Pitoiset wrote: On 04/18/2

[Mesa-dev] [PATCH] configure.ac: Refuse to build Vulkan without DRI3

From: Ville Syrjälä Trying to build the Vulkan WSI code results in a failure without DRI3. Make configure check that DRI3 is available before trying to build the Vulkan drivers. Signed-off-by: Ville Syrjälä --- configure.ac | 4 1 file changed, 4 insertions(+) diff --git a/configure.ac b

[Mesa-dev] [PATCH] mesa/glthread: correctly comparae thread handles

From: Emil Velikov As mentioned in the manual - comparing pthread_t handles via the C comparison operator is incorrect and pthread_equal() should be used instead. Cc: Timothy Arceri Cc: Eric Anholt Fixes: d8d81fbc316 ("mesa: Add infrastructure for a worker thread to process GL commands.") Sig

Re: [Mesa-dev] [PATCH 1/3] genxml/pack: Allow hex values in the XML

Quoting Jason Ekstrand (2017-04-19 17:17:25) > --- > src/intel/genxml/gen_pack_header.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/intel/genxml/gen_pack_header.py > b/src/intel/genxml/gen_pack_header.py > index 2a70945..5b55143 100644 > --- a/src/intel/genxml

Re: [Mesa-dev] [PATCH 1/7] gallium: fold u_trim_pipe_prim call from st/mesa to drivers

On Fri, Apr 14, 2017 at 6:47 PM, Ilia Mirkin wrote: > On Fri, Apr 14, 2017 at 12:42 PM, Marek Olšák wrote: >> On Fri, Apr 14, 2017 at 5:45 PM, Ilia Mirkin wrote: >>> On Fri, Apr 14, 2017 at 11:07 AM, Marek Olšák wrote: diff --git a/src/gallium/drivers/nouveau/nv30/nv30_vbo.c b/src/ga

Re: [Mesa-dev] [PATCH 1/7] gallium: fold u_trim_pipe_prim call from st/mesa to drivers

On Thu, Apr 20, 2017 at 12:00 PM, Marek Olšák wrote: > On Fri, Apr 14, 2017 at 6:47 PM, Ilia Mirkin wrote: >> On Fri, Apr 14, 2017 at 12:42 PM, Marek Olšák wrote: >>> On Fri, Apr 14, 2017 at 5:45 PM, Ilia Mirkin wrote: On Fri, Apr 14, 2017 at 11:07 AM, Marek Olšák wrote: > diff --git

Re: [Mesa-dev] question about container_of

On 18 April 2017 at 13:55, Pekka Paalanen wrote: > On Mon, 27 Feb 2017 13:26:11 + > Emil Velikov wrote: > >> Hi Julien, >> >> On 27 February 2017 at 12:08, Julien Isorce wrote: >> > Hi, >> > >> > Since 2012 commit ccff74971203b533bf16b46b49a9e61753f75e6c it is said: >> > "sample must be init

Re: [Mesa-dev] [PATCH 3/3] egl/android: Dequeue buffers inside EGL calls (v2)

2017-04-20 4:18 GMT+02:00 Tomasz Figa : > On Wed, Apr 19, 2017 at 11:51 PM, Emil Velikov > wrote: > > Hi Tomasz, > > > > On 19 April 2017 at 08:00, Tomasz Figa wrote: > >> Android buffer queues can be abandoned, which results in failing to > >> dequeue next buffer. Currently this would fail some

Re: [Mesa-dev] [PATCH v5 0/3] asynchronous pbo transfer with glthread

On Thu, 20 Apr 2017 11:57:08 +0200 Marek Olšák wrote: > On Thu, Apr 20, 2017 at 10:28 AM, gregory hainaut > wrote: > > On Thu, 20 Apr 2017 12:29:11 +0900 > > Michel Dänzer wrote: > > > >> On 20/04/17 01:54 AM, Gregory Hainaut wrote: > >> > Hello, > >> > > >> > Please find the latest version tha

Re: [Mesa-dev] [PATCH 02/12] i965/cnl: Add gen10.xml

Hi Anuj, On 15 April 2017 at 01:35, Anuj Phogat wrote: > From: Jason Ekstrand > > Signed-off-by: Anuj Phogat > --- > src/intel/Makefile.sources |3 +- > src/intel/genxml/gen10.xml | 3557 > > 2 files changed, 3559 insertions(+), 1 deletion(-) >

Re: [Mesa-dev] [PATCH 22/35] i965: Port gen6+ 3DSTATE_VS to genxml.

Rafael Antognolli writes: > Emit 3DSTATE_VS on Gen6+ using brw_batch_emit helper, that uses pack > structs from genxml. > > Signed-off-by: Rafael Antognolli > --- > src/mesa/drivers/dri/i965/Makefile.sources| 2 +- > src/mesa/drivers/dri/i965/brw_state.h | 3 +- > src/mesa/drive

[Mesa-dev] [PATCH 0/2] glsl: some sort of preliminary work for bindless

Hi, Found by inspection while working on the GLSL bindless alternative (ie. don't introduce new base types). A full piglit run doesn't report any regressions using RadeonSI. Please review, Thanks! Samuel Pitoiset (2): glsl: make component_slots() returns 1 for sampler types glsl: get rid of

[Mesa-dev] [PATCH 1/2] glsl: make component_slots() returns 1 for sampler types

It looks inconsistent to return 1 for image types and 0 for sampler types. Especially because component_slots() is mostly used by values_for_type() which always returns 1 for samplers. For bindless, this value will be bumped to 2 because the ARB_bindless_texture states that bindless samplers/image

[Mesa-dev] [PATCH 2/2] glsl: get rid of values_for_type()

This function is actually a wrapper for component_slots() and it always returns 1 (or N) for samplers. Since component_slots() now return 1 for samplers, it can go. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/link_uniforms.cpp | 19 ++- src/compiler/glsl/linker.h

Re: [Mesa-dev] question about container_of

Emil Velikov writes: > On 18 April 2017 at 13:55, Pekka Paalanen wrote: >> On Mon, 27 Feb 2017 13:26:11 + >> Emil Velikov wrote: >> >>> Hi Julien, >>> >>> On 27 February 2017 at 12:08, Julien Isorce wrote: >>> > Hi, >>> > >>> > Since 2012 commit ccff74971203b533bf16b46b49a9e61753f75e6c it

Re: [Mesa-dev] [PATCH 30/35] i965: Port gen6+ emit vertices code to genxml.

On Wednesday, April 19, 2017 4:56:23 PM PDT Rafael Antognolli wrote: [snip] > +#ifndef NDEBUG > +static bool > +is_passthru_format(uint32_t format) Wrapping this in ifndef NDEBUG breaks release builds - for example, genX(uploads_needed) uses it outside of an assertion. If you want to shut up warn

Re: [Mesa-dev] [PATCH] mesa/glthread: correctly comparae thread handles

Looks good to me :) Reviewed-by: Plamena Manolova On Thu, Apr 20, 2017 at 8:24 AM, Emil Velikov wrote: > From: Emil Velikov > > As mentioned in the manual - comparing pthread_t handles via the C > comparison operator is incorrect and pthread_equal() should be used > instead. > > Cc: Timothy A

[Mesa-dev] [Bug 100693] 'identifier "L__FUNCTION__" is undefined' error for Debug builds using ICC on Windows

https://bugs.freedesktop.org/show_bug.cgi?id=100693 --- Comment #8 from sav...@ukr.net --- ICC Developers figured out, that source of this issue is code: /* XXX: Use standard `__func__` instead */ #ifndef __FUNCTION__ # define __FUNCTION__ __func__ #endif in file 'src/gallium/include/pipe/p_comp

Re: [Mesa-dev] [PATCH 02/12] i965/cnl: Add gen10.xml

On Thu, Apr 20, 2017 at 9:55 AM, Emil Velikov wrote: > Hi Anuj, > > On 15 April 2017 at 01:35, Anuj Phogat wrote: >> From: Jason Ekstrand >> >> Signed-off-by: Anuj Phogat >> --- >> src/intel/Makefile.sources |3 +- >> src/intel/genxml/gen10.xml | 3557 >> ++

Re: [Mesa-dev] [PATCH] mesa/glthread: correctly comparae thread handles

In the subject line "compare" Reviewed-by: Brian Paul On 04/20/2017 09:24 AM, Emil Velikov wrote: From: Emil Velikov As mentioned in the manual - comparing pthread_t handles via the C comparison operator is incorrect and pthread_equal() should be used instead. Cc: Timothy Arceri Cc: Eric

Re: [Mesa-dev] [PATCH 1/2] c11/threads: implement thrd_current on Windows

Series LGTM. Jose should probably take a look too, though. One typo below? Reviewed-by: Brian Paul On 04/20/2017 08:15 AM, Emil Velikov wrote: From: Emil Velikov Earlier commit removed the implementation due to a subtle bug, in the existing code. Namely: One was comparing directly the thr

Re: [Mesa-dev] [PATCH] RFC: mesa: remove MESA_VERBOSE env variable

On 04/20/2017 08:12 AM, Emil Velikov wrote: From: Emil Velikov The env variable was useful in the early days of mesa development, when tools such at Apitrace were not available. Nowadays, out of the 12 options only a third are used. With nearly all instances printing the API state. And even th

Re: [Mesa-dev] [PATCH 1/2] i965/vec4: set swizzle when loading an uniform

Samuel Iglesias Gonsálvez writes: > It was setting XYWZ swizzle to all uniforms, no matter if they were > a vector or not. > > Signed-off-by: Samuel Iglesias Gonsálvez > Cc: curroje...@riseup.net Don't you need to CC mesa-stable here and in the next patch? > --- > src/intel/compiler/brw_vec4_

Re: [Mesa-dev] [RFC PATCH 03/26] glsl: introduce new base types for bindless samplers/images

On 20.04.2017 16:54, Samuel Pitoiset wrote: [snip] Yes, contains_opaque() not is_opaque(). Well, how do you plan to handle the fact that bindless sampler types are 64-bit? It seemed quite logical to make glsl_type::is_64bit() returns true for them. So, for the purposes of src/compiler/glsl/, I

Re: [Mesa-dev] [RFC PATCH 03/26] glsl: introduce new base types for bindless samplers/images

On 04/20/2017 07:47 PM, Nicolai Hähnle wrote: On 20.04.2017 16:54, Samuel Pitoiset wrote: [snip] Yes, contains_opaque() not is_opaque(). Well, how do you plan to handle the fact that bindless sampler types are 64-bit? It seemed quite logical to make glsl_type::is_64bit() returns true for them

Re: [Mesa-dev] [PATCH v5 0/3] asynchronous pbo transfer with glthread

On Thu, Apr 20, 2017 at 6:53 PM, gregory hainaut wrote: > On Thu, 20 Apr 2017 11:57:08 +0200 > Marek Olšák wrote: > >> On Thu, Apr 20, 2017 at 10:28 AM, gregory hainaut >> wrote: >> > On Thu, 20 Apr 2017 12:29:11 +0900 >> > Michel Dänzer wrote: >> > >> >> On 20/04/17 01:54 AM, Gregory Hainaut w

Re: [Mesa-dev] [PATCH v4 0/3] asynchronous pbo transfer with glthread

On Thu, 20 Apr 2017 10:56:34 +0900 Michel Dänzer wrote: > On 20/04/17 01:43 AM, gregory hainaut wrote: > > Hello All, > > > > I ported PCSX2 to xcb (at least the non-glx part). Crash is gone :) > > So I can send the v5 with the hash delete fix. > > > > However, Mesa might receive crash bug repo

Re: [Mesa-dev] [PATCH] mesa/glthread: correctly comparae thread handles

Emil Velikov writes: > From: Emil Velikov > > As mentioned in the manual - comparing pthread_t handles via the C > comparison operator is incorrect and pthread_equal() should be used > instead. Seems fine Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [Mesa-dev] [RFC 2/2] glx: drop GLX_MESA_multithread_makecurrent support

Timothy Arceri writes: > On 20/04/17 10:53, Eric Anholt wrote: >> Timothy Arceri writes: >> >>> This extension is not supported by GLVND, also as far >>> as I can tell this extension requires us to do extra >>> locking for objects that are not normaly shared across >>> contexts, like vertex arr

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

On 04/19/2017 05:23 AM, Emil Velikov wrote: On 11 April 2017 at 13:10, Jean Hertel wrote: Any more thoughts on this? I would really appreciate feedback from more contributors. Indeed. Brian, Eric, others - how do you feel with the Sphinx edition of the site? If the current theme feels a bi

Re: [Mesa-dev] [PATCH] RFC: mesa: remove MESA_VERBOSE env variable

Emil Velikov writes: > From: Emil Velikov > > The env variable was useful in the early days of mesa development, when > tools such at Apitrace were not available. > > Nowadays, out of the 12 options only a third are used. With nearly all > instances printing the API state. And even then not all

Re: [Mesa-dev] [PATCH] RFC: mesa: remove MESA_VERBOSE env variable

I have used it sometimes, but since VERBOSE_API is missing in a bunch of places, that's quite useless. :) On 04/20/2017 04:12 PM, Emil Velikov wrote: From: Emil Velikov The env variable was useful in the early days of mesa development, when tools such at Apitrace were not available. Nowadays

Re: [Mesa-dev] [PATCH v5 0/3] asynchronous pbo transfer with glthread

On Thu, 20 Apr 2017 20:01:00 +0200 Marek Olšák wrote: > On Thu, Apr 20, 2017 at 6:53 PM, gregory hainaut > wrote: > > On Thu, 20 Apr 2017 11:57:08 +0200 > > Marek Olšák wrote: > > > >> On Thu, Apr 20, 2017 at 10:28 AM, gregory hainaut > >> wrote: > >> > On Thu, 20 Apr 2017 12:29:11 +0900 > >>

[Mesa-dev] [PATCH] radv/ac: use tex_lz if we can.

From: Dave Airlie Looking at some Talos shaders vs radeonsi, I noticed they use tex_lz in a few places, so we should be able to as well. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/sr

[Mesa-dev] [PATCH] radv: Prefetch compute shader too.

For consistency, doesn't really impact performance. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_cmd_buffer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 958ae6e361e..40e6e432ae7 100644 --- a/src/amd/vu

[Mesa-dev] [Bug 100741] Chromium - Memory leak

https://bugs.freedesktop.org/show_bug.cgi?id=100741 Bug ID: 100741 Summary: Chromium - Memory leak Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH] mesa: replace _mesa_index_buffer::type with index_size

On Friday, April 14, 2017 8:06:21 AM PDT Marek Olšák wrote: > From: Marek Olšák > > This avoids repeated translations of the enum. Reviewed-by: Kenneth Graunke signature.asc Description: This is a digitally signed message part. ___ mesa-dev mailing

[Mesa-dev] [PATCH] configure.ac: Fix typos.

Signed-off-by: Vinson Lee --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 957d15df8caa..e42fcfff7757 100644 --- a/configure.ac +++ b/configure.ac @@ -724,7 +724,7 @@ dnl Arch/platform-specific settings dnl AC_ARG_ENABL

Re: [Mesa-dev] [PATCH v5 0/3] asynchronous pbo transfer with glthread

On Thu, Apr 20, 2017 at 9:44 PM, gregory hainaut wrote: > On Thu, 20 Apr 2017 20:01:00 +0200 > Marek Olšák wrote: > >> On Thu, Apr 20, 2017 at 6:53 PM, gregory hainaut >> wrote: >> > On Thu, 20 Apr 2017 11:57:08 +0200 >> > Marek Olšák wrote: >> > >> >> On Thu, Apr 20, 2017 at 10:28 AM, gregory

Re: [Mesa-dev] [PATCH] RFC: mesa: remove MESA_VERBOSE env variable

Thanks for doing this. Looks like you forgot to updated the docs, with that fixed. Acked-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] glsl: get rid of values_for_type()

Looks ok to me. Series: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] glsl: get rid of values_for_type()

Reviewed-by: Edward O'Callaghan On 04/21/2017 11:20 AM, Timothy Arceri wrote: > Looks ok to me. Series: > > Reviewed-by: Timothy Arceri > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mes

Re: [Mesa-dev] [PATCH] RFC: mesa: remove MESA_VERBOSE env variable

On 2017-04-20 12:33:45, Samuel Pitoiset wrote: > I have used it sometimes, but since VERBOSE_API is missing in a bunch of > places, that's quite useless. :) > I also use MESA_VERBOSE=api every few months or so. I've found it pretty useful, but frustratingly I've nearly always ended up having to ad

Re: [Mesa-dev] [PATCH] RFC: mesa: remove MESA_VERBOSE env variable

On 21/04/17 11:37, Jordan Justen wrote: On 2017-04-20 12:33:45, Samuel Pitoiset wrote: I have used it sometimes, but since VERBOSE_API is missing in a bunch of places, that's quite useless. :) I also use MESA_VERBOSE=api every few months or so. I've found it pretty useful, but frustratingly I

Re: [Mesa-dev] [PATCH v5 0/3] asynchronous pbo transfer with glthread

On 20/04/17 05:28 PM, gregory hainaut wrote: > On Thu, 20 Apr 2017 12:29:11 +0900 > Michel Dänzer wrote: > >> On 20/04/17 01:54 AM, Gregory Hainaut wrote: >>> Hello, >>> >>> Please find the latest version that include a small fix for hash deletion. I >>> think the series is good now. Please revie

Re: [Mesa-dev] [PATCH v5 0/3] asynchronous pbo transfer with glthread

On 21/04/17 09:01 AM, Marek Olšák wrote: > On Thu, Apr 20, 2017 at 9:44 PM, gregory hainaut > wrote: >> On Thu, 20 Apr 2017 20:01:00 +0200 >> Marek Olšák wrote: >> >>> On Thu, Apr 20, 2017 at 6:53 PM, gregory hainaut >>> wrote: On Thu, 20 Apr 2017 11:57:08 +0200 Marek Olšák wrote: >>>

[Mesa-dev] [PATCH 1/3] radv/ac: move point coord after layer/viewport.

From: Dave Airlie These need to be ordered as per shader enum ordering, I'll rewrite this soon, but this is a bug fix. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_pipeline.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c

[Mesa-dev] [PATCH 2/3] radv/ac: overhaul vs output/ps input routing

From: Dave Airlie In order to cleanly eliminate exports rewrite the code first to mirror how radeonsi works for now. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 10 +++--- src/amd/common/ac_nir_to_llvm.h | 15 +++-- src/amd/vulkan/radv_pipeline.c | 67

[Mesa-dev] [PATCH 3/3] radv/ac: eliminate unused vertex shader outputs.

From: Dave Airlie This is ported from radeonsi, and I can see at least one Talos shader drops an export due to this, and saves some VGPR usage. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 178 1 file changed, 178 insertions(+) diff

Re: [Mesa-dev] [PATCH 3/3] egl/android: Dequeue buffers inside EGL calls (v2)

On 04/20/2017 07:51 PM, Mauro Rossi wrote: 2017-04-20 4:18 GMT+02:00 Tomasz Figa >: On Wed, Apr 19, 2017 at 11:51 PM, Emil Velikov mailto:emil.l.veli...@gmail.com>> wrote: > Hi Tomasz, > > On 19 April 2017 at 08:00, Tomasz Figa mailto:tf...@

Re: [Mesa-dev] [PATCH 1/2] i965/vec4: set swizzle when loading an uniform

On Thu, 2017-04-20 at 10:26 -0700, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > It was setting XYWZ swizzle to all uniforms, no matter if they were > > a vector or not. > > > > Signed-off-by: Samuel Iglesias Gonsálvez > > Cc: curroje...@riseup.net > > Don't you need to CC m

[Mesa-dev] [PATCH 1/4] mesa: remove fallback RefCount == 0 pattern

We should never get here if this is 0 unless there is a bug. Replace the check with an assert. --- src/mesa/main/arrayobj.c | 14 -- src/mesa/main/bufferobj.c | 14 -- src/mesa/main/pipelineobj.c | 14 -- src/mesa/main/samplerobj.c

[Mesa-dev] [PATCH 4/4] mesa: don't lock hashtables that are not shared across contexts

From Chapter 5 'Shared Objects and Multiple Contexts' of the OpenGL 4.5 spec: "Objects which contain references to other objects include framebuffer, program pipeline, query, transform feedback, and vertex array objects. Such objects are called container objects and are not shared"

[Mesa-dev] [PATCH 3/4] mesa: Remove deleteFlag pattern.

From: Matt Turner --- src/mesa/main/arrayobj.c| 4 +--- src/mesa/main/pipelineobj.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c index 9f4477e..24555d9 100644 --- a/src/mesa/main/arrayobj.c +++ b/src/mesa/main/ar

[Mesa-dev] [PATCH 2/4] mesa: Remove unnecessary locking from container objects.

From: Matt Turner From Chapter 5 'Shared Objects and Multiple Contexts' of the OpenGL 4.5 spec: "Objects which contain references to other objects include framebuffer, program pipeline, query, transform feedback, and vertex array objects. Such objects are called container objects a

Re: [Mesa-dev] [PATCH] configure.ac: Fix typos.

Reviewed-by: Alejandro Piñeiro On 20/04/17 23:50, Vinson Lee wrote: > Signed-off-by: Vinson Lee > --- > configure.ac | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 957d15df8caa..e42fcfff7757 100644 > --- a/configure.ac > +++ b/

Re: [Mesa-dev] [PATCH] st/mesa/i965: validate sampler type across the whole program

On 04/19/2017 05:15 AM, Timothy Arceri wrote: Hi Tapani, You seem to have been one of the last people to touch this code. Do you think you could take a look at this patch? OK sure. The validation loop looks fine to me but I find it strange that we need to initialize SamplersValidated on e

Re: [Mesa-dev] [PATCH] RFC: mesa: remove MESA_VERBOSE env variable

On 2017-04-20 18:49:57, Timothy Arceri wrote: > On 21/04/17 11:37, Jordan Justen wrote: > > On 2017-04-20 12:33:45, Samuel Pitoiset wrote: > >> I have used it sometimes, but since VERBOSE_API is missing in a bunch of > >> places, that's quite useless. :) > >> > > > > I also use MESA_VERBOSE=api ev

Re: [Mesa-dev] [PATCH 0/3] Fix window surface handling in Android EGL code

> On 04/19/2017 10:00 AM, Tomasz Figa wrote: > >> This series aims to improve standard conformance and application >> compatibility of Mesa EGL Android code, by changing the window surface >> code to properly handle cases when the buffer queue backing the native >> window is abandoned, which is rel

Re: [Mesa-dev] [PATCH 0/3] Fix window surface handling in Android EGL code

On 04/21/2017 09:24 AM, Mauro Rossi wrote: On 04/19/2017 10:00 AM, Tomasz Figa wrote: This series aims to improve standard conformance and application compatibility of Mesa EGL Android code, by changing the window surface code to properly handle cases whe

Re: [Mesa-dev] [PATCH 0/3] Fix window surface handling in Android EGL code

On Fri, Apr 21, 2017 at 3:32 PM, Tapani Pälli wrote: > > > On 04/21/2017 09:24 AM, Mauro Rossi wrote: >> >> >> >> >> On 04/19/2017 10:00 AM, Tomasz Figa wrote: >> >> This series aims to improve standard conformance and application >> compatibility of Mesa EGL Android code, by c

Re: [Mesa-dev] [PATCH 0/3] Fix window surface handling in Android EGL code

On 04/21/2017 09:48 AM, Tomasz Figa wrote: On Fri, Apr 21, 2017 at 3:32 PM, Tapani Pälli wrote: On 04/21/2017 09:24 AM, Mauro Rossi wrote: On 04/19/2017 10:00 AM, Tomasz Figa wrote: This series aims to improve standard conformance and application compatibility o