Re: [Mesa-dev] [PATCH] mesa glthread: allow asynchronous pixel transfer operation when a buffer is bound

2017-03-29 Thread Nicolai Hähnle
On 28.03.2017 22:37, gregory hainaut wrote: On Mon, 27 Mar 2017 16:10:32 +0200 Gregory Hainaut wrote: Hello, Sorry I was in vacation. I will update my patch with a hash map to trace buffer creation/destruction. Cheers, Gregory On 3/20/17, Nicolai Hähnle wrote: On 20.03.2017 14:33, Markus

Re: [Mesa-dev] [PATCH 0/2] nir: Add support for 8 and 16-bit types

2017-03-29 Thread Eduardo Lima Mitev
Both patches need rebase, but look fine otherwise. Series is: Reviewed-by: Eduardo Lima Mitev On 03/09/2017 11:05 PM, Jason Ekstrand wrote: > This tiny series adds support in NIR for 8 and 16-bit types. In > particular, it now supports int8_t, uint8_t, int16_t, uint16_t, and > float16_t. No 8

[Mesa-dev] [PATCH v2 2/2] st/mesa: EGLImageTarget* error handling

2017-03-29 Thread Philipp Zabel
Stop trying to specify texture or renderbuffer objects for unsupported EGL images. Generate the error codes specified in the OES_EGL_image extension. EGLImageTargetTexture2D and EGLImageTargetRenderbuffer would call the pipe driver's create_surface callback without ever checking that the given EGL

[Mesa-dev] [PATCH v2 1/2] st/mesa: move st_manager_get_egl_image_surface into st_cb_eglimage.c

2017-03-29 Thread Philipp Zabel
The only callers are here, and we will add generation of GL errors in the following patch. Rename the function to st_egl_image_get_surface, pass the gl_context instead of st_context, and move the cast from GLeglImageOES to void* into st_egl_image_get_surface. Signed-off-by: Philipp Zabel Reviewe

[Mesa-dev] [Bug 100441] glsl/tests/optimization-test.sh regression

2017-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100441 --- Comment #1 from Michel Dänzer --- Created attachment 130526 --> https://bugs.freedesktop.org/attachment.cgi?id=130526&action=edit Test suite log This happens for me since commit 86a937d2644a ("glsl/tests/optimization-test: correctly manag

[Mesa-dev] [Bug 100441] glsl/tests/optimization-test.sh regression

2017-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100441 --- Comment #2 from Michel Dänzer --- Note that I was seeing different intermittent failures with earlier commits, which make clean resolved. -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-29 Thread Thomas Hellstrom
On 03/28/2017 10:36 PM, Eric Anholt wrote: > Thomas Hellstrom writes: > >> Drivers may queue dma operations on the context at unmap time so we need >> to flush to make sure the data gets to the bo. Ideally the application >> would take care of this, but since there appears to be no exported gbm >>

[Mesa-dev] [Bug 100441] glsl/tests/optimization-test.sh regression

2017-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100441 Michel Dänzer changed: What|Removed |Added CC||emil.l.veli...@gmail.com --- Comment #3

Re: [Mesa-dev] [PATCH 4/5] radv: move calculating fragment shader i/os to pipeline.

2017-03-29 Thread Alex Smith
On 28 March 2017 at 20:11, Dave Airlie wrote: > On 28 March 2017 at 21:05, Alex Smith wrote: > > Hi Dave, > > > > This commit is causing some GPU hangs for us, on Polaris cards at least > (470 > > and 480). > > > > It also causes hangs in Dota 2 (on the initial logo screen at startup). > > > > S

[Mesa-dev] [Bug 100441] glsl/tests/optimization-test.sh regression

2017-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100441 --- Comment #4 from Timothy Arceri --- Po(In reply to Michel Dänzer from comment #1) > Created attachment 130526 [details] > Test suite log > > This happens for me since commit 86a937d2644a > ("glsl/tests/optimization-test: correctly manage src

[Mesa-dev] [Bug 100441] glsl/tests/optimization-test.sh regression

2017-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100441 Michel Dänzer changed: What|Removed |Added CC|emil.l.veli...@gmail.com| --- Comment #5 from Michel Dänzer ---

Re: [Mesa-dev] [PATCH v2 1/2] anv: Add support for 48-bit addresses

2017-03-29 Thread Chris Wilson
On Tue, Mar 28, 2017 at 05:41:12PM -0700, Jason Ekstrand wrote: > This commit adds support for using the full 48-bit address space on > Broadwell and newer hardware. Thanks to certain limitations, not all > objects can be placed above the 32-bit boundary. In particular, general > and state base a

[Mesa-dev] [Bug 100201] llvmpipe Windows scons build with MSVC toolchain and LLVM 4.0 fails

2017-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100201 --- Comment #8 from Anonymous Helper --- (In reply to Jose Fonseca from comment #7) > The links errors are possibly due to Mesa and LLVM not being built exactly > with the same compiler as Mesa, no? LLVM 4.0 was built with MSVC 2017 toolset. I g

[Mesa-dev] [PATCH] mesa: update lower_jumps tests after bug fix

2017-03-29 Thread Timothy Arceri
This change updates the tests to reflect the IR after the following bug fix. glsl: fix lower jumps for returns when loop is inside an if commit c1096b7f1d49f33c85b1042f82ccb063f63e7c20 --- .../glsl/tests/lower_jumps/create_test_cases.py | 17 +++-- 1 file changed, 15 insertion

[Mesa-dev] [Bug 100441] glsl/tests/optimization-test.sh regression

2017-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100441 --- Comment #6 from Timothy Arceri --- This updates the test to reflect the new IR: https://patchwork.freedesktop.org/patch/147012/ -- You are receiving this mail because: You are the assignee for the bug._

Re: [Mesa-dev] [PATCH] mesa: update lower_jumps tests after bug fix

2017-03-29 Thread Michel Dänzer
On 29/03/17 06:30 PM, Timothy Arceri wrote: > This change updates the tests to reflect the IR after > the following bug fix. > > glsl: fix lower jumps for returns when loop is inside an if > commit c1096b7f1d49f33c85b1042f82ccb063f63e7c20 This should be written as Fixes: c1096b7f1d49 ("glsl: fix

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-29 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Mar 28, 2017 at 9:39 PM, Thomas Hellstrom wrote: > Drivers may queue dma operations on the context at unmap time so we need > to flush to make sure the data gets to the bo. Ideally the application > would take care of this, but since there appears to be no

[Mesa-dev] [Bug 100441] glsl/tests/optimization-test.sh regression

2017-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100441 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 100201] llvmpipe Windows scons build with MSVC toolchain and LLVM 4.0 fails

2017-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100201 --- Comment #9 from Jose Fonseca --- (In reply to Anonymous Helper from comment #8) > (In reply to Jose Fonseca from comment #7) > > The links errors are possibly due to Mesa and LLVM not being built exactly > > with the same compiler as Mesa, n

Re: [Mesa-dev] [PATCH 2/2] mesa/glthread: fallback to sync if count validation fails

2017-03-29 Thread Nicolai Hähnle
On 29.03.2017 07:30, Timothy Arceri wrote: The old code would sync and then throw a cryptic error message. There is no need for a custome error, we can just fallback to the real function and have it do proper validation. Fixes piglit test: glsl-uniform-out-of-bounds Which was returning the wron

Re: [Mesa-dev] [PATCH] mesa/glthread: print out syncs when MARSHAL_MAX_CMD_SIZE is exceeded

2017-03-29 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 29.03.2017 04:20, Timothy Arceri wrote: --- src/mapi/glapi/gen/gl_marshal.py | 1 + src/mesa/main/marshal.h | 13 + 2 files changed, 14 insertions(+) diff --git a/src/mapi/glapi/gen/gl_marshal.py b/src/mapi/glapi/gen/gl_marshal.py index c89

Re: [Mesa-dev] [PATCH v2 05/25] gallium: add sparse buffer interface and capability

2017-03-29 Thread Nicolai Hähnle
On 28.03.2017 21:46, Marek Olšák wrote: On Tue, Mar 28, 2017 at 11:11 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle TODO fill out caps in all drivers v2: - explain the resource_commit interface in more detail --- src/gallium/docs/source/context.rst | 25 + src/gall

Re: [Mesa-dev] [PATCH v2 07/25] trace: add resource_commit pass-through

2017-03-29 Thread Nicolai Hähnle
On 28.03.2017 21:50, Marek Olšák wrote: Patches 6 & 7 return void, but patch 5 defines the return type as bool. With those fixed, patches 5-7 are: Reviewed-by: Marek Olšák Fixed locally, thanks! Marek On Tue, Mar 28, 2017 at 11:11 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle --- s

Re: [Mesa-dev] [PATCH] st: Add cubeMapFace parameter to st_finalize_texture.

2017-03-29 Thread Nicolai Hähnle
Hi Michal, thanks for the patch. That piglit test actually fails on radeonsi as well. On 28.03.2017 22:39, Michal Srb wrote: st_finalize_texture always accesses image at face 0, but it may not be set if we are working with cubemap that had other face set. This fixes crash in piglit same-att

Re: [Mesa-dev] [PATCH v2 1/6] radv/amdgpu: Add winsys implementation of virtual buffers.

2017-03-29 Thread Nicolai Hähnle
This could probably be simplified quite a bit by using VA_OP_CLEAR and VA_OP_REPLACE. That requires a newer kernel, though, so there's arguments to be had both ways. Cheers, Nicolai On 29.03.2017 02:03, Bas Nieuwenhuizen wrote: v2: - Added comments. - Fixed a double unmap bug. - Actua

Re: [Mesa-dev] [PATCH v2 2/2] st/mesa: EGLImageTarget* error handling

2017-03-29 Thread Nicolai Hähnle
On 29.03.2017 09:44, Philipp Zabel wrote: Stop trying to specify texture or renderbuffer objects for unsupported EGL images. Generate the error codes specified in the OES_EGL_image extension. EGLImageTargetTexture2D and EGLImageTargetRenderbuffer would call the pipe driver's create_surface callb

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-29 Thread Emil Velikov
Hi Thomas, On 28 March 2017 at 20:39, Thomas Hellstrom wrote: > Drivers may queue dma operations on the context at unmap time so we need > to flush to make sure the data gets to the bo. Ideally the application > would take care of this, but since there appears to be no exported gbm > flush functi

[Mesa-dev] [PATCH] i965: expose BRW_OPCODE_[F32TO16/F16TO32] opcode_descs on gen8+

2017-03-29 Thread Alejandro Piñeiro
Technically those hw operations are only available on gen7, as gen8+ support the conversion on the MOV. But, when using the builder to implement nir operations (example: nir_op_fquantize2f16), it is not needed to do the gen check. This check is done later, on the final emission at brw_F32TO16 (brw_

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-29 Thread Thomas Hellstrom
Hi, Emil, On 03/29/2017 01:30 PM, Emil Velikov wrote: > Hi Thomas, > > On 28 March 2017 at 20:39, Thomas Hellstrom wrote: >> Drivers may queue dma operations on the context at unmap time so we need >> to flush to make sure the data gets to the bo. Ideally the application >> would take care of thi

Re: [Mesa-dev] [PATCH] radv: Invalidate L2 for TRANSFER_WRITE barriers

2017-03-29 Thread Emil Velikov
On 28 March 2017 at 19:11, Bas Nieuwenhuizen wrote: > On Tue, Mar 28, 2017 at 6:31 PM, Alex Smith > wrote: >> On 28 March 2017 at 17:09, Emil Velikov wrote: >>> >>> On 22 March 2017 at 10:06, Bas Nieuwenhuizen >>> wrote: >>> > On Tue, Mar 21, 2017 at 1:02 PM, Alex Smith >>> > wrote: >>> >> CP

Re: [Mesa-dev] [PATCH v2 2/2] st/mesa: EGLImageTarget* error handling

2017-03-29 Thread Philipp Zabel
On Wed, 2017-03-29 at 13:01 +0200, Nicolai Hähnle wrote: > On 29.03.2017 09:44, Philipp Zabel wrote: > > Stop trying to specify texture or renderbuffer objects for unsupported > > EGL images. Generate the error codes specified in the OES_EGL_image > > extension. > > > > EGLImageTargetTexture2D and

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-29 Thread Emil Velikov
On 29 March 2017 at 13:02, Thomas Hellstrom wrote: > Hi, Emil, > > On 03/29/2017 01:30 PM, Emil Velikov wrote: >> Hi Thomas, >> >> On 28 March 2017 at 20:39, Thomas Hellstrom wrote: >>> Drivers may queue dma operations on the context at unmap time so we need >>> to flush to make sure the data get

Re: [Mesa-dev] [PATCH] i965: expose BRW_OPCODE_[F32TO16/F16TO32] opcode_descs on gen8+

2017-03-29 Thread Ilia Mirkin
I guess you want GEN_GE(GEN7), no? On Mar 29, 2017 7:48 AM, "Alejandro Piñeiro" wrote: > Technically those hw operations are only available on gen7, as gen8+ > support the conversion on the MOV. But, when using the builder to > implement nir operations (example: nir_op_fquantize2f16), it is not

[Mesa-dev] [PATCH v2] i965: expose BRW_OPCODE_[F32TO16/F16TO32] opcode_descs on gen8+

2017-03-29 Thread Alejandro Piñeiro
Technically those hw operations are only available on gen7, as gen8+ support the conversion on the MOV. But, when using the builder to implement nir operations (example: nir_op_fquantize2f16), it is not needed to do the gen check. This check is done later, on the final emission at brw_F32TO16 (brw_

Re: [Mesa-dev] [PATCH] i965: expose BRW_OPCODE_[F32TO16/F16TO32] opcode_descs on gen8+

2017-03-29 Thread Matt Turner
On Wed, Mar 29, 2017 at 4:47 AM, Alejandro Piñeiro wrote: > Technically those hw operations are only available on gen7, as gen8+ > support the conversion on the MOV. But, when using the builder to > implement nir operations (example: nir_op_fquantize2f16), it is not > needed to do the gen check. T

Re: [Mesa-dev] [PATCH] radv: move to using nir clip/cull merge pass.

2017-03-29 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 03/29/2017 04:14 PM, Dave Airlie wrote: > From: Dave Airlie > > Doing this before tessellation makes doing some bits of > tessellation a bit cleaner. It also cleans up a bit of the > llvm generator code. > > Signed-off-by: Dave Airlie > --- > src/amd/common

Re: [Mesa-dev] [PATCH v2 05/25] gallium: add sparse buffer interface and capability

2017-03-29 Thread Marek Olšák
On Wed, Mar 29, 2017 at 12:26 PM, Nicolai Hähnle wrote: > On 28.03.2017 21:46, Marek Olšák wrote: >> >> On Tue, Mar 28, 2017 at 11:11 AM, Nicolai Hähnle >> wrote: >>> >>> From: Nicolai Hähnle >>> >>> TODO fill out caps in all drivers >>> >>> v2: >>> - explain the resource_commit interface in mor

Re: [Mesa-dev] [PATCH] i965: expose BRW_OPCODE_[F32TO16/F16TO32] opcode_descs on gen8+

2017-03-29 Thread Alejandro Piñeiro
On 29/03/17 16:15, Matt Turner wrote: > On Wed, Mar 29, 2017 at 4:47 AM, Alejandro Piñeiro > wrote: >> Technically those hw operations are only available on gen7, as gen8+ >> support the conversion on the MOV. But, when using the builder to >> implement nir operations (example: nir_op_fquantize2f

[Mesa-dev] [PATCH v3] i965: expose BRW_OPCODE_[F32TO16/F16TO32] name on gen8+

2017-03-29 Thread Alejandro Piñeiro
Technically those hw operations are only available on gen7, as gen8+ support the conversion on the MOV. But, when using the builder to implement nir operations (example: nir_op_fquantize2f16), it is not needed to do the gen check. This check is done later, on the final emission at brw_F32TO16 (brw_

Re: [Mesa-dev] [PATCH v3] i965: expose BRW_OPCODE_[F32TO16/F16TO32] name on gen8+

2017-03-29 Thread Matt Turner
Thanks. That looks good. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/2] nir: Add support for 8 and 16-bit types

2017-03-29 Thread Jason Ekstrand
On Wed, Mar 29, 2017 at 12:41 AM, Eduardo Lima Mitev wrote: > Both patches need rebase, but look fine otherwise. > The first has already landed (I think). The second definitely needs rebasing. Yesterday, I rebased it on top of the other two constant_expressions fixup patches I sent out: https:

Re: [Mesa-dev] [Request for Comments] - Port documentation to Markdown

2017-03-29 Thread Emil Velikov
Hi Jean, On 8 March 2017 at 16:12, Brian Paul wrote: >> >One thing that I would prefer so not see if heavy things like >> Bootstrap. >> >We definitely don't need it, I think writing our own few lines of CSS >> >(which can be inspired by anything you want) is better. We have more >>

Re: [Mesa-dev] [PATCH v2 1/2] anv: Add support for 48-bit addresses

2017-03-29 Thread Jason Ekstrand
On Wed, Mar 29, 2017 at 1:51 AM, Chris Wilson wrote: > On Tue, Mar 28, 2017 at 05:41:12PM -0700, Jason Ekstrand wrote: > > This commit adds support for using the full 48-bit address space on > > Broadwell and newer hardware. Thanks to certain limitations, not all > > objects can be placed above

[Mesa-dev] [PATCH] [RFC] mesa/glthread: Call unmarshal_batch directly in glthread_finish when batch queue is empty.

2017-03-29 Thread Bartosz Tomczyk
This avoids costly thread synchronisation. With this fix games that previously regressed with mesa_glthread=true like xonotic or grid autosport. Could someone test if games that benefit from glthread didn't regress? --- src/mesa/main/glthread.c | 17 + 1 file changed, 13 insertion

Re: [Mesa-dev] [PATCH] [RFC] mesa/glthread: Call unmarshal_batch directly in glthread_finish when batch queue is empty.

2017-03-29 Thread Bartosz Tomczyk
Please ignore above patch. On Wed, Mar 29, 2017 at 5:48 PM, Bartosz Tomczyk < bartosz.tomczy...@gmail.com> wrote: > This avoids costly thread synchronisation. With this fix games that > previously regressed with mesa_glthread=true like xonotic or grid autosport. > Could someone test if games that

Re: [Mesa-dev] [PATCH v2 1/2] anv: Add support for 48-bit addresses

2017-03-29 Thread Chris Wilson
On Wed, Mar 29, 2017 at 08:36:36AM -0700, Jason Ekstrand wrote: >On Wed, Mar 29, 2017 at 1:51 AM, Chris Wilson ><[1]ch...@chris-wilson.co.uk> wrote: > > On Tue, Mar 28, 2017 at 05:41:12PM -0700, Jason Ekstrand wrote: > > This commit adds support for using the full 48-bit address

Re: [Mesa-dev] [PATCH v2 1/2] anv: Add support for 48-bit addresses

2017-03-29 Thread Kristian H. Kristensen
Jason Ekstrand writes: > This commit adds support for using the full 48-bit address space on > Broadwell and newer hardware. Thanks to certain limitations, not all > objects can be placed above the 32-bit boundary. In particular, general > and state base address need to live within 32 bits. (S

Re: [Mesa-dev] [PATCH v2 2/2] st/mesa: EGLImageTarget* error handling

2017-03-29 Thread Nicolai Hähnle
On 29.03.2017 14:28, Philipp Zabel wrote: On Wed, 2017-03-29 at 13:01 +0200, Nicolai Hähnle wrote: On 29.03.2017 09:44, Philipp Zabel wrote: Stop trying to specify texture or renderbuffer objects for unsupported EGL images. Generate the error codes specified in the OES_EGL_image extension. EGL

Re: [Mesa-dev] [PATCH] gbm/dri: Flush after unmap

2017-03-29 Thread Thomas Hellstrom
Hi, Emil, On 03/29/2017 02:34 PM, Emil Velikov wrote: > On 29 March 2017 at 13:02, Thomas Hellstrom wrote: >> Hi, Emil, >> >> On 03/29/2017 01:30 PM, Emil Velikov wrote: >>> Hi Thomas, >>> >>> On 28 March 2017 at 20:39, Thomas Hellstrom wrote: Drivers may queue dma operations on the context

[Mesa-dev] [PATCH] [RFC v2] mesa/glthread: Call unmarshal_batch directly in glthread_finish when batch queue is empty.

2017-03-29 Thread Bartosz Tomczyk
This avoids costly thread synchronisation. With this fix games that previously regressed with mesa_glthread=true like xonotic or grid autosport. Could someone test if games that benefit from glthread didn't regress? --- src/mesa/main/glthread.c | 49 +--

Re: [Mesa-dev] [PATCH] [RFC v2] mesa/glthread: Call unmarshal_batch directly in glthread_finish when batch queue is empty.

2017-03-29 Thread Nicolai Hähnle
On 29.03.2017 18:11, Bartosz Tomczyk wrote: This avoids costly thread synchronisation. With this fix games that previously regressed with mesa_glthread=true like xonotic or grid autosport. Could someone test if games that benefit from glthread didn't regress? Please make sure the commit messag

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2017-03-29 Thread Emil Velikov
On 29 March 2017 at 16:51, Marek Olšák wrote: > From: Marek Olšák > > Neved used. > --- > src/gallium/auxiliary/gallivm/lp_bld_limits.h | 4 - > src/gallium/auxiliary/gallivm/lp_bld_tgsi.h| 2 - > src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c| 46 --- > src/gallium/au

Re: [Mesa-dev] [PATCH] [RFC v2] mesa/glthread: Call unmarshal_batch directly in glthread_finish when batch queue is empty.

2017-03-29 Thread Matt Turner
On Wed, Mar 29, 2017 at 9:11 AM, Bartosz Tomczyk wrote: > This avoids costly thread synchronisation. With this fix games that > previously regressed with mesa_glthread=true like xonotic or grid autosport. > Could someone test if games that benefit from glthread didn't regress? > --- > src/mesa/m

Re: [Mesa-dev] [PATCH v2 05/25] gallium: add sparse buffer interface and capability

2017-03-29 Thread Nicolai Hähnle
On 29.03.2017 16:27, Marek Olšák wrote: On Wed, Mar 29, 2017 at 12:26 PM, Nicolai Hähnle wrote: On 28.03.2017 21:46, Marek Olšák wrote: On Tue, Mar 28, 2017 at 11:11 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle TODO fill out caps in all drivers v2: - explain the resource_commit interf

[Mesa-dev] [PATCH] [RFC v3] mesa/glthread: Call unmarshal_batch directly in glthread_finish

2017-03-29 Thread Bartosz Tomczyk
Call it directly when batch queue is empty. This avoids costly thread synchronisation. With this fix games that previously regressed with mesa_glthread=true like xonotic or grid autosport. --- src/mesa/main/glthread.c | 47 ++- 1 file changed, 34 inserti

Re: [Mesa-dev] [PATCH] [RFC v3] mesa/glthread: Call unmarshal_batch directly in glthread_finish

2017-03-29 Thread Bartosz Tomczyk
I would be very grateful if someone could help with testing performance impact of this change. On Wed, Mar 29, 2017 at 7:31 PM, Bartosz Tomczyk < bartosz.tomczy...@gmail.com> wrote: > Call it directly when batch queue is empty. This avoids costly thread > synchronisation. With this fix games tha

[Mesa-dev] [PATCH v2 2/2] anv: Query the kernel for reset status

2017-03-29 Thread Jason Ekstrand
When a client causes a GPU hang (or experiences issues due to a hang in another client) we want to let it know as soon as possible. In particular, if it submits work with a fence and calls vkWaitForFences or vkQueueQaitIdle and it returns VK_SUCCESS, then the client should be able to trust the res

Re: [Mesa-dev] [PATCH v2 1/2] anv: Add support for 48-bit addresses

2017-03-29 Thread Jason Ekstrand
On Wed, Mar 29, 2017 at 8:59 AM, Kristian H. Kristensen wrote: > Jason Ekstrand writes: > > > This commit adds support for using the full 48-bit address space on > > Broadwell and newer hardware. Thanks to certain limitations, not all > > objects can be placed above the 32-bit boundary. In par

[Mesa-dev] [PATCH 5/9] radeonsi: remove a workaround for inexact *8_SNORM blits

2017-03-29 Thread Marek Olšák
From: Marek Olšák All tests pass on Fiji now. This prevents DCC disablement due to incompatible DCC formats due to the fallback. --- src/gallium/drivers/radeonsi/si_blit.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium

[Mesa-dev] [PATCH 1/9] gallium/util: use const in u_index_modify helpers

2017-03-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_index_modify.c | 6 +++--- src/gallium/auxiliary/util/u_index_modify.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/util/u_index_modify.c b/src/gallium/auxiliary/util/u_index_modify.c index 7b

[Mesa-dev] [PATCH 2/9] radeonsi: don't make a copy of pipe_index_buffer in draw_vbo

2017-03-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_draw.c | 59 +--- 1 file changed, 27 insertions(+), 32 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index 1ff1547..6882ff4 100644 --- a/s

[Mesa-dev] [PATCH 0/9] RadeonSI cleanups

2017-03-29 Thread Marek Olšák
General cleanups and cleanups in preparation for threaded gallium. Please review. Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 4/9] gallium/radeon: add and use a new helper vi_dcc_enabled

2017-03-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 6 ++ src/gallium/drivers/radeon/r600_texture.c | 11 +-- src/gallium/drivers/radeonsi/si_blit.c| 6 ++ src/gallium/drivers/radeonsi/si_descriptors.c | 5 ++--- src/gallium/drivers/radeonsi/si_st

[Mesa-dev] [PATCH 3/9] gallium/radeon: formalize that r600_query_hw_add_result doesn't need a context

2017-03-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_perfcounter.c | 2 +- src/gallium/drivers/radeon/r600_query.c | 13 +++-- src/gallium/drivers/radeon/r600_query.h | 2 +- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_per

[Mesa-dev] [PATCH 7/9] gallium/radeon: s/dcc_disable/disable_dcc/

2017-03-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 2 +- src/gallium/drivers/radeon/r600_texture.c | 4 ++-- src/gallium/drivers/radeonsi/si_blit.c| 10 +- src/gallium/drivers/radeonsi/si_state.c | 2 +- 4 files changed, 9 insertions(+), 9 deletion

[Mesa-dev] [PATCH 9/9] radeonsi: decompress DCC in set_sampler_view instead of create_sampler_view

2017-03-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 14 +++--- src/gallium/drivers/radeonsi/si_pipe.h| 1 + src/gallium/drivers/radeonsi/si_state.c | 7 --- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/

[Mesa-dev] [PATCH 8/9] radeonsi: decompress DCC in set_framebuffer_state instead of create_surface

2017-03-29 Thread Marek Olšák
From: Marek Olšák for threaded gallium, which can't use pipe_context in create_surface --- src/gallium/drivers/radeon/r600_pipe_common.h | 8 +++ src/gallium/drivers/radeon/r600_texture.c | 33 +++ src/gallium/drivers/radeonsi/si_state.c | 26 ++

[Mesa-dev] [PATCH 6/9] radeonsi: handle incompatible DCC formats in resource_copy_region

2017-03-29 Thread Marek Olšák
From: Marek Olšák Required because of later commits. --- src/gallium/drivers/radeonsi/si_blit.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index bc5c2d6..ded8beb 100644 --- a/src/gallium/drivers/radeon

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2017-03-29 Thread Roland Scheidegger
[resend with snipped bits as it's too big] A couple comments inline. [snip] > --- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c > +++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c > @@ -746,39 +746,30 @@ static void lp_exec_default(struct lp_exec_mask *mask, > } > > > /* stores val

[Mesa-dev] [PATCH] configure.ac: require libdrm_amdgpu 2.4.76 for Vega

2017-03-29 Thread Marek Olšák
From: Marek Olšák --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ab9a91e..70885fb 100644 --- a/configure.ac +++ b/configure.ac @@ -67,21 +67,21 @@ OPENCL_VERSION=1 AC_SUBST([OPENCL_VERSION]) # The idea is that libdrm is

Re: [Mesa-dev] [PATCH v2] anv: add support for allocating more than 1 block of memory

2017-03-29 Thread Jason Ekstrand
Looking over the patch, I think I've convinced myself that it's correct. (I honestly wasn't expecting to come to that conclusion without more iteration.) That said, this raises some interesting questions. I added Kristian to the Cc in case he has any input. 1. Should we do powers of two or line

[Mesa-dev] [PATCH] winsys/amdgpu: remove AMDGPU_INFO_NUM_EVICTIONS

2017-03-29 Thread Samuel Pitoiset
This is now exposed with libdrm_amdgpu 2.4.76. Signed-off-by: Samuel Pitoiset --- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 4 1 file changed, 4 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c b/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c index 37e0140311..

[Mesa-dev] [PATCH] anv/cmd_buffer: fix dynamic state leak

2017-03-29 Thread cstout
From: Craig Stout anv_state_pool_alloc requires a matching free, whereas anv_state_stream_alloc will be cleaned up on finish. Applies only to 13.0 branch. x https://bugs.freedesktop.org/show_bug.cgi?id=100365 --- src/intel/vulkan/anv_private.h | 12 src/intel/vulkan/genX_cmd_bu

[Mesa-dev] [PATCH] anv/cmd_buffer: fix host memory leak

2017-03-29 Thread cstout
From: Craig Stout push_constants must be free'd. https://bugs.freedesktop.org/show_bug.cgi?id=100452 --- src/intel/vulkan/anv_cmd_buffer.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_cmd_buffer.c b/src/intel/vulkan/anv_cmd_buffer.c index 9

Re: [Mesa-dev] [PATCH] [RFC v3] mesa/glthread: Call unmarshal_batch directly in glthread_finish

2017-03-29 Thread Thomas Helland
2017-03-29 19:35 GMT+02:00 Bartosz Tomczyk : > I would be very grateful if someone could help with testing performance > impact of this change. > Currently prepping some tests on my HTPC, which is a bit CPU-bound. I'll report back in about an hour or so. > On Wed, Mar 29, 2017 at 7:31 PM, Bartos

[Mesa-dev] [Bug 100259] [EGL] [GBM] undefined reference to `gbm_bo_create_with_modifiers'

2017-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100259 ovarieg...@yahoo.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[Mesa-dev] [PATCH v3 2/2] anv: Query the kernel for reset status

2017-03-29 Thread Jason Ekstrand
When a client causes a GPU hang (or experiences issues due to a hang in another client) we want to let it know as soon as possible. In particular, if it submits work with a fence and calls vkWaitForFences or vkQueueQaitIdle and it returns VK_SUCCESS, then the client should be able to trust the res

Re: [Mesa-dev] [PATCH v2 25/25] radeonsi: enable ARB_sparse_buffer

2017-03-29 Thread Marek Olšák
For patches 13-25: Reviewed-by: Marek Olšák I think the series will also need a newer libdrm than the one required by configure.ac, but my latest configure.ac patch for Vega should address that. Marek On Tue, Mar 28, 2017 at 11:12 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > TODO add

[Mesa-dev] [Bug 100424] X hang (in kernel) after some event in Serious Sam Fusion using radv. 4.9/amd-staging-4.9

2017-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100424 --- Comment #4 from Darren Salt --- … okay, it's looking like the Steam overlay has a lot to do with this problem. (Tested with current Mesa git, but the same LLVM as before.) -- You are receiving this mail because: You are the assignee for th

Re: [Mesa-dev] [RFC 3/3] mesa: expose KHR_no_error for GL

2017-03-29 Thread Marek Olšák
The series looks good to me except the "==" -> "&" in patch 2. The patches have no effect without the GLX extension, right? Marek On Tue, Mar 28, 2017 at 6:35 AM, Timothy Arceri wrote: > There ES is no support for now as this requires > EGL_KHR_create_context_no_error to be implemented. > --- >

Re: [Mesa-dev] [PATCH] [RFC v3] mesa/glthread: Call unmarshal_batch directly in glthread_finish

2017-03-29 Thread Edmondo Tommasina
This patch helps against the massive performance drop of glthread with Two Worlds. The performance boost in Civ5 is not hurt by this patch. It looks good. Some trivial comments in the patch: On Wed, Mar 29, 2017 at 7:35 PM, Bartosz Tomczyk wrote: > I would be very grateful if someone could hel

Re: [Mesa-dev] [PATCH] st: Add cubeMapFace parameter to st_finalize_texture.

2017-03-29 Thread Marek Olšák
I'm OK with this patch. Marek On Wed, Mar 29, 2017 at 12:57 PM, Nicolai Hähnle wrote: > Hi Michal, > > thanks for the patch. That piglit test actually fails on radeonsi as well. > > > On 28.03.2017 22:39, Michal Srb wrote: >> >> st_finalize_texture always accesses image at face 0, but it may not

[Mesa-dev] [PATCH 6/7] intel: genxml: add RING_BUFFER_CTL registers

2017-03-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen6.xml | 40 +++ src/intel/genxml/gen7.xml | 40 +++ src/intel/genxml/gen75.xml | 54 src/intel/genxml/gen8.xml | 69

[Mesa-dev] [PATCH 5/7] intel: genxml: add FAULT_REG register

2017-03-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen6.xml | 48 ++ src/intel/genxml/gen7.xml | 48 ++ src/intel/genxml/gen75.xml | 64 ++ src/intel/genxml/gen8.xml | 23

[Mesa-dev] [PATCH 0/7] Aubinator error decode

2017-03-29 Thread Lionel Landwerlin
Hi, This series introduces a slightly enhanced version of intel_error_decode. Most Mesa developers working on the i965/vulkan drivers may have to deal with hangs related to a specific workload. Having the complete decoding of the instruction stream is quite useful. With the Anv driver genxml file

[Mesa-dev] [PATCH 3/7] intel: genxml: add ACTHD registers

2017-03-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen8.xml | 16 src/intel/genxml/gen9.xml | 16 2 files changed, 32 insertions(+) diff --git a/src/intel/genxml/gen8.xml b/src/intel/genxml/gen8.xml index 91573ae73a..be54748876 100644 --- a/src/intel/genxml/g

[Mesa-dev] [PATCH 1/7] intel: genxml: add INSTDONE registers

2017-03-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen6.xml | 110 + src/intel/genxml/gen7.xml | 64 ++ src/intel/genxml/gen75.xml | 71 + src/intel/genxml/gen8.xml | 71 ++

[Mesa-dev] [PATCH 4/7] intel: genxml: add gen7 ERR_INT register

2017-03-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen7.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/intel/genxml/gen7.xml b/src/intel/genxml/gen7.xml index ba9c8e8154..08307b3506 100644 --- a/src/intel/genxml/gen7.xml +++ b/src/intel/genxml/gen7.xml @@ -2665,4 +266

[Mesa-dev] [PATCH 2/7] intel: genxml: add GFX_ARB_ERROR_RPT register

2017-03-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen6.xml | 12 src/intel/genxml/gen7.xml | 12 src/intel/genxml/gen75.xml | 13 + src/intel/genxml/gen8.xml | 18 ++ src/intel/genxml/gen9.xml | 18 ++ 5 files changed,

[Mesa-dev] [PATCH 7/7] intel: tools: add aubinator_error_decode tool

2017-03-29 Thread Lionel Landwerlin
This is pretty much the same tool as what i-g-t has, only with a more fancy decoding of the instructions/registers. It also doesn't support anything before gen4. Signed-off-by: Lionel Landwerlin --- src/intel/Makefile.tools.am | 20 +- src/intel/common/gen_decoder.c | 10

Re: [Mesa-dev] [PATCH] [RFC v3] mesa/glthread: Call unmarshal_batch directly in glthread_finish

2017-03-29 Thread Thomas Helland
2017-03-29 21:17 GMT+02:00 Thomas Helland : > 2017-03-29 19:35 GMT+02:00 Bartosz Tomczyk : >> I would be very grateful if someone could help with testing performance >> impact of this change. >> > > Currently prepping some tests on my HTPC, which is a bit CPU-bound. > I'll report back in about an

Re: [Mesa-dev] [PATCH] winsys/amdgpu: remove AMDGPU_INFO_NUM_EVICTIONS

2017-03-29 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Mar 29, 2017 at 9:06 PM, Samuel Pitoiset wrote: > This is now exposed with libdrm_amdgpu 2.4.76. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/src/gall

Re: [Mesa-dev] [PATCH] radv: move to using nir clip/cull merge pass.

2017-03-29 Thread Bas Nieuwenhuizen
Acked-by: Bas Nieuwenhuizen On Wed, Mar 29, 2017 at 7:14 AM, Dave Airlie wrote: > From: Dave Airlie > > Doing this before tessellation makes doing some bits of > tessellation a bit cleaner. It also cleans up a bit of the > llvm generator code. > > Signed-off-by: Dave Airlie > --- > src/amd/co

[Mesa-dev] [Bug 100259] [EGL] [GBM] undefined reference to `gbm_bo_create_with_modifiers'

2017-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100259 --- Comment #10 from ovarieg...@yahoo.com --- It turns out in my case this is an issue with using pkgconf (Which worked previously) instead of pkg-config. It builds fine with pkg-config. I'd prefer to keep this open until the pkgconf devs have a

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: fix dynamic state leak

2017-03-29 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Wed, Mar 29, 2017 at 12:11 PM, wrote: > From: Craig Stout > > anv_state_pool_alloc requires a matching free, whereas > anv_state_stream_alloc will be cleaned up on finish. > > Applies only to 13.0 branch. > x > https://bugs.freedesktop.org/show_bug.cgi?id=100365

Re: [Mesa-dev] [PATCH] configure.ac: require libdrm_amdgpu 2.4.76 for Vega

2017-03-29 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 03/29/2017 08:23 PM, Marek Olšák wrote: From: Marek Olšák --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ab9a91e..70885fb 100644 --- a/configure.ac +++ b/configure.ac @@ -67,21 +67,21 @@ O

Re: [Mesa-dev] [RFC 3/3] mesa: expose KHR_no_error for GL

2017-03-29 Thread Timothy Arceri
On 30/03/17 06:53, Marek Olšák wrote: The series looks good to me except the "==" -> "&" in patch 2. The patches have no effect without the GLX extension, right? Correct. I was partly sending this out to see if anyone knew what was going on since Nvidia exposes this on their driver but I cou

Re: [Mesa-dev] [RFC 3/3] mesa: expose KHR_no_error for GL

2017-03-29 Thread Samuel Pitoiset
On 03/29/2017 11:01 PM, Timothy Arceri wrote: On 30/03/17 06:53, Marek Olšák wrote: The series looks good to me except the "==" -> "&" in patch 2. The patches have no effect without the GLX extension, right? Correct. I was partly sending this out to see if anyone knew what was going on sin

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2017-03-29 Thread Jose Fonseca
On 29/03/17 19:02, Roland Scheidegger wrote: [resend with snipped bits as it's too big] A couple comments inline. [snip] --- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c +++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c @@ -746,39 +746,30 @@ static void lp_exec_default(struct lp_exec

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: fix host memory leak

2017-03-29 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand And pushed. On Wed, Mar 29, 2017 at 12:14 PM, wrote: > From: Craig Stout > > push_constants must be free'd. > > https://bugs.freedesktop.org/show_bug.cgi?id=100452 > --- > src/intel/vulkan/anv_cmd_buffer.c | 10 +- > 1 file changed, 9 insertions(+), 1 dele

  1   2   >