On Wed, 2017-03-29 at 13:01 +0200, Nicolai Hähnle wrote: > On 29.03.2017 09:44, Philipp Zabel wrote: > > Stop trying to specify texture or renderbuffer objects for unsupported > > EGL images. Generate the error codes specified in the OES_EGL_image > > extension. > > > > EGLImageTargetTexture2D and EGLImageTargetRenderbuffer would call > > the pipe driver's create_surface callback without ever checking that > > the given EGL image is actually compatible with the chosen target > > texture or renderbuffer. This patch adds a call to the pipe driver's > > is_format_supported callback and generates an INVALID_OPERATION error > > for unsupported EGL images. If the EGL image handle does not describe > > a valid EGL image, an INVALID_VALUE error is generated. > > > > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> > > Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> > > --- > > v2: fixed get_surface to actually use the usage and error parameters > > The v2 usually goes above :)
Ok, I'll remember that next time. > Do you need someone to commit this for you? Yes, please. regards Philipp _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
