Re: [Mesa-dev] [Intel-gfx] [PATCH] drm/i915: Add I915_PARAM_MMAP_GTT_VERSION to advertise unlimited mmaps

2016-08-25 Thread Daniel Vetter
On Wed, Aug 24, 2016 at 08:42:43PM +0100, Chris Wilson wrote: > Now that we have working partial VMA and faulting support for all > objects, including fence support, advertise to userspace that it can > take advantage of unlimited GGTT mmaps. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/d

Re: [Mesa-dev] [PATCH] i965: Embrace "unlimited" GTT mmap support

2016-08-25 Thread Daniel Vetter
On Wed, Aug 24, 2016 at 08:42:44PM +0100, Chris Wilson wrote: > From about kernel 4.9, GTT mmaps are virtually unlimited. A new > parameter, I915_PARAM_MMAP_GTT_VERSION, is added to advertise the > feature so query it and use it to avoid limiting tiled allocations to > only fit within the mappable

Re: [Mesa-dev] [PATCH 1/4] i965: move subreg_offset to backend_reg

2016-08-25 Thread Iago Toral
On Wed, 2016-08-24 at 18:51 -0700, Francisco Jerez wrote: > Iago Toral writes: > > > > > On Tue, 2016-08-23 at 12:58 -0700, Francisco Jerez wrote: > > > > > > Iago Toral Quiroga writes: > > > > > > > > > > > > > > > So we can access it in the vec4 backend to handle byte offsets > > > > into

Re: [Mesa-dev] [PATCH] i965: Embrace "unlimited" GTT mmap support

2016-08-25 Thread Kenneth Graunke
On Wednesday, August 24, 2016 8:42:44 PM PDT Chris Wilson wrote: > From about kernel 4.9, GTT mmaps are virtually unlimited. A new > parameter, I915_PARAM_MMAP_GTT_VERSION, is added to advertise the > feature so query it and use it to avoid limiting tiled allocations to > only fit within the mappab

Re: [Mesa-dev] [PATCH 27/31] i965: Move get_fast_clear_rect to blorp_clear.c

2016-08-25 Thread Pohjolainen, Topi
On Fri, Aug 19, 2016 at 09:56:04AM -0700, Jason Ekstrand wrote: > This has been the only caller since we deleted the meta fast clear code. > --- > src/mesa/drivers/dri/i965/blorp_clear.c | 127 > +- Patches 19-27 are: Reviewed-by: Topi Pohjolainen > src/mesa/driv

Re: [Mesa-dev] [PATCH] radeonsi: disable SDMA on Carrizo

2016-08-25 Thread Michel Dänzer
On 25/08/16 06:39 AM, Marek Olšák wrote: > From: Marek Olšák > > Cc: 12.0 > --- > src/gallium/drivers/radeonsi/cik_sdma.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/gallium/drivers/radeonsi/cik_sdma.c > b/src/gallium/drivers/radeonsi/cik_sdma.c > index 2eade50..e1fd050

Re: [Mesa-dev] [Intel-gfx] [PATCH] drm/i915: Add I915_PARAM_MMAP_GTT_VERSION to advertise unlimited mmaps

2016-08-25 Thread Joonas Lahtinen
On ke, 2016-08-24 at 20:42 +0100, Chris Wilson wrote: > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -355,6 +355,14 @@ static int i915_getparam(struct drm_device *dev, void > *data, >   case I915_PARAM_MIN_EU_IN_POOL: >   value = INTEL_INFO(dev)->min_eu_in_pool; >   break

Re: [Mesa-dev] [PATCH 00/31] i965: Separate blorp from the rest of the driver

2016-08-25 Thread Pohjolainen, Topi
On Fri, Aug 19, 2016 at 09:55:37AM -0700, Jason Ekstrand wrote: > This little patch series is even more blorp code churn. The end objective > is in patch 31 which pulls blorp into its own directory completely separate > from the i965 dri driver. > > Jason Ekstrand (31): > i965/blorp: Add a blor

Re: [Mesa-dev] FW: build and run gallium on Intel platform

2016-08-25 Thread Weng, Chuanbo
Thank you all for your reply! By creating a symbol link i965_dri.so pointing to ilo_dri.so, I can successfully run eglinfo on drm platform and run glxgears on x11 platform. Hmm... It’s really a little tricky. -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.or

Re: [Mesa-dev] [Intel-gfx] [PATCH] drm/i915: Add I915_PARAM_MMAP_GTT_VERSION to advertise unlimited mmaps

2016-08-25 Thread Chris Wilson
On Thu, Aug 25, 2016 at 11:00:54AM +0300, Joonas Lahtinen wrote: > On ke, 2016-08-24 at 20:42 +0100, Chris Wilson wrote: > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > @@ -355,6 +355,14 @@ static int i915_getparam(struct drm_device *dev, void > > *data, > >   case I915_PARAM_MIN_EU_IN_POOL: > >  

[Mesa-dev] [PATCH] gallium/radeon: unify and simplify checking for an empty gfx IB

2016-08-25 Thread Marek Olšák
From: Marek Olšák We can take advantage of the fact that multi_fence does the obvious thing with NULL fences. This fixes unflushed fences that can get stuck due to empty IBs. --- src/gallium/drivers/r600/r600_hw_context.c| 8 +--- src/gallium/drivers/radeon/r600_pipe_common.c | 29

Re: [Mesa-dev] [PATCH] loader/dri3: Overhaul dri3_update_num_back

2016-08-25 Thread Michel Dänzer
On 24/08/16 06:35 AM, Eric Anholt wrote: > Michel Dänzer writes: >> On 20/08/16 04:42 AM, Eric Anholt wrote: >>> Michel Dänzer writes: >>> From: Michel Dänzer Always use 3 buffers when flipping. With only 2 buffers, we have to wait for a flip to complete (which takes non-0 ti

[Mesa-dev] [Bug 97250] Mesa/Clover: openCV library bugs on CL_MEM_USE_HOST_PTR

2016-08-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97250 Sander Eikelenboom changed: What|Removed |Added Component|Mesa core |Other CC|

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

2016-08-25 Thread Nayan Deshmukh
ping On Mon, Aug 22, 2016 at 7:49 PM, Nayan Deshmukh wrote: > Hi Christian, > > I checked the height/width of the surface. I get a luma channel with > the original size. The Cb and Cr > channel with height/2 and width/2. I had tested videos with 4:2:0 > chroma format. But I still get the > artifa

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

2016-08-25 Thread Nayan Deshmukh
Agreed. I will file a bug report for the chroma artifacts and submit a patch which uses temporary surfaces to while writing. Meanwhile, you can revert the patch. Regards, Nayan. On Thu, Aug 25, 2016 at 3:34 PM, Christian König wrote: > Sorry for not coming back to this earlier, but you know as

Re: [Mesa-dev] [PATCH 03/13] docs: Rename GL3.txt to features.txt

2016-08-25 Thread Eric Engestrom
On Wed, Aug 24, 2016 at 07:46:11PM +0100, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Suggested-by: Ilia Mirkin > --- > docs/GL3.txt | 335 > -- > docs/features.txt | 335 > +++

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

2016-08-25 Thread Christian König
Sorry for not coming back to this earlier, but you know as busy as usual :) I thought that a possible reason could be that the Cb and Cr should be first interpolated to the original Mhm, could be. But in theory that shouldn't make a difference. Please open up a bug report and attach a picture

[Mesa-dev] [PATCH v2] egl: return corresponding offset of EGLImage instead of 0.

2016-08-25 Thread Chuanbo Weng
The offset should not always be 0. For example, if EGLImage is created from a 2D texture with EGL_GL_TEXTURE_LEVEL=1, then the offset should be the actual start of miplevel 1 in drm bo. v2: version bump on the EGL image interface and add gallium pieces. Signed-off-by: Chuanbo Weng --- include/G

Re: [Mesa-dev] [PATCH] Return corresponding offset of EGLImage instead of 0.

2016-08-25 Thread Weng, Chuanbo
Hi Dave, I've sent out v2 patch based on your comments. Could you please review it? Thanks! -Original Message- From: Weng, Chuanbo Sent: Friday, August 19, 2016 4:15 PM To: 'Dave Airlie' Cc: Eric Engestrom ; airl...@redhat.com; emil.l.veli...@gmail.com; mesa-dev@lists.freedeskt

[Mesa-dev] [Bug 97285] Darkness in Dota 2 after Patch "Make Gallium's BlitFramebuffer follow the GL 4.4 sRGB rules"

2016-08-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97285 Marek Olšák changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[Mesa-dev] [Bug 97260] [bisected] R9 290 low performance in Linux 4.7

2016-08-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97260 --- Comment #30 from Clésio Luiz --- Well, I'm too much a newbie to compile those things (I'm using Ubuntu...). But, if you point me to some documentation I can test it in a clear install in another HDD. -- You are receiving this mail because:

[Mesa-dev] [Bug 97481] mesa-12.0.1 exposes only OpenGL 3.0 on wayland under gnome-shell on Intel HD 520

2016-08-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97481 Bug ID: 97481 Summary: mesa-12.0.1 exposes only OpenGL 3.0 on wayland under gnome-shell on Intel HD 520 Product: Mesa Version: 12.0 Hardware: Other OS: All

Re: [Mesa-dev] [Intel-gfx] [PATCH] drm/i915: Add I915_PARAM_MMAP_GTT_VERSION to advertise unlimited mmaps

2016-08-25 Thread Joonas Lahtinen
On to, 2016-08-25 at 09:27 +0100, Chris Wilson wrote: > On Thu, Aug 25, 2016 at 11:00:54AM +0300, Joonas Lahtinen wrote: > > > > On ke, 2016-08-24 at 20:42 +0100, Chris Wilson wrote: > > > > > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > > @@ -355,6 +355,14 @@ static int i915_getparam(struct drm_d

[Mesa-dev] [PATCH] mesa/main: missing return in a non-void function

2016-08-25 Thread Francesco Ansanelli
Signed-off-by: Francesco Ansanelli --- src/mesa/main/program_resource.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/program_resource.c b/src/mesa/main/program_resource.c index 6ddbdad..51dbe95 100644 --- a/src/mesa/main/program_resource.c +++ b/src/mesa/main/program_resou

[Mesa-dev] [Bug 97481] mesa-12.0.1 exposes only OpenGL 3.0 on wayland under gnome-shell on Intel HD 520

2016-08-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97481 --- Comment #1 from Bas Nieuwenhuizen --- Note that OpenGL has two context profiles: core and compatibility. Mesa does not support OpenGL for versions later than 3.0 using a compatibility profile, on any platform. Looking at the eglinfo source

[Mesa-dev] [Request for Testing] i965: import prime buffers in the current context, not screen

2016-08-25 Thread Martin Peres
This mirrors the codepath taken by DRI2 in IntelSetTexBuffer2() and fixes many applications when using DRI3: - Totem with libva on hw-accelerated decoding - obs-studio, using Window Capture (Xcomposite) as a Source - gstreamer with VAAPI Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=71

[Mesa-dev] [Bug 97426] glScissor gives vertically inverted result

2016-08-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97426 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] mesa/main: Fix missing return in non void function

2016-08-25 Thread Tobias Klausmann
This was found by obs: I: Program returns random data in a function E: Mesa no-return-in-nonvoid-function main/program_resource.c:109 Signed-off-by: Tobias Klausmann --- src/mesa/main/program_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/program_res

Re: [Mesa-dev] [PATCH 1/3] intel/isl: Use DIM_LAYOUT_GEN4_2D for tiled 1-D surfaces on SKL

2016-08-25 Thread Pohjolainen, Topi
On Tue, Aug 23, 2016 at 09:53:46PM -0700, Jason Ekstrand wrote: > The Sky Lake 1D layout is only used if the surface is linear. For tiled > surfaces such as depth and stenil the old gen4 2D layout is used. stencil > > Signed-off-by: Jason Ekstrand > Cc: Chad Versac

Re: [Mesa-dev] [PATCH] mesa/main: missing return in a non-void function

2016-08-25 Thread Alejandro Piñeiro
Reviewed-by: Alejandro Piñeiro On 25/08/16 14:24, Francesco Ansanelli wrote: > Signed-off-by: Francesco Ansanelli > --- > src/mesa/main/program_resource.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/main/program_resource.c > b/src/mesa/main/program_resource.c > index

Re: [Mesa-dev] [PATCH] i965/blorp: Add a format parameter to blorp_fast_clear

2016-08-25 Thread Pohjolainen, Topi
On Tue, Aug 23, 2016 at 11:08:00AM -0700, Jason Ekstrand wrote: > We were inferring the format from the surface but that doesn't always work > as the surface format is the texture format and we want the render format > (which may be different on i965). Makes sense: Reviewed-by: Topi Pohjolainen

Re: [Mesa-dev] [PATCH 3/3] intel/isl/gen9: Only use the magic 1D alignment for GEN9_2D surfaces

2016-08-25 Thread Pohjolainen, Topi
In the title did you mean GEN_1D? Otherwise patches two and three look good also: Reviewed-by: Topi Pohjolainen On Tue, Aug 23, 2016 at 09:53:48PM -0700, Jason Ekstrand wrote: > If the surface has a layout of GEN4_2D then we need to compute a normal 2D > alignment and not use the bogus 1D one.

Re: [Mesa-dev] [PATCH] meta: Always do GenerateMipmaps in linear colorspace.

2016-08-25 Thread Pohjolainen, Topi
On Wed, Aug 24, 2016 at 10:04:58PM -0700, Kenneth Graunke wrote: > On Friday, August 12, 2016 3:59:35 PM PDT Kenneth Graunke wrote: > > When generating mipmaps for sRGB textures, force both decode and encode, > > so the filtering is done in linear colorspace, regardless of settings. > > > > Fixes

Re: [Mesa-dev] [PATCH] mesa/main: missing return in a non-void function

2016-08-25 Thread Emil Velikov
On 25 August 2016 at 13:24, Francesco Ansanelli wrote: > Signed-off-by: Francesco Ansanelli > --- > src/mesa/main/program_resource.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/main/program_resource.c > b/src/mesa/main/program_resource.c > index 6ddbdad..51dbe95 100644

Re: [Mesa-dev] [PATCH mesa] configure.ac: raise Mako required version to 0.8.0

2016-08-25 Thread Emil Velikov
On 25 August 2016 at 01:26, Dave Airlie wrote: > On 24 August 2016 at 20:43, Emil Velikov wrote: >> On 19 July 2016 at 13:41, Eric Engestrom wrote: >>> It seems [0] old versions of Mako are no longer supported. Emil mentioned it >>> might need v0.8.0 [1] for isl_format_layout [2], although I did

[Mesa-dev] [PATCH 4/4] mesa: annotate AttribFuncsARB[] as const

2016-08-25 Thread Emil Velikov
From: Emil Velikov It's read-only data, so annotate it accordingly. Signed-off-by: Emil Velikov --- src/mesa/main/api_arrayelt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/api_arrayelt.c b/src/mesa/main/api_arrayelt.c index c84db5f..15fbb8c 100644 --- a/s

[Mesa-dev] [PATCH 3/4] mapi/glapi: remove unused _glapi_check_table()

2016-08-25 Thread Emil Velikov
From: Emil Velikov Similar to earlier commit - symbol was never part of the public API so we're safe to remove it. Signed-off-by: Emil Velikov --- src/mapi/glapi/glapi_getproc.c | 62 -- src/mapi/glapi/glapi_priv.h| 6 2 files changed, 68 delet

[Mesa-dev] [PATCH 1/4] mapi/glapi: remove unused _glapi_check_table_not_null

2016-08-25 Thread Emil Velikov
From: Emil Velikov Function was never part of the API/ABI and the final user was removed with commit a73c6540d9a7f6e26d8568ba2fc522cb865f0a6c, back in 2010. Signed-off-by: Emil Velikov --- src/mapi/glapi/glapi_getproc.c | 20 src/mapi/glapi/glapi_priv.h| 4 2 fil

[Mesa-dev] [PATCH 2/4] glapi/hgl: remove the final user of _glapi_check_table()

2016-08-25 Thread Emil Velikov
From: Emil Velikov The symbol is a no-op since, the EXTRA_DEBUG macro is not set in the build. Unused by !Haiku people/platforms since 2010 (commit a73c6540d9a7f6e26d8568ba2fc522cb865f0a6c) while the Haiku C++ wrapper has no obvious users. Cc: Alexander von Gluck IV Signed-off-by: Emil Velikov

[Mesa-dev] [PATCH 1/4] egl: treat EGL_OPENGL_API as invalid on Android

2016-08-25 Thread Emil Velikov
From: Emil Velikov At the moment one can use OpenGL in eglBindAPI() only to clear the EGL_OPENGL_BIT from RenderableType and Conformant for _each_ config. Signed-off-by: Emil Velikov --- src/egl/main/eglcurrent.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/eg

[Mesa-dev] [PATCH 2/4] egl/android: annotate static const data as such

2016-08-25 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_android.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index e7b30b4..512a1b8 100644 --- a/src/egl/drivers/d

[Mesa-dev] [PATCH 3/4] egl/dri2: check if the EGL API is valid before adding it to ClientAPIs

2016-08-25 Thread Emil Velikov
From: Emil Velikov In the rather unlikely case that the API is considered invalid, don't add it to the (supported) ClientAPIs bitmask. Signed-off-by: Emil Velikov --- Strictly speaking we only need this in the Android case for OpenGL. Adding it everywhere doesn't hurt us since the compiler will

[Mesa-dev] [PATCH 4/4] egl/android: remove config post-processing

2016-08-25 Thread Emil Velikov
From: Emil Velikov No longer needed as of last commit, since we no longer add OPENGL to the ClientAPIs thus, RenderType and Conformant don't have the desktop GL bit set. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_android.c | 9 - 1 file changed, 9 deletions(-) diff

[Mesa-dev] [PATCH 0/4] Resolving Android + desktop OpenGL 'hack'

2016-08-25 Thread Emil Velikov
Hi all, While in the area, I've noticed an odd behaviour (and somewhat of a bug) in the egl/android code. Namely: although we allow binding the EGL_OPENGL_API we explicitly clear the OPENGL_BIT for all the configs at eglInitalize time. I've reworked things in a less(?) hacky way, although ther

[Mesa-dev] [PATCH 00/30] egl: a ton of eglMakeCurrent inspired cleanups

2016-08-25 Thread Emil Velikov
Hi all, With the resent noise in the egl area I decided to do some of the long planned cleanup in the area. It spans across the following: - glapi missing glFlush and non-shared glapi are not an option - encapsulate/separate disp->DriverData (more?) management - 'unwrap' eglMakeCurrent - don

[Mesa-dev] [PATCH 01/30] egl/dri2: glFlush is not optional, treat it as such

2016-08-25 Thread Emil Velikov
From: Emil Velikov The documentation is clear - one must glFlush the old context on eglMakeCurrent. Thus keeping it optional is not something we should be doing. Furthermore if we cannot get the entry point we're likely having a broken setup/stack. Signed-off-by: Emil Velikov --- src/egl/drive

[Mesa-dev] [PATCH 07/30] egl/dri2: call static functions directly, not via _EGLDriver::API

2016-08-25 Thread Emil Velikov
From: Emil Velikov The indirection is meant to be used by the core EGL implementation in main. Not in the drivers themselves. Move the dri2_destroy_surface definition to avoid forward declaration of the static function. Signed-off-by: Emil Velikov --- XXX: Aren't we forgetting to Unlink the su

[Mesa-dev] [PATCH 03/30] egl/dri2: coding style fix

2016-08-25 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 551eb84..0925d44 100644 --- a/src/egl/drivers/dri2/egl_dri2.c +++ b/sr

[Mesa-dev] [PATCH 14/30] egl/surfaceless: trivial coding style fixes

2016-08-25 Thread Emil Velikov
From: Emil Velikov Remove a few gratious blank lines and use the correct level of indentation. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.h | 1 - src/egl/drivers/dri2/platform_surfaceless.c | 5 + 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a

[Mesa-dev] [PATCH 10/30] egl/dri2: rework dri2_make_current code flow

2016-08-25 Thread Emil Velikov
From: Emil Velikov Duplicate a few lines at the expense of making the code-flow clearer while adding a few extra comments ;-) Signed-off-by: Emil Velikov --- It makes things clearer the way on this end, but if people have better suggestions I would love to hear them. Emil --- src/egl/drivers

[Mesa-dev] [PATCH 13/30] egl/surfaceless: don't check the mask(s) prior to calling dri2_add_config

2016-08-25 Thread Emil Velikov
From: Emil Velikov The latter already does it for us. As we're here annotate the masks as const and use unsigned for the index(es). Cc: Gurchetan Singh Cc: Chad Versace Signed-off-by: Emil Velikov --- Similar to the earlier surfaceless patch - only compile tested ! --- src/egl/drivers/dri2/

[Mesa-dev] [PATCH 15/30] egl/wayland: don't populate dri2_dpy->dri2_loader_extension

2016-08-25 Thread Emil Velikov
From: Emil Velikov Analogous to the earlier android patch. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_wayland.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayla

[Mesa-dev] [PATCH 08/30] XXX: egl: comment on IsLinked presence/necessity

2016-08-25 Thread Emil Velikov
--- Not meant to be merged, but to inspire dicussion. --- src/egl/main/egldisplay.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/egl/main/egldisplay.c b/src/egl/main/egldisplay.c index bbc3063..30fb687 100644 --- a/src/egl/main/egldisplay.c +++ b/src/egl/main/egldisplay.c @@ -411

[Mesa-dev] [PATCH 06/30] egl/dri2: use dri2_egl_display inline wrapper where possible

2016-08-25 Thread Emil Velikov
From: Emil Velikov This way the only places that reference DriverData are the ones that manipulate it. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/d

[Mesa-dev] [PATCH 21/30] egl/x11: don't crash if dri2_dpy->conn is NULL

2016-08-25 Thread Emil Velikov
From: Emil Velikov The dri3 version of commits 60e9c35b3a0 and 6de9a03bed4. CC: Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_x11.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/egl/drivers/dri2/platform_x11.c b/src/egl/drivers/dri2/pl

[Mesa-dev] [PATCH 02/30] egl/dri2: non-shared glapi cleanups

2016-08-25 Thread Emil Velikov
From: Emil Velikov For a while now we require shared glapi for EGL, thus we can drop a few bits from the olden days. Namely - dlopen(NULL...) is not possible, error out at build stage if so and drop the guard around dlclose(). Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 3

[Mesa-dev] [PATCH 09/30] egl/dri2: drop NULL checks prior to dri2_destroy_surface

2016-08-25 Thread Emil Velikov
From: Emil Velikov The function already have the respective check within. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 89d2966..a

[Mesa-dev] [PATCH 04/30] egl/dri2: move surface refcounting out of the platform code

2016-08-25 Thread Emil Velikov
From: Emil Velikov All the platforms are duplicating what should be a driver/dri2 thing - refcounting. Just fold it accordingly. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 4 src/egl/drivers/dri2/platform_android.c | 3 --- src/egl/drivers/dri2/platf

[Mesa-dev] [PATCH 11/30] egl/android: don't populate dri2_dpy->dri2_loader_extension

2016-08-25 Thread Emil Velikov
From: Emil Velikov The extension stored in struct dri2_egl_display isn't used, thus we can create a static const instance of the extension and point extensions[] to it. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_android.c | 16 +--- src/egl/drivers/dri2/platf

[Mesa-dev] [PATCH 29/30] egl/android: remove duplicate KHR_image_base set

2016-08-25 Thread Emil Velikov
From: Emil Velikov The core egl/dri2 already sets the extension bit _only_ when possible - which in Android's case is always. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_android.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/sr

[Mesa-dev] [PATCH 23/30] egl/dri2: add support for optional extensions in dri2_bind_extensions()

2016-08-25 Thread Emil Velikov
From: Emil Velikov Will allow us to reuse the function for optional extensions and fold a bit of code. Cc: Rob Clark Signed-off-by: Emil Velikov --- Rob, you were thinking about a similar thing on the GBM front, correct ? Low hanging fruit for anyone: move this, amongst others, to loader_dri.

[Mesa-dev] [PATCH 24/30] gbm: rename gbm_dri_device::{, loader_}extensions

2016-08-25 Thread Emil Velikov
From: Emil Velikov To align with the name used in the EGL and GLX loaders. Signed-off-by: Emil Velikov --- src/gbm/backends/dri/gbm_dri.c| 12 ++-- src/gbm/backends/dri/gbm_driint.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gbm/backends/dri/gbm_dri

[Mesa-dev] [PATCH 28/30] loader/dri3: constify the loader_dri3_vtable

2016-08-25 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_x11_dri3.c | 2 +- src/glx/dri3_glx.c | 2 +- src/loader/loader_dri3_helper.c | 2 +- src/loader/loader_dri3_helper.h | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(

[Mesa-dev] [PATCH 05/30] egl/dri2: bail out on NULL dpy in dri2_display_release()

2016-08-25 Thread Emil Velikov
From: Emil Velikov Currently all callers are careful enough not to do that, yet that will not be the case in the future. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/s

[Mesa-dev] [PATCH 16/30] egl/x11: don't populate dri2_dpy->dri2_loader_extension

2016-08-25 Thread Emil Velikov
From: Emil Velikov Analogous to the earlier android and wayland patches. As we're here we can drop exposing the old version of the extension. Any dri loader/driver interface use lower bound checking thus exposing dri2 loader v3 to a v2 capable driver is perfectly normal. Signed-off-by: Emil Vel

[Mesa-dev] [PATCH 30/30] egl/dri2: set WL_bind_wayland_display in a consistent way

2016-08-25 Thread Emil Velikov
From: Emil Velikov Introduce a helper and use it throughout the platform code. This allows us to reduce the amount of ifdef(s) and (potentially) use kms_swrast_dri.so for platform !drm (namely wayland and x11). Note: in the future as other platforms (android, surfaceless) support the extension t

[Mesa-dev] [PATCH 20/30] egl/dri2: rework dri2_egl_display::extensions storage

2016-08-25 Thread Emil Velikov
From: Emil Velikov Remove the error prone fixed size array. While we're here also rename to loader_extensions like in the GLX code. Signed-off-by: Emil Velikov --- There's a single easter egg hidden within (functionality change) which... I should keep separate, perhaps :-\ XXX: - Any ideas why

[Mesa-dev] [PATCH 12/30] egl/surfaceless: remove unused dri2_loader_extension implementation

2016-08-25 Thread Emil Velikov
From: Emil Velikov Earlier commit introduced support for image_loader and left the dri2_loader code dangling/unused. Let's remove it. Fixes: 63c5d5c6c46 ("Added pbuffer hooks for surfaceless platform") Cc: Gurchetan Singh Cc: Chad Versace Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/

[Mesa-dev] [PATCH 27/30] egl/dri2: micro optimise dri2_bind_extensions()

2016-08-25 Thread Emil Velikov
From: Emil Velikov Do not loop over all matches if we've already found one. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 3ec2c53..e638fc9 100644 --- a/

[Mesa-dev] [PATCH 18/30] egl/x11: don't populate dri2_dpy->swrast_loader_extension

2016-08-25 Thread Emil Velikov
From: Emil Velikov Analogous to earlier commits. Note: the actual version of the extension is 1, since it does not implement .putImage2. Signed-off-by: Emil Velikov --- We're safe since when 2 was used the actual struct defined in dri_interface.h was greater thus the calloc was explicitly zero

[Mesa-dev] [PATCH 19/30] egl/dri2: remove unused dri2_egl_display::{dri2, swrast}_loader_extension

2016-08-25 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.h b/src/egl/drivers/dri2/egl_dri2.h index 7156955..f902006 100644 --- a/src/egl/drivers/dri2/egl_dri2.h +++ b/src/egl/drivers/dri

[Mesa-dev] [PATCH 26/30] egl/dri2: annotate dri2_extension_match instances as const data

2016-08-25 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 6edee68..3ec2c53 100644 --- a/src/egl/drivers/dri2/egl_dr

[Mesa-dev] [PATCH 17/30] egl/wayland: don't populate dri2_dpy->swrast_loader_extension

2016-08-25 Thread Emil Velikov
From: Emil Velikov Similar to the dri2 one - the extension stored in struct dri2_egl_display is unused. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_wayland.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/egl/drivers/dri2/platform_

[Mesa-dev] [PATCH 22/30] egl/dri2: coding style cleanup

2016-08-25 Thread Emil Velikov
From: Emil Velikov Consistently indent with space rather than a mix of tab and spaces. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 286 src/egl/drivers/dri2/egl_dri2.h | 18 +-- 2 files changed, 152 insertions(+), 152 deletions(-)

[Mesa-dev] [PATCH 25/30] egl/dri2: use dri2_bind_extensions to manage the optional extensions

2016-08-25 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index f41f9a9..6edee68 100644 --- a/src/egl/dri

[Mesa-dev] [PATCH 0/7] egl: *_add_configs_for_visuals() polish

2016-08-25 Thread Emil Velikov
Hi all, This egl series depends on the previous one (although can be split and applied independently). It includes a bunch of polish and 'not big enough for -stable' bugfixes. As always: speak up if you have a preference on splitting and/or folding the patches. Thanks Emil __

[Mesa-dev] [PATCH 1/7] egl/surfaceless: print out a message on zero configs for given format

2016-08-25 Thread Emil Velikov
From: Emil Velikov Currently we print a debug message if the total configs is non-zero only to do the same (at an error level) as we return from the function. Rework the message to print if we're missing a config for the given format. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platf

[Mesa-dev] [PATCH 3/7] egl/android: tweak droid_add_configs_for_visuals()

2016-08-25 Thread Emil Velikov
From: Emil Velikov Iterate over the driver_configs first in order to cut down the number of getConfigAttrib() calls by a factor of 5. While we're here, also drop the sentinel of the visuals array. We already know its size so we can use that and save a few bytes. Signed-off-by: Emil Velikov ---

[Mesa-dev] [PATCH 2/7] egl/drm: introduce drm_add_configs_for_visuals() helper

2016-08-25 Thread Emil Velikov
From: Emil Velikov Factor out and rework the existing code so that it prints a debug message if we have zero configs for any visual. As a nice side effect we now provide a correct (sequential ID) when creating a config (via dri2_add_config). Signed-off-by: Emil Velikov --- src/egl/drivers/dri

[Mesa-dev] [PATCH 5/7] egl/wayland: introduce dri2_wl_add_configs_for_visuals() helper

2016-08-25 Thread Emil Velikov
From: Emil Velikov Analogous to previous commits - with an extra bonus. Current code, apart from not attributing the lack of 'per visual' and overall configs also overwrites the newly added config. Namely if the dpy supports two or more of the supported formats (XRGB, ARGB and RGB565) e

[Mesa-dev] [PATCH 4/7] egl/surfaceless: tweak surfaceless_add_configs_for_visuals()

2016-08-25 Thread Emil Velikov
From: Emil Velikov Analogous to previous commit. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_surfaceless.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/egl/drivers/dri2/platform_surfaceless.c b/src/egl/drivers/dri2/platform_surfacel

[Mesa-dev] [PATCH 7/7] egl/drm: set eglError and provide an error message on failure

2016-08-25 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/egl/drivers/dri2/platform_drm.c index aa9a186..df711cf 100644 --- a/src/e

[Mesa-dev] [PATCH 6/7] egl/x11: attribute for dri2_add_config failure

2016-08-25 Thread Emil Velikov
From: Emil Velikov ... in dri2_x11_add_configs_for_visuals(). Currently the latter does not consider that, thus in such cases it adds "empty" configs in the list. Properly account for things and as we do that we can reuse count, instead of calling _eglGetArraySize to deterime if we've added any

Re: [Mesa-dev] [PATCH 2/3] nir: Change nir_shader_get_entrypoint to return an impl.

2016-08-25 Thread Eric Anholt
Kenneth Graunke writes: > Jason suggested adding an assert(function->impl) here. All callers > of this function actually want ->impl, so I decided just to change > the API. > > We also change the nir_lower_io_to_temporaries API here. All but one > caller passed nir_shader_get_entrypoint(), and

[Mesa-dev] [PATCH] nv50/ir: always emit the NDV bit for OP_QUADOP

2016-08-25 Thread Samuel Pitoiset
This fixes a divergent error found with F1 2015. GM107 emitter already sets that bit. Signed-off-by: Samuel Pitoiset Cc: --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 5 + src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 5 + 2 files changed, 2 insertions

Re: [Mesa-dev] [PATCH 16/30] egl/x11: don't populate dri2_dpy->dri2_loader_extension

2016-08-25 Thread Kristian Høgsberg
On Thu, Aug 25, 2016 at 9:18 AM, Emil Velikov wrote: > From: Emil Velikov > > Analogous to the earlier android and wayland patches. As we're here we > can drop exposing the old version of the extension. > > Any dri loader/driver interface use lower bound checking thus exposing > dri2 loader v3 to

Re: [Mesa-dev] [PATCH 21/30] egl/x11: don't crash if dri2_dpy->conn is NULL

2016-08-25 Thread Kristian Høgsberg
On Thu, Aug 25, 2016 at 9:18 AM, Emil Velikov wrote: > From: Emil Velikov > > The dri3 version of commits 60e9c35b3a0 and 6de9a03bed4. > > CC: > Signed-off-by: Emil Velikov > --- > src/egl/drivers/dri2/platform_x11.c | 14 +- > 1 file changed, 5 insertions(+), 9 deletions(-) > > di

Re: [Mesa-dev] [PATCH 25/30] egl/dri2: use dri2_bind_extensions to manage the optional extensions

2016-08-25 Thread Kristian Høgsberg
On Thu, Aug 25, 2016 at 9:18 AM, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > src/egl/drivers/dri2/egl_dri2.c | 28 ++-- > 1 file changed, 10 insertions(+), 18 deletions(-) > > diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/dri

Re: [Mesa-dev] [PATCH v2] egl: return corresponding offset of EGLImage instead of 0.

2016-08-25 Thread Weng, Chuanbo
Sorry, please ignore this patch. I'll send out a new one. Thanks. -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Chuanbo Weng Sent: Thursday, August 25, 2016 6:47 PM To: mesa-dev@lists.freedesktop.org; airl...@redhat.com Cc: emil.l.veli...@g

Re: [Mesa-dev] [PATCH 1/3] intel/isl: Use DIM_LAYOUT_GEN4_2D for tiled 1-D surfaces on SKL

2016-08-25 Thread Chad Versace
On Thu 25 Aug 2016, Pohjolainen, Topi wrote: > On Tue, Aug 23, 2016 at 09:53:46PM -0700, Jason Ekstrand wrote: > > The Sky Lake 1D layout is only used if the surface is linear. For tiled > > surfaces such as depth and stenil the old gen4 2D layout is used. > > stencil

Re: [Mesa-dev] [PATCH 4/7] egl/surfaceless: tweak surfaceless_add_configs_for_visuals()

2016-08-25 Thread Gurchetan Singh
>> unsigned int format_count[ARRAY_SIZE(visuals)] = {}; Isn't this invalid in C? http://stackoverflow.com/questions/17589533/is-an-empty-initializer-list-valid-c-code Other than that, this patch is Reviewed-by: Gurchetan Singh On Thu, Aug 25, 2016 at 9:23 AM, Emil Velikov wrote: > From: Emil

Re: [Mesa-dev] [PATCH 3/3] intel/isl/gen9: Only use the magic 1D alignment for GEN9_2D surfaces

2016-08-25 Thread Chad Versace
On Thu 25 Aug 2016, Pohjolainen, Topi wrote: > > In the title did you mean GEN_1D? > > Otherwise patches two and three look good also: > > Reviewed-by: Topi Pohjolainen Yep. Patches 2 and 3 are Reviewed-by: Chad Versace ___ mesa-dev mailing list mes

[Mesa-dev] [PATCH v2] egl: return corresponding offset of EGLImage instead of 0.

2016-08-25 Thread Chuanbo Weng
The offset should not always be 0. For example, if EGLImage is created from a 2D texture with EGL_GL_TEXTURE_LEVEL=1, then the offset should be the actual start of miplevel 1 in drm bo. v2: version bump on the EGL image interface and add gallium pieces. Signed-off-by: Chuanbo Weng --- include/G

Re: [Mesa-dev] [PATCH 2/2] mesa: Fix glFramebufferTexture* error codes (v2)

2016-08-25 Thread Chad Versace
Bump. On Thu 11 Aug 2016, Chad Versace wrote: > If check_textarget() determined that textarget was incorrect, it emitted > GL_INVALID_OPERATION. This is the correct behavior when target and > textarget are mismatched but textarget is a valid textarget enum. > > When textarget is not a valid text

Re: [Mesa-dev] [PATCH] nir: Walk blocks in source code order in lower_vars_to_ssa.

2016-08-25 Thread Matt Turner
On Wed, Aug 24, 2016 at 11:25 PM, Connor Abbott wrote: > On Thu, Aug 25, 2016 at 12:04 AM, Matt Turner wrote: >> Prior to this commit rename_variables_block() is recursively called, >> performing a depth-first traversal of the control flow graph. The >> function uses a non-trivial amount of stack

[Mesa-dev] [PATCH] radeonsi: don't use allocas for arrays with LLVM 3.8

2016-08-25 Thread Marek Olšák
From: Marek Olšák It crashes. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97413 --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/ra

Re: [Mesa-dev] [PATCH 0/2] i965: Fix dEQP-EGL.functional.image.create.gles2_cubemap_*

2016-08-25 Thread Chad Versace
Bump. Can I get a reviewed-by? Or at least a tested-by? This patch fixes failures on Chrome OS. On Thu 04 Aug 2016, Chad Versace wrote: > Hi Intel folks, could one of you please run this through Jenkins? > I verified manually that it fixes the listed dEQP tests on Skylake. > > Chad Versace (2): >

Re: [Mesa-dev] [PATCH] nir/phi_builder: Don't recurse in value_get_block_def

2016-08-25 Thread Matt Turner
On Wed, Aug 24, 2016 at 10:49 PM, Jason Ekstrand wrote: > In some programs, we can have very deep dominance trees and the recursion > can cause us to risk stack overflows. Instead, we replace the recursion > with a pair of loops, one at the start and one at the end. This is > functionally equiva

Re: [Mesa-dev] [Request for Testing] i965: import prime buffers in the current context, not screen

2016-08-25 Thread Chad Versace
On Thu 25 Aug 2016, Martin Peres wrote: > This mirrors the codepath taken by DRI2 in IntelSetTexBuffer2() and > fixes many applications when using DRI3: > - Totem with libva on hw-accelerated decoding > - obs-studio, using Window Capture (Xcomposite) as a Source > - gstreamer with VAAPI > > Bug

Re: [Mesa-dev] [PATCH 0/2] i965: Fix dEQP-EGL.functional.image.create.gles2_cubemap_*

2016-08-25 Thread Kenneth Graunke
On Thursday, August 25, 2016 11:06:01 AM PDT Chad Versace wrote: > Bump. Can I get a reviewed-by? Or at least a tested-by? This patch fixes > failures on Chrome OS. Oh, sorry, I thought these had been reviewed a while ago. But I see it was just chatter about running dEQP-EGL. Both are: Reviewed-

  1   2   >