Re: [Mesa-dev] [PATCH] glsl: geom shader max_vertices layout must match.

2016-06-06 Thread Dave Airlie
On 6 June 2016 at 16:30, Alejandro Piñeiro wrote: > On 03/06/16 23:04, Dave Airlie wrote: >> On 4 June 2016 at 03:39, Alejandro Piñeiro wrote: >>> On 03/06/16 02:46, Dave Airlie wrote: From: Dave Airlie "all geometry shader output vertex count declarations in a program must d

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2016-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Jacek Konieczny changed: What|Removed |Added Depends on||95530 Referenced Bugs: https://bugs.

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2016-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Jacek Konieczny changed: What|Removed |Added Depends on|95530 | Referenced Bugs: https://bugs.freed

Re: [Mesa-dev] [PATCH] glsl: geom shader max_vertices layout must match.

2016-06-06 Thread Alejandro Piñeiro
On 06/06/16 09:00, Dave Airlie wrote: > On 6 June 2016 at 16:30, Alejandro Piñeiro wrote: >> On 03/06/16 23:04, Dave Airlie wrote: >>> On 4 June 2016 at 03:39, Alejandro Piñeiro wrote: On 03/06/16 02:46, Dave Airlie wrote: > From: Dave Airlie > > "all geometry shader output vert

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2016-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Davin McCall changed: What|Removed |Added Depends on||80419 Referenced Bugs: https://bugs.fre

Re: [Mesa-dev] [PATCH] glsl: geom shader max_vertices layout must match.

2016-06-06 Thread Alejandro Piñeiro
On 06/06/16 09:44, Alejandro Piñeiro wrote: > On 06/06/16 09:00, Dave Airlie wrote: >> On 6 June 2016 at 16:30, Alejandro Piñeiro wrote: >>> On 03/06/16 23:04, Dave Airlie wrote: On 4 June 2016 at 03:39, Alejandro Piñeiro wrote: > On 03/06/16 02:46, Dave Airlie wrote: >> From: Dave A

[Mesa-dev] [PATCH] EGL: automatic API binding on eglMakeCurrent

2016-06-06 Thread Adrien Maglo
A first thread binds an API and creates a context. If a second thread calls eglMakeCurrent with the same context as parameter without having bound the same API, the context is not linked correctly as the CurrentAPIIndex variable as never been set. --- src/egl/main/eglcontext.c | 1 + 1 file change

[Mesa-dev] [PATCH] EGL: automatic API binding on eglMakeCurrent

2016-06-06 Thread Adrien Maglo
Hello, For some OpenGL visualization module inside VLC media player, we create the OpenGL context in one initialization thread and render in an other one. I discovered that with Mesa EGL, eglMakeCurrent did not let me draw inside the rendering thread. Even if eglMakeCurrent returns EGL_SUCCESS,

Re: [Mesa-dev] [PATCH 4/4] radeonsi: force non-displayable tiling based on surface dimensions

2016-06-06 Thread Michel Dänzer
On 03.06.2016 19:52, Marek Olšák wrote: > From: Marek Olšák > > Simply ignore the "scanout" flag if the surface dimensions are unlikely > to be used by DCE. I don't like this. Ideally, there should be feedback from the display server so that he state tracker(s) can set the PIPE_BIND_SCANOUT fla

Re: [Mesa-dev] Mesa (master): Revert "egl: Check if API is supported when using eglBindAPI."

2016-06-06 Thread Michel Dänzer
On 04.06.2016 00:10, Marek Olšák wrote: > On Fri, Jun 3, 2016 at 4:33 PM, Dieter Nützel wrote: >> Am 03.06.2016 11:47, schrieb Michel Dänzer: >>> >>> On 03.06.2016 18:34, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: Module: Mesa Branch: master Commit: 8c361e84ad010552a42593fad4130be

Re: [Mesa-dev] [PATCH 4/4] radeonsi: force non-displayable tiling based on surface dimensions

2016-06-06 Thread Marek Olšák
On Mon, Jun 6, 2016 at 10:58 AM, Michel Dänzer wrote: > On 03.06.2016 19:52, Marek Olšák wrote: >> From: Marek Olšák >> >> Simply ignore the "scanout" flag if the surface dimensions are unlikely >> to be used by DCE. > > I don't like this. > > Ideally, there should be feedback from the display se

Re: [Mesa-dev] Mesa (master): Revert "egl: Check if API is supported when using eglBindAPI."

2016-06-06 Thread Emil Velikov
On 6 June 2016 at 10:10, Michel Dänzer wrote: > On 04.06.2016 00:10, Marek Olšák wrote: >> On Fri, Jun 3, 2016 at 4:33 PM, Dieter Nützel wrote: >>> Am 03.06.2016 11:47, schrieb Michel Dänzer: On 03.06.2016 18:34, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: > > Module: Mesa > Bra

Re: [Mesa-dev] tilers and out-of-order rendering..

2016-06-06 Thread Jose Fonseca
On 04/06/16 20:36, Rob Clark wrote: On Fri, Jun 3, 2016 at 8:53 AM, Rob Clark wrote: Ok, so I had a really evil thought that I wanted to bounce off people.. it's a quite different approach from the more obvious one discussed below (and which I've already started implementing) Basically, idea

Re: [Mesa-dev] Mesa (master): Revert "egl: Check if API is supported when using eglBindAPI."

2016-06-06 Thread Laurent Carlier
Le 06/06/2016 à 11:19, Emil Velikov a écrit : > Fully agree behind that one. > > On the overall topic here is a (related) idea I've had lying around: > - Contact distribution maintainers to patch their glamor packages as > far back as possible. > Having a mesa-maintainers ML or alike might help,

Re: [Mesa-dev] [PATCH 4/4] radeonsi: force non-displayable tiling based on surface dimensions

2016-06-06 Thread Michel Dänzer
On 06.06.2016 18:14, Marek Olšák wrote: > On Mon, Jun 6, 2016 at 10:58 AM, Michel Dänzer wrote: >> On 03.06.2016 19:52, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> Simply ignore the "scanout" flag if the surface dimensions are unlikely >>> to be used by DCE. >> >> I don't like this. >> >> Id

Re: [Mesa-dev] Mesa (master): Revert "egl: Check if API is supported when using eglBindAPI."

2016-06-06 Thread Tapani Pälli
On 06/06/2016 12:19 PM, Emil Velikov wrote: On 6 June 2016 at 10:10, Michel Dänzer wrote: On 04.06.2016 00:10, Marek Olšák wrote: On Fri, Jun 3, 2016 at 4:33 PM, Dieter Nützel wrote: Am 03.06.2016 11:47, schrieb Michel Dänzer: On 03.06.2016 18:34, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote:

Re: [Mesa-dev] [PATCH] gallium/util: remove u_staging

2016-06-06 Thread Jose Fonseca
On 02/06/16 15:15, Rob Clark wrote: From: Rob Clark Unused, and fixes a couple of coverity warnings: CID 1362171, 1362170 Signed-off-by: Rob Clark --- src/gallium/auxiliary/Makefile.sources | 2 - src/gallium/auxiliary/util/u_staging.c | 136 - src/galliu

Re: [Mesa-dev] Mesa (master): Revert "egl: Check if API is supported when using eglBindAPI."

2016-06-06 Thread Marek Olšák
On Mon, Jun 6, 2016 at 11:10 AM, Michel Dänzer wrote: > On 04.06.2016 00:10, Marek Olšák wrote: >> On Fri, Jun 3, 2016 at 4:33 PM, Dieter Nützel wrote: >>> Am 03.06.2016 11:47, schrieb Michel Dänzer: On 03.06.2016 18:34, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: > > Module: Mesa >

Re: [Mesa-dev] [PATCH 4/4] radeonsi: force non-displayable tiling based on surface dimensions

2016-06-06 Thread Axel Davy
On 06/06/2016 11:37, Michel Dänzer wrote : With DRI3, st/dri could (re-)allocate buffers with the scanout flag first and after any window geometry changes, then re-allocate without the flag if the present complete event indicates that page flipping couldn't be used. That sounds like a bad id

Re: [Mesa-dev] [PATCH 4/4] radeonsi: force non-displayable tiling based on surface dimensions

2016-06-06 Thread Michel Dänzer
On 06.06.2016 18:44, Axel Davy wrote: > On 06/06/2016 11:37, Michel Dänzer wrote : >> With DRI3, st/dri could (re-)allocate buffers with the scanout flag >> first and after any window geometry changes, then re-allocate without >> the flag if the present complete event indicates that page flipping >

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread
Hello I would like to keep the number of lines displayed at http://patchwork.freedesktop.org/project/mesa/patches/?submitter=15850 to a low number. 0 is the best, 1 or 2 is meh...ok, 3+ is too much. Seeing 0 lines allows me to move on and start working on the next patch. From my viewpoint, the i

Re: [Mesa-dev] [PATCH 4/4] radeonsi: force non-displayable tiling based on surface dimensions

2016-06-06 Thread Marek Olšák
On Mon, Jun 6, 2016 at 11:47 AM, Michel Dänzer wrote: > On 06.06.2016 18:44, Axel Davy wrote: >> On 06/06/2016 11:37, Michel Dänzer wrote : >>> With DRI3, st/dri could (re-)allocate buffers with the scanout flag >>> first and after any window geometry changes, then re-allocate without >>> the flag

Re: [Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

2016-06-06 Thread Vedran Miletić
On 06/06/2016 02:04 AM, Francisco Jerez wrote: Vedran Miletić writes: Aside from working just like NVIDIA and AMD proprietary stacks, no. However, what we do right now is most certainly broken. Consider the following argument -I"/foo bar/baz" which is going to be sent to Clang as two argume

Re: [Mesa-dev] [PATCH 4/4] radeonsi: force non-displayable tiling based on surface dimensions

2016-06-06 Thread Marek Olšák
On Mon, Jun 6, 2016 at 12:24 PM, Marek Olšák wrote: > On Mon, Jun 6, 2016 at 11:47 AM, Michel Dänzer wrote: >> On 06.06.2016 18:44, Axel Davy wrote: >>> On 06/06/2016 11:37, Michel Dänzer wrote : With DRI3, st/dri could (re-)allocate buffers with the scanout flag first and after any win

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread Timothy Arceri
I'm pretty sure someone told you this already. But you need to remove that symbol and just use your name. Note the symbol also seems to be casing your name to be removed in patchwork. On Mon, 2016-06-06 at 12:11 +0200, ⚛ wrote: > Hello > > I would like to keep the number of lines displayed at > h

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread
On Mon, Jun 6, 2016 at 12:29 PM, Timothy Arceri wrote: > I'm pretty sure someone told you this already. But you need to remove > that symbol and just use your name. Note the symbol also seems to be > casing your name to be removed in patchwork. There's no causal relationship between a name and su

Re: [Mesa-dev] Discussion: C++11 std::future in Mesa

2016-06-06 Thread
On Wed, Jun 1, 2016 at 7:07 PM, Marek Olšák wrote: > On Wed, Jun 1, 2016 at 6:06 PM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: >> On Wed, Jun 1, 2016 at 3:53 PM, Marek Olšák wrote: >>> Because of external factors you can't predict, your driver suddenly >>> receives a bunch of shaders that take 2000 ms

[Mesa-dev] [PATCH v5] clover: Update OpenCL version string to match OpenGL

2016-06-06 Thread Vedran Miletić
Change MESA into Mesa in CL_PLATFORM_VERSION and CL_DEVICE_VERSION. For both, always append git version suffix from git_sha1.h. v5: move semicolon to same line as MESA_GIT_SHA1. v4: drop #ifdef guards. v3: add missing include. v2: change CL_DEVICE_VERSION as well. Reviewed-by: Francisco Jerez --

[Mesa-dev] [RFC] Shall we have mesa-maintainers ? (Was Re: Mesa (master): Revert "egl: Check if API is supported when using eglBindAPI.")

2016-06-06 Thread Emil Velikov
Hi Laurent, On 6 June 2016 at 10:25, Laurent Carlier wrote: > Le 06/06/2016 à 11:19, Emil Velikov a écrit : >> Fully agree behind that one. >> >> On the overall topic here is a (related) idea I've had lying around: >> - Contact distribution maintainers to patch their glamor packages as >> far ba

Re: [Mesa-dev] [PATCH 4/4] radeonsi: force non-displayable tiling based on surface dimensions

2016-06-06 Thread Axel Davy
Le 06/06/2016 12:28, Marek Olšák a écrit : On Mon, Jun 6, 2016 at 12:24 PM, Marek Olšák wrote: On Mon, Jun 6, 2016 at 11:47 AM, Michel Dänzer wrote: On 06.06.2016 18:44, Axel Davy wrote: On 06/06/2016 11:37, Michel Dänzer wrote : With DRI3, st/dri could (re-)allocate buffers with the scanou

Re: [Mesa-dev] Discussion: C++11 std::future in Mesa

2016-06-06 Thread
On Mon, Jun 6, 2016 at 12:40 PM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > I apologize for the confusion. I won't happen again. Typo: "I won't ..." -> "It won't ..." ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailm

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread Emil Velikov
Hi Jan, Fwiw I fully agree on your point on outstanding patches. Now about this patch itself. On 2 June 2016 at 18:41, Jan Ziak (⚛) <0xe2.0x9a.0...@gmail.com> wrote: > LTO compilation can sometimes fail with GCC 4.9 and GCC 5.3 because > src/mapi uses unusual mixing of C code and assembly code.

Re: [Mesa-dev] [PATCH 3/4] scons: rework the git_sha1.h generation rule

2016-06-06 Thread Jose Fonseca
On 30/05/16 13:46, Emil Velikov wrote: From: Emil Velikov Analogous to the previous commit Cc: Brian Paul Cc: Jose Fonseca Signed-off-by: Emil Velikov --- Note: this may cause "false positives" if one extracts the release tarball in another git repository. This is a preexisting bug, which w

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread
On Mon, Jun 6, 2016 at 1:12 PM, Emil Velikov wrote: > > Hi Jan, > > Fwiw I fully agree on your point on outstanding patches. > > Now about this patch itself. > > On 2 June 2016 at 18:41, Jan Ziak (⚛) <0xe2.0x9a.0...@gmail.com> wrote: > > LTO compilation can sometimes fail with GCC 4.9 and GCC 5.3

Re: [Mesa-dev] [PATCH] tgsi: use truncf in micro_trunc

2016-06-06 Thread Lars Hamre
Gentle ping, I would appreciate a Gallium developer's eyes on this. Regards, Lars Hamre On Thu, May 26, 2016 at 6:30 PM, Lars Hamre wrote: > Switches to using truncf in micro_trunc. > > Fixes the following piglit tests (for softpipe): > > /spec/glsl-1.30/execution/built-in-functions/... > fs-tru

[Mesa-dev] [PATCH RESEND v4] glsl: enforce invariant conditions for built-in variables

2016-06-06 Thread Lars Hamre
v2: - ES version check (Tapani Pälli) v3/v4: - compare varying slot locations rather than names (Ilia Mirkin) The conditions for which certain built-in special variables can be declared invariant were not being checked. GLSL ES 1.00 specification, Section "Invariance and linkage" says: For the

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread Mike Lothian
This doesn't seem to affect me using GCC 6.1 and gold On Thu, 2 Jun 2016, 6:42 p.m. Jan Ziak (⚛), <0xe2.0x9a.0...@gmail.com> wrote: > LTO compilation can sometimes fail with GCC 4.9 and GCC 5.3 because > src/mapi uses unusual mixing of C code and assembly code. The issue > may be present in case

Re: [Mesa-dev] [PATCH] glsl: initialise pointer to NULL

2016-06-06 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Sat, 2016-06-04 at 01:09 +0200, Jakob Sinclair wrote: > Could cause issues if you tried to read from an uninitialised pointer. > This just initalises the pointer to null to avoid that being a problem. > Discovered by Coverity. > > CID: 1343616 > > Signed-off-b

Re: [Mesa-dev] [PATCH] tgsi: use truncf in micro_trunc

2016-06-06 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger I suppose we could use a wrapper like for rintf, using sse41 round instructions directly. However, just for softpipe it doesn't sound like it would be worth it, noone is really interested in peformance for softpipe (and noone compiles with sse41 flag anyway). Pushe

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread Emil Velikov
On 6 June 2016 at 13:01, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > On Mon, Jun 6, 2016 at 1:12 PM, Emil Velikov wrote: >> >> Hi Jan, >> >> Fwiw I fully agree on your point on outstanding patches. >> >> Now about this patch itself. >> >> On 2 June 2016 at 18:41, Jan Ziak (⚛) <0xe2.0x9a.0...@gmail.com>

Re: [Mesa-dev] tilers and out-of-order rendering..

2016-06-06 Thread Rob Clark
On Mon, Jun 6, 2016 at 5:19 AM, Jose Fonseca wrote: > On 04/06/16 20:36, Rob Clark wrote: >> >> On Fri, Jun 3, 2016 at 8:53 AM, Rob Clark wrote: >>> >>> Ok, so I had a really evil thought that I wanted to bounce off >>> people.. it's a quite different approach from the more obvious one >>> discu

Re: [Mesa-dev] [PATCH 4/4] radeonsi: force non-displayable tiling based on surface dimensions

2016-06-06 Thread Marek Olšák
Alright, let's drop this patch. I'd still like to push patches 1-3 since they enable DCC for any shared texture without the scanout flag. Marek On Mon, Jun 6, 2016 at 12:47 PM, Axel Davy wrote: > Le 06/06/2016 12:28, Marek Olšák a écrit : >> >> On Mon, Jun 6, 2016 at 12:24 PM, Marek Olšák wrote

Re: [Mesa-dev] [PATCH 3/4] gallium/radeon: add support for sharing textures with DCC between processes

2016-06-06 Thread Nicolai Hähnle
On 03.06.2016 12:52, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 4 src/gallium/drivers/radeon/r600_texture.c | 16 +++--- src/gallium/drivers/radeonsi/si_state.c | 32 ++- 3 files changed, 48 inse

Re: [Mesa-dev] [PATCH] st/mesa: check shader image format support before using PBO download

2016-06-06 Thread Samuel Pitoiset
This fixes the following piglits on nvc0 (tested on GK106, and should work like a charm on Fermi as well): - spec/mesa_pack_invert/mesa_pack_invert-readpixels/PBO unorm BGRA - spec/arb_pixel_buffer_object/fbo-pbo-readpixels-small - spec/arb_pixel_buffer_object/pbo-read-argb - spec/arb_pixel_

Re: [Mesa-dev] Mesa (master): 29 new commits

2016-06-06 Thread Marek Olšák
On Tue, May 10, 2016 at 10:20 AM, Michel Dänzer wrote: > On 10.05.2016 13:00, Nicolai Hähnle wrote: >> On 30.04.2016 05:26, Michel Dänzer wrote: >>> On 28.04.2016 10:54, Michel Dänzer wrote: On 23.04.2016 07:24, Marek Olšák wrote: > On Fri, Apr 22, 2016 at 11:28 PM, Nicolai Hähnle >

Re: [Mesa-dev] [PATCH 5/5] nvc0: add support for VOTE tgsi opcodes

2016-06-06 Thread Samuel Pitoiset
Not surprising that code emission for VOTE was not totally correct because it was first attempt in that area and it was just impossible to test. Assuming that now this thing is correct, this patch is: Reviewed-by: Samuel Pitoiset On 05/29/2016 08:01 PM, Ilia Mirkin wrote: Signed-off-by: Ili

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Enable DCC for X mipmaps and other shared textures

2016-06-06 Thread Nicolai Hähnle
On 03.06.2016 12:52, Marek Olšák wrote: We can save some bandwidth and power with this. It also enables fast clear for some windowed apps on Stoney. If you update radeonsi_dri.so but not restart X while using DRI3, X won't be able to display drawables correctly. (e.g. firefox will display garb

Re: [Mesa-dev] [PATCH 2/4] gallium/radeon: don't discard DCC if an external user can write to it

2016-06-06 Thread Nicolai Hähnle
Patches 1 & 2: Reviewed-by: Nicolai Hähnle On 03.06.2016 12:52, Marek Olšák wrote: From: Marek Olšák We don't import textures with DCC now, but soon we will. --- src/gallium/drivers/radeon/r600_pipe_common.h | 2 +- src/gallium/drivers/radeon/r600_texture.c | 31 +++--

Re: [Mesa-dev] [PATCH] glsl/ast: don't crash when func_name is NULL

2016-06-06 Thread Iago Toral
I guess this makes sense: Reviewed-by: Iago Toral Quiroga From: Dave Airlie > > This fixes a crash in > GL43-CTS.shader_subroutine.subroutines_not_allowed_as_variables_constructors_and_argument_or_return_types > > If we can't find the func_name in one of these paths, > we have emitted an earlie

Re: [Mesa-dev] [PATCH 2/4] gallium/radeon: don't discard DCC if an external user can write to it

2016-06-06 Thread Nicolai Hähnle
On 06.06.2016 16:16, Nicolai Hähnle wrote: Patches 1 & 2: Reviewed-by: Nicolai Hähnle Hold off on patch #2 - how does this work together with shader image writes? Then we're in an ugly situation where the other process could write to DCC, but we still need to decompress while the texture is

Re: [Mesa-dev] [PATCH] st/mesa: check shader image format support before using PBO download

2016-06-06 Thread Ilia Mirkin
AMD folk - can you confirm that this will work with radeonsi? Unfortunately we don't support all RT formats as images in nvc0 right now. On Mon, Jun 6, 2016 at 10:10 AM, Samuel Pitoiset wrote: > This fixes the following piglits on nvc0 (tested on GK106, and should work > like a charm on Fermi as

Re: [Mesa-dev] [PATCH] st/mesa: check shader image format support before using PBO download

2016-06-06 Thread Nicolai Hähnle
Makes sense. Reviewed-by: Nicolai Hähnle On 06.06.2016 00:59, Ilia Mirkin wrote: ARB_shader_image_load_store only requires a very fixed list of formats to be supported, while textures may be in all kinds of formats, like BGRA which are presently not supported on at least Kepler. Signed-off-by

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Enable DCC for X mipmaps and other shared textures

2016-06-06 Thread Marek Olšák
On Mon, Jun 6, 2016 at 4:14 PM, Nicolai Hähnle wrote: > On 03.06.2016 12:52, Marek Olšák wrote: >> >> We can save some bandwidth and power with this. It also enables fast clear >> for some windowed apps on Stoney. >> >> If you update radeonsi_dri.so but not restart X while using DRI3, X won't >> b

Re: [Mesa-dev] [PATCH] glsl: initialise pointer to NULL

2016-06-06 Thread Jakob Sinclair
On 2016-06-06 15:48, Iago Toral wrote: Reviewed-by: Iago Toral Quiroga I don't have push access so I would be very happy if you could push this patch for me. Thanks! -- Mvh Jakob Sinclair On Sat, 2016-06-04 at 01:09 +0200, Jakob Sinclair wrote: Could cause issues if you tried to read fro

[Mesa-dev] [PATCH 2/4] gallium/radeon: don't discard DCC if an external user can write to it

2016-06-06 Thread Marek Olšák
From: Marek Olšák We don't import textures with DCC now, but soon we will. v2: if we can't disable DCC for image writes, at least decompress DCC at bind time --- src/gallium/drivers/radeon/r600_pipe_common.h | 2 +- src/gallium/drivers/radeon/r600_texture.c | 31 +++

Re: [Mesa-dev] [PATCH 2/4] gallium/radeon: don't discard DCC if an external user can write to it

2016-06-06 Thread Bas Nieuwenhuizen
On Mon, Jun 6, 2016 at 4:21 PM, Nicolai Hähnle wrote: > On 06.06.2016 16:16, Nicolai Hähnle wrote: >> >> Patches 1 & 2: >> >> Reviewed-by: Nicolai Hähnle > > > Hold off on patch #2 - how does this work together with shader image writes? > Then we're in an ugly situation where the other process co

Re: [Mesa-dev] [PATCH] radeonsi: Save and restore entire CE RAM.

2016-06-06 Thread Nicolai Hähnle
On 06.06.2016 00:28, Bas Nieuwenhuizen wrote: This fixes a problem with the CE preamble and restoring only stuff in the preamble when needed. To illustrate suppose we have two graphics IB's 1 and 2, which are submitted in that order. Furthermore suppose IB 1 does not use CE ram, but IB 2 does,

[Mesa-dev] [PATCH 3/4] gallium/radeon: add support for sharing textures with DCC between processes

2016-06-06 Thread Marek Olšák
From: Marek Olšák v2: use a function for calculating WORD1 of bo metadata --- src/gallium/drivers/radeon/r600_pipe_common.h | 4 +++ src/gallium/drivers/radeon/r600_texture.c | 16 +--- src/gallium/drivers/radeonsi/si_state.c | 35 ++- 3 files changed,

Re: [Mesa-dev] [PATCH 2/4] gallium/radeon: don't discard DCC if an external user can write to it

2016-06-06 Thread Marek Olšák
On Mon, Jun 6, 2016 at 5:12 PM, Bas Nieuwenhuizen wrote: > On Mon, Jun 6, 2016 at 4:21 PM, Nicolai Hähnle wrote: >> On 06.06.2016 16:16, Nicolai Hähnle wrote: >>> >>> Patches 1 & 2: >>> >>> Reviewed-by: Nicolai Hähnle >> >> >> Hold off on patch #2 - how does this work together with shader image

Re: [Mesa-dev] [PATCH] st/mesa: check shader image format support before using PBO download

2016-06-06 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Jun 6, 2016 at 4:29 PM, Nicolai Hähnle wrote: > Makes sense. > > Reviewed-by: Nicolai Hähnle > > > On 06.06.2016 00:59, Ilia Mirkin wrote: >> >> ARB_shader_image_load_store only requires a very fixed list of formats >> to be supported, while textures may

Re: [Mesa-dev] [PATCH 0/3] R600-GCN: Use hw MSAA resolve for non-trivial resolves

2016-06-06 Thread Nicolai Hähnle
Patches 1 & 3: Reviewed-by: Nicolai Hähnle On 05.06.2016 17:07, Marek Olšák wrote: Hi, The shader-based resolve is slow. With this series, one scene with 8xMSAA in HL2: Lost Coast goes from 8-9 FPS to 32 FPS on Evergreen & Wine/Nine. Please review. Marek __

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-06-06 Thread Brian Paul
On 06/05/2016 12:24 AM, Ilia Mirkin wrote: In the case where we can't guess the base level size, just use the first image's dims. The width0/height0/depth0 on stObj may not have been set at this point. Observed in a trace that set up levels 2..9 of a 2d texture, and set the base level to 2, with

Re: [Mesa-dev] [PATCH] radeonsi: Save and restore entire CE RAM.

2016-06-06 Thread Bas Nieuwenhuizen
On Mon, Jun 6, 2016 at 5:14 PM, Nicolai Hähnle wrote: > On 06.06.2016 00:28, Bas Nieuwenhuizen wrote: >> >> This fixes a problem with the CE preamble and restoring only stuff in the >> preamble when needed. >> >> To illustrate suppose we have two graphics IB's 1 and 2, which are >> submitted in >

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-06-06 Thread Ilia Mirkin
On Mon, Jun 6, 2016 at 11:37 AM, Brian Paul wrote: > On 06/05/2016 12:24 AM, Ilia Mirkin wrote: >> >> In the case where we can't guess the base level size, just use the first >> image's dims. The width0/height0/depth0 on stObj may not have been set >> at this point. Observed in a trace that set up

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-06-06 Thread Brian Paul
On 06/06/2016 10:05 AM, Ilia Mirkin wrote: On Mon, Jun 6, 2016 at 11:37 AM, Brian Paul wrote: On 06/05/2016 12:24 AM, Ilia Mirkin wrote: In the case where we can't guess the base level size, just use the first image's dims. The width0/height0/depth0 on stObj may not have been set at this poin

[Mesa-dev] [Bug 96408] [PERF] SSO: dirty all stages when only one is updated. Trigger extra validations.

2016-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96408 Bug ID: 96408 Summary: [PERF] SSO: dirty all stages when only one is updated. Trigger extra validations. Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread
On Mon, Jun 6, 2016 at 3:39 PM, Mike Lothian wrote: > > This doesn't seem to affect me using GCC 6.1 and gold I don't have GCC 6.1 installed at the moment, and it takes quite long to install it on Gentoo. Can you please send me the output of the following command? $ cd mesa/src/mapi $ make clea

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-06-06 Thread Ilia Mirkin
On Mon, Jun 6, 2016 at 12:52 PM, Brian Paul wrote: > On 06/06/2016 10:05 AM, Ilia Mirkin wrote: >> >> On Mon, Jun 6, 2016 at 11:37 AM, Brian Paul wrote: >>> >>> On 06/05/2016 12:24 AM, Ilia Mirkin wrote: In the case where we can't guess the base level size, just use the first

Re: [Mesa-dev] radeonfb: BAR 0: can't reserve [mem 0x98000000-0x9fffffff pref]

2016-06-06 Thread Marek Olšák
[+ dri-devel] On Mon, Jun 6, 2016 at 8:42 AM, Mathieu Malaterre wrote: > Hi, > > Before reporting a possible invalid bug report. Does anyone knows why > radeaonfb is not configured the same way radeon is ? For instance on a > PowerPC machine, when Open Firmware Frame Buffer is used (OFfb), I > ca

[Mesa-dev] [Bug 96410] [Perf] Pre validate _mesa_sampler_uniforms_pipeline_are_valid like _mesa_sampler_uniforms_are_valid

2016-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96410 Bug ID: 96410 Summary: [Perf] Pre validate _mesa_sampler_uniforms_pipeline_are_valid like _mesa_sampler_uniforms_are_valid Product: Mesa Version: git Ha

Re: [Mesa-dev] radeonfb: BAR 0: can't reserve [mem 0x98000000-0x9fffffff pref]

2016-06-06 Thread Alex Deucher
On Mon, Jun 6, 2016 at 1:16 PM, Marek Olšák wrote: > [+ dri-devel] > > On Mon, Jun 6, 2016 at 8:42 AM, Mathieu Malaterre wrote: >> Hi, >> >> Before reporting a possible invalid bug report. Does anyone knows why >> radeaonfb is not configured the same way radeon is ? For instance on a >> PowerPC m

Re: [Mesa-dev] [PATCH 1/2] glsl: Make opt_copy_propagation actually propagate into loops.

2016-06-06 Thread Matt Turner
Both are Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 4/5] anv/pipeline: Store the (set, binding, index) tripple in the bind map

2016-06-06 Thread Jason Ekstrand
This way the the bind map (which we're caching) is mostly independent of the pipeline layout. The only coupling remaining is that we pull the array size of a binding out of the layout. However, that size is also specified in the shader and should always match so it's not really coupled. This ren

[Mesa-dev] [PATCH 3/5] anv/descriptor_set: Ensure that bindings are always in increasing order

2016-06-06 Thread Jason Ekstrand
Since applications are allowed to specify some set of bindings which need not be dense they also need not be in order. For most things, this doesn't matter, but it could result getting the wrong dynamic offsets. This adds a quick-and-dirty sort to ensure that everything is always in increasing ord

[Mesa-dev] [PATCH 2/5] anv/descriptor_set: Add a type field in debug builds

2016-06-06 Thread Jason Ekstrand
This allows for some extra validation and makes it easier to see what's going on when poking around in gdb. Signed-off-by: Jason Ekstrand Cc: Kristian Høgsberg Kristensen --- src/intel/vulkan/anv_descriptor_set.c | 5 + src/intel/vulkan/anv_private.h| 5 + 2 files changed, 10 in

[Mesa-dev] [PATCH 1/5] anv/descriptor_set: Set array_size to zero for non-existant descriptors

2016-06-06 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: Kristian Høgsberg Kristensen --- src/intel/vulkan/anv_descriptor_set.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index f7a9cb0..3924d04 100644 --- a/src/intel/vulkan/anv_des

[Mesa-dev] [PATCH 5/5] anv/pipeline_cache: Allow for an zero-sized cache

2016-06-06 Thread Jason Ekstrand
This gets ANV_ENABLE_PIPELINE_CACHE=false working again. Signed-off-by: Jason Ekstrand Cc: Kristian Høgsberg Kristensen --- src/intel/vulkan/anv_pipeline_cache.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_pipeline_cache.c b/src/intel/vulkan/anv

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread Mike Lothian
I'm running Gentoo too, it didn't take significantly longer to compile GCC 6.1 than any other version of GCC I use portage to compile mesa On Mon, 6 Jun 2016, 5:58 p.m. ⚛, <0xe2.0x9a.0...@gmail.com> wrote: > On Mon, Jun 6, 2016 at 3:39 PM, Mike Lothian wrote: > > > > This doesn't seem to affect

[Mesa-dev] [Bug 94512] X segfaults with glx-tls enabled in a x32 environment

2016-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94512 --- Comment #7 from EoD --- Created attachment 124376 --> https://bugs.freedesktop.org/attachment.cgi?id=124376&action=edit LD_DEBUG=libs startx (In reply to Emil Velikov from comment #6) > Based of the backtrace there is no information if mes

[Mesa-dev] [PATCH] nv50/ir: use round toward 0 when converting doubles to integers

2016-06-06 Thread Samuel Pitoiset
Like floats, we should use the round toward 0 mode instead of the nearest one (which is the default) for doubles to integers. This fixes all arb_gpu_shader_fp64 piglits which convert doubles to integers (16 tests). Signed-off-by: Samuel Pitoiset Cc: "11.2 12.0" --- src/gallium/drivers/nouveau/

Re: [Mesa-dev] [PATCH 4/5] anv/pipeline: Store the (set, binding, index) tripple in the bind map

2016-06-06 Thread Michael Schellenberger Costa
Hi Jason Am 06/06/2016 um 20:26 schrieb Jason Ekstrand: > This way the the bind map (which we're caching) is mostly independent of double the here > the pipeline layout. The only coupling remaining is that we pull the array > size of a binding out of the layout. However, that size is also specif

Re: [Mesa-dev] [PATCH 3/5] anv/descriptor_set: Ensure that bindings are always in increasing order

2016-06-06 Thread Michael Schellenberger Costa
Hi Jason, Am 06/06/2016 um 20:26 schrieb Jason Ekstrand: > Since applications are allowed to specify some set of bindings which need > not be dense they also need not be in order. That sentence reads strange. "Need not be" sounds like must not. Dont you mean "Do not need to be"? --Michael For

Re: [Mesa-dev] [PATCH] nv50/ir: use round toward 0 when converting doubles to integers

2016-06-06 Thread Ilia Mirkin
On Mon, Jun 6, 2016 at 3:25 PM, Samuel Pitoiset wrote: > Like floats, we should use the round toward 0 mode instead of the > nearest one (which is the default) for doubles to integers. > > This fixes all arb_gpu_shader_fp64 piglits which convert doubles to > integers (16 tests). > > Signed-off-by:

Re: [Mesa-dev] [PATCH 1/2] radeonsi: simplify PRIMGROUP_SIZE computation for tessellation

2016-06-06 Thread Nicolai Hähnle
On 03.06.2016 17:14, Marek Olšák wrote: From: Marek Olšák Ported from Vulkan. --- src/gallium/drivers/radeonsi/si_state_draw.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state

Re: [Mesa-dev] [PATCH] glsl/ast: don't crash when func_name is NULL

2016-06-06 Thread Dave Airlie
On 7 June 2016 at 00:17, Iago Toral wrote: > I guess this makes sense: > Reviewed-by: Iago Toral Quiroga > Out of curiosity, in which case do we get here and can't find a function > name? The test does something illegal earlier, but we keep parsing it, the case we end up here is with id->oper be

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread
On Mon, Jun 6, 2016 at 9:01 PM, Mike Lothian wrote: > > I'm running Gentoo too, it didn't take significantly longer to compile GCC > 6.1 than any other version of GCC > > I use portage to compile mesa Ok. What is the output of a command like: $ ls --sort=time /var/log/portage/media-libs:mesa-*.

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread Mike Lothian
I only have /var/log/portage/elog/ the file(s) you specified don't exist on my system On Mon, 6 Jun 2016 at 21:13 ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > On Mon, Jun 6, 2016 at 9:01 PM, Mike Lothian wrote: > > > > I'm running Gentoo too, it didn't take significantly longer to compile > GCC 6.1 tha

Re: [Mesa-dev] [PATCH 9/9] radeonsi: keep track of dirty descriptor sets

2016-06-06 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Fri, Jun 3, 2016 at 7:01 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Reduces CPU load for draw calls that change none or few of the descriptors. > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 39 > --

[Mesa-dev] [PATCH] radeonsi: Reinitialize all descriptors in CE preamble.

2016-06-06 Thread Bas Nieuwenhuizen
This fixes a problem with the CE preamble and restoring only stuff in the preamble when needed. To illustrate suppose we have two graphics IB's 1 and 2, which are submitted in that order. Furthermore suppose IB 1 does not use CE ram, but IB 2 does, and we have a context switch at the start of IB

[Mesa-dev] [PATCH] st/mesa: use base level size as "guess" when available

2016-06-06 Thread Nicolai Hähnle
From: Nicolai Hähnle When an applications specifies mip levels _before_ setting a mipmap texture filter, we will initially guess a single texture level. When the second level image is created, we try to allocate the full texture -- however, we get the base level size guess wrong if that size is o

[Mesa-dev] [PATCH 2/2] anv/entrypoints: Stop using the C preprocessor

2016-06-06 Thread Jason Ekstrand
Now that we emit guards for everything, we can just generate the files and trust build flags to keep us safe. This should also fix the tarball problems. --- src/intel/vulkan/Makefile.am | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/intel/vulkan/Makefile.a

[Mesa-dev] [PATCH 1/2] anv/entrypoints: Emit #if guards for all platforms

2016-06-06 Thread Jason Ekstrand
--- src/intel/vulkan/anv_entrypoints_gen.py | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 7a47372..546829f 100644 --- a/src/intel/vulkan/anv_entrypoints

Re: [Mesa-dev] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-06-06 Thread Nicolai Hähnle
On 05.06.2016 08:24, Ilia Mirkin wrote: In the case where we can't guess the base level size, just use the first image's dims. The width0/height0/depth0 on stObj may not have been set at this point. Observed in a trace that set up levels 2..9 of a 2d texture, and set the base level to 2, with hei

Re: [Mesa-dev] [PATCH 1/3] docs/devinfo: Add closing paragraph tag

2016-06-06 Thread Ian Romanick
This matches what we've been doing since you reworked the extension string handling. This series is Reviewed-by: Ian Romanick On 06/03/2016 11:04 AM, Nanley Chery wrote: > From: Nanley Chery > > Signed-off-by: Nanley Chery > --- > docs/devinfo.html | 1 + > 1 file changed, 1 insertion(+) >

Re: [Mesa-dev] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-06-06 Thread Ilia Mirkin
On Mon, Jun 6, 2016 at 5:37 PM, Nicolai Hähnle wrote: > On 05.06.2016 08:24, Ilia Mirkin wrote: >> >> In the case where we can't guess the base level size, just use the first >> image's dims. The width0/height0/depth0 on stObj may not have been set >> at this point. Observed in a trace that set up

Re: [Mesa-dev] [PATCH 1/5] mesa: hook up core bits of GL_ARB_shader_group_vote

2016-06-06 Thread Ian Romanick
On 05/29/2016 11:01 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/compiler/glsl/builtin_functions.cpp| 22 > ++ > src/compiler/glsl/glcpp/glcpp-parse.y | 3 +++ > src/compiler/glsl/glsl_parser_extras.cpp | 1 + > src/comp

Re: [Mesa-dev] [PATCH 3/4] gallium/radeon: add support for sharing textures with DCC between processes

2016-06-06 Thread Nicolai Hähnle
Thanks. In the v2 versions, patch 2 & 3 are also Reviewed-by: Nicolai Hähnle On 06.06.2016 17:21, Marek Olšák wrote: From: Marek Olšák v2: use a function for calculating WORD1 of bo metadata --- src/gallium/drivers/radeon/r600_pipe_common.h | 4 +++ src/gallium/drivers/radeon/r600_textur

Re: [Mesa-dev] Mesa (master): Revert "egl: Check if API is supported when using eglBindAPI."

2016-06-06 Thread Ian Romanick
On 06/06/2016 02:10 AM, Michel Dänzer wrote: > On 04.06.2016 00:10, Marek Olšák wrote: >> On Fri, Jun 3, 2016 at 4:33 PM, Dieter Nützel wrote: >>> Am 03.06.2016 11:47, schrieb Michel Dänzer: On 03.06.2016 18:34, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: > > Module: Mesa > Branc

Re: [Mesa-dev] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-06-06 Thread Nicolai Hähnle
On 06.06.2016 23:58, Ilia Mirkin wrote: On Mon, Jun 6, 2016 at 5:37 PM, Nicolai Hähnle wrote: On 05.06.2016 08:24, Ilia Mirkin wrote: In the case where we can't guess the base level size, just use the first image's dims. The width0/height0/depth0 on stObj may not have been set at this point.

Re: [Mesa-dev] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-06-06 Thread Ilia Mirkin
On Mon, Jun 6, 2016 at 6:32 PM, Nicolai Hähnle wrote: > On 06.06.2016 23:58, Ilia Mirkin wrote: >> >> On Mon, Jun 6, 2016 at 5:37 PM, Nicolai Hähnle wrote: >>> >>> On 05.06.2016 08:24, Ilia Mirkin wrote: In the case where we can't guess the base level size, just use the first

  1   2   >