[Mesa-dev] [Bug 93187] Error: ffsll(long long) was previously declared "extern", not "inline".

https://bugs.freedesktop.org/show_bug.cgi?id=93187 Bug ID: 93187 Summary: Error: ffsll(long long) was previously declared "extern", not "inline". Product: Mesa Version: git Hardware: x86 (IA32) OS: Solaris

[Mesa-dev] [Bug 93188] "nir/nir.h", line 552: Error: Unexpected type name "nir_src" encountered.

https://bugs.freedesktop.org/show_bug.cgi?id=93188 Bug ID: 93188 Summary: "nir/nir.h", line 552: Error: Unexpected type name "nir_src" encountered. Product: Mesa Version: git Hardware: x86 (IA32) OS: Solaris

[Mesa-dev] [PATCH v3 02/44] i965: Adjust gen check in can_do_pipelined_register_writes

From: Francisco Jerez Allow for pipelined register writes for gen < 7. v2: * Split from another patch and adjust comment (jljusten) Reviewed-by: Jordan Justen --- src/mesa/drivers/dri/i965/intel_extensions.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/

[Mesa-dev] [PATCH v3 01/44] i965: Define symbolic constants for some useful L3 cache control registers.

From: Francisco Jerez Reviewed-by: Jordan Justen --- src/mesa/drivers/dri/i965/intel_reg.h | 53 +++ 1 file changed, 53 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_reg.h b/src/mesa/drivers/dri/i965/intel_reg.h index a261c2b..0b167d5 100644 --- a/

[Mesa-dev] [PATCH v3 03/44] i965: Keep track of whether LRI is allowed in the context struct.

From: Francisco Jerez This stores the result of can_do_pipelined_register_writes() in the context struct so we can find out later whether LRI can be used to program the L3 configuration. v2: * Split change of gen check in can_do_pipelined_register_writes (jljusten) Reviewed-by: Jordan Justen

[Mesa-dev] [PATCH v3 14/44] i965: Add debug flag to print out the new L3 state during transitions.

From: Francisco Jerez Reviewed-by: Jordan Justen Reviewed-by: Samuel Iglesias Gonsálvez --- src/mesa/drivers/dri/i965/gen7_l3_state.c | 17 + src/mesa/drivers/dri/i965/intel_debug.c | 1 + src/mesa/drivers/dri/i965/intel_debug.h | 1 + 3 files changed, 19 insertions(+) d

[Mesa-dev] [PATCH v3 12/44] i965: Calculate appropriate L3 partition weights for the current pipeline state.

From: Francisco Jerez This calculates a rather conservative partitioning of the L3 cache based on the shaders currently bound to the pipeline and whether they use SLM, atomics, images or scratch space. The result is intended to be fine-tuned later on based on other pipeline state. --- src/mesa/

[Mesa-dev] [PATCH v3 22/44] glsl: Remove mem_ctx as member variable in lower_ubo_reference_visitor

Signed-off-by: Jordan Justen Reviewed-by: Iago Toral Quiroga --- src/glsl/lower_ubo_reference.cpp | 64 +--- 1 file changed, 34 insertions(+), 30 deletions(-) diff --git a/src/glsl/lower_ubo_reference.cpp b/src/glsl/lower_ubo_reference.cpp index 9e569ba..5f58

[Mesa-dev] [PATCH v3 13/44] i965: Implement L3 state atom.

From: Francisco Jerez The L3 state atom calculates the target L3 partition weights when the program bound to some shader stage is modified, and in case they are far enough from the current partitioning it makes sure that the L3 state is re-emitted. v3: Fix for inconsistent units the context URB

[Mesa-dev] [PATCH v3 28/44] i965: Disable vector splitting on shared variables

Signed-off-by: Jordan Justen Reviewed-by: Iago Toral Quiroga --- src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp b/src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp index b7bad29.

[Mesa-dev] [PATCH v3 10/44] i965: Define and use REG_MASK macro to make masked MMIO writes slightly more readable.

From: Francisco Jerez Reviewed-by: Samuel Iglesias Gonsálvez --- src/mesa/drivers/dri/i965/brw_defines.h | 6 ++ src/mesa/drivers/dri/i965/brw_state_upload.c | 2 +- src/mesa/drivers/dri/i965/gen7_l3_state.c| 2 +- src/mesa/drivers/dri/i965/intel_reg.h| 2 +- 4 files change

[Mesa-dev] [PATCH v3 33/44] glsl: Allow atomic functions to be used with shared variables

Signed-off-by: Jordan Justen Reviewed-by: Timothy Arceri Reviewed-by: Iago Toral Quiroga --- src/glsl/ast_function.cpp | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp index 466ece6..da1167a 100644 ---

[Mesa-dev] [PATCH v3 25/44] glsl: Add lowering pass for shared variable references

In this lowering pass, shared variables are decomposed into intrinsic calls. v2: * Send mem_ctx as a parameter (Iago) v3: * Shared variables don't have an associated interface block (Iago) * Always use 430 packing (Iago) * Comment / whitespace cleanup (Iago) Signed-off-by: Jordan Justen Cc:

[Mesa-dev] [PATCH v3 04/44] i965: Define state flag to signal that the URB size has been altered.

From: Francisco Jerez This will make sure that we recalculate the URB layout anytime the URB size is modified by the L3 partitioning code. Reviewed-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.h | 2 ++ src/mesa/drivers/dri/i965/brw_state_upload.c | 1 + src/mesa/drivers/dr

[Mesa-dev] [PATCH v3 09/44] i965/hsw: Enable L3 atomics.

From: Francisco Jerez Improves performance of the arb_shader_image_load_store-atomicity piglit test by over 25x (which isn't a real benchmark it's just heavy on atomics -- the improvement in a microbenchmark I wrote a while ago seemed to be even greater). The drawback is one needs to be extra-ca

[Mesa-dev] [PATCH v3 24/44] glsl: Don't assert on shared variable matrices with 'inherited' layout

From: Iago Toral Quiroga We use column-major for shared variable matrices. Reviewed-by: Jordan Justen --- src/glsl/lower_buffer_access.cpp | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/glsl/lower_buffer_access.cpp b/src/glsl/lower_buffer_access.cpp index 7

[Mesa-dev] [PATCH v3 27/44] nir: Translate glsl shared var store intrinsic to nir intrinsic

Signed-off-by: Jordan Justen Reviewed-by: Iago Toral Quiroga --- src/glsl/nir/glsl_to_nir.cpp | 33 + src/glsl/nir/nir_intrinsics.h | 3 ++- 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cp

[Mesa-dev] [PATCH v3 20/44] glsl ubo/ssbo: Move is_dereferenced_thing_row_major into lower_buffer_access

Signed-off-by: Jordan Justen Reviewed-by: Iago Toral Quiroga --- src/glsl/lower_buffer_access.cpp | 90 src/glsl/lower_buffer_access.h | 2 + src/glsl/lower_ubo_reference.cpp | 90 3 files changed, 92 insertions

[Mesa-dev] [PATCH v3 21/44] glsl ubo/ssbo: Move common code into lower_buffer_access::setup_buffer_access

This code will also be usable by the pass to lower shared variables. Note, that *const_offset is adjusted by setup_buffer_access so it must be initialized before calling setup_buffer_access. v2: * Add comment for lower_buffer_access::setup_buffer_access Signed-off-by: Jordan Justen Reviewed-by

[Mesa-dev] [PATCH v3 40/44] nir: Add nir intrinsics for shared variable atomic operations

v3: * Update min/max based on latest SSBO code (Iago) Signed-off-by: Jordan Justen Cc: Iago Toral Quiroga --- src/glsl/nir/glsl_to_nir.cpp | 67 +++ src/glsl/nir/nir_intrinsics.h | 27 + 2 files changed, 94 insertions(+) diff --git a/sr

[Mesa-dev] [PATCH v3 00/44] Computer shader shared variables

git://people.freedesktop.org/~jljusten/mesa cs-shared-variables-v3 http://patchwork.freedesktop.org/bundle/jljusten/cs-shared-variables-v3 I received lots of good suggestions for v2 of the series, and the patches needed a rebase. Thanks! So far 33 of the 44 patches have a Reviewed-by. The patchwo

[Mesa-dev] [PATCH v3 11/44] i965: Implement selection of the closest L3 configuration based on a vector of weights.

From: Francisco Jerez The input of the L3 set-up code is a vector giving the approximate desired relative size of each partition. This implements logic to compare the input vector against the table of validated configurations for the device and pick the closest compatible one. Reviewed-by: Samu

[Mesa-dev] [PATCH v3 08/44] i965: Implement programming of the L3 configuration.

From: Francisco Jerez --- src/mesa/drivers/dri/i965/gen7_l3_state.c | 95 +++ 1 file changed, 95 insertions(+) diff --git a/src/mesa/drivers/dri/i965/gen7_l3_state.c b/src/mesa/drivers/dri/i965/gen7_l3_state.c index 8765b11..108f3a8 100644 --- a/src/mesa/drivers/dri

[Mesa-dev] [PATCH v3 35/44] glsl: Check for SSBO variable in SSBO atomic lowering

When an atomic function is called, we need to check to see if it is for an SSBO variable before lowering it to the SSBO specific intrinsic function. v2: * is_in_buffer_block => is_in_shader_storage_block (Iago) Signed-off-by: Jordan Justen Reviewed-by: Iago Toral Quiroga --- src/glsl/lower_ub

[Mesa-dev] [PATCH v3 05/44] i965/gen8: Don't add workaround bits to PIPE_CONTROL stalls if DC flush is set.

From: Francisco Jerez According to the hardware docs a DC flush is sufficient to make CS_STALL happy, there's no need to add STALL_AT_SCOREBOARD whenever it's present. Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_pipe_control.c | 4 +++- 1 file changed, 3 insertions(+), 1 del

[Mesa-dev] [PATCH v3 18/44] glsl ubo/ssbo: Split buffer access to insert_buffer_access

This allows the code in emit_access to be generic enough to also be for lowering shared variables. Signed-off-by: Jordan Justen Reviewed-by: Iago Toral Quiroga --- src/glsl/lower_ubo_reference.cpp | 78 ++-- 1 file changed, 43 insertions(+), 35 deletions(-)

[Mesa-dev] [PATCH v3 29/44] i965/fs: Handle nir shared variable load intrinsic

v3: * Remove extra #includes (Iago) * Use recently added GEN7_BTI_SLM instead of BRW_SLM_SURFACE_INDEX (curro) Signed-off-by: Jordan Justen Cc: Iago Toral Quiroga --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 28 1 file changed, 28 insertions(+) diff --git a/src

[Mesa-dev] [PATCH v3 17/44] glsl ubo/ssbo: Use enum to track current buffer access type

v2: * Rename ssbo_get_array_length to ssbo_unsized_array_length_access (Iago) * Use always use this-> when referencing buffer_access_type (Iago) Signed-off-by: Jordan Justen Reviewed-by: Iago Toral Quiroga --- src/glsl/lower_ubo_reference.cpp | 26 +- 1 file changed, 2

[Mesa-dev] [PATCH v3 16/44] i965: Hook up L3 partitioning state atom.

From: Francisco Jerez Reviewed-by: Samuel Iglesias Gonsálvez --- src/mesa/drivers/dri/i965/brw_context.h | 4 ++-- src/mesa/drivers/dri/i965/brw_state_upload.c | 4 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drive

[Mesa-dev] [PATCH v3 38/44] glsl: Buffer atomics are supported for compute shaders

Signed-off-by: Jordan Justen Reviewed-by: Iago Toral Quiroga --- src/glsl/builtin_functions.cpp | 70 +++--- 1 file changed, 38 insertions(+), 32 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 3d7a64f..6810241

[Mesa-dev] [PATCH v3 39/44] glsl: Disable several optimizations on shared variables

Shared variables can be accessed by other threads within the same local workgroup. This prevents us from performing certain optimizations with shared variables. Signed-off-by: Jordan Justen Reviewed-by: Iago Toral Quiroga --- src/glsl/opt_constant_propagation.cpp | 3 ++- src/glsl/opt_constant_

[Mesa-dev] [PATCH v3 15/44] i965: Work around L3 state leaks during context switches.

From: Francisco Jerez This is going to require some rather intrusive kernel changes to fix properly, in the meantime (and forever on at least pre-v4.1 kernels) we'll have to restore the hardware defaults at the end of every batch in which the L3 configuration was changed to avoid interfering with

[Mesa-dev] [PATCH v3 19/44] glsl ubo/ssbo: Add lower_buffer_access class

This class has code that will be shared by lower_ubo_reference and lower_shared_reference. (lower_shared_reference will be used to support compute shader shared variables.) v2: * Add lower_buffer_access.h to makefile (Emil) * Remove static is_dereferenced_thing_row_major from lower_buffer_acc

[Mesa-dev] [PATCH v3 07/44] i965: Import tables enumerating the set of validated L3 configurations.

From: Francisco Jerez It should be possible to use additional L3 configurations other than the ones listed in the tables of validated allocations ("BSpec » 3D-Media-GPGPU Engine » L3 Cache and URB [IVB+] » L3 Cache and URB [*] » L3 Allocation and Programming"), but it seems sensible for now to ha

[Mesa-dev] [PATCH v3 37/44] glsl: Translate atomic intrinsic functions on shared variables

When an intrinsic atomic operation is used on a shared variable, we translate it to a new 'share variable' specific intrinsic function call. For example, add call to __intrinsic_atomic_add when used on a shared variable will be translated to a call to __intrinsic_atomic_add_shared. v3: * Fix sta

[Mesa-dev] [PATCH v3 42/44] i965: Enable ARB_compute_shader extension on supported hardware

Enable ARB_compute_shader on gen7+, on hardware that supports the OpenGL 4.3 requirements of a local group size of 1024. With SIMD16 support, this is limited to Ivy Bridge and Haswell. Broadwell will work with a local group size up to 896 on SIMD16 meaning programs that use this size or lower sho

[Mesa-dev] [PATCH v3 41/44] i965/nir: Implement shared variable atomic operations

v3: * Update based on latest SSBO code (Iago) Signed-off-by: Jordan Justen Cc: Iago Toral Quiroga --- src/mesa/drivers/dri/i965/brw_fs.h | 2 ++ src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 58 2 files changed, 60 insertions(+) diff --git a/src/mesa/drive

[Mesa-dev] [PATCH v3 23/44] glsl: Don't lower_variable_index_to_cond_assign for shared variables

Signed-off-by: Jordan Justen Reviewed-by: Iago Toral Quiroga --- src/glsl/lower_variable_index_to_cond_assign.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/lower_variable_index_to_cond_assign.cpp b/src/glsl/lower_variable_index_to_cond_assign.cpp index 1ab3afe..a1ba934 100

[Mesa-dev] [PATCH v3 44/44] docs: Add ARB_compute_shader to 11.2.0 release notes

Signed-off-by: Jordan Justen Cc: Iago Toral Quiroga --- docs/relnotes/11.2.0.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/11.2.0.html b/docs/relnotes/11.2.0.html index c9c0c90..eb53e81 100644 --- a/docs/relnotes/11.2.0.html +++ b/docs/relnotes/11.2.0.html @@ -45,6 +45,7

[Mesa-dev] [PATCH v3 26/44] nir: Translate glsl shared var load intrinsic to nir intrinsic

Signed-off-by: Jordan Justen Reviewed-by: Iago Toral Quiroga --- src/glsl/nir/glsl_to_nir.cpp | 29 + src/glsl/nir/nir_intrinsics.h | 1 + 2 files changed, 30 insertions(+) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 45d045c..38f9

[Mesa-dev] [PATCH v3 43/44] docs: Mark ARB_compute_shader as done for i965

Signed-off-by: Jordan Justen Reviewed-by: Iago Toral Quiroga --- docs/GL3.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 45da51a..2bfb887 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -152,7 +152,7 @@ GL 4.3, GLSL 4.30: GL_ARB_a

[Mesa-dev] [PATCH v3 30/44] i965/fs: Handle nir shared variable store intrinsic

Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 52 1 file changed, 52 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 12a8b59..6cbb0e2 100644 --- a/src/mesa/drivers

[Mesa-dev] [PATCH v3 36/44] glsl: Check for SSBO variable in check_for_ssbo_store

The compiler probably already blocks this earlier on, but we should be checking for an SSBO here. Signed-off-by: Jordan Justen Reviewed-by: Iago Toral Quiroga --- src/glsl/lower_ubo_reference.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/lower_ubo_reference.cp

[Mesa-dev] [PATCH v3 31/44] i965: Enable shared local memory for CS shared variables

v3: * Check shared variable size at link time Signed-off-by: Jordan Justen Cc: Iago Toral Quiroga --- src/mesa/drivers/dri/i965/brw_cs.c| 13 + src/mesa/drivers/dri/i965/brw_defines.h | 2 ++ src/mesa/drivers/dri/i965/gen7_cs_state.c | 12 3 files changed, 2

[Mesa-dev] [PATCH v3 06/44] i965: Add slice count to the brw_device_info structure.

From: Francisco Jerez Reviewed-by: Samuel Iglesias Gonsálvez --- src/mesa/drivers/dri/i965/brw_device_info.c | 20 src/mesa/drivers/dri/i965/brw_device_info.h | 5 + 2 files changed, 25 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_device_info.c b/src/mesa

[Mesa-dev] [PATCH v3 34/44] glsl: Replace atomic_ssbo and ssbo_atomic with atomic

The atomic functions can also be used with shared variables in compute shaders. When lowering the intrinsic in lower_ubo_reference, we still create an SSBO specific intrinsic since SSBO accesses can be indirectly addressed, whereas all compute shader shared variable live in a single shared variabl

[Mesa-dev] [PATCH v3 32/44] i965: Lower shared variable references to intrinsic calls

Signed-off-by: Jordan Justen Reviewed-by: Iago Toral Quiroga --- src/mesa/drivers/dri/i965/brw_shader.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp index 5a6752b..7a6751b 100644 --- a/src/mesa/drive

[Mesa-dev] [Bug 93189] "./util/u_inlines.h", line 83: operands have incompatible types: void ":" int

https://bugs.freedesktop.org/show_bug.cgi?id=93189 Bug ID: 93189 Summary: "./util/u_inlines.h", line 83: operands have incompatible types: void ":" int Product: Mesa Version: git Hardware: x86 (IA32) OS: Sol

[Mesa-dev] [Bug 93188] "nir/nir.h", line 552: Error: Unexpected type name "nir_src" encountered.

https://bugs.freedesktop.org/show_bug.cgi?id=93188 --- Comment #1 from Alan Coopersmith --- The Studio C++ compiler does not support C99 compound literals - when I raised this to the Studio C++ team they said: > This: > (nir_src) { init } > > is a C99 feature called "compound literals", which

[Mesa-dev] [Bug 93189] "./util/u_inlines.h", line 83: operands have incompatible types: void ":" int

https://bugs.freedesktop.org/show_bug.cgi?id=93189 --- Comment #1 from Alan Coopersmith --- Mesa cannot be built with non-gcc compilers, no matter how many bugs you cc me on. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. __

Re: [Mesa-dev] [PATCH 0/2] Improve emitted code for copies of large buffer-backed variables

Series Reviewed-by: Jordan Justen On 2015-11-23 04:53:07, Iago Toral Quiroga wrote: > Fixes linking issues when copying large variables backed by buffers (ubos, > ssbos, etc). > In these cases, lower_ubo_reference would split the rhs into loads for all > the elements > first and then the lhs i

Re: [Mesa-dev] [PATCH 08/53] r600: add SET_NULL_SHADER macro.

On Mon, Nov 30, 2015 at 8:20 AM, Dave Airlie wrote: > From: Dave Airlie > > This is used to set a hw shader to NULL. > > Signed-off-by: Dave Airlie > --- > src/gallium/drivers/r600/r600_state_common.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/

Re: [Mesa-dev] [PATCH 07/53] r600: move clip misc and streamout stream updates to a single place

On Mon, Nov 30, 2015 at 8:20 AM, Dave Airlie wrote: > From: Dave Airlie > > This will be updated in a macro later. > > Signed-off-by: Dave Airlie > --- > src/gallium/drivers/r600/r600_state_common.c | 17 +++-- > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/src/

Re: [Mesa-dev] [PATCH 09/53] r600: use macros for updating the various stages.

On Mon, Nov 30, 2015 at 8:20 AM, Dave Airlie wrote: > From: Dave Airlie > > These macros will make things easier to see when tess > is added to the mix. > > Signed-off-by: Dave Airlie > --- > src/gallium/drivers/r600/r600_state_common.c | 40 > +--- > 1 file changed, 25

Re: [Mesa-dev] [Mesa-stable] [PATCH] clover: Check the return value of pipe_loader_probe() when probing for devices v2

Tom Stellard writes: > When probing for devices, clover will call pipe_loader_probe() twice. > The first time to retrieve the number of devices, and then second time > to retrieve the device structures. > > We currently assume that the return value of both calls will be the > same, but this will

Re: [Mesa-dev] [PATCH 34/53] r600/eg: workaround bug with tess shader and dynamic GPRs.

Did the alternative workaround (reserving one SIMD as PS only) not work? Marek On Mon, Nov 30, 2015 at 7:20 AM, Dave Airlie wrote: > From: Dave Airlie > > When using tessellation on eg/ni chipsets, we must disable > dynamic GPRs to workaround a hw bug where the GPU hangs > when too many things

Re: [Mesa-dev] [PATCH 2/2] i965: Do dead-code elimination in a single pass.

Matt Turner writes: > The first pass marked dead instructions as opcode = NOP, and a second > pass deleted those instructions so that the live ranges used in the > first pass wouldn't change. > > But since we're walking the instructions in reverse order, we can just > do everything in one pass. T

Re: [Mesa-dev] [RFC] r600g: evergreen/cayman tessellation support

On Mon, Nov 30, 2015 at 11:06 PM, Dave Airlie wrote: > On 30 November 2015 at 19:51, Marek Olšák wrote: >> On Mon, Nov 30, 2015 at 7:20 AM, Dave Airlie wrote: >>> Hi, >>> >>> Patchbomb time, this set of patches is a first pass at add adding >>> ARB_tessellation_shader support to the r600g driver

Re: [Mesa-dev] [PATCH 2/2] r600: SMX returns CONTEXT_DONE early workaround

For the series: Reviewed-by: Marek Olšák Marek On Tue, Dec 1, 2015 at 4:16 AM, Dave Airlie wrote: > From: Dave Airlie > > streamout, gs rings bug on certain r600s, requires a wait idle > before each surface sync. > > Signed-off-by: Dave Airlie > --- > src/gallium/drivers/r600/r600_pipe.h

Re: [Mesa-dev] [PATCH] glsl: always re-validate program pipeline

On 12/01/2015 02:13 AM, Timothy Arceri wrote: Just because the validation passed the last time is was called doesn't automatically mean it will pass again the next time its called. This is a rather large hammer though :/ Maybe we should look at invalidating the pipeline when samplers are chang

Re: [Mesa-dev] [PATCH v3 25/44] glsl: Add lowering pass for shared variable references

On Tue, 2015-12-01 at 00:19 -0800, Jordan Justen wrote: > In this lowering pass, shared variables are decomposed into intrinsic > calls. > > v2: > * Send mem_ctx as a parameter (Iago) > > v3: > * Shared variables don't have an associated interface block (Iago) > * Always use 430 packing (Iago)

Re: [Mesa-dev] [PATCH v3 29/44] i965/fs: Handle nir shared variable load intrinsic

Reviewed-by: Iago Toral Quiroga On Tue, 2015-12-01 at 00:19 -0800, Jordan Justen wrote: > v3: > * Remove extra #includes (Iago) > * Use recently added GEN7_BTI_SLM instead of BRW_SLM_SURFACE_INDEX (curro) > > Signed-off-by: Jordan Justen > Cc: Iago Toral Quiroga > --- > src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH v3 31/44] i965: Enable shared local memory for CS shared variables

Reviewed-by: Iago Toral Quiroga On Tue, 2015-12-01 at 00:19 -0800, Jordan Justen wrote: > v3: > * Check shared variable size at link time > > Signed-off-by: Jordan Justen > Cc: Iago Toral Quiroga > --- > src/mesa/drivers/dri/i965/brw_cs.c| 13 + > src/mesa/drivers/dri/i96

Re: [Mesa-dev] [PATCH v3 37/44] glsl: Translate atomic intrinsic functions on shared variables

On Tue, 2015-12-01 at 00:19 -0800, Jordan Justen wrote: > When an intrinsic atomic operation is used on a shared variable, we > translate it to a new 'share variable' specific intrinsic function 'shared variable' > call. > > For example, add call to __intrinsic_atomic_add when used on a shared

Re: [Mesa-dev] [PATCH v3 40/44] nir: Add nir intrinsics for shared variable atomic operations

Reviewed-by: Iago Toral Quiroga On Tue, 2015-12-01 at 00:19 -0800, Jordan Justen wrote: > v3: > * Update min/max based on latest SSBO code (Iago) > > Signed-off-by: Jordan Justen > Cc: Iago Toral Quiroga > --- > src/glsl/nir/glsl_to_nir.cpp | 67 > ++

Re: [Mesa-dev] question on GL_RED and gles

On Wed, 25 Nov 2015 15:24:07 + Julien Isorce wrote: > Hi, > > In EXT_texture_rg.txt it is mentioned of GL_RED_EXT on gles 2.0. > > In glformats.c::_mesa_es_error_check_format_and_type returns > GL_INVALID_VALUE if GL_RED_EXT(as it reaches default case) > so glTexImage2D(..., GL_RED_EXT, G

Re: [Mesa-dev] [PATCH v3 41/44] i965/nir: Implement shared variable atomic operations

Reviewed-by: Iago Toral Quiroga On Tue, 2015-12-01 at 00:19 -0800, Jordan Justen wrote: > v3: > * Update based on latest SSBO code (Iago) > > Signed-off-by: Jordan Justen > Cc: Iago Toral Quiroga > --- > src/mesa/drivers/dri/i965/brw_fs.h | 2 ++ > src/mesa/drivers/dri/i965/brw_fs_nir

Re: [Mesa-dev] [PATCH v3 44/44] docs: Add ARB_compute_shader to 11.2.0 release notes

Reviewed-by: Iago Toral Quiroga On Tue, 2015-12-01 at 00:20 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > Cc: Iago Toral Quiroga > --- > docs/relnotes/11.2.0.html | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/docs/relnotes/11.2.0.html b/docs/relnotes/11.2.0.html > in

Re: [Mesa-dev] [PATCH v3 30/44] i965/fs: Handle nir shared variable store intrinsic

On Tue, 2015-12-01 at 00:19 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 52 > > 1 file changed, 52 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp > b/src/mesa/drivers/dri

Re: [Mesa-dev] question on GL_RED and gles

Hi; On 11/25/2015 05:24 PM, Julien Isorce wrote: Hi, In EXT_texture_rg.txt it is mentioned of GL_RED_EXT on gles 2.0. In glformats.c::_mesa_es_error_check_format_and_type returns GL_INVALID_VALUE if GL_RED_EXT(as it reaches default case) so glTexImage2D(..., GL_RED_EXT, GL_UNSIGNED_BYTE, d

Re: [Mesa-dev] question on GL_RED and gles

On 1 December 2015 at 13:08, Tapani Pälli wrote: > Which version of Mesa are you using to test this? Ilia fixed this bug: > > https://bugs.freedesktop.org/show_bug.cgi?id=93126 > > which I believe should fix this issue, fix is available in current master > and Mesa 11.1. > > Hi, It is me that ope

Re: [Mesa-dev] question on GL_RED and gles

On 12/01/2015 03:10 PM, Julien Isorce wrote: On 1 December 2015 at 13:08, Tapani Pälli > wrote: Which version of Mesa are you using to test this? Ilia fixed this bug: https://bugs.freedesktop.org/show_bug.cgi?id=93126 which I believe should fix this

Re: [Mesa-dev] [PATCH v3 08/44] i965: Implement programming of the L3 configuration.

Reviewed-by: Samuel Iglesias Gonsálvez On 01/12/15 09:19, Jordan Justen wrote: > From: Francisco Jerez > > --- > src/mesa/drivers/dri/i965/gen7_l3_state.c | 95 > +++ > 1 file changed, 95 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/gen7_l3_state.c >

Re: [Mesa-dev] [PATCH v3 12/44] i965: Calculate appropriate L3 partition weights for the current pipeline state.

Reviewed-by: Samuel Iglesias Gonsálvez On 01/12/15 09:19, Jordan Justen wrote: > From: Francisco Jerez > > This calculates a rather conservative partitioning of the L3 cache > based on the shaders currently bound to the pipeline and whether they > use SLM, atomics, images or scratch space. The

Re: [Mesa-dev] [PATCH v2] gallium/tests: fix build with clang compiler

On Sunday 29 November 2015 15:23:37 Samuel Pitoiset wrote: > Nested functions are supported as an extension in GNU C, but Clang > don't support them. > > This fixes compilation errors when (manually) building compute.c, > or by setting --enable-gallium-tests to the configure script. > > Changes f

Re: [Mesa-dev] [PATCH v3 13/44] i965: Implement L3 state atom.

Reviewed-by: Samuel Iglesias Gonsálvez On 01/12/15 09:19, Jordan Justen wrote: > From: Francisco Jerez > > The L3 state atom calculates the target L3 partition weights when the > program bound to some shader stage is modified, and in case they are > far enough from the current partitioning it m

Re: [Mesa-dev] [PATCH 1/5] i965/meta-fast-clear: Disable GL_FRAMEBUFFER_SRGB during clear

On Wed, Nov 25, 2015 at 06:36:35PM +0100, Neil Roberts wrote: > Adds MESA_META_FRAMEBUFFER_SRGB to the meta save state so that > GL_FRAMEBUFFER_SRGB will be disabled when performing the fast clear. > That way the render surface state will be programmed with the linear > equivalent format during the

Re: [Mesa-dev] [PATCH v2] gallium/tests: fix build with clang compiler

On 12/01/2015 02:44 PM, Serge Martin wrote: On Sunday 29 November 2015 15:23:37 Samuel Pitoiset wrote: Nested functions are supported as an extension in GNU C, but Clang don't support them. This fixes compilation errors when (manually) building compute.c, or by setting --enable-gallium-tests

Re: [Mesa-dev] [PATCH v2 3/6] glsl: add support for GL_OES_geometry_shader

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Ilia Mirkin > Sent: Friday, November 27, 2015 8:16 PM > To: Emil Velikov > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v2 3/6] glsl: add support for > GL_OES_geomet

Re: [Mesa-dev] [PATCH v2 3/6] glsl: add support for GL_OES_geometry_shader

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Ian Romanick > Sent: Monday, November 30, 2015 8:48 PM > To: Marta Lofstedt; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v2 3/6] glsl: add support for > GL_OES_geometry_s

[Mesa-dev] [PATCH v3] glsl: add support for GL_OES_geometry_shader

From: Marta Lofstedt This adds glsl support of GL_OES_geometry_shader for OpenGL ES 3.1. Signed-off-by: Marta Lofstedt --- src/glsl/builtin_variables.cpp | 25 + src/glsl/glsl_parser.yy | 4 ++-- src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_ext

Re: [Mesa-dev] [PATCH v3] glsl: add support for GL_OES_geometry_shader

Doesn't strictly have to be in this patch, but you also need to modify if (state->is_version(400, 0) || state->ARB_gpu_shader5_enable) add_system_value(SYSTEM_VALUE_INVOCATION_ID, int_t, "gl_InvocationID"); and the invocations layout qualifier, as I believe that OES_geometry_shader inclu

Re: [Mesa-dev] [PATCH v3] glsl: add support for GL_OES_geometry_shader

> -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Tuesday, December 1, 2015 4:15 PM > To: Marta Lofstedt > Cc: mesa-dev@lists.freedesktop.org; Romanick, Ian D; Emil Velikov; Lofstedt, > Marta > Subject: Re: [PATCH v3] glsl: add

Re: [Mesa-dev] [PATCH v2 4/6] mesa: enable enums for OES_geometry_shader

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Ilia Mirkin > Sent: Friday, November 27, 2015 7:08 PM > To: Marta Lofstedt > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v2 4/6] mesa: enable enums for > OES_geomet

[Mesa-dev] [PATCH v3] mesa: enable enums for OES_geometry_shader

From: Marta Lofstedt Enable GL_OES_geometry_shader enums for OpenGL ES 3.1. Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 64 ++-- src/mesa/main/get_hash_params.py | 53 +++-- 2 files changed, 86 insertions(

[Mesa-dev] [Bug 93189] "./util/u_inlines.h", line 83: operands have incompatible types: void ":" int

https://bugs.freedesktop.org/show_bug.cgi?id=93189 Jose Fonseca changed: What|Removed |Added CC||jfons...@vmware.com --- Comment #2 from J

Re: [Mesa-dev] [PATCH v2 5/6] mesa: Update _mesa_has_geometry_shaders

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Friday, November 27, 2015 4:19 PM > To: Marta Lofstedt > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH v2 5/6] mesa: Update > _mesa_has_geometry_shaders > > On 27

[Mesa-dev] [PATCH v3] mesa: Update _mesa_has_geometry_shaders

From: Marta Lofstedt Updates the _mesa_has_geometry_shaders function to also look for OpenGL ES 3.1 contexts that has OES_geometry_shader enabled. --- src/mesa/main/context.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h i

Re: [Mesa-dev] [PATCH v3] mesa: enable enums for OES_geometry_shader

On Tue, Dec 1, 2015 at 10:37 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > Enable GL_OES_geometry_shader enums for OpenGL ES 3.1. > > Signed-off-by: Marta Lofstedt > --- > src/mesa/main/get.c | 64 > ++-- > src/mesa/main/get_hash_params.p

Re: [Mesa-dev] [PATCH v2 5/6] mesa: Update _mesa_has_geometry_shaders

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Lofstedt, Marta > Sent: Tuesday, December 1, 2015 4:48 PM > To: Emil Velikov; Marta Lofstedt > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH v2 5/6] mesa: Update > _mesa_has_geometry_shad

[Mesa-dev] [Bug 93189] "./util/u_inlines.h", line 83: operands have incompatible types: void ":" int

https://bugs.freedesktop.org/show_bug.cgi?id=93189 --- Comment #4 from Alan Coopersmith --- (In reply to Jose Fonseca from comment #2) > Anybody knows a reliable way to detect Solaris CC on configure.ac? Whoops, missed this part. It's easy - autoconf will set $GCC to "no". A more definitive wa

[Mesa-dev] [Bug 93189] "./util/u_inlines.h", line 83: operands have incompatible types: void ":" int

https://bugs.freedesktop.org/show_bug.cgi?id=93189 --- Comment #3 from Alan Coopersmith --- There was interest in the past, but trying to keep up is too hard and the benefit too small, so we've just given up and build Mesa with gcc now. -- You are receiving this mail because: You are the QA Con

Re: [Mesa-dev] [PATCH v3] mesa: enable enums for OES_geometry_shader

> -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Tuesday, December 1, 2015 4:53 PM > To: Marta Lofstedt > Cc: mesa-dev@lists.freedesktop.org; Lofstedt, Marta > Subject: Re: [PATCH v3] mesa: enable enums for OES_geometry_shader

Re: [Mesa-dev] [PATCH v3] mesa: enable enums for OES_geometry_shader

On Tue, Dec 1, 2015 at 11:24 AM, Lofstedt, Marta wrote: >> > +static const int extra_ARB_viewport_array_or_geometry_shader[] = { >> > + EXT(ARB_viewport_array), >> > + EXT(OES_geometry_shader), >> > + EXTRA_END >> > +}; >> >> This won't do what you want... unless drivers only ever set >> OES

Re: [Mesa-dev] [PATCH v2 5/6] mesa: Update _mesa_has_geometry_shaders

On 1 December 2015 at 16:03, Lofstedt, Marta wrote: >> > > - return _mesa_is_desktop_gl(ctx) && ctx->Version >= 32; >> > > + return (_mesa_is_gles31(ctx) && >> > > + ctx->Extensions.OES_geometry_shader) || >> > >> > Please use the new _mesa_has_##name_str helpers from Nanley. They >> > alread

Re: [Mesa-dev] [PATCH 3/5] i965/gen9: Resolve SRGB color buffers when GL_FRAMEBUFFER_SRGB enabled

On Wed, Nov 25, 2015 at 06:36:37PM +0100, Neil Roberts wrote: > SKL can't cope with the CCS buffer for SRGB buffers. Normally the > hardware won't see the SRGB formats because when GL_FRAMEBUFFER_SRGB > is disabled these get mapped to their linear equivalents. In order to > avoid relying on the CCS

Re: [Mesa-dev] [Mesa-stable] [PATCH] automake: fix some occurrences of hardcoded -ldl and -lpthread

On 23 November 2015 at 03:22, Jonathan Gray wrote: > Correct some occurrences of -ldl and -lpthread to use > $(DLOPEN_LIBS) and $(PTHREAD_LIBS) respectively. > > Signed-off-by: Jonathan Gray > Cc: "11.0 11.1" > --- > src/gallium/targets/opencl/Makefile.am | 2 +- > src/mesa/drivers/dri/i965/Mak

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure.ac: use pkg-config for libelf

Hi Jonathan, On 23 November 2015 at 03:24, Jonathan Gray wrote: > Use PKG_CHECK_MODULES to get the flags to link libelf. > > Signed-off-by: Jonathan Gray > Cc: "11.0 11.1" > --- > configure.ac | 4 +--- > src/gallium/drivers/radeon/Makefile.am | 2 +- > src/gallium/ta

Re: [Mesa-dev] [PATCH] clover: Check the return value of pipe_loader_probe() when probing for devices v2

On 30 November 2015 at 17:50, Tom Stellard wrote: > When probing for devices, clover will call pipe_loader_probe() twice. > The first time to retrieve the number of devices, and then second time > to retrieve the device structures. > > We currently assume that the return value of both calls will b

Re: [Mesa-dev] [PATCH 0/3] misc janitorial

On 30 November 2015 at 22:06, Dave Airlie wrote: > On 1 December 2015 at 07:18, Emil Velikov wrote: >> On 30 November 2015 at 20:00, Ian Romanick wrote: >>> On 11/29/2015 07:21 AM, Emil Velikov wrote: Hi Giuseppe, On 28 November 2015 at 15:43, Giuseppe Bilotta wrote: > T

  1   2   >