On 1 December 2015 at 16:03, Lofstedt, Marta <marta.lofst...@intel.com> wrote:
>> > > - return _mesa_is_desktop_gl(ctx) && ctx->Version >= 32; >> > > + return (_mesa_is_gles31(ctx) && >> > > + ctx->Extensions.OES_geometry_shader) || >> > >> > Please use the new _mesa_has_##name_str helpers from Nanley. They >> > already have the appropriate API and version check - >> > _mesa_has_OES_geometry_shader is what we want here. >> > >> Oh, that's a cool new feature. >> I'll send up a V3. >> Unfortunately I have problem getting the name_str helper to work and I am >> not entirely sure if it is for all gles context or only because I am on gles >> version override. I will send up a patch for this where we can discuss >> further. >> > Hi Nanley, > > I can't seem to get you ##name_str helper to work. I was planning to send up > a patch changing ctx->Extension.Version to ctx->Version in the helper, > because that works. But then I noticed that you had ctx->Version before you > added the ctx->Extension.Version. So, now I am not sure how to use your nice > feature. > The only possible issue I can see is: ctx->Extensions.Version vs ctx->Version. I believe Nanley added the one in Extensions as a workaround for meta. So I'm assuming that either it isn't getting set/restored properly or the helper is using the wrong one ? Just a food for thought. -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
