Re: [Mesa-dev] [PATCH 06/11] st/mesa: add atomic buffer support

2015-09-27 Thread Kai Wasserbäch
Ilia Mirkin wrote on 27.09.2015 08:33: > Signed-off-by: Ilia Mirkin > --- > src/mesa/Makefile.sources| 1 + > src/mesa/program/ir_to_mesa.cpp | 4 +- > src/mesa/state_tracker/st_atom.c | 5 + > src/mesa/state_tracker/st_atom.h | 5 +

Re: [Mesa-dev] [PATCH 06/11] st/mesa: add atomic buffer support

2015-09-27 Thread Ilia Mirkin
On Sun, Sep 27, 2015 at 3:20 AM, Kai Wasserbäch wrote: > Ilia Mirkin wrote on 27.09.2015 08:33: >> Signed-off-by: Ilia Mirkin >> --- >> src/mesa/Makefile.sources| 1 + >> src/mesa/program/ir_to_mesa.cpp | 4 +- >> src/mesa/state_tracker/st_atom.c

[Mesa-dev] [Bug 92137] [regression, bisected] piglit arb_separate_shader_objects.validateprogrampipeline fails

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92137 Bug ID: 92137 Summary: [regression, bisected] piglit arb_separate_shader_objects.validateprogrampipeline fails Product: Mesa Version: git Hardware: Othe

[Mesa-dev] [Bug 92138] Configuratin define "HAVE_LIBDRM" must not used in installed header

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92138 Bug ID: 92138 Summary: Configuratin define "HAVE_LIBDRM" must not used in installed header Product: Mesa Version: 11.0 Hardware: Other OS: All S

Re: [Mesa-dev] [PATCH 2/2] egl/dri2: don't require a context for ClientWaitSync

2015-09-27 Thread Albert Freeman
On 25 September 2015 at 23:49, Marek Olšák wrote: > From: Marek Olšák > > The spec doesn't require it. This fixes a crash on Android. > > Cc: 10.6 11.0 > --- > src/egl/drivers/dri2/egl_dri2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/egl/drivers/dri2/egl_dri2.

Re: [Mesa-dev] Pending issues of lollipop-x86

2015-09-27 Thread Albert Freeman
On 27 September 2015 at 03:21, Mauro Rossi wrote: > Hi, > > Marek's patches solved Camera and Youtube crashes on nouveau and radeonsi. > I'm available to test on i965, if needed > > I think at this point the remaining major problem for lollipop-x86 is the > font artifacts/invisible chars on i965GM

[Mesa-dev] [Bug 92138] Configuratin define "HAVE_LIBDRM" must not used in installed header

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92138 --- Comment #1 from Albert Freeman --- Where in particular is this an issue? Can't such software #define or #undef HAVE_DRM as required before including the header (and perhaps revert HAVE_DRM to the state it was in originally)? -- You are rece

[Mesa-dev] [Bug 92138] Configuratin define "HAVE_LIBDRM" must not used in installed header

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92138 --- Comment #2 from Albert Freeman --- Oops, I meant HAVE_LIBDRM -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ mesa-dev mailing list

[Mesa-dev] [Bug 92138] Configuratin define "HAVE_LIBDRM" must not used in installed header

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92138 --- Comment #3 from OBATA Akio --- It's xorg-server/glx/glxdri2.c. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ mesa-dev mailing li

[Mesa-dev] [Bug 92138] Configuratin define "HAVE_LIBDRM" must not used in installed header

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92138 --- Comment #4 from Albert Freeman --- (In reply to OBATA Akio from comment #3) > It's xorg-server/glx/glxdri2.c. Oh -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

[Mesa-dev] [PATCH] clover: clGetExtensionFunctionAddressForPlatform

2015-09-27 Thread Serge Martin
add clGetExtensionFunctionAddressForPlatform (CL 1.2) --- src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- src/gallium/state_trackers/clover/api/dispatch.hpp | 4 src/gallium/state_trackers/clover/api/platform.cpp | 16 3 files changed, 21 insertions(+), 1 deletio

[Mesa-dev] [PATCH] docs/GL3.txt: fix typo

2015-09-27 Thread Boyan Ding
Signed-off-by: Boyan Ding --- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index bd44d12..ed6a98d 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -237,7 +237,7 @@ GLES3.2, GLSL ES 3.2 GL_KHR_texture_compression_astc_ldr

[Mesa-dev] [PATCH] vc4: use nir two-sided-color lowering

2015-09-27 Thread Boyan Ding
Similar to 9ffc1049ca (freedreno/ir3: use nir two-sided-color lowering). No piglit regression. Signed-off-by: Boyan Ding --- src/gallium/drivers/vc4/vc4_context.h | 1 - src/gallium/drivers/vc4/vc4_program.c | 25 ++--- 2 files changed, 2 insertions(+), 24 deletions(-) diff

Re: [Mesa-dev] [PATCH] docs/GL3.txt: fix typo

2015-09-27 Thread Albert Freeman
On 27 September 2015 at 09:15, Boyan Ding wrote: > Signed-off-by: Boyan Ding > --- > docs/GL3.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/GL3.txt b/docs/GL3.txt > index bd44d12..ed6a98d 100644 > --- a/docs/GL3.txt > +++ b/docs/GL3.txt > @@ -237,7 +237,7 @@ G

[Mesa-dev] [Bug 92138] Configuratin define "HAVE_LIBDRM" must not used in installed header

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92138 --- Comment #5 from Emil Velikov --- Hi OBATA, Can you give a specific example (failing config/build log, platform info) of the issue. I recall giving the last 4 xserver branches a try and did not notice anything wrong. -- You are receiving th

[Mesa-dev] [Bug 92138] Configuratin define "HAVE_LIBDRM" must not used in installed header

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92138 --- Comment #6 from Albert Freeman --- I can not reproduce this. Which platform and which version of the X server? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___

[Mesa-dev] [Bug 92138] Configuratin define "HAVE_LIBDRM" must not used in installed header

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92138 --- Comment #7 from OBATA Akio --- Maybe, depend on compiler (I'm using gcc-4.5.3). related changes in GCC? https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=ce3765bf44e49ef0568a1ad4a0b7f807591d6412 -- You are receiving this mail because: You a

[Mesa-dev] [Bug 92138] Configuratin define "HAVE_LIBDRM" must not used in installed header

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92138 --- Comment #8 from Albert Freeman --- Which binutils? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@

Re: [Mesa-dev] [PATCH] gallium/util: avoid unreferencing random memory on buffer alloc failure

2015-09-27 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sat, Sep 26, 2015 at 7:46 PM, Ilia Mirkin wrote: > Found by Coverity > > Signed-off-by: Ilia Mirkin > --- > src/gallium/auxiliary/util/u_blitter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/auxiliary/util/u_blitter.c

[Mesa-dev] [Bug 92138] Configuratin define "HAVE_LIBDRM" must not used in installed header

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92138 --- Comment #9 from OBATA Akio --- With gcc-4.6 and later, you can reproduce such error with "-pedantic-errors". -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. _

[Mesa-dev] [Bug 92138] Configuratin define "HAVE_LIBDRM" must not used in installed header

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92138 --- Comment #10 from Albert Freeman --- nah, I want to build gcc anyway -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ mesa-dev maili

Re: [Mesa-dev] [PATCH 02/11] ureg: add buffer support to ureg

2015-09-27 Thread Marek Olšák
On Sun, Sep 27, 2015 at 8:33 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/gallium/auxiliary/tgsi/tgsi_strings.c | 3 ++- > src/gallium/auxiliary/tgsi/tgsi_ureg.c | 27 +++ > src/gallium/auxiliary/tgsi/tgsi_ureg.h | 3 +++ > src/gallium/includ

[Mesa-dev] [PATCH] configure.ac: handle llvm built with cmake in one shared library.

2015-09-27 Thread Laurent Carlier
llvm can be built with cmake in a libray with the name libLLVM.so.$version Signed-off-by: Laurent Carlier --- configure.ac | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 217281f..361ffba 100644 --- a/configure.ac +++ b/co

[Mesa-dev] [Bug 91596] EGL_KHR_gl_colorspace (v2) causes problem with Android-x86 GUI

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91596 --- Comment #5 from Mauro Rossi --- Hi Makek, I have performed test by disabling EGL_KHR_gl_colorspace extension, Chih-Wei has tried with following override export MESA_EXTENSION_OVERRIDE "-EGL_KHR_gl_colorspace" With both methods (to my know

[Mesa-dev] [Bug 92138] Configuratin define "HAVE_LIBDRM" must not used in installed header

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92138 --- Comment #11 from Albert Freeman --- I guess building a really old gcc toolchain with a recent gcc compiler is an incredibly stupid thing to do (i.e. those old libraries are incredibly buggy). I really should have just grabbed a distro with g

[Mesa-dev] [Bug 91596] EGL_KHR_gl_colorspace (v2) causes problem with Android-x86 GUI

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91596 --- Comment #6 from Mauro Rossi --- To be precise: We came to the conclusion that c2c2e9a need to be reverted on android-x86 git external/mesa upcoming project in lollipop-x86 branch Mauro -- You are receiving this mail because: You are the Q

[Mesa-dev] [Bug 92138] Configuratin define "HAVE_LIBDRM" must not used in installed header

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92138 --- Comment #12 from Albert Freeman --- Maybe try and find a way to suppress compiler warnings (although I am guessing you have done that), also it would be nice if you tried to compile the git://anongit.freedesktop.org/xorg/xserver if at all pos

[Mesa-dev] [Bug 92138] Configuratin define "HAVE_LIBDRM" must not used in installed header

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92138 --- Comment #13 from Emil Velikov --- Ouch... seems that typedef redefinitions are a C11 thing, which obviously we cannot force onto others. Rather than reintroducing the double-negative (esp. since the meaning varies, in one's native language),

[Mesa-dev] [Bug 92137] [regression, bisected] piglit arb_separate_shader_objects.validateprogrampipeline fails

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92137 Tapani Pälli changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mesa-dev@list

[Mesa-dev] [Bug 92137] [regression, bisected] piglit arb_separate_shader_objects.validateprogrampipeline fails

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92137 --- Comment #2 from Tapani Pälli --- (In reply to Tapani Pälli from comment #1) > what is the HEAD commit of your Piglit tree? Or maybe more specifically, do you have following commit in your tree? --- 8< --- sso: bind pipeline object in Valid

Re: [Mesa-dev] [PATCH 4/5] i965/miptree: Rename align_w, align_h -> halign, valign

2015-09-27 Thread Ben Widawsky
On Fri, Sep 25, 2015 at 12:05:49PM -0700, Chad Versace wrote: > The values of intel_mipmap_tree::align_w and ::align_h correspond to the > hardware enums HALIGN_* and VALIGN_*. > > See the confusion? > align_h != HALIGN > align_h == VALIGN > > Reduce the confusion by renaming the variable

Re: [Mesa-dev] [PATCH 2/2] egl/dri2: don't require a context for ClientWaitSync

2015-09-27 Thread Emil Velikov
On 26 September 2015 at 00:49, Marek Olšák wrote: > From: Marek Olšák > > The spec doesn't require it. This fixes a crash on Android. > Nicely spotted Marek. A couple of related (not supposed to be part of this patch) notes: - This will just move the crash (from libEGL to i965_dri.so) for i965

[Mesa-dev] Question: st/mesa and context-shareable shaders

2015-09-27 Thread Marek Olšák
Hi, For some reason, st/mesa assumes that shaders can't be shared by multiple contexts and therefore has a context pointer in shader keys. I'd like to get rid of this dependency, because there is no reason why shaders would need to be tied to a context. In fact, shaders don't even need a device, t

Re: [Mesa-dev] Question: st/mesa and context-shareable shaders

2015-09-27 Thread Ilia Mirkin
On Sun, Sep 27, 2015 at 2:14 PM, Marek Olšák wrote: > Hi, > > For some reason, st/mesa assumes that shaders can't be shared by > multiple contexts and therefore has a context pointer in shader keys. > I'd like to get rid of this dependency, because there is no reason why > shaders would need to be

[Mesa-dev] [PATCH] egl/dri2: don't require a context for ClientWaitSync (v2)

2015-09-27 Thread Marek Olšák
From: Marek Olšák The spec doesn't require it. This fixes a crash on Android. v2: don't set any flags if ctx == NULL Cc: 10.6 11.0 --- src/egl/drivers/dri2/egl_dri2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2

Re: [Mesa-dev] Question: st/mesa and context-shareable shaders

2015-09-27 Thread Marek Olšák
On Sun, Sep 27, 2015 at 8:21 PM, Ilia Mirkin wrote: > On Sun, Sep 27, 2015 at 2:14 PM, Marek Olšák wrote: >> Hi, >> >> For some reason, st/mesa assumes that shaders can't be shared by >> multiple contexts and therefore has a context pointer in shader keys. >> I'd like to get rid of this dependenc

Re: [Mesa-dev] [PATCH 06/11] st/mesa: add atomic buffer support

2015-09-27 Thread Marek Olšák
Patches 2-5 are: Reviewed-by: Marek Olšák Same for patch 1 if you rename "RES" to "IMAGE". See below for patch 6 comments. On Sun, Sep 27, 2015 at 8:33 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/mesa/Makefile.sources| 1 + > src/mesa/program/ir_to_

Re: [Mesa-dev] Question: st/mesa and context-shareable shaders

2015-09-27 Thread Ilia Mirkin
On Sun, Sep 27, 2015 at 2:25 PM, Marek Olšák wrote: > On Sun, Sep 27, 2015 at 8:21 PM, Ilia Mirkin wrote: >> On Sun, Sep 27, 2015 at 2:14 PM, Marek Olšák wrote: >>> Hi, >>> >>> For some reason, st/mesa assumes that shaders can't be shared by >>> multiple contexts and therefore has a context poin

Re: [Mesa-dev] [PATCH 3/6] glsl: return the number of uniform blocks in error message

2015-09-27 Thread Timothy Arceri
On Fri, 2015-09-25 at 10:24 +0200, Samuel Iglesias Gonsalvez wrote: > Signed-off-by: Samuel Iglesias Gonsalvez Maybe change the commit message to something like: glsl: use correct number of uniform blocks in error message Otherwise: Reviewed-by: Timothy Arceri > --- > src/glsl/linker.cpp |

Re: [Mesa-dev] [PATCH 6/6] docs: mention ARB_shader_storage_buffer_object on 11.1.0 release notes

2015-09-27 Thread Timothy Arceri
On Fri, 2015-09-25 at 10:24 +0200, Samuel Iglesias Gonsalvez wrote: > Signed-off-by: Samuel Iglesias Gonsalvez Reviewed-by: Timothy Arceri > --- > docs/relnotes/11.1.0.html | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.0.html > index e

Re: [Mesa-dev] [PATCH 06/11] st/mesa: add atomic buffer support

2015-09-27 Thread Ilia Mirkin
On Sun, Sep 27, 2015 at 2:48 PM, Marek Olšák wrote: > Patches 2-5 are: > > Reviewed-by: Marek Olšák > > Same for patch 1 if you rename "RES" to "IMAGE". > > See below for patch 6 comments. > > On Sun, Sep 27, 2015 at 8:33 AM, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> src/mesa/

Re: [Mesa-dev] [PATCH 1/6] main: fix ACTIVE_UNIFORM_BLOCKS value

2015-09-27 Thread Timothy Arceri
On Fri, 2015-09-25 at 10:24 +0200, Samuel Iglesias Gonsalvez wrote: > NumUniformBlocks also counts shader storage blocks. > NumUniformBlocks variable will be renamed in a later patch to avoid > misunderstandings. > > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/mesa/main/shaderapi.c | 9

Re: [Mesa-dev] Question: st/mesa and context-shareable shaders

2015-09-27 Thread Marek Olšák
On Sun, Sep 27, 2015 at 10:41 PM, Ilia Mirkin wrote: > On Sun, Sep 27, 2015 at 2:25 PM, Marek Olšák wrote: >> On Sun, Sep 27, 2015 at 8:21 PM, Ilia Mirkin wrote: >>> On Sun, Sep 27, 2015 at 2:14 PM, Marek Olšák wrote: Hi, For some reason, st/mesa assumes that shaders can't be sha

Re: [Mesa-dev] [PATCH 06/11] st/mesa: add atomic buffer support

2015-09-27 Thread Marek Olšák
On Sun, Sep 27, 2015 at 11:10 PM, Ilia Mirkin wrote: > On Sun, Sep 27, 2015 at 2:48 PM, Marek Olšák wrote: >> Patches 2-5 are: >>> +static void st_bind_atomics(struct st_context *st, >>> + struct gl_shader_program *prog, >>> + unsigned shader_ty

Re: [Mesa-dev] [PATCH 06/11] st/mesa: add atomic buffer support

2015-09-27 Thread Ilia Mirkin
On Sun, Sep 27, 2015 at 5:27 PM, Marek Olšák wrote: > On Sun, Sep 27, 2015 at 11:10 PM, Ilia Mirkin wrote: >> On Sun, Sep 27, 2015 at 2:48 PM, Marek Olšák wrote: >>> Patches 2-5 are: +static void st_bind_atomics(struct st_context *st, + struct gl_shader_progra

Re: [Mesa-dev] [PATCH 5/6] glsl: apply shader storage block member rules when adding program resources

2015-09-27 Thread Timothy Arceri
On Fri, 2015-09-25 at 10:24 +0200, Samuel Iglesias Gonsalvez wrote: > From ARB_program_interface_query: > > "For an active shader storage block member declared as an array, an > entry will be generated only for the first array element, regardless > of its type. For arrays of aggregate types, the

[Mesa-dev] [PATCH 03/23] mesa: remove Driver.DeleteShader

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing overrides it. --- src/glsl/linker.cpp | 8 src/glsl/standalone_scaffolding.cpp | 8 src/glsl/standalone_scaffolding.h | 3 +++ src/mesa/main/dd.h | 1 - src/mesa/main/shaderobj.c | 8 +++- src/mesa/main/

[Mesa-dev] [PATCH 10/23] mesa: remove Driver.Hint

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing sets it. --- src/mesa/drivers/common/driverfuncs.c | 1 - src/mesa/drivers/dri/r200/r200_state.c | 1 - src/mesa/drivers/dri/radeon/radeon_state.c | 1 - src/mesa/main/dd.h | 2 -- src/mesa/main/hint.c | 5 - 5

[Mesa-dev] [PATCH 23/23] mesa: remove Driver.BindImageTexture

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing sets it. --- src/mesa/main/dd.h | 6 -- src/mesa/main/shaderimage.c | 9 - 2 files changed, 15 deletions(-) diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h index 1edf76b..5199620 100644 --- a/src/mesa/main/dd.h +++ b/src/mesa/main/dd.h @@ -915

[Mesa-dev] [PATCH 14/23] mesa: remove Driver.BeginVertices

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing overrides it. --- src/mesa/main/dd.h | 5 - src/mesa/vbo/vbo_exec.c | 1 - src/mesa/vbo/vbo_exec_api.c | 4 ++-- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h index 446a1ba..a5991cb 100644 --- a/s

[Mesa-dev] [PATCH 09/23] mesa: remove Driver.ColorMaskIndexed

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing sets it. --- src/mesa/drivers/common/driverfuncs.c | 22 +- src/mesa/main/blend.c | 3 --- src/mesa/main/dd.h| 2 -- 3 files changed, 5 insertions(+), 22 deletions(-) diff --git a/src/mesa/drivers/common/driverf

[Mesa-dev] [PATCH 17/23] mesa: remove Driver.NotifySaveBegin

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing overrides it. --- src/mesa/drivers/common/driverfuncs.c | 1 - src/mesa/main/dd.h| 7 --- src/mesa/main/dlist.c | 2 +- src/mesa/vbo/vbo.h| 2 +- src/mesa/vbo/vbo_save.c | 1 - src/mesa/vbo/vbo_sa

[Mesa-dev] [PATCH 13/23] mesa: remove Driver.BindArrayObject

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing sets it. --- src/mesa/drivers/common/driverfuncs.c | 6 -- src/mesa/main/arrayobj.c | 4 src/mesa/main/dd.h| 8 3 files changed, 18 deletions(-) diff --git a/src/mesa/drivers/common/driverfuncs.c b/src/mesa/drivers/co

[Mesa-dev] [PATCH 05/23] mesa: remove Driver.DeleteShaderProgram

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing overrides it. --- src/mesa/main/dd.h| 2 -- src/mesa/main/shaderobj.c | 9 - src/mesa/main/shaderobj.h | 3 +++ src/mesa/main/shared.c| 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h index

[Mesa-dev] [PATCH 20/23] mesa: remove Driver.BeginCallList

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing overrides it. --- src/mesa/drivers/common/driverfuncs.c | 1 - src/mesa/main/dd.h| 7 --- src/mesa/main/dlist.c | 3 +-- src/mesa/vbo/vbo.h| 1 + src/mesa/vbo/vbo_save.c | 1 - src/mesa/vbo/vbo_sa

[Mesa-dev] [PATCH 22/23] mesa: remove Driver.DeleteSamplerObject

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing overrides it. --- src/mesa/main/dd.h | 2 -- src/mesa/main/samplerobj.c | 28 ++-- 2 files changed, 10 insertions(+), 20 deletions(-) diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h index 14066dd..1edf76b 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH 01/23] i965: remove brw_new_shader, it's the same as the core Mesa version

2015-09-27 Thread Marek Olšák
From: Marek Olšák --- src/mesa/drivers/dri/i965/brw_program.c | 1 - src/mesa/drivers/dri/i965/brw_shader.cpp | 16 src/mesa/drivers/dri/i965/brw_wm.h | 1 - 3 files changed, 18 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_program.c b/src/mesa/drivers/dri/i

[Mesa-dev] [PATCH 16/23] mesa: remove Driver.SaveFlushVertices

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing overrides it. --- src/mesa/drivers/common/driverfuncs.c | 1 - src/mesa/main/dd.h| 4 +--- src/mesa/main/dlist.c | 5 ++--- src/mesa/vbo/vbo.h| 1 + src/mesa/vbo/vbo_save.c | 1 - src/mesa/vbo/vbo_sav

[Mesa-dev] [PATCH 21/23] mesa: remove Driver.EndCallList

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing overrides it. --- src/mesa/drivers/common/driverfuncs.c | 3 --- src/mesa/main/dd.h| 7 --- src/mesa/main/dlist.c | 3 +-- src/mesa/vbo/vbo.h| 1 + src/mesa/vbo/vbo_save.c | 8 src/mesa/v

[Mesa-dev] [PATCH 12/23] mesa: remove Driver.DeleteArrayObject

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing reimplements it. --- src/mesa/drivers/common/driverfuncs.c| 1 - src/mesa/main/arrayobj.c | 6 ++ src/mesa/main/dd.h | 1 - src/mesa/state_tracker/st_cb_bufferobjects.c | 3 --- 4 files changed, 2 insertions(+),

[Mesa-dev] [PATCH 04/23] mesa: remove Driver.NewShaderProgram

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing overrides it. --- src/mesa/main/dd.h | 1 - src/mesa/main/ff_fragment_shader.cpp | 2 +- src/mesa/main/shaderapi.c| 2 +- src/mesa/main/shaderobj.c| 4 +--- src/mesa/main/shaderobj.h| 3 +++ 5 files changed, 6 insert

[Mesa-dev] [PATCH 11/23] mesa: remove Driver.NewArrayObject

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing reimplements it. --- src/mesa/drivers/common/driverfuncs.c| 1 - src/mesa/main/arrayobj.c | 5 ++--- src/mesa/main/dd.h | 1 - src/mesa/main/varray.c | 2 +- src/mesa/state_tracker/st_cb_buffero

[Mesa-dev] [PATCH 15/23] mesa: remove Driver.FlushVertices

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing overrides it. --- src/mesa/drivers/common/driverfuncs.c | 1 - src/mesa/main/context.h | 5 +++-- src/mesa/main/dd.h| 10 -- src/mesa/vbo/vbo.h| 3 +++ src/mesa/vbo/vbo_exec.c | 1 - src/mes

[Mesa-dev] [PATCH 18/23] mesa: remove Driver.NewList

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing overrides it. --- src/mesa/drivers/common/driverfuncs.c | 1 - src/mesa/main/dd.h| 7 --- src/mesa/main/dlist.c | 2 +- src/mesa/vbo/vbo.h| 1 + src/mesa/vbo/vbo_save.c | 1 - src/mesa/vbo/vbo_sav

[Mesa-dev] [PATCH 06/23] mesa: remove Driver.ResizeBuffers

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing overrides it. --- src/mesa/drivers/common/driverfuncs.c | 1 - src/mesa/drivers/dri/common/dri_util.c | 3 ++- src/mesa/main/dd.h | 7 --- 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/common/driverfuncs.c b/sr

[Mesa-dev] [PATCH 02/23] mesa: remove Driver.NewShader

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing overrides it. --- src/glsl/linker.cpp | 2 +- src/glsl/main.cpp| 2 -- src/glsl/test_optpass.cpp| 1 - src/mesa/main/dd.h | 2 -- src/mesa/main/ff_fragment_shader.cpp | 3 ++- src/mesa/main/shaderapi.c

[Mesa-dev] [PATCH 19/23] mesa: remove Driver.EndList

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing overrides it. --- src/mesa/drivers/common/driverfuncs.c | 1 - src/mesa/main/dd.h| 7 --- src/mesa/main/dlist.c | 2 +- src/mesa/vbo/vbo.h| 1 + src/mesa/vbo/vbo_save.c | 1 - src/mesa/vbo/vbo_sav

[Mesa-dev] [PATCH 00/23] Remove useless driver hooks from dd.h

2015-09-27 Thread Marek Olšák
Hi, This series removes all driver hooks from dd.h that can be removed easily. Such hooks are typically only set to one function from core Mesa. There are no easy ones left. Some of the old state hooks that we'd like to kill with fire are used by old classic drivers unfortunately. Please revie

[Mesa-dev] [PATCH 07/23] mesa: remove Driver.Accum

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing calls it. --- src/mesa/drivers/common/driverfuncs.c | 1 - src/mesa/drivers/dri/i915/intel_pixel.c | 1 - src/mesa/drivers/dri/i965/intel_pixel.c | 1 - src/mesa/main/dd.h | 6 -- src/mesa/state_tracker/st_context.c | 2 -- 5 files changed

[Mesa-dev] [PATCH 08/23] mesa: remove some Driver.Blend* hooks

2015-09-27 Thread Marek Olšák
From: Marek Olšák Nothing sets them. --- src/mesa/main/blend.c | 11 --- src/mesa/main/dd.h| 5 - 2 files changed, 16 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 4fc3296..1638417 100644 --- a/src/mesa/main/blend.c +++ b/src/mesa/main/blend.c @@

[Mesa-dev] [PATCH 0/8] RadeonSI: New tool for VM fault debugging

2015-09-27 Thread Marek Olšák
Hi, This adds 2 things: 1) R600_DEBUG=check_vm - which checks dmesg for VM faults for each submitted IB and if a VM fault appears, it writes a debug report to a file with the failing address. 2) Writes a buffer list for that IB into the report file along with a description how each buffer was

[Mesa-dev] [PATCH 6/8] winsys/amdgpu: add winsys function cs_get_buffer_list

2015-09-27 Thread Marek Olšák
From: Marek Olšák For debugging. --- src/gallium/drivers/radeon/radeon_winsys.h | 16 src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 19 +++ src/gallium/winsys/amdgpu/drm/amdgpu_cs.h | 1 + 3 files changed, 36 insertions(+) diff --git a/src/gallium/drivers/radeo

[Mesa-dev] [PATCH 8/8] radeonsi: dump buffer lists while debugging

2015-09-27 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_debug.c | 110 +++ src/gallium/drivers/radeonsi/si_hw_context.c | 15 +++- src/gallium/drivers/radeonsi/si_pipe.c | 5 ++ src/gallium/drivers/radeonsi/si_pipe.h | 2 + 4 files changed, 131 inserti

[Mesa-dev] [PATCH 5/8] gallium/radeon: stop using "reloc" in a few places

2015-09-27 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/r300/r300_cs.h| 4 +-- src/gallium/drivers/r300/r300_emit.c | 18 +- src/gallium/drivers/radeon/r600_cs.h | 2 +- src/gallium/drivers/radeon/radeon_uvd.c | 2 +- src/gallium/drivers/radeon/radeon_vce.c

[Mesa-dev] [PATCH 1/8] ddebug: separate creation of debug files

2015-09-27 Thread Marek Olšák
From: Marek Olšák This will be used by radeonsi for logging. --- src/gallium/drivers/ddebug/dd_draw.c | 27 +- src/gallium/drivers/ddebug/dd_pipe.h | 4 +- src/gallium/drivers/ddebug/dd_util.h | 71 3 files changed, 74 insertions(+), 28 deletions

[Mesa-dev] [PATCH 4/8] gallium/radeon: tell the winsys the exact resource binding types

2015-09-27 Thread Marek Olšák
From: Marek Olšák Use the priority flags and expand them. This information will be used for debugging. --- src/gallium/drivers/r300/r300_emit.c| 10 ++-- src/gallium/drivers/r600/evergreen_compute.c| 4 +- src/gallium/drivers/r600/evergreen_hw_context.c | 6 +-- src/gallium/dri

[Mesa-dev] [PATCH 2/8] radeonsi: move dumping the last IB into its own function

2015-09-27 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_debug.c | 52 ++--- 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/radeonsi/si_debug.c index d3fd201..308f181 100644 --- a/src/gallium

[Mesa-dev] [PATCH 3/8] radeonsi: add an option for debugging VM faults

2015-09-27 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeonsi/si_debug.c | 113 ++ src/gallium/drivers/radeonsi/si_hw_context.c | 4 + src/gallium/drivers/radeonsi/

[Mesa-dev] [PATCH 7/8] winsys/radeon: implement cs_get_buffer_list

2015-09-27 Thread Marek Olšák
From: Marek Olšák This is more complicated, because tracking priority_usage needed changing the relocs_bo type. --- src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 45 +++--- src/gallium/winsys/radeon/drm/radeon_drm_cs.h | 8 +++- src/gallium/winsys/radeon/drm/radeon_d

Re: [Mesa-dev] [PATCH 01/24] glsl: calculate component size for arrays of arrays when varying packing disabled

2015-09-27 Thread Dave Airlie
On 17 September 2015 at 17:02, Timothy Arceri wrote: > Signed-off-by: Timothy Arceri > Reviewed-by: Ilia Mirkin > Reviewed-by: Ian Romanick > --- > src/glsl/link_varyings.cpp | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/src/glsl/link_varyings.cpp b/sr

[Mesa-dev] [Bug 90346] DispatchSanity_test.GLES2 regression

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90346 Vinson Lee changed: What|Removed |Added Version|git |10.6 -- You are receiving this mail becaus

[Mesa-dev] [Bug 91591] rounding.h:102:2: error: #error "Unsupported or undefined LONG_BIT"

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91591 Vinson Lee changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[Mesa-dev] [Bug 91099] [llvmpipe] piglit glsl-max-varyings >max_varying_components regression

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91099 Vinson Lee changed: What|Removed |Added Version|git |10.6 -- You are receiving this mail becaus

Re: [Mesa-dev] [PATCH] docs/GL3.txt: fix typo

2015-09-27 Thread Kenneth Graunke
On Sunday, September 27, 2015 05:15:28 PM Boyan Ding wrote: > Signed-off-by: Boyan Ding > --- > docs/GL3.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/GL3.txt b/docs/GL3.txt > index bd44d12..ed6a98d 100644 > --- a/docs/GL3.txt > +++ b/docs/GL3.txt > @@ -237,7

Re: [Mesa-dev] [PATCH 01/23] i965: remove brw_new_shader, it's the same as the core Mesa version

2015-09-27 Thread Kenneth Graunke
On Monday, September 28, 2015 12:20:30 AM Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/drivers/dri/i965/brw_program.c | 1 - > src/mesa/drivers/dri/i965/brw_shader.cpp | 16 > src/mesa/drivers/dri/i965/brw_wm.h | 1 - > 3 files changed, 18 deletions(-) > >

[Mesa-dev] [Bug 89978] nine_state.c:1440: error: unknown field ‘m’ specified in initializer

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89978 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] freedreno: fix some leaks

2015-09-27 Thread Ilia Mirkin
Freeing the compiler in the common destroy function is a sad hack, but it's too annoying to create separate destroy functions. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/freedreno/freedreno_context.c| 2 ++ src/gallium/drivers/freedreno/freedreno_screen.c | 4 src/gallium/dr

[Mesa-dev] [Bug 89330] piglit glsl-1.50 invariant-qualifier-in-out-block-01 regression

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89330 Vinson Lee changed: What|Removed |Added Version|git |10.6 -- You are receiving this mail becaus

[Mesa-dev] [Bug 87276] u_atomic_test.c:108:1: error: implicit declaration of function 'test_atomic_cmpxchg_int16_t'

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87276 Vinson Lee changed: What|Removed |Added Version|git |10.5 -- You are receiving this mail becaus

[Mesa-dev] [PATCH] glsl: fix component size calculation for tessellation and geom shaders

2015-09-27 Thread Timothy Arceri
Broken in commit abdab88b30ab when adding arrays of arrays support Cc: Dave Airlie --- src/glsl/link_varyings.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index 0d343d6..7e77a67 100644 --- a/src/glsl/link_varyings

Re: [Mesa-dev] [PATCH 01/24] glsl: calculate component size for arrays of arrays when varying packing disabled

2015-09-27 Thread Timothy Arceri
On Mon, 2015-09-28 at 10:42 +1000, Dave Airlie wrote: > On 17 September 2015 at 17:02, Timothy Arceri > wrote: > > Signed-off-by: Timothy Arceri > > Reviewed-by: Ilia Mirkin > > Reviewed-by: Ian Romanick > > --- > > src/glsl/link_varyings.cpp | 13 ++--- > > 1 file changed, 10 insertio

Re: [Mesa-dev] [PATCH 01/23] i965: remove brw_new_shader, it's the same as the core Mesa version

2015-09-27 Thread Marek Olšák
On Mon, Sep 28, 2015 at 2:56 AM, Kenneth Graunke wrote: > On Monday, September 28, 2015 12:20:30 AM Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/mesa/drivers/dri/i965/brw_program.c | 1 - >> src/mesa/drivers/dri/i965/brw_shader.cpp | 16 >> src/mesa/drivers/dri/i96

Re: [Mesa-dev] [PATCH] glsl: fix component size calculation for tessellation and geom shaders

2015-09-27 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Sep 28, 2015 at 3:08 AM, Timothy Arceri wrote: > Broken in commit abdab88b30ab when adding arrays of arrays support > > Cc: Dave Airlie > --- > src/glsl/link_varyings.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/glsl/l

[Mesa-dev] leaks and invalid memory accesses in shader linking

2015-09-27 Thread Ilia Mirkin
This is what I see when I run valgrind --leak-check=full bin/shader_runner tests/spec/arb_shader_atomic_counters/execution/vs-simple-inc-dec-read.shader_test -fbo -auto Anybody know what's going on with these? Cheers, -ilia ==7899== Invalid read of size 4 ==7899==at 0x483C3DC: memcpy (vg

[Mesa-dev] [Bug 92137] [regression, bisected] piglit arb_separate_shader_objects.validateprogrampipeline fails

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92137 --- Comment #3 from Boyan Ding --- My piglit tree was a little bit old. I updated today only to find now this test consistently fails on both old and new versions of mesa. Log below --- 8< --- PIGLIT: {"subtest": {"VS/FS program, single glUsePr

Re: [Mesa-dev] [PATCH 8/8] radeonsi: dump buffer lists while debugging

2015-09-27 Thread Michel Dänzer
On 28.09.2015 07:53, Marek Olšák wrote: > + /* Note: Buffer sizes are expected to be aligned to 4k by the > winsys. */ > + const unsigned page_size = 4096; This stems from TTM; it requires BOs to be aligned to the CPU page size, which can be larger than 4096 bytes. We shou

Re: [Mesa-dev] [PATCH 2/8] radeonsi: move dumping the last IB into its own function

2015-09-27 Thread Michel Dänzer
On 28.09.2015 07:53, Marek Olšák wrote: > > + if (sctx->last_trace_buf) { > + /* We are expecting that the ddebug pipe has already > + * waited for the context, so this buffer should be idle. > + * If the GPU is hung, there is no point in waiting for it. >

Re: [Mesa-dev] [PATCH 0/8] RadeonSI: New tool for VM fault debugging

2015-09-27 Thread Michel Dänzer
On 28.09.2015 07:53, Marek Olšák wrote: > Hi, > > This adds 2 things: > > 1) R600_DEBUG=check_vm - which checks dmesg for VM faults for each submitted > IB and if a VM fault appears, it writes a debug report to a file with the > failing address. > > 2) Writes a buffer list for that IB into the

[Mesa-dev] [PATCH] freedreno: unreference resources on context destruction

2015-09-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/freedreno/freedreno_context.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/freedreno_context.c b/src/gallium/drivers/freedreno/freedreno_context.c index 5b7c32f..9dc918d 10

[Mesa-dev] [Bug 92137] [regression, bisected] piglit arb_separate_shader_objects.validateprogrampipeline fails

2015-09-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92137 --- Comment #4 from Tapani Pälli --- > My piglit tree was a little bit old. I updated today only to find > now this test consistently fails on both old and new versions of mesa. Right, this should be the 'expected result' right now. It has been

  1   2   >