> -Original Message-
> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On
> Behalf Of Kenneth Graunke
> Sent: Wednesday, September 23, 2015 6:25 PM
> To: mesa-dev@lists.freedesktop.org
> Subject: Re: [Mesa-dev] [PATCH 5/7] mesa: enable enums for
> OES_geometry_shader
>
> On
> -Original Message-
> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On
> Behalf Of Ilia Mirkin
> Sent: Wednesday, September 23, 2015 5:17 PM
> To: Marta Lofstedt
> Cc: mesa-dev@lists.freedesktop.org
> Subject: Re: [Mesa-dev] [PATCH 3/7] mesa: Add extension enable for
> GL_
> -Original Message-
> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On
> Behalf Of Ilia Mirkin
> Sent: Wednesday, September 23, 2015 5:20 PM
> To: Marta Lofstedt
> Cc: mesa-dev@lists.freedesktop.org
> Subject: Re: [Mesa-dev] [PATCH 4/7] glsl: add support for
> GL_OES_geome
Without this commit, copy propagation is discarded if it involves
a uniform with an instruction that has 3 sources. But 3 sourced
instructions can access scalar values.
For example, this is what vec4_visitor::fix_3src_operand() is already
doing:
if (src.file == UNIFORM && brw_is_single_value_s
This function will be needed as part of validating the combination of format,
type and internal format of texture pixel operations, which happens in
glformats files. Specifically, we want to be able to obtain the base format
of a resolved effective internal format, to compare it with the original
i
When validating format+type+internalFormat for texture pixel operations
on GLES3, the effective internal format should be used if the one
specified is an unsized internal format. Page 127, section "3.8 Texturing"
of the GLES 3.0.4 spec says:
"if internalformat is a base internal format, the ef
This is a new version of the series that attempt to fix the regression reported
at:
https://bugs.freedesktop.org/show_bug.cgi?id=91582
The review by Jason helped me uncover the fact that the following 3 dEQP tests
are buggy:
dEQP-GLES2.functional.negative_api.texture.texsubimage2d_neg_offset
d
The more specific GLES constrains should be checked after the general
validation performed by _mesa_error_check_format_and_type(). This is also
for consistency with the error checks order of glTexSubImage ops.
v3: The change of order uncovered a bug that regresses a couple of piglit
tests written
On 23/09/15 12:07, Samuel Iglesias Gonsalvez wrote:
> From: Iago Toral Quiroga
>
> v2:
> - Fix ssbo loads with boolean variables.
>
> v3:
> - Simplify the changes (Kristian)
>
> Reviewed-by: Connor Abbott
> ---
> src/glsl/nir/glsl_to_nir.cpp| 66
> ++
On 09/24/2015 01:04 AM, Mark Janes wrote:
> Hi Eduardo,
>
> I can't get this patch to apply to any recent version of glformats.c
>
> Can you double check it?
>
Hi Mark,
Yes, I just rebased it and fixed the conflicts. After Jason's feedback,
I sent the whole series dropping the last patch, beca
On 09/23/2015 11:59 PM, Jason Ekstrand wrote:
> On Tue, Sep 15, 2015 at 3:01 PM, Eduardo Lima Mitev wrote:
>> On 09/15/2015 09:23 PM, Jason Ekstrand wrote:
>>> On Tue, Sep 15, 2015 at 4:47 AM, Eduardo Lima Mitev
>>> wrote:
For consistency and efficiency, the (sub)texture dimension error che
On Mon, 2015-09-21 at 09:21 -0700, Matt Turner wrote:
> On Mon, Sep 21, 2015 at 8:00 AM, Iago Toral wrote:
> > On Mon, 2015-09-21 at 07:49 -0700, Kenneth Graunke wrote:
> >> On Monday, September 21, 2015 09:46:24 AM Mark Janes wrote:
> >> > This series hits an assertion on ILK and G45:
> >> >
> >>
https://bugs.freedesktop.org/show_bug.cgi?id=91889
--- Comment #26 from Krzysztof A. Sobiecki ---
Trace from wayland/Xwayland:
https://drive.google.com/file/d/0B3J0Mg89izcbR1BHWXEwREJhY00/view?usp=sharing
It shows only dark screen in menu.
--
You are receiving this mail because:
You are the QA
On 24/09/15 02:16, Timothy Arceri wrote:
> On Wed, 2015-09-23 at 13:21 +0200, Samuel Iglesias Gonsálvez wrote:
>> On 22/09/15 15:30, Samuel Iglesias Gonsálvez wrote:
>>> Reviewed-by: Samuel Iglesias Gonsálvez
>>>
>>
>> Forgot to say that we need to implement a similar patch for
>> std430_size()
Hi all,
On 10 September 2015 at 00:30, Mark Janes wrote:
> Mark Janes writes:
>
>> Francisco Jerez writes:
>>
>>> Mark Janes writes:
>>>
When I tested this, I saw an intermittent BSW gpu hang. I haven't been
able to confirm that it is due to the host-mem-barrier test.
>>> It wo
Hi guys,
On 2 September 2015 at 20:10, Pohjolainen, Topi
wrote:
> On Thu, Aug 27, 2015 at 10:05:14AM -0700, Ben Widawsky wrote:
>> On Thu, Aug 27, 2015 at 10:51:59AM +0300, Pohjolainen, Topi wrote:
>> > On Wed, Aug 26, 2015 at 03:46:05PM -0700, Ben Widawsky wrote:
>> > > This reverts commit 1bba2
Hi all,
On 3 September 2015 at 14:53, Francisco Jerez wrote:
> A future commit will remove all texture object-dependent derived state
> from the image unit struct to make validation unnecessary on texture
> state changes. Instead of checking gl_image_unit::_Valid drivers will
> be required to ca
Hi Francisco,
On 9 September 2015 at 18:04, Ian Romanick wrote:
> On 09/09/2015 05:30 AM, Francisco Jerez wrote:
>> Ian Romanick writes:
>>
>>> On 09/03/2015 06:03 AM, Francisco Jerez wrote:
IVB and VLV hang sporadically when an untyped surface read or write
message is used to access a
Hi Ben,
On 11 September 2015 at 20:15, Ben Widawsky wrote:
> On Fri, Sep 11, 2015 at 12:12:15PM -0700, Jordan Justen wrote:
>> On 2015-09-10 16:59:12, Ben Widawsky wrote:
>> > All SKL SKUs except the lowest one which has half the L3 size actually
>> > have 384K
>>
>> These commit message lines s
Hello list,
The candidate for the Mesa 11.0.1 is now available. Currently we have:
- 23 queued
- 29 nominated (outstanding)
- and 0 rejected/obsolete patches
The present queue consists mostly of nouveau and i965 fixes, although we
have the odd llvmpipe (big endian) and gbm bugfix.
Note: we d
On 23 September 2015 at 17:03, Christian König wrote:
> On 23.09.2015 17:34, Matt Turner wrote:
>>
>> Should these patches go to the stable branch as well?
>
>
> Good point, most likely yes.
>
Please throw in a line or two of commit message and a bugzilla link,
if there is one.
Cc: "10.6 11.0"
Hi guys,
A couple of suggestions - feel free to take or leave them.
On 23 September 2015 at 09:11, Christian König wrote:
> From: Boyuan Zhang
>
A line or two lines of commit message would be appreciated.
> Signed-off-by: Boyuan Zhang
> Reviewed-by: Christian König
If you think that one can
Hi Marek,
Thanks for the review and my apologies, it seems I underestimated the
potential for regressions in this series.
See below for some comments in reaction to the review.
For a v2 is it preferred that I rebase it to master, or keep basing it on the
old version? There are some function re
Hi all,
On 15 September 2015 at 17:42, Emil Velikov wrote:
> No driver changes needed for softpipe/llvmpipe - things just work.
>
> v2: Whitespace fixes.
>
> Signed-off-by: Emil Velikov
> Reviewed-by: Boyan Ding
Courtesy ping. If we don't get any objections/comments, over the next
few days I w
Hi all,
On 16 September 2015 at 16:38, Emil Velikov wrote:
> From: Matthew Waters
>
> Move all the enums but CONTEXT_FLAGS. The spec seems quite explicit
> about the latter (wrt OpenGL ES)
>
> "In OpenGL ES versions prior to and including ES 3.1 there is no
> CONTEXT_FLAGS state and ther
On Thursday, September 24, 2015 02:22:23 AM Marek Olšák wrote:
> On Fri, Sep 4, 2015 at 9:47 PM, Bas Nieuwenhuizen
>
> wrote:
> > This is needed by DCC when using compressed textures.
> >
> > Signed-off-by: Bas Nieuwenhuizen
> > ---
> >
> > src/gallium/drivers/radeonsi/si_state.c | 2 ++
> >
On 7 September 2015 at 10:16, Jean-Sébastien Pédron
wrote:
> On 06.09.2015 23:40, Emil Velikov wrote:
>> Hi Jean-Sébastien,
>
> Hi!
>
>> On 3 September 2015 at 19:07, Jean-Sébastien Pédron
>> We have 4(5) users of atexit() - EGL, gallium trace driver, core mesa
>> and util/ralloc. The latter of wh
On 24.09.2015 14:55, Emil Velikov wrote:
__attribute__((destructor)) fixes the problem because such handlers are
called when a library is unloaded and when the program exits.
>>> Considering that atexit() (reportedly) works for Linux/Glibc, Solaris,
>>> Android and Windows perhaps we shou
On Thu, Sep 24, 2015 at 8:16 AM, Emil Velikov wrote:
> Hi all,
>
> On 15 September 2015 at 17:42, Emil Velikov wrote:
>> No driver changes needed for softpipe/llvmpipe - things just work.
>>
>> v2: Whitespace fixes.
>>
>> Signed-off-by: Emil Velikov
>> Reviewed-by: Boyan Ding
>
> Courtesy ping.
Yes, that's fine - we modify instr so we need to update dest.
Kristian
> On Sep 24, 2015, at 1:59 AM, Samuel Iglesias Gonsálvez
> wrote:
>
>
>
>> On 23/09/15 12:07, Samuel Iglesias Gonsalvez wrote:
>> From: Iago Toral Quiroga
>>
>> v2:
>> - Fix ssbo loads with boolean variables.
>>
>> v3
On 09/23/2015 07:03 PM, Nick Sarnie wrote:
Hi,
The game still works for me with your patch.
Tested-by: Nick Sarnie mailto:commendsar...@gmail.com>>
Thanks for testing, Nick and Kai!
I'll push the patch soon.
-Brian
___
mesa-dev mailing list
mesa-d
On 24/09/15 02:04, Timothy Arceri wrote:
> On Wed, 2015-09-23 at 17:02 +0200, Antía Puentes wrote:
>> Hi! Timothy,
>> thanks for your review.
>>
>> Seeing your patch in:
>> http://lists.freedesktop.org/archives/mesa-dev/2015-September/095070.
>> html
>>
>> The condition in my patch:
>> (var->type
v2: Fix the x_scale in the shader. Remove the doubts in the commit
message.
---
After some helpful explanation from Anuj and reading the code a bit
more, I think I understand this a bit better and I no longer think
there is an issue with the sample map array having out-of-bounds
indices. The t
On Thu, Sep 24, 2015 at 1:32 AM, Alejandro Piñeiro wrote:
> Without this commit, copy propagation is discarded if it involves
> a uniform with an instruction that has 3 sources. But 3 sourced
> instructions can access scalar values.
>
> For example, this is what vec4_visitor::fix_3src_operand() is
Reviewed-by: Jason Ekstrand
On Thu, Sep 24, 2015 at 1:57 AM, Eduardo Lima Mitev wrote:
> When validating format+type+internalFormat for texture pixel operations
> on GLES3, the effective internal format should be used if the one
> specified is an unsized internal format. Page 127, section "3.8 T
Emil Velikov writes:
> Hi all,
>
> On 10 September 2015 at 00:30, Mark Janes wrote:
>> Mark Janes writes:
>>
>>> Francisco Jerez writes:
>>>
Mark Janes writes:
> When I tested this, I saw an intermittent BSW gpu hang. I haven't been
> able to confirm that it is due to the h
Without this commit, copy propagation is discarded if it involves
a uniform with an instruction that has 3 sources. But 3 sourced
instructions can access scalar values.
For example, this is what vec4_visitor::fix_3src_operand() is already
doing:
if (src.file == UNIFORM && brw_is_single_value_s
On 25 September 2015 12:54:38 am AEST, "Samuel Iglesias Gonsálvez"
wrote:
>
>
>On 24/09/15 02:04, Timothy Arceri wrote:
>> On Wed, 2015-09-23 at 17:02 +0200, Antía Puentes wrote:
>>> Hi! Timothy,
>>> thanks for your review.
>>>
>>> Seeing your patch in:
>>>
>http://lists.freedesktop.org/archive
On 09/24/2015 05:39 PM, Jason Ekstrand wrote:
> Reviewed-by: Jason Ekstrand
>
Thanks! I will wait for Mark to confirm if it is safe or not to push the
series, since it will effectively regress the 3 dEQP tests.
I should also remove the "Bugzilla:" tag from this commit, since it
doesn't fix the
On Thu, Sep 24, 2015 at 9:29 AM, Alejandro Piñeiro wrote:
> Without this commit, copy propagation is discarded if it involves
> a uniform with an instruction that has 3 sources. But 3 sourced
> instructions can access scalar values.
>
> For example, this is what vec4_visitor::fix_3src_operand() is
Cc'ing stable.
On Tue, Sep 22, 2015 at 9:53 AM, Antia Puentes wrote:
> Gen6 MATH instructions can not execute in align16 mode, so swizzles or
> writemasking are not allowed.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92033
> ---
>
> I have tried to find an example where the writem
On Thu, Sep 24, 2015 at 8:07 AM, Neil Roberts wrote:
>
> v2: Fix the x_scale in the shader. Remove the doubts in the commit
> message.
> ---
>
> After some helpful explanation from Anuj and reading the code a bit
> more, I think I understand this a bit better and I no longer think
> there is a
On Thu, Sep 24, 2015 at 11:41:15AM +0100, Emil Velikov wrote:
> Hi guys,
>
> On 2 September 2015 at 20:10, Pohjolainen, Topi
> wrote:
> > On Thu, Aug 27, 2015 at 10:05:14AM -0700, Ben Widawsky wrote:
> >> On Thu, Aug 27, 2015 at 10:51:59AM +0300, Pohjolainen, Topi wrote:
> >> > On Wed, Aug 26, 20
On Thu, Sep 24, 2015 at 1:57 AM, Eduardo Lima Mitev wrote:
> This is a new version of the series that attempt to fix the regression
> reported at:
>
> https://bugs.freedesktop.org/show_bug.cgi?id=91582
>
> The review by Jason helped me uncover the fact that the following 3 dEQP
> tests are buggy
On Thu, Sep 24, 2015 at 11:54:57AM +0100, Emil Velikov wrote:
> Hi Ben,
>
> On 11 September 2015 at 20:15, Ben Widawsky wrote:
> > On Fri, Sep 11, 2015 at 12:12:15PM -0700, Jordan Justen wrote:
> >> On 2015-09-10 16:59:12, Ben Widawsky wrote:
> >> > All SKL SKUs except the lowest one which has ha
On Thu, Sep 24, 2015 at 2:15 PM, Bas Nieuwenhuizen
wrote:
> Hi Marek,
>
> Thanks for the review and my apologies, it seems I underestimated the
> potential for regressions in this series.
>
> See below for some comments in reaction to the review.
>
> For a v2 is it preferred that I rebase it to ma
This fixes a race condition in the glx-multithreaded-shader-compile
test.
CC: "10.6 11.0"
---
src/gallium/drivers/radeon/radeon_llvm_emit.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c
b/src/gallium/drivers/radeon/radeon_llvm_emit.c
index
Pushed this patch. Thanks.
BTW, I don't think this is a candidate for stable.
Marek
On Fri, Sep 4, 2015 at 8:27 PM, Benjamin Bellec wrote:
> Signed-off-by: Benjamin Bellec
> ---
> src/gallium/drivers/radeon/r600_pipe_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --
On Wed, Sep 2, 2015 at 12:55 AM, Jose Fonseca wrote:
> I'm all for TGIS simplification, but I just checked, and we rely on TGSI
> predicates for some of our internal state trackers. So I'll need more time
> to evaluate how much effort it would be to not rely on it, and when can it
> be done.
Any
https://bugs.freedesktop.org/show_bug.cgi?id=91596
--- Comment #4 from Marek Olšák ---
What happens if you hide the extension on Android?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
___
Pushed, thanks.
Marek
On Wed, Sep 23, 2015 at 10:30 PM, Mauro Rossi wrote:
> ---
> src/gallium/drivers/radeonsi/Android.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/drivers/radeonsi/Android.mk
> b/src/gallium/drivers/radeonsi/Android.mk
> index b469aca..7e5e54b 10064
Drivers and state trackers that use LLVM for generating code, must
register the targets they use with LLVM's global TargetRegistry.
The TargetRegistry is not thread-safe, so all targets must be added
to the registry before it can be queried for target information.
When drivers and state trackers i
On Wed, Sep 9, 2015 at 10:07 AM, Michel Dänzer wrote:
> On 07.09.2015 07:17, Marek Olšák wrote:
>> From: Marek Olšák
>>
>> We will only do depth-only or stencil-only decompress blits, whichever is
>> needed by textures, instead of always doing both.
>> ---
>> src/gallium/drivers/r600/evergreen_s
Without this commit, copy propagation is discarded if it involves
a uniform with an instruction that has 3 sources. But 3 sourced
instructions can access scalar values.
For example, this is what vec4_visitor::fix_3src_operand() is already
doing:
if (src.file == UNIFORM && brw_is_single_value_s
Reviewed-by: Matt Turner
Thanks!
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
For the series:
Reviewed-by: Marek Olšák
Marek
On Thu, Sep 24, 2015 at 6:32 PM, Tom Stellard wrote:
> This fixes a race condition in the glx-multithreaded-shader-compile
> test.
>
> CC: "10.6 11.0"
> ---
> src/gallium/drivers/radeon/radeon_llvm_emit.c | 3 +++
> 1 file changed, 3 insertions(
On Thursday, September 24, 2015 07:24:50 PM Marek Olšák wrote:
> On Thu, Sep 24, 2015 at 2:15 PM, Bas Nieuwenhuizen
>
> wrote:
> > Hi Marek,
> >
> > Thanks for the review and my apologies, it seems I underestimated the
> > potential for regressions in this series.
> >
> > See below for some com
Can you please add this commit to the branch for 11.0.1?
commit 2ea16966ae66d4dd5c5dcb996d7996d9c734bbee
Author: Kristian Høgsberg Kristensen
Date: Wed Sep 23 16:57:47 2015 -0700
i965: Respect stride and subreg_offset for ATTR registers
It fixes a Braswell dEQP regression.
thanks,
Mark
On Thu, Sep 24, 2015 at 1:18 PM, Mark Janes wrote:
> Can you please add this commit to the branch for 11.0.1?
>
> commit 2ea16966ae66d4dd5c5dcb996d7996d9c734bbee
> Author: Kristian Høgsberg Kristensen
> Date: Wed Sep 23 16:57:47 2015 -0700
>
> i965: Respect stride and subreg_offset for ATTR
On Thu, Sep 24, 2015 at 9:47 PM, Bas Nieuwenhuizen
wrote:
> On Thursday, September 24, 2015 07:24:50 PM Marek Olšák wrote:
>> On Thu, Sep 24, 2015 at 2:15 PM, Bas Nieuwenhuizen
>>
>> wrote:
>> > Hi Marek,
>> >
>> > Thanks for the review and my apologies, it seems I underestimated the
>> > potenti
On Thu, Sep 24, 2015 at 11:54 AM, Alejandro Piñeiro
wrote:
> Without this commit, copy propagation is discarded if it involves
> a uniform with an instruction that has 3 sources. But 3 sourced
> instructions can access scalar values.
>
> For example, this is what vec4_visitor::fix_3src_operand() i
Hi Tom,
On 24 September 2015 at 17:31, Tom Stellard wrote:
> Drivers and state trackers that use LLVM for generating code, must
> register the targets they use with LLVM's global TargetRegistry.
> The TargetRegistry is not thread-safe, so all targets must be added
> to the registry before it can
On Tue, Sep 22, 2015 at 4:18 PM, Ben Widawsky wrote:
> On Thu, Sep 17, 2015 at 05:00:11PM +0100, Neil Roberts wrote:
> > In order to accomodate 16x MSAA, the starting sample pair index is now
> > 3 bits rather than 2 on SKL+.
>
> Hooray for bad docs. "PS Thread Payload for Normal Dispatch": SSPI
When USE_MGL_NAMESPACE is defined, _glapi_get_stub will check for the "m"
prefix before trying to skip it, so that "glFoo" and "mglFoo" are
equivalent.
This should let it work with all the places where something calls
_glapi_get_proc_offset with a hard-coded name that starts with the normal
"gl" p
Rearranged the GLX_ALIAS macro in glextensions.h so that it will pick up
the renames from glx_mangle.h.
Fixed the alias attribute for glXGetProcAddress when USE_MGL_NAMESPACE is
defined.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=2
---
src/glx/glxcmds.c | 4
src/glx/gl
Some hardware (such as Broadwell) can run geometry shaders more
efficiently when the number of vertices emitted is statically known.
This pass provides a way to obtain the constant vertex count, or
-1 indicating that the vertex count is unknown/non-constant.
Signed-off-by: Kenneth Graunke
---
s
Broadwell's 3DSTATE_GS contains new "Static Output" and "Static Vertex
Count" fields, which control a new optimization. Normally, geometry
shaders can output arbitrary numbers of vertices, which means that
resource allocation has to be done on the fly. However, if the number
of vertices is static
The visitor was setting a mlen that was wrong for Broadwell, but the
generator was ignoring it and doing the right thing regardless. We may
as well move the logic fully into the visitor. This will be useful in
the next commit as well.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i96
On Fri, Sep 11, 2015 at 3:19 AM, Tapani Pälli wrote:
> This makes sure that user is still able to query properties about
> variables that have gotten packed by lower_packed_varyings pass.
>
> Fixes following OpenGL ES 3.1 test:
>ES31-CTS.program_interface_query.separate-programs-vertex
>
> v2:
On 09/25/2015 08:45 AM, Ilia Mirkin wrote:
On Fri, Sep 11, 2015 at 3:19 AM, Tapani Pälli wrote:
This makes sure that user is still able to query properties about
variables that have gotten packed by lower_packed_varyings pass.
Fixes following OpenGL ES 3.1 test:
ES31-CTS.program_interfac
On 2015-09-24 22:20:40, Kenneth Graunke wrote:
> Broadwell's 3DSTATE_GS contains new "Static Output" and "Static Vertex
> Count" fields, which control a new optimization. Normally, geometry
> shaders can output arbitrary numbers of vertices, which means that
> resource allocation has to be done on
Broadwell's 3DSTATE_GS contains new "Static Output" and "Static Vertex
Count" fields, which control a new optimization. Normally, geometry
shaders can output arbitrary numbers of vertices, which means that
resource allocation has to be done on the fly. However, if the number
of vertices is static
72 matches
Mail list logo
