Re: [Mesa-dev] [PATCH 5/5] i965/vec4_nir: Properly handle integer multiplies on BDW+

2015-08-11 Thread Kenneth Graunke
On Monday, August 03, 2015 05:22:14 PM Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 52 > -- > 1 file changed, 28 insertions(+), 24 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp > b/src/mesa/drivers/dri/i965/br

Re: [Mesa-dev] [PATCH 1/2] i965: Add SKL support to brw_miptree_get_horizontal_slice_pitch().

2015-08-11 Thread Francisco Jerez
Jason Ekstrand writes: > On Sat, Aug 8, 2015 at 2:58 AM, Francisco Jerez wrote: >> Jason Ekstrand writes: >> >>> I'm not a huge fan of this patch. Really, given how complicated 3-D >>> textures are on SKL, there really is no sensible horizontal slice >>> pitch. We could return 0 as an "invali

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Lower 32x32 bit multiplication on BXT.

2015-08-11 Thread Francisco Jerez
Neil Roberts writes: > Are you sure this patch is necessary? The documentation for the multiply > instruction on BDW+ says: > > SourceType : *D > DestinationType : *D > Project : EXCLUDE(CHV) > > This to me implies that it should work on BXT because it doesn't say > EXCLUDE(

Re: [Mesa-dev] [PATCHv2 07/14] i965: Implement surface state set-up for shader images.

2015-08-11 Thread Francisco Jerez
Jason Ekstrand writes: > On Sat, Aug 8, 2015 at 4:04 AM, Francisco Jerez wrote: >> Jason Ekstrand writes: >> >>> On Wed, May 13, 2015 at 9:43 AM, Francisco Jerez >>> wrote: v2: Add SKL support. --- src/mesa/drivers/dri/i965/brw_context.h | 2 + src/mesa/drivers

Re: [Mesa-dev] [PATCH] mesa/formats: Fix swizzle flipping for big-endian targets

2015-08-11 Thread Oded Gabbay
On Mon, Aug 10, 2015 at 9:50 AM, Jason Ekstrand wrote: > The swizzle defines where in the format you should look for any given > channel. When we flip the format around for BE targets, we need to change > the destinations of the swizzles, not the sources. For example, say the > format is an RGBX

Re: [Mesa-dev] [PATCH 4/4] r600g: use a bitfield to track dirty atoms

2015-08-11 Thread Marek Olšák
On Tue, Aug 11, 2015 at 2:20 AM, Grazvydas Ignotas wrote: > On Mon, Aug 10, 2015 at 1:47 PM, Marek Olšák wrote: >> Please never use "long" in Mesa. It only has 32 bits on 32-bit >> systems. uint64_t is generally used for all unsigned 64-bit variables >> and "llu" or "ull" is the number suffix. Al

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Lower 32x32 bit multiplication on BXT.

2015-08-11 Thread Francisco Jerez
Francisco Jerez writes: > Neil Roberts writes: > >> Are you sure this patch is necessary? The documentation for the multiply >> instruction on BDW+ says: >> >> SourceType : *D >> DestinationType :*D >> Project :EXCLUDE(CHV) >> >> This to me implies that it should wor

Re: [Mesa-dev] [PATCH] i965/skl: Remove early platform support

2015-08-11 Thread Neil Roberts
Ben Widawsky writes: > Either of you opposed to doing it as a follow-on patch? (This failure > you speak of was the primary goal for removing it). Initially, I tried > to remove it, but we do still seem to use this logic pre-HSW, and so > things got messier than I initially anticipated. Doing a

Re: [Mesa-dev] [PATCH] mesa/formats: Fix swizzle flipping for big-endian targets

2015-08-11 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga El 2015-08-11 14:25, Oded Gabbay escribió: On Mon, Aug 10, 2015 at 9:50 AM, Jason Ekstrand wrote: The swizzle defines where in the format you should look for any given channel. When we flip the format around for BE targets, we need to change the destinations

Re: [Mesa-dev] [PATCH] mesa/formats: Only do byteswapping for packed formats

2015-08-11 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga El 2015-08-08 18:04, Jason Ekstrand escribió: Cc: Iago Toral Cc: Oded Gabbay --- src/mesa/main/formats.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/formats.c b/src/mesa/main/formats.c index baeb1bf..d927073 100644 -

[Mesa-dev] drm/i915/bxt: Pooled EU support

2015-08-11 Thread Siluvery, Arun
Hi, BXT supports Pooled EU feature using which EU can be pooled to process work collectively. It is mainly required for GPGPU, Media and compute shaders. I have completed the implementation in kernel and patches are sent to intel-gfx mailing list. These are already reviewed but we need an opensou

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Lower 32x32 bit multiplication on BXT.

2015-08-11 Thread Neil Roberts
Ok, that makes sense, thanks for the detailed explanation. I think you're right, given the extra restrictions avoiding the integer dword multiplication seems like the simplest solution. I can't say that I fully understand what the documentation is trying to say here. Does it mean that the horizont

[Mesa-dev] [PATCH 1/5] main: add extension GL_ARB_shader_image_size

2015-08-11 Thread Martin Peres
Signed-off-by: Martin Peres --- src/glsl/glcpp/glcpp-parse.y| 3 +++ src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 5 files changed, 8 insertions(+) diff --git a/src/glsl/glcpp/glcpp

[Mesa-dev] [PATCH 3/5] nir: convert the glsl intrinsic image_size to nir_intrinsic_image_size

2015-08-11 Thread Martin Peres
Signed-off-by: Martin Peres --- src/glsl/nir/glsl_to_nir.cpp | 18 -- src/glsl/nir/nir_intrinsics.h | 2 ++ 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 77327b6..bae9d20 100644 --- a/src/glsl/ni

[Mesa-dev] [PATCH 0/5] Add support for ARB_shader_image_size

2015-08-11 Thread Martin Peres
This series is enough to pass all the image-size piglit test. Martin Peres (5): main: add extension GL_ARB_shader_image_size glsl: add support for the imageSize builtin nir: convert the glsl intrinsic image_size to nir_intrinsic_image_size i965: handle nir_intrinsic_image_size i965: enab

[Mesa-dev] [PATCH 2/5] glsl: add support for the imageSize builtin

2015-08-11 Thread Martin Peres
The code is heavily inspired from Francisco Jerez's code supporting the image_load_store extension. I moved out image_types[] out of builtin_builder::add_image_function to share it with the newly-added builtin_builder::add_image_size_functions. Backends willing to support this builtin should hand

[Mesa-dev] [PATCH 4/5] i965: handle nir_intrinsic_image_size

2015-08-11 Thread Martin Peres
Signed-off-by: Martin Peres --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 51 1 file changed, 51 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index ce4153d..3d172ff 100644 --- a/src/mesa/drivers/

[Mesa-dev] [PATCH 5/5] i965: enable GL_ARB_shader_image_size

2015-08-11 Thread Martin Peres
Signed-off-by: Martin Peres --- docs/GL3.txt | 4 ++-- docs/relnotes/11.0.0.html| 1 + src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 54c0c5a..

Re: [Mesa-dev] [PATCH 2/5] glsl: add support for the imageSize builtin

2015-08-11 Thread Ilia Mirkin
On Tue, Aug 11, 2015 at 12:43 PM, Martin Peres wrote: > The code is heavily inspired from Francisco Jerez's code supporting the > image_load_store extension. > > I moved out image_types[] out of builtin_builder::add_image_function to > share it with the newly-added builtin_builder::add_image_size_

Re: [Mesa-dev] [PATCH 2/5] glsl: add support for the imageSize builtin

2015-08-11 Thread Martin Peres
On 11/08/15 19:52, Ilia Mirkin wrote: On Tue, Aug 11, 2015 at 12:43 PM, Martin Peres wrote: The code is heavily inspired from Francisco Jerez's code supporting the image_load_store extension. I moved out image_types[] out of builtin_builder::add_image_function to share it with the newly-added

Re: [Mesa-dev] Mesa 11.0.0 release plan

2015-08-11 Thread Emil Velikov
On 29/07/15 19:20, Emil Velikov wrote: > Hi all, > > Below is the preliminary release schedule for Mesa 11.0.0 > > August 21st 2015 - Feature freeze/Release candidate 1 > August 28th 2015 - Release candidate 2 > September 04th 2015 - Release candidate 3 > September 11th 2015 - Release candidate 4

[Mesa-dev] [PATCH 1/2][RFC] docs: Update with GLES3.2 entries and status

2015-08-11 Thread Thomas Helland
Signed-off-by: Thomas Helland --- These are listed to the best of my knowledge, looking at the nvidia driver dropped yesterday, and a glance at the "what changed according to the ARB variant" section of each extension spec. Hopefully it should not be too far off. Feel free to leave your comments

[Mesa-dev] [PATCH 2/2][RFC] docs: Add the 2015 ARB extensions

2015-08-11 Thread Thomas Helland
Signed-off-by: Thomas Helland --- This adds a section for the extensions nvidia has chosen to call the "GL ARB 2015 Extensions" unveiled at SIGGRAPH. Also some minor whitespace fixes for consistency. We might also want to add other extensions that are not part of the openGL core specs, but that w

Re: [Mesa-dev] [PATCH 1/4] gallium/radeon: use helper functions to mark atoms dirty

2015-08-11 Thread Marek Olšák
I pushed this series. Thanks. Marek On Sun, Aug 9, 2015 at 11:42 PM, Grazvydas Ignotas wrote: > This is analogous to r300_mark_atom_dirty() used by r300, and will > be used by later patches. For common radeon code, appropriate helper > is called through a function pointer. > > No functional chan

[Mesa-dev] Mesa 10.6.4

2015-08-11 Thread Emil Velikov
Mesa 10.6.4 is now available. In this release we have a few GL specific fixes (in both dri drivers and the EGL loader), an updated mesa.icd file and a crashfix for the standalone glcpp tool. Anuj Phogat (6): mesa: Turn get_readpixels_transfer_ops() in to a global function meta: Fix t

Re: [Mesa-dev] [PATCH 5/5] i965: enable GL_ARB_shader_image_size

2015-08-11 Thread Matt Turner
On Tue, Aug 11, 2015 at 9:43 AM, Martin Peres wrote: > Signed-off-by: Martin Peres > --- > docs/GL3.txt | 4 ++-- > docs/relnotes/11.0.0.html| 1 + > src/mesa/drivers/dri/i965/intel_extensions.c | 1 + > 3 files changed, 4 insertions(+), 2 dele

[Mesa-dev] Reworking mesa mapi (Was Re: [PATCH 2/2] glapi: remap_helper.py: remove unused argument 'es')

2015-08-11 Thread Emil Velikov
Hi Dylan, On 21/06/15 22:20, Dylan Baker wrote: > Cleanups are definitely party of the plan. I'm doing three phases. First > is going to mako for generation. Second is using the khronos XML. > Finally I want to clean things up and hybridize for python 3 > I'm thinking about doing some cleanup+fix

[Mesa-dev] [PATCH 2/2] nir: Don't try to scalarize unpack ops.

2015-08-11 Thread Eric Anholt
Avoids regressions in vc4 when trying to do our blending in NIR. v2: Add the other unpack ops I meant to when writing the original commit message. --- src/glsl/nir/nir_lower_alu_to_scalar.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/glsl/nir/nir_lower_alu_to_scal

[Mesa-dev] [PATCH 1/2] nir: Add a nir_opt_undef() to handle csels with undef.

2015-08-11 Thread Eric Anholt
We may find a cause to do more undef optimization in the future, but for now this fixes up things after if flattening. vc4 was handling this internally most of the time, but a GLB2.7 shader that did a conditional discard and assign gl_FragColor in the else was still emitting some extra code. tota

Re: [Mesa-dev] [PATCH 5/5] i965: enable GL_ARB_shader_image_size

2015-08-11 Thread Francisco Jerez
Matt Turner writes: > On Tue, Aug 11, 2015 at 9:43 AM, Martin Peres > wrote: >> Signed-off-by: Martin Peres >> --- >> docs/GL3.txt | 4 ++-- >> docs/relnotes/11.0.0.html| 1 + >> src/mesa/drivers/dri/i965/intel_extensions.c | 1 + >> 3 files

Re: [Mesa-dev] [PATCH 2/2] nir: Don't try to scalarize unpack ops.

2015-08-11 Thread Matt Turner
On Tue, Aug 11, 2015 at 11:25 AM, Eric Anholt wrote: > Avoids regressions in vc4 when trying to do our blending in NIR. > > v2: Add the other unpack ops I meant to when writing the original commit > message. > --- > src/glsl/nir/nir_lower_alu_to_scalar.c | 15 +++ > 1 file changed

Re: [Mesa-dev] [PATCH 1/2] nir: Add a nir_opt_undef() to handle csels with undef.

2015-08-11 Thread Thomas Helland
2015-08-11 20:25 GMT+02:00 Eric Anholt : > We may find a cause to do more undef optimization in the future, but for > now this fixes up things after if flattening. vc4 was handling this > internally most of the time, but a GLB2.7 shader that did a conditional > discard and assign gl_FragColor in t

Re: [Mesa-dev] [PATCH 2/2] nir: Don't try to scalarize unpack ops.

2015-08-11 Thread Eric Anholt
Matt Turner writes: > On Tue, Aug 11, 2015 at 11:25 AM, Eric Anholt wrote: >> Avoids regressions in vc4 when trying to do our blending in NIR. >> >> v2: Add the other unpack ops I meant to when writing the original commit >> message. >> --- >> src/glsl/nir/nir_lower_alu_to_scalar.c | 15 +++

Re: [Mesa-dev] [PATCH 1/2] i965: Add SKL support to brw_miptree_get_horizontal_slice_pitch().

2015-08-11 Thread Jason Ekstrand
On Tue, Aug 11, 2015 at 2:45 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Sat, Aug 8, 2015 at 2:58 AM, Francisco Jerez >> wrote: >>> Jason Ekstrand writes: >>> I'm not a huge fan of this patch. Really, given how complicated 3-D textures are on SKL, there really is no

Re: [Mesa-dev] [PATCH] r600, compute: setup compute sampler states and views

2015-08-11 Thread Marek Olšák
On Mon, Aug 10, 2015 at 8:30 PM, Zoltan Gilian wrote: > --- > src/gallium/drivers/r600/evergreen_compute.c | 25 ++ > src/gallium/drivers/r600/evergreen_state.c | 30 -- > src/gallium/drivers/r600/evergreend.h| 5 + > src/gallium/drivers/

[Mesa-dev] [Bug 91596] EGL_KHR_gl_colorspace (v2) causes problem with Android-x86 GUI

2015-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91596 --- Comment #3 from Mauro Rossi --- Hi, as a confirmation the described Android-x86 GUI problems are solved by reverting commit c2c2e9ab604793c6e01f85497f3f5bf645f962fa. I am available if you need further information or to test upcoming patches

[Mesa-dev] [PATCH 1/2] i965: Optimize brw_inst_bits() and brw_compact_inst_bits().

2015-08-11 Thread Matt Turner
Cuts about 1k of .text. text data bss dec hex filename 5018165 19716027672 5242997 500075 i965_dri.so before 5017141 19716027672 5241973 4ffc75 i965_dri.so after --- src/mesa/drivers/dri/i965/brw_inst.h | 8 1 file changed, 4 insertions(+), 4 de

[Mesa-dev] [PATCH 2/2] i965: Optimize brw_inst_set_bits() and brw_compact_inst_set_bits().

2015-08-11 Thread Matt Turner
Cuts about 2k of .text. text data bss dec hex filename 5017141 19716027672 5241973 4ffc75 i965_dri.so before 5014981 19716027672 5239813 4ff405 i965_dri.so after --- src/mesa/drivers/dri/i965/brw_inst.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

Re: [Mesa-dev] [PATCH 1/2] nir: Add a nir_opt_undef() to handle csels with undef.

2015-08-11 Thread Thomas Helland
2015-08-11 20:25 GMT+02:00 Eric Anholt : > We may find a cause to do more undef optimization in the future, but for > now this fixes up things after if flattening. vc4 was handling this > internally most of the time, but a GLB2.7 shader that did a conditional > discard and assign gl_FragColor in t

Re: [Mesa-dev] [PATCH 1/2] i965: Optimize brw_inst_bits() and brw_compact_inst_bits().

2015-08-11 Thread Kenneth Graunke
On Tuesday, August 11, 2015 01:29:46 PM Matt Turner wrote: > Cuts about 1k of .text. > >text data bss dec hex filename > 5018165 19716027672 5242997 500075 i965_dri.so before > 5017141 19716027672 5241973 4ffc75 i965_dri.so after > --- > src/mesa/driver

[Mesa-dev] [PATCH] gallium: add support for GLES texture float extensions

2015-08-11 Thread Marek Olšák
From: Marek Olšák --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/ilo/ilo_screen.c | 1 + src/gallium/drivers/llvmpipe/lp_screen.c

[Mesa-dev] [PATCH] st/mesa: small cleanup in st_extensions.c

2015-08-11 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_extensions.c | 40 -- 1 file changed, 9 insertions(+), 31 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 5459891..77d6201 100644 --- a/src/mesa/state

Re: [Mesa-dev] [PATCH] gallium: add support for GLES texture float extensions

2015-08-11 Thread Ilia Mirkin
Marek, take a look at http://people.freedesktop.org/~imirkin/glxinfo/glxinfo.html#p=es&v=Vendor Note that a4xx supports all 4 exts, but a3xx supports half_float_linear but not float_linear. Thoughts? On Tue, Aug 11, 2015 at 5:25 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium

Re: [Mesa-dev] [PATCH] st/mesa: small cleanup in st_extensions.c

2015-08-11 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Tue, Aug 11, 2015 at 5:26 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/state_tracker/st_extensions.c | 40 > -- > 1 file changed, 9 insertions(+), 31 deletions(-) > > diff --git a/src/mesa/state_tracker/st_extensions

Re: [Mesa-dev] [PATCH] gallium: add support for GLES texture float extensions

2015-08-11 Thread Roland Scheidegger
FWIW d3d10 has the same requirements, the "any filter" needs to be supported for half float formats, but is optional for float formats (d3d10.1 made it required for floats). https://msdn.microsoft.com/en-us/library/windows/desktop/cc627090%28v=vs.85%29.aspx So there might well be some more hw where

Re: [Mesa-dev] [PATCH] gallium: add support for GLES texture float extensions

2015-08-11 Thread Matt Turner
On Tue, Aug 11, 2015 at 2:25 PM, Marek Olšák wrote: > From: Marek Olšák > > --- Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74329 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] nir: Add a nir_opt_undef() to handle csels with undef.

2015-08-11 Thread Matt Turner
On Tue, Aug 11, 2015 at 1:31 PM, Thomas Helland wrote: > 2015-08-11 20:25 GMT+02:00 Eric Anholt : >> We may find a cause to do more undef optimization in the future, but for >> now this fixes up things after if flattening. vc4 was handling this >> internally most of the time, but a GLB2.7 shader

[Mesa-dev] [Bug 85203] [DRI2][RadeonSI] Pageflip completion event has impossible msc.

2015-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85203 Andrei Slavoiu changed: What|Removed |Added CC||ansl...@yahoo.com -- You are receiving

[Mesa-dev] [Bug 73465] latest mesa from git doesn't compile on powerpc

2015-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73465 Matt Turner changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 91591] rounding.h:102:2: error: #error "Unsupported or undefined LONG_BIT"

2015-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91591 Matt Turner changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v2 21/21] i965/gen7: Resolve GCC sign-compare warning.

2015-08-11 Thread Thomas Helland
2015-08-06 10:47 GMT+02:00 Rhys Kidd : > That is correct Thomas. I do not have commit access to push these myself. > Oh, wow. Top-quoting is bad. Sorry about that. After a discussion with Matt we decided that I'll pull these down, add my R-b, and put it in a branch with some of my own reviewed pat

[Mesa-dev] [PATCH 2/5] radeonsi: add support for gl_PrimitiveID in the fragment shader

2015-08-11 Thread Marek Olšák
From: Marek Olšák It must be obtained from the VS. The GS scenario A must be enabled for PrimID to be generated for the VS. + 4 piglits --- src/gallium/drivers/radeonsi/si_shader.c| 22 +++--- src/gallium/drivers/radeonsi/si_shader.h| 12 src/galliu

[Mesa-dev] [PATCH 4/5] radeonsi: revert a wrong DB bug workaround for VI

2015-08-11 Thread Marek Olšák
From: Marek Olšák The bug was misunderstood. Besides that, the bug affects a DB feature we don't use yet. --- src/gallium/drivers/radeonsi/si_state.c | 4 1 file changed, 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 86

[Mesa-dev] [PATCH 5/5] radeonsi: fix polygon offset scale

2015-08-11 Thread Marek Olšák
From: Marek Olšák The value was copied from r300g, which uses 1/12 subpixels, but this hw uses 1/16 subpixels. Fixes piglit: gl-1.4-polygon-offset (formerly a glean test) --- src/gallium/drivers/radeonsi/si_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/

[Mesa-dev] [PATCH 1/5] radeonsi: move VGT_GS_MODE to the VS state

2015-08-11 Thread Marek Olšák
From: Marek Olšák The VS will want to select GS scenario A here (VS with PrimitiveID). --- src/gallium/drivers/radeonsi/si_state_shaders.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/s

[Mesa-dev] [PATCH 3/5] radeonsi: enable VS_OUT_MISC_SIDE_BUS_ENA

2015-08-11 Thread Marek Olšák
From: Marek Olšák This is recommended for better performance. Diag tests always enable this. --- src/gallium/drivers/radeonsi/si_state.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index bd11c4b..863991c 1

[Mesa-dev] [PATCH 1/2] r600g: fix polygon offset scale

2015-08-11 Thread Marek Olšák
From: Marek Olšák The value was copied from r300g, which uses 1/12 subpixels, but this hw uses 1/16 subpixels. Should fix piglit: gl-1.4-polygon-offset (formerly a glean test) (untested, ported from radeonsi) --- src/gallium/drivers/r600/evergreen_state.c | 2 +- src/gallium/drivers/r600/r600_s

[Mesa-dev] [PATCH 2/2] r600g: allow setting geometry shader sampler states

2015-08-11 Thread Marek Olšák
From: Marek Olšák We were ignoring them. This is both hilarious and sad. Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/r600/r600_state_common.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/gallium/drivers/r600/r600_state_common.c b/src/gallium/drivers/r600/r600_s

[Mesa-dev] [PATCH 2/4] mesa/formats: refactor by removing compressed formats

2015-08-11 Thread Nanley Chery
From: Nanley Chery All compressed formats return GL_FALSE. Remove all switch cases for compressed formats. Compressed formats should be at the bottom of the switch statement, so ordering is still preserved. Cc: Jason Ekstrand Signed-off-by: Nanley Chery --- src/mesa/main/formats.c | 47 ++

[Mesa-dev] [PATCH 3/4] mesa/formats: add more MESA_FORMAT_LAYOUTs

2015-08-11 Thread Nanley Chery
From: Nanley Chery Add the classes of compressed formats as layouts. This will make determining if a texture is an ASTC format simpler. Cc: Jason Ekstrand Signed-off-by: Nanley Chery --- src/mesa/main/format_info.py | 4 +++- src/mesa/main/formats.c | 6 ++ src/mesa/main/formats.h

[Mesa-dev] [PATCH 4/4] mesa/formats: refactor by globbing on types in switch statement

2015-08-11 Thread Nanley Chery
From: Nanley Chery Combine the adjacent cases which have the same GL type in the switch statemnt. Signed-off-by: Nanley Chery --- src/mesa/main/formats.c | 152 ++-- 1 file changed, 17 insertions(+), 135 deletions(-) diff --git a/src/mesa/main/forma

[Mesa-dev] [PATCH 1/4] mesa/formats: only do type and component lookup for uncompressed formats

2015-08-11 Thread Nanley Chery
From: Nanley Chery Only uncompressed formats have a non-void type and actual components per pixel. Rename _mesa_format_to_type_and_comps to _mesa_uncompressed_format_to_type_and_comps and require callers to check if the format is not compressed. Cc: Jason Ekstrand Signed-off-by: Nanley Chery -

[Mesa-dev] [Bug 91591] rounding.h:102:2: error: #error "Unsupported or undefined LONG_BIT"

2015-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91591 Vinson Lee changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

Re: [Mesa-dev] [PATCH 3/4] mesa/formats: add more MESA_FORMAT_LAYOUTs

2015-08-11 Thread Ilia Mirkin
On Tue, Aug 11, 2015 at 7:07 PM, Nanley Chery wrote: > From: Nanley Chery > > Add the classes of compressed formats as layouts. This will make determining > if > a texture is an ASTC format simpler. > > Cc: Jason Ekstrand > Signed-off-by: Nanley Chery > --- > src/mesa/main/format_info.py | 4

[Mesa-dev] [PATCH v2] mesa: don't enable online compression for ASTC formats

2015-08-11 Thread Nanley Chery
From: Nanley Chery In agreement with the ASTC spec, this makes calls to TexImage*D unsuccessful. Implied by the spec, Generate[Texture]Mipmap and [Copy]TexSubImage*D calls must be unsuccessful as well. v2. actually force attempts to compress online to fail. Signed-off-by: Nanley Chery --- src

[Mesa-dev] [PATCH v3] mesa/teximage: accept ASTC formats for 3D texture specification

2015-08-11 Thread Nanley Chery
From: Nanley Chery The ASTC spec was revised as follows: Revision 2, April 28, 2015 - added CompressedTex{Sub,}Image3D to commands accepting ASTC format tokens in the New Tokens section [...]. Support only exists in the HDR submode: Add a second new column "3D Tex." which is empty for

Re: [Mesa-dev] [PATCH 3/4] mesa/formats: add more MESA_FORMAT_LAYOUTs

2015-08-11 Thread Nanley Chery
On Tue, Aug 11, 2015 at 4:16 PM, Ilia Mirkin wrote: > On Tue, Aug 11, 2015 at 7:07 PM, Nanley Chery > wrote: > > From: Nanley Chery > > > > Add the classes of compressed formats as layouts. This will make > determining if > > a texture is an ASTC format simpler. > > > > Cc: Jason Ekstrand > >

Re: [Mesa-dev] [PATCH v2] mesa: don't enable online compression for ASTC formats

2015-08-11 Thread Matt Turner
On Tue, Aug 11, 2015 at 4:14 PM, Nanley Chery wrote: > +static bool > +_mesa_format_no_online_compression(const struct gl_context *ctx, GLenum > format) > +{ > + return _mesa_is_astc_format(format) || > + compressedteximage_only_format(ctx, format); Needs one more space of indentation.

[Mesa-dev] [PATCH v2] mesa/formats: add more MESA_FORMAT_LAYOUTs

2015-08-11 Thread Nanley Chery
From: Nanley Chery Add the classes of compressed formats as layouts. This will make determining if a texture is an ASTC format simpler. v2. simplify layout name construction (Ilia). Cc: Jason Ekstrand Signed-off-by: Nanley Chery --- src/mesa/main/format_info.py | 10 +- src/mesa/main

[Mesa-dev] [PATCH v3] mesa: don't enable online compression for ASTC formats

2015-08-11 Thread Nanley Chery
From: Nanley Chery In agreement with the ASTC spec, this makes calls to TexImage*D unsuccessful. Implied by the spec, Generate[Texture]Mipmap and [Copy]TexSubImage*D calls must be unsuccessful as well. v2. actually force attempts to compress online to fail. v3. indentation (Matt). Signed-off-by

Re: [Mesa-dev] [PATCH 1/2] nir: Add a nir_opt_undef() to handle csels with undef.

2015-08-11 Thread Eric Anholt
Thomas Helland writes: > 2015-08-11 20:25 GMT+02:00 Eric Anholt : >> We may find a cause to do more undef optimization in the future, but for >> now this fixes up things after if flattening. vc4 was handling this >> internally most of the time, but a GLB2.7 shader that did a conditional >> disca

Re: [Mesa-dev] [PATCH v3] mesa: don't enable online compression for ASTC formats

2015-08-11 Thread Nanley Chery
This patch is a followup on this: http://lists.freedesktop.org/archives/mesa-dev/2015-June/087055.html On Tue, Aug 11, 2015 at 4:54 PM, Nanley Chery wrote: > From: Nanley Chery > > In agreement with the ASTC spec, this makes calls to TexImage*D > unsuccessful. > Implied by the spec, Generate[Te

[Mesa-dev] [PATCH] mesa/teximage: report the correct function which triggered the error

2015-08-11 Thread Nanley Chery
From: Nanley Chery This function would always report that a dimension or size error occurred in glTexImage even when it was called from glCompressedTexImage. Replace the static string with the dynamically determined caller name. Signed-off-by: Nanley Chery --- src/mesa/main/teximage.c | 8

[Mesa-dev] [PATCH 2/2] i965: add support for textureSamples function

2015-08-11 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/drivers/dri/i965/brw_defines.h | 3 +++ src/mesa/drivers/dri/i965/brw_disasm.c | 1 + src/mesa/drivers/dri/i965/brw_fs.cpp | 7 +++ src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 4 src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH 1/2] glsl: add support for textureSamples function

2015-08-11 Thread Ilia Mirkin
--- src/glsl/builtin_functions.cpp | 32 +- src/glsl/glcpp/glcpp-parse.y | 3 +++ src/glsl/glsl_parser_extras.cpp| 1 + src/glsl/glsl_parser_extras.h | 2 ++ src/glsl/ir.cpp| 5 +++-- src

Re: [Mesa-dev] [PATCH 2/2][RFC] docs: Add the 2015 ARB extensions

2015-08-11 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 03:48 AM, Thomas Helland wrote: > Signed-off-by: Thomas Helland > --- > This adds a section for the extensions nvidia has chosen to > call the "GL ARB 2015 Extensions" unveiled at SI

Re: [Mesa-dev] [PATCH 1/5] main: add extension GL_ARB_shader_image_size

2015-08-11 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 02:43 AM, Martin Peres wrote: > Signed-off-by: Martin Peres > --- > src/glsl/glcpp/glcpp-parse.y| 3 +++ > src/glsl/glsl_parser_extras.cpp | 1 + > src/glsl/glsl_parser_extras.h

Re: [Mesa-dev] [PATCH 1/2] r600g: fix polygon offset scale

2015-08-11 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 09:02 AM, Marek Olšák wrote: > From: Marek Olšák > > The value was copied from r300g, which uses 1/12 subpixels, but this hw > uses 1/16 subpixels. > > Should fix piglit: gl-1.4-po

Re: [Mesa-dev] [PATCH 2/2] r600g: allow setting geometry shader sampler states

2015-08-11 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 09:03 AM, Marek Olšák wrote: > From: Marek Olšák > > We were ignoring them. This is both hilarious and sad. > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/gallium/drivers/r

Re: [Mesa-dev] [PATCH] r600, compute: setup compute sampler states and views

2015-08-11 Thread Edward O'Callaghan
-- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 05:54 AM, Marek Olšák wrote: > On Mon, Aug 10, 2015 at 8:30 PM, Zoltan Gilian > wrote: > > --- > > src/gallium/drivers/r600/evergreen_compute.c | 25 ++ > > src/gallium/drivers/r600/evergreen_s

Re: [Mesa-dev] [PATCH] st/mesa: small cleanup in st_extensions.c

2015-08-11 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 07:34 AM, Ilia Mirkin wrote: > Reviewed-by: Ilia Mirkin > > On Tue, Aug 11, 2015 at 5:26 PM, Marek Olšák wrote: > > From: Marek Olšák > > > > --- > > src/mesa/state_tracker/st_ex

Re: [Mesa-dev] [PATCH] i965/fs: Clamp image array indices to the array bounds on IVB.

2015-08-11 Thread Timothy Arceri
On Mon, 2015-07-27 at 16:01 +0300, Francisco Jerez wrote: > This fixes the spec@arb_shader_image_load_store@invalid index bounds > piglit tests on IVB, which were causing a GPU hang and then a crash > due to the invalid binding table index result of the array index > calculation. Other generations

Re: [Mesa-dev] [PATCH 1/2][RFC] docs: Update with GLES3.2 entries and status

2015-08-11 Thread Tapani Pälli
On 08/11/2015 08:48 PM, Thomas Helland wrote: Signed-off-by: Thomas Helland --- These are listed to the best of my knowledge, looking at the nvidia driver dropped yesterday, and a glance at the "what changed according to the ARB variant" section of each extension spec. Hopefully it should not

Re: [Mesa-dev] [PATCH] mesa/teximage: report the correct function which triggered the error

2015-08-11 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 08/12/2015 03:09 AM, Nanley Chery wrote: From: Nanley Chery This function would always report that a dimension or size error occurred in glTexImage even when it was called from glCompressedTexImage. Replace the static string with the dynamically determined caller

Re: [Mesa-dev] [PATCH 1/2] glsl: add support for textureSamples function

2015-08-11 Thread Tapani Pälli
Hi Ilia; Some comments below; On 08/12/2015 04:51 AM, Ilia Mirkin wrote: --- src/glsl/builtin_functions.cpp | 32 +- src/glsl/glcpp/glcpp-parse.y | 3 +++ src/glsl/glsl_parser_extras.cpp| 1 + src/glsl/glsl_parser_extras.h