On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> Without this patch, piglit test arb_color_buffer_float-readpixels
> fails, when forced to use the meta pbo path.
>
> Signed-off-by: Anuj Phogat
> Cc:
> ---
> src/mesa/drivers/common/meta_tex_subimage.c | 5 +
> 1 file changed, 5 insert
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> ---
> src/mesa/drivers/common/meta.c | 13 ++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c
> index 214a68a..fceb2
Reviewed-by: Samuel Iglesias Gonsálvez
On 18/07/15 03:25, Timothy Arceri wrote:
> ---
> src/glsl/linker.cpp | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
> index b7a783c..cb679bd 100644
> --- a/src/glsl/linker.cpp
> +++ b/src/glsl/linker.
On 18/07/15 03:25, Timothy Arceri wrote:
> ---
> src/glsl/link_uniforms.cpp | 16 ++--
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp
> index 11ae06f..2d50b9b 100644
> --- a/src/glsl/link_uniforms.cpp
> +++ b
Reviewed-by: Samuel Iglesias Gonsálvez
On 18/07/15 03:25, Timothy Arceri wrote:
> This fixes the remaining failing tests in:
> ES31-CTS.program_interface_query.uniform-types
> ---
> src/glsl/linker.cpp | 16 +---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/sr
Reviewed-by: Samuel Iglesias Gonsálvez
On 18/07/15 03:25, Timothy Arceri wrote:
> The type stored in gl_uniform_storage is the type of a single array
> element not the array type so size was always 1.
>
> V2: Dont validate sampler units pointing to 0
> ---
> src/mesa/main/uniform_query.cpp | 20
On 18/07/15 03:25, Timothy Arceri wrote:
> V2: move single dimensionial array detection into a helper
>
s/dimensionial/dimensional
With that change,
Reviewed-by: Samuel Iglesias Gonsálvez
Sam
> Signed-off-by: Timothy Arceri
> ---
> src/glsl/ast.h | 8
> src/glsl/ast_to_h
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> ---
> src/mesa/main/glformats.c | 44
> src/mesa/main/glformats.h | 3 +++
> 2 files changed, 47 insertions(+)
>
> diff --git a/src/mesa/main/glformats.c b/src/mesa/
I agree with Ilia but, as you said, it is not adding a lot of value. So
I give my R-b to either option.
Reviewed-by: Samuel Iglesias Gonsálvez
On 18/07/15 04:12, Timothy Arceri wrote:
> Yeah your right but its also used by _mesa_program_resource_prop
>
> I can move the comment but is it really
On Tue, 2015-07-21 at 09:24 +0200, Iago Toral wrote:
> On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> > Without this patch, piglit test arb_color_buffer_float-readpixels
> > fails, when forced to use the meta pbo path.
> >
> > Signed-off-by: Anuj Phogat
> > Cc:
> > ---
> > src/mesa/dri
On Tue, 2015-07-21 at 08:13 +0200, Iago Toral wrote:
> On Mon, 2015-07-20 at 10:56 -0700, Anuj Phogat wrote:
> > On Mon, Jul 20, 2015 at 5:10 AM, Iago Toral wrote:
> > > On Fri, 2015-06-19 at 13:40 -0700, Anuj Phogat wrote:
> > >> On Tue, Jun 16, 2015 at 9:21 PM, Jason Ekstrand
> > >> wrote:
> >
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
> _mesa_base_tex_format() doesn't handle GL_*_INTEGER formats.
>
> Signed-off-by: Anuj Phogat
> ---
> src/mesa/drivers/common/meta.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/src/mesa/drivers/common/meta.
On Tue, 2015-07-21 at 10:03 +0200, Samuel Iglesias Gonsálvez wrote:
> On 18/07/15 03:25, Timothy Arceri wrote:
> > ---
> > src/glsl/link_uniforms.cpp | 16 ++--
> > 1 file changed, 6 insertions(+), 10 deletions(-)
> >
> > diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniform
On Tuesday, July 14, 2015 04:02:47 PM Emil Velikov wrote:
> See previous two commits for details.
>
> Signed-off-by: Emil Velikov
> ---
> Android.mk | 3 +-
> src/egl/drivers/dri2/Android.mk | 63
> - src/egl/main/Android.mk |
https://bugs.freedesktop.org/show_bug.cgi?id=91254
--- Comment #8 from Tomasz C. ---
> To confirm, the issue only happens on Ironlake for you?
>
> I was unable to reproduce on GM45 or Ivy Bridge using
> 10.6.0 or master.
>
> I tried the 3, 5, 10 and 70 Mbps versions, with
> this command line:
>
I was mistaken, I thought we already had fixed this in the kernel a
couple of years ago. We had not, and the broken read (the hardware
shifts the register output on 64bit kernels, but not on 32bit kernels) is
now enshrined into the ABI. I also had the buggy architecture reversed,
believing it to be
On 20/07/15 21:25, Chad Versace wrote:
> On Fri 17 Jul 2015, Emil Velikov wrote:
>> On 17 July 2015 at 19:11, Ilia Mirkin wrote:
>>> On Fri, Jul 17, 2015 at 2:11 PM, Eric Anholt wrote:
Matt Turner writes:
> On Fri, Jul 17, 2015 at 10:17 AM, Emil Velikov
> wrote:
>> Cc: Er
On 17/07/15 18:17, Emil Velikov wrote:
> Cc: 10.6
> Cc: Eric Anholt
> Signed-off-by: Emil Velikov
> ---
> src/gallium/drivers/vc4/Makefile.am | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/drivers/vc4/Makefile.am
> b/src/gallium/drivers/vc4/Makefile.am
> index a4a7f86..3
Hi all,
Humble reminder:
Any patches sent to mesa-stable and/or landed in master after 12 PM
(noon) GMT, on the 22nd of July won't feature in 10.6.3.
Cheers,
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/ma
On 21 July 2015 at 10:53, Varad Gautam wrote:
> On Tuesday, July 14, 2015 04:02:47 PM Emil Velikov wrote:
>> See previous two commits for details.
>>
>> Signed-off-by: Emil Velikov
>> ---
>> Android.mk | 3 +-
>> src/egl/drivers/dri2/Android.mk | 63
>> -
On 07/20/2015 10:55 PM, Vinson Lee wrote:
Silence a release build warning.
st_glsl_to_tgsi.cpp: In function 'pipe_error st_translate_program(gl_context*,
uint, ureg_program*, glsl_to_tgsi_visitor*, const gl_program*, GLuint, const
GLuint*, const GLuint*, const ubyte*, const ubyte*, const GLuin
Just a couple minor nits...
On 07/16/2015 10:54 AM, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/auxiliary/util/u_dump.h | 20 ++-
src/gallium/auxiliary/util/u_dump_defines.c | 41 +
src/gallium/auxiliary/util/u_dump_state.c | 233 ++--
3 fi
https://bugs.freedesktop.org/show_bug.cgi?id=91254
--- Comment #9 from me...@frugalware.org ---
(In reply to Tomasz C. from comment #8)
>
> Yes, the issue only happens on Intel Core i5 M 450. This is probably
> Ironlake Graphics.
> On other processors listed by me everything is working properly.
On Tue, Jul 21, 2015 at 3:56 PM, Brian Paul wrote:
> Just a couple minor nits...
>
> On 07/16/2015 10:54 AM, Marek Olšák wrote:
>>
>> From: Marek Olšák
>>
>> ---
>> src/gallium/auxiliary/util/u_dump.h | 20 ++-
>> src/gallium/auxiliary/util/u_dump_defines.c | 41 +
>> src/galliu
https://bugs.freedesktop.org/show_bug.cgi?id=91387
--- Comment #2 from Michael Godfrey ---
I believe that the seg fault actually occurs in Octave. I could
run a backtrace but, in any case, other Octave developers can do
this quicker. If it is found that there is a problem in the Mesa
code, they w
See previous two commits for details.
v2: Don't forget git mv, bring back DRM_GRALLOC_TOP. Spotted by Varad.
Cc: Varad Gautam
Cc: Chih-Wei Huang
Cc: Eric Anholt
Signed-off-by: Emil Velikov
---
Patch generated with -M to ease diff/review process.
-Emil
Android.mk | 3
On 07/21/2015 08:17 AM, Marek Olšák wrote:
On Tue, Jul 21, 2015 at 3:56 PM, Brian Paul wrote:
Just a couple minor nits...
On 07/16/2015 10:54 AM, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/auxiliary/util/u_dump.h | 20 ++-
src/gallium/auxiliary/util/u_dump_defines.c
Now that the drm_gralloc module exports the correct includes we can get
rid of this hack.
Cc: Varad Gautam
Cc: Chih-Wei Huang
Cc: Eric Anholt
Signed-off-by: Emil Velikov
---
Android.mk | 2 --
src/egl/Android.mk | 1 -
2 files changed, 3 deletions(-)
diff --git a/Android.mk b/Android
... in order to prevent fixed path hacks in other projects.
Cc: Varad Gautam
Cc: Chih-Wei Huang
Cc: Eric Anholt
Signed-off-by: Emil Velikov
---
Android.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Android.mk b/Android.mk
index 571ec1c..f749e6e 100644
--- a/Android.mk
+++ b/Androi
On 18 July 2015 at 08:13, Jose Fonseca wrote:
> On 18/07/15 01:38, Eric Anholt wrote:
>>
>> Emil Velikov writes:
>>
>>> On 14/07/15 19:45, Eric Anholt wrote:
These are really useful hints to the compiler in the absence of
link-time
optimization, and I'm going to use them in VC
Acked-by: Marek Olšák
What's next? boolean -> bool? :)
Marek
On Tue, Jul 21, 2015 at 2:20 AM, Ilia Mirkin wrote:
> Generated by running:
> git grep -l INLINE src/gallium/ | xargs sed -i 's/\bINLINE\b/inline/g'
> git grep -l INLINE src/mesa/state_tracker/ | xargs sed -i
> 's/\bINLINE\b/inline/
That's already done :) At least in nouveau, thanks to Samuel.
On Tue, Jul 21, 2015 at 11:22 AM, Marek Olšák wrote:
> Acked-by: Marek Olšák
>
> What's next? boolean -> bool? :)
>
> Marek
>
> On Tue, Jul 21, 2015 at 2:20 AM, Ilia Mirkin wrote:
>> Generated by running:
>> git grep -l INLINE src/ga
Signed-off-by: Boyan Ding
---
configure.ac|4 -
src/glx/dri3_glx.c | 1446 ++-
src/glx/dri3_priv.h | 96 +---
3 files changed, 171 insertions(+), 1375 deletions(-)
diff --git a/configure.ac b/configure.ac
index a91bbd4..872f15b 10064
Signed-off-by: Boyan Ding
---
configure.ac|8 +-
src/loader/Makefile.am |9 +
src/loader/loader_dri3_helper.c | 1397 +++
src/loader/loader_dri3_helper.h | 226 +++
4 files changed, 1639 insertions(+), 1 deletion(-)
cr
Signed-off-by: Boyan Ding
---
src/egl/drivers/dri2/platform_x11.c | 1 +
src/egl/drivers/dri2/platform_x11_dri3.c | 77 +++-
2 files changed, 77 insertions(+), 1 deletion(-)
diff --git a/src/egl/drivers/dri2/platform_x11.c
b/src/egl/drivers/dri2/platform_x11.c
This requires swrast version >= 3. Also EGL_EXT_create_context_robostness
is supported if __DRI2_ROBUSTNESS extension is found.
Reference: https://bugs.freedesktop.org/show_bug.cgi?id=80821
Signed-off-by: Boyan Ding
---
src/egl/drivers/dri2/egl_dri2.c | 3 ++-
1 file changed, 2 insertions(+), 1
This is the second version of my effort to bring dri3 to EGL on X. This
time I took Emil's advice and moved common logic of GLX and EGL into
loader/loader_dri3_helper.[ch]. With this, the dri3 code in libEGL is
only ~650 lines, with a bunch of trivial code, and glx/dri3 code also
shrinks a lot.
I
v2: Change return type of the new function from int to bool
Signed-off-by: Boyan Ding
---
src/egl/drivers/dri2/egl_dri2.c | 33 +++--
1 file changed, 27 insertions(+), 6 deletions(-)
diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
index
v2: Change return type of the new function from int to bool
Reviewed-by: Marek Olšák
Signed-off-by: Boyan Ding
---
src/egl/drivers/dri2/egl_dri2.c | 90 -
1 file changed, 54 insertions(+), 36 deletions(-)
diff --git a/src/egl/drivers/dri2/egl_dri2.c b/sr
Signed-off-by: Boyan Ding
---
configure.ac | 6 +
src/egl/drivers/dri2/Makefile.am | 5 +
src/egl/drivers/dri2/egl_dri2.c | 66 +++-
src/egl/drivers/dri2/egl_dri2.h | 14 +-
src/egl/drivers/dri2/platform_x11.c | 105 ++-
src/egl
dri3 for EGL will use different struct other than dri2_egl_surface for
an EGL surface, the common code only uses __DRIdrawable from that
struct, so instead of converting _EGLSurface to dri2_egl_surface, let
the platform code return the __DRIdrawable by its own (although the
current platforms use th
Without this this extension basically can't work in indirect contexts,
TexImage2D will compute the image size as 0 and we'll send no image data
to the server.
v2: Add EXT_texture_integer to the client extension list too (Ian)
Signed-off-by: Adam Jackson
---
src/glx/compsize.c | 10
Used to support EGL_KHR_image_pixmap.
Signed-off-by: Boyan Ding
---
src/loader/loader_dri3_helper.c | 82 -
src/loader/loader_dri3_helper.h | 9 +
2 files changed, 58 insertions(+), 33 deletions(-)
diff --git a/src/loader/loader_dri3_helper.c b/src/l
On 20 July 2015 at 19:36, Ian Romanick wrote:
> On 07/09/2015 01:12 PM, Emil Velikov wrote:
>> On 9 July 2015 at 18:50, Ian Romanick wrote:
>>> On 07/08/2015 10:07 AM, Emil Velikov wrote:
Signed-off-by: Emil Velikov
---
include/GL/internal/dri_interface.h | 11 ---
1
I don't think resource_copy_region is a good match for all possible
cases that can occur with ARB_copy_image and I extensively explained
this to Ilia on IRC. The format swizzling is the problem.
Assume you have a copy from RGBA8 to R32F. This is equivalent to
copying RGBA8 to RGBA8, because it's j
v2: use HAVE_LIBDRM macro.
Cc: Ian Romanick
Signed-off-by: Emil Velikov
---
include/GL/internal/dri_interface.h | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/include/GL/internal/dri_interface.h
b/include/GL/internal/dri_interface.h
index c827bb6..7266071 100644
--
gcc says:
sb/sb_sched.cpp: In member function 'bool
r600_sb::alu_group_tracker::try_reserve(r600_sb::alu_node*)':
sb/sb_sched.cpp:492:7: warning: suggest parentheses around operand of '!'
or change '&' to '&&' or '!' to '~' [-Wparentheses]
if (!trans & fbs)
It happens to be harmle
This cleans up fs_inst::regs_read() slightly by disentangling the
calculation of "components" from the handling of message payload
arguments. This will also simplify the SIMD lowering and logical send
message lowering passes, because it will avoid expressions like
'regs_read * REG_SIZE / component
2015-07-21 14:12 GMT+02:00 Emil Velikov :
> On 20/07/15 21:25, Chad Versace wrote:
>> On Fri 17 Jul 2015, Emil Velikov wrote:
>>> On 17 July 2015 at 19:11, Ilia Mirkin wrote:
On Fri, Jul 17, 2015 at 2:11 PM, Eric Anholt wrote:
> Matt Turner writes:
>
>> On Fri, Jul 17, 2015 at 1
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 1062ded..a996676 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
@@ -405
Another resend of the i965 compiler-related changes for
ARB_shader_image_load_store, reworked to make use of the SIMD lowering
infrastructure introduced in a previous series [1]. For a
self-contained branch in testable form see [2].
[1] http://lists.freedesktop.org/archives/mesa-dev/2015-July/089
Implement helper functions that can be used to construct and send
untyped and typed surface read, write and atomic messages to the
shared dataport unit easily.
v2: Drop VEC4 suport.
v3: Reimplement in terms of logical send opcodes.
---
src/mesa/drivers/dri/i965/Makefile.sources | 2 +
.
Define some utility functions to query the bitfield layout of a given
image format and whether it satisfies a number of more or less
hardware-specific properties.
v2: Drop VEC4 suport.
v3: Add SKL support.
---
src/mesa/drivers/dri/i965/brw_fs_surface_builder.h | 148 +
1 file
This will be handy to avoid some ugly ternary operators in the next
patch, like:
fs_reg reg = (size == 0 ? null_reg_ud() : vgrf(..., size));
Because a zero-size register allocation is guaranteed not to ever be
read or written we can just return the null register. Another
possibility would be to
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 63 +++-
1 file changed, 55 insertions(+), 8 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index a996676..0b0c5e1 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
+
Define a function to calculate the memory address of the image
location given by a vector of coordinates. This is required in cases
where we need to fall back to untyped surface access, which take a raw
memory offset and know nothing about surface coordinates, type
conversion or memory tiling and
Define bitfield packing, unpacking and type conversion operations in
terms of which the image format conversion code will be implemented.
These don't directly know about image formats: The packing and
unpacking functions take a 4-tuple of bit shifts and a 4-tuple of bit
widths as arguments, determi
Images take up zero uniform slots in the nir_shader::num_uniforms
calculation, but nir_setup_uniforms needs to be executed even if the
program has no non-image uniforms so the driver-specific image
parameters are uploaded. nir_setup_uniforms is a no-op if there are
really no uniforms, so checking
v2: Move the image_params array back to brw_stage_prog_data.
---
src/mesa/drivers/dri/i965/brw_shader.cpp | 31 +++
src/mesa/drivers/dri/i965/brw_shader.h | 1 +
2 files changed, 32 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp
b/src/mesa/driv
These utility functions check whether an image access is valid.
According to the spec an invalid image access should have no effect on
the image and yield well-defined results. Typically the hardware
implements correct bounds and surface checking by itself, but in some
cases (typed atomics on IVB
Reviewed-by: Paul Berry
---
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa/drivers/dri/i965/intel_extensions.c
index 6b3bd12..5a5e308 100644
--- a/src/mesa/drivers/dri/i965/intel_extensions.
v2: Drop VEC4 suport.
v3: Rebase.
---
.../drivers/dri/i965/brw_fs_surface_builder.cpp| 216 +
src/mesa/drivers/dri/i965/brw_fs_surface_builder.h | 17 ++
2 files changed, 233 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp
b/src/mesa/drive
Rewrite the NIR atomic counter intrinsics translation code making use
of the recently introduced surface builder. This will allow the
removal of some of the functionality duplicated between the visitor
and surface builder.
v2: Drop VEC4 suport.
---
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 49 +
Each logical variant is largely equivalent to the original opcode but
instead of taking a single payload source it expects its arguments
separately as individual sources, like:
typed_surface_write_logical null, coordinates, source, surface,
num_coordinates, num
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 1 +
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 0b0c5e1..0d97474 100644
--- a/src/mesa/drivers/dri/i965/
v2: Move the image_params array back to brw_stage_prog_data.
---
src/mesa/drivers/dri/i965/brw_fs.h | 1 +
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 50 +++-
2 files changed, 43 insertions(+), 8 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.h
b/sr
---
src/mesa/drivers/dri/i965/brw_fs.h | 7 --
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 13 ++--
src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 112 ---
3 files changed, 5 insertions(+), 127 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.h
b
Image variables need to allocate additional uniform slots over
nir_shader::num_uniforms. nir_setup_uniforms() overwrites the values
imported from the SIMD8 visitor and then exits early before entering
the nir_shader::uniforms loop, so image uniforms are never re-created.
Instead leave the imported
---
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
index 76297b7..9a1fb4b 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
+++ b/src/mesa/drivers/dri/i965/
---
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 149 +++
1 file changed, 149 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
index 31024b7..76297b7 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
+++
If a non-const sample number is given to interpolateAtSample it will
now generate an indirect send message with the sample ID similar to
how non-const sampler array indexing works. Previously non-const
values were ignored and instead it ended up using a constant 0 value.
Note that unlike sampler a
On Tue, Jul 21, 2015 at 12:12 PM, Adam Jackson wrote:
> gcc says:
>
> sb/sb_sched.cpp: In member function 'bool
> r600_sb::alu_group_tracker::try_reserve(r600_sb::alu_node*)':
> sb/sb_sched.cpp:492:7: warning: suggest parentheses around operand of '!'
> or change '&' to '&&' or '!' to '~
Read-only and write-only image arguments are recognized and
distinguished.
Attributes of the image arguments are passed to the kernel as implicit
arguments.
---
src/gallium/state_trackers/clover/core/kernel.cpp | 46 ++-
src/gallium/state_trackers/clover/core/kernel.hpp | 13 +-
src/galliu
On Tue, Jul 21, 2015 at 12:50 AM, Iago Toral wrote:
> On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
>> Signed-off-by: Anuj Phogat
>> ---
>> src/mesa/drivers/common/meta.c | 13 ++---
>> 1 file changed, 10 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/mesa/drivers/common/me
A few comments below. Mostly just asking for explanation.
1-3 are
Reviewed-by: Jason Ekstrand
Obviously, don't merge 4/4 until it actually has users.
--Jason
On Thu, Jul 16, 2015 at 8:35 AM, Francisco Jerez wrote:
> This lowering pass implements an algorithm to expand SIMDN
> instructions in
Just FYI:
http://lists.freedesktop.org/archives/mesa-dev/2015-June/085869.html
Am Dienstag, 21. Juli 2015, 12:12:33 schrieb Adam Jackson:
> gcc says:
>
> sb/sb_sched.cpp: In member function 'bool
> r600_sb::alu_group_tracker::try_reserve(r600_sb::alu_node*)':
> sb/sb_sched.cpp:492:7: war
This fixes the following piglit test:
ext_transform_feedback-immediate-reuse-uniform-buffer
Signed-off-by: Samuel Pitoiset
---
src/gallium/drivers/nouveau/nv50/nv50_shader_state.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/drivers/nouveau/nv50/nv50_shader_state.c
b/src/
How about
"nv50: force cache flush when binding a new ubo"
Reviewed-by: Ilia Mirkin
On Tue, Jul 21, 2015 at 3:37 PM, Samuel Pitoiset
wrote:
> This fixes the following piglit test:
> ext_transform_feedback-immediate-reuse-uniform-buffer
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/gallium
This fixes the following piglit test:
ext_transform_feedback-immediate-reuse-uniform-buffer
Signed-off-by: Samuel Pitoiset
---
src/gallium/drivers/nouveau/nvc0/nvc0_state_validate.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_state_validate.c
b/
Reviewed-by: Ilia Mirkin
I'm unconvinced that this is strictly necessary, but it seems to fix
the test so... wtvr. UBO's don't get rebound too often without also
doing other things that would incur a similar barrier/flush.
On Tue, Jul 21, 2015 at 3:59 PM, Samuel Pitoiset
wrote:
> This fixes the
FYI, I will push tessellation after Dave lands shader subroutines.
Marek
On Thu, Jul 16, 2015 at 10:27 PM, Marek Olšák wrote:
> Thanks for the reviewing.
>
> The patches that are missing Rbs are:
>
> 23-24, 26-43, 45-46.
>
> The patches have been on the mailing list for one month. It looks like
I just realized that there's actually another difference if you'd use
the util_is_format_compatible to see whether resource_copy_region may be
used: d3d style, this would exclude things like rg16 being compatible
with r32 completely, swizzled or not (this is how d3d10 typeless groups
work). Granted
On Thu, Jul 16, 2015 at 8:41 AM, Francisco Jerez wrote:
> The only non-trivial thing it still has to do is figure out where to
> take the src/dst depth values from and predicate the instruction if
> discard is in use. The manual SIMD unrolling logic in the dual-source
> case goes away because thi
Since s3tc works for cube maps and 2D arrays, it should also work for
cube arrays. NVIDIA's driver supports this too. This is a minor follow-on
fix for the commit "mesa: fix up some texture error checks".
---
src/mesa/main/teximage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
Fixes 'make check' on FreeBSD.
Signed-off-by: Vinson Lee
---
src/mapi/es1api/ABI-check | 2 +-
src/mapi/es2api/ABI-check | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mapi/es1api/ABI-check b/src/mapi/es1api/ABI-check
index 44654cd..819568f 100755
--- a/src/mapi/es1ap
On Sat, Jul 18, 2015 at 7:34 AM, Francisco Jerez wrote:
> So that it's left uninitialized by LOAD_PAYLOAD, we only need to
> reserve space for it in the message since it will be initialized
> implicitly by the generator.
> ---
> src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 7 ---
> 1 file c
Adam Jackson writes:
> Without this this extension basically can't work in indirect contexts,
> TexImage2D will compute the image size as 0 and we'll send no image data
> to the server.
>
> v2: Add EXT_texture_integer to the client extension list too (Ian)
Reviewed-by: Eric Anholt
signature.a
Could mention this is actually a gl spec bug in the commit message, but
either way:
Reviewed-by: Roland Scheidegger
Am 21.07.2015 um 22:55 schrieb Brian Paul:
> Since s3tc works for cube maps and 2D arrays, it should also work for
> cube arrays. NVIDIA's driver supports this too. This is a mi
I *think* this is sane. I compared it against the current SIMD16 and
SIMD8 code and it looks like it does the right thing. However, it's
not a direct translation and I don't know the gen4 texturing code, so
I can't really call it reviewed.
Acked-by: Jason Ekstrand
Ken, could you give it a quic
It seems that I was under the wrong impression on the hole thing.
Some of the files generated from these scripts are used in/by xserver.
Although they are imported/tracked into version control of the latter in
order to prevent the xserver build directly diving into mesa source tree.
The XORG_GLAP
Cool, I was under that impression too, but having it confirmed is great.
Since these do matter and I don't have push access, could you make sure
this lands?
On Jul 21, 2015 15:33, "Emil Velikov" wrote:
> It seems that I was under the wrong impression on the hole thing.
>
> Some of the files gene
Reviewed-by: Ian Romanick
On 07/21/2015 09:07 AM, Emil Velikov wrote:
> v2: use HAVE_LIBDRM macro.
>
> Cc: Ian Romanick
> Signed-off-by: Emil Velikov
> ---
> include/GL/internal/dri_interface.h | 9 +
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/include/GL/intern
On Sat, Jul 18, 2015 at 7:34 AM, Francisco Jerez wrote:
> This should match the set of cases in which we currently call fail()
> or no16() from the emit_texture_*() methods and the ones in which
> emit_texture_gen4() enables the SIMD16 workaround.
>
> Hint for reviewers: It's not a big deal if I h
On Sat, Jul 18, 2015 at 7:34 AM, Francisco Jerez wrote:
> ---
> src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 66
> +---
> 1 file changed, 49 insertions(+), 17 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> b/src/mesa/drivers/dri/i965/brw_f
From: Dave Airlie
This is prep work for using it in the interpolation code
later.
Also add storage for the input interpolation mode so we
can pick it up later.
Signed-off-by: Dave Airlie
---
src/gallium/drivers/radeonsi/si_shader.c | 62 +++-
src/gallium/drivers/ra
From: Dave Airlie
This is part of ARB_gpu_shader5, and this passes
all the piglit tests currently available.
Signed-off-by: Dave Airlie
---
docs/GL3.txt | 2 +-
src/gallium/drivers/radeonsi/si_shader.c | 232 ++-
2 files changed, 232 in
From: Dave Airlie
This adds support for fine derivatives and enables
ARB_derivative_control on radeonsi.
(just fell out of my working out interpolation)
Signed-off-by: Dave Airlie
---
docs/GL3.txt | 2 +-
docs/relnotes/10.7.0.html| 1 +
src/galliu
From: Dave Airlie
This is prep work for reusing this in the interpolation
code later.
Signed-off-by: Dave Airlie
---
src/gallium/drivers/radeonsi/si_shader.c | 44 +++-
1 file changed, 26 insertions(+), 18 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_s
These are pretty standalone so I've pulled them out from my radeonsi-dev
tree and cleaned them up.
They pass all the tests, and get one step closer to gpu_shader5.
Dave.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.
I made a few minor nitpick comments on a couple of patches and I
didn't feel like I could fully review 08/12. Other than the few nits,
patches 1-7 and 9-12 are
Reviewed-by: Jason Ekstrand
On Sat, Jul 18, 2015 at 7:34 AM, Francisco Jerez wrote:
> This is now dead code.
> ---
> src/mesa/drivers/
1 - 100 of 157 matches
Mail list logo
