Re: [Mesa-dev] [PATCH] clover: add --with-icd-file-dir option

2015-05-07 Thread Michel Dänzer
On 05.05.2015 01:47, Tom Stellard wrote: > On Mon, May 04, 2015 at 10:13:19AM -0400, Ilia Mirkin wrote: >> On Mon, May 4, 2015 at 10:04 AM, Tom Stellard wrote: >>> On Sat, May 02, 2015 at 01:31:41PM -0400, Ilia Mirkin wrote: On Sat, May 2, 2015 at 1:19 PM, EdB wrote: > The standard ICD f

[Mesa-dev] [Bug 80183] [llvmpipe] triangles with vertices that map to raster positions > viewport width/height are not displayed

2015-05-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80183 --- Comment #14 from cgerlac...@gmail.com --- The problem is also reproducible with softpipe. I understand your concern and I will try provide some samplecode to reproduce the clipping error. -- You are receiving this mail because: You are the

Re: [Mesa-dev] [PATCH] util: Take memset out of rzalloc_size()

2015-05-07 Thread Juha-Pekka Heikkila
On 06.05.2015 21:51, Rob Clark wrote: > On Wed, May 6, 2015 at 1:24 PM, Kenneth Graunke wrote: >> On Wednesday, May 06, 2015 03:35:27 PM Juha-Pekka Heikkila wrote: >>> rzalloc_size() call ralloc_size() to allocate memory. ralloc_size() >>> use calloc to get memory thus zeroing in rzalloc_size is n

Re: [Mesa-dev] [PATCH 2/2] glx: provide a way to disable DRI3 using an environment variable

2015-05-07 Thread Martin Peres
On 06/05/15 19:47, Axel Davy wrote: Le 06/05/2015 14:43, Martin Peres a écrit : diff --git a/src/glx/dri3_glx.c b/src/glx/dri3_glx.c index ff77a91..5246737 100644 --- a/src/glx/dri3_glx.c +++ b/src/glx/dri3_glx.c @@ -2092,6 +2092,11 @@ dri3_create_display(Display * dpy) xcb_generic_error_

Re: [Mesa-dev] [PATCH 1/2] glx: report which DRI version is used when in verbose debug mode

2015-05-07 Thread Eero Tamminen
Hi, On 05/06/2015 08:28 PM, Kenneth Graunke wrote: I agree with Axel - I think LIBGL_DRI3_DISABLE=1 already does what you want, so patch 2 is unnecessary. That needs a patch to doc/envvars.html... - Eero ___ mesa-dev mailing list mesa-dev@

[Mesa-dev] [Bug 69101] prime: black window

2015-05-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69101 higu...@gmx.net changed: What|Removed |Added CC||higu...@gmx.net -- You are receiving t

Re: [Mesa-dev] [PATCH 10/13] mesa/main: Check context pointer in _mesa_error before using it

2015-05-07 Thread Pohjolainen, Topi
On Tue, May 05, 2015 at 02:25:26PM +0300, Juha-Pekka Heikkila wrote: > I guess this should not really be able to segfault but still it > seems to be able to during context creation. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/main/errors.c | 26 -- > 1 file ch

Re: [Mesa-dev] [PATCH 13/13] mesa/main: Verify context creation on progress

2015-05-07 Thread Pohjolainen, Topi
On Tue, May 05, 2015 at 02:25:29PM +0300, Juha-Pekka Heikkila wrote: > Stop context creation if something failed. If something errored > during context creation we'd segfault. Now will clean up and > return error. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/main/shared.c | 66 >

Re: [Mesa-dev] [PATCH v2 03/15] i965/fs_cse: Factor out code to create copy instructions

2015-05-07 Thread Pohjolainen, Topi
On Tue, May 05, 2015 at 06:28:06PM -0700, Jason Ekstrand wrote: > v2: Get rid of the block parameter and make src a const reference > > Reviewed-by: Topi Pohjolainen > Reviewed-by: Matt Turner > Reviewed-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 75 > +

Re: [Mesa-dev] [PATCH 14/27] nir: Add glsl_get_element_type() wrapper.

2015-05-07 Thread Timothy Arceri
On Tue, 2015-04-28 at 23:08 +0300, Abdiel Janulgue wrote: > Signed-off-by: Abdiel Janulgue > --- > src/glsl/nir/nir_types.cpp | 5 + > src/glsl/nir/nir_types.h | 2 ++ > 2 files changed, 7 insertions(+) > > diff --git a/src/glsl/nir/nir_types.cpp b/src/glsl/nir/nir_types.cpp > index f0d0b

[Mesa-dev] [PATCH] i965/skl: In opt_sampler_eot always set destination register to null

2015-05-07 Thread Neil Roberts
opt_sampler_eot enables a direct write to framebuffer from a sample. In order to do this the sample message needs to have a message header so if there wasn't one already then the function adds one. In addition the function sets the destination register to null because it's no longer used. However i

[Mesa-dev] [PATCH] i965/wm/gen6: Add option for disabling statistics collection

2015-05-07 Thread Topi Pohjolainen
Normally this always needed but for internal blits and clears we need to be able to disable it. CC: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_state.h | 3 ++- src/mesa/drivers/dri/i965/gen6_wm_state.c | 14 +++--- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 03/27] i965: Enable hardware-generated binding tables on render path.

2015-05-07 Thread Pohjolainen, Topi
On Tue, Apr 28, 2015 at 11:08:00PM +0300, Abdiel Janulgue wrote: > This patch implements the binding table enable command which is also > used to allocate a binding table pool where hardware-generated > binding table entries are flushed into. Each binding table offset in > the binding table pool is

Re: [Mesa-dev] [PATCH 01/27] i965: Define HW-binding table and resource streamer control opcodes

2015-05-07 Thread Pohjolainen, Topi
On Sun, May 03, 2015 at 06:04:05PM +0300, Pohjolainen, Topi wrote: > On Tue, Apr 28, 2015 at 11:07:58PM +0300, Abdiel Janulgue wrote: > > Signed-off-by: Abdiel Janulgue > > --- > > src/mesa/drivers/dri/i965/brw_context.h | 1 + > > src/mesa/drivers/dri/i965/brw_defines.h | 24 +++

Re: [Mesa-dev] [PATCH 06/27] i965: Define gather push constants opcodes

2015-05-07 Thread Pohjolainen, Topi
On Tue, Apr 28, 2015 at 11:08:03PM +0300, Abdiel Janulgue wrote: > Signed-off-by: Abdiel Janulgue > --- > src/mesa/drivers/dri/i965/brw_defines.h | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_defines.h > b/src/mesa/drivers/dri/i9

Re: [Mesa-dev] [PATCH 16/27] i965: Include UBO parameter sizes in push constant parameters

2015-05-07 Thread Timothy Arceri
On Tue, 2015-04-28 at 23:08 +0300, Abdiel Janulgue wrote: > Now that we consider UBO constants as push constants, we need to include > the sizes of the UBO's constant slots in the visitor's uniform slot sizes. > This information is needed to properly pack vector constants tightly next to > each oth

Re: [Mesa-dev] i965: Revision of texture surface setup refactoring

2015-05-07 Thread Francisco Jerez
"Pohjolainen, Topi" writes: > On Wed, May 06, 2015 at 02:56:53PM +0300, Francisco Jerez wrote: >> Hi! >> >> Topi Pohjolainen writes: >> >> > This series moves all the decision making of values into common >> > hardware independent dispatcher while leaving the hardware specific >> > logic to de

[Mesa-dev] [PATCH v2 0/6] Continu enabling Open Gl ES 3.1

2015-05-07 Thread Marta Lofstedt
Changes to my previous patch-set accoring to comments from Tapani Palli. This will only expose the enums for the respective extensions to gles 3.1 and GL Core. Marta Lofstedt (6): mesa/es3.1: enable GL_ARB_shader_image_load_store for gles3.1 mesa/es3.1: enable ARB_shader_atomic_counters for GL

[Mesa-dev] [PATCH v2 2/6] mesa/es3.1: enable ARB_shader_atomic_counters for GLES 3.1

2015-05-07 Thread Marta Lofstedt
From: Marta Lofstedt v2 : only expose ARB_shader_atomic_counters enums for gles 3.1 and GL core. Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 23 +-- 2 files changed, 19 insertions(+), 10 deletions(-) d

[Mesa-dev] [PATCH v2 6/6] mesa/es3.1: enable GL_ARB_explicit_uniform_location for GLES 3.1

2015-05-07 Thread Marta Lofstedt
From: Marta Lofstedt v2 : only expose GL_ARB_explicit_uniform_location enums for gles 3.1 and GL core. Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/mesa

[Mesa-dev] [PATCH v2 3/6] mesa/es3.1: enable GL_ARB_texture_multisample for GLES 3.1

2015-05-07 Thread Marta Lofstedt
From: Marta Lofstedt v2 : only expose GL_ARB_texture_multisample enums for gles 3.1 and Gl core. Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 17 - 2 files changed, 14 insertions(+), 9 deletions(-) diff --gi

[Mesa-dev] [PATCH v2 1/6] mesa/es3.1: enable GL_ARB_shader_image_load_store for gles3.1

2015-05-07 Thread Marta Lofstedt
From: Marta Lofstedt v2: only expose enums from GL_ARB_shader_image_load_store for gles 3.1 and GL core Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 17 - 2 files changed, 14 insertions(+), 9 deletions(-) di

[Mesa-dev] [PATCH v2 4/6] mesa/es3.1: enable GL_ARB_texture_gather for GLES 3.1

2015-05-07 Thread Marta Lofstedt
From: Marta Lofstedt v2 : only expose GL_ARB_texture_gather enums for gles 3.1 and GL core. Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 9 - 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/mesa/ma

[Mesa-dev] [PATCH v2 5/6] mesa/es3.1: enable GL_ARB_compute_shader for GLES 3.1

2015-05-07 Thread Marta Lofstedt
From: Marta Lofstedt v2 : only expose GL_ARB_compute_shader enums for gles 3.1 and GL core. Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 19 +-- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git

[Mesa-dev] [PATCH 2/7] i965: Move tex miptree and format resolving into dispatcher

2015-05-07 Thread Francisco Jerez
From: Topi Pohjolainen All hardware platforms have this in common, so do it in the hardware independent dispatcher. v2 (Matt): Removed extra whitespace. Reviewed-by: Matt Turner (v1) Reviewed-by: Kenneth Graunke (v1) Signed-off-by: Topi Pohjolainen [ Francisco Jerez: Non-trivial rebase. ] Re

[Mesa-dev] [PATCH 7/7] i965: Drop the update_texture_surface vtbl hook.

2015-05-07 Thread Francisco Jerez
At this point the update_texture_surface and emit_texture_surface_state hooks are almost equivalent, the only significant difference is that emit_texture_surface_state supports binding read-write surfaces. The name of the latter is more consistent with the other emit_something_surface_state hooks,

[Mesa-dev] [PATCH 1/7] i965: Move texture buffer dispatch into single location

2015-05-07 Thread Francisco Jerez
From: Topi Pohjolainen All generations do the same exact dispatch and it could be therefore done in the hardware independent stage. Reviewed-by: Matt Turner Reviewed-by: Kenneth Graunke Signed-off-by: Topi Pohjolainen [ Francisco Jerez: Non-trivial rebase. ] Reviewed-by: Francisco Jerez ---

[Mesa-dev] [PATCH 4/7] i965: Refactor effective depth calculation

2015-05-07 Thread Francisco Jerez
From: Topi Pohjolainen Reviewed-by: Matt Turner Reviewed-by: Kenneth Graunke Signed-off-by: Topi Pohjolainen [ Francisco Jerez: Non-trivial rebase. Pass a half-open interval of layers like emit_texture_surface_state does. ] Reviewed-by: Francisco Jerez --- src/mesa/drivers/dri/i965/brw_co

[Mesa-dev] [PATCH 3/7] i965: Move texture swizzle resolving into dispatcher

2015-05-07 Thread Francisco Jerez
From: Topi Pohjolainen Reviewed-by: Matt Turner Reviewed-by: Kenneth Graunke Signed-off-by: Topi Pohjolainen [ Francisco Jerez: Non-trivial rebase. ] Reviewed-by: Francisco Jerez --- src/mesa/drivers/dri/i965/brw_context.h | 4 ++-- src/mesa/drivers/dri/i965/brw_wm_surface_state.c

[Mesa-dev] [PATCH 5/7] i965: Pass texture target as parameter for surface setup

2015-05-07 Thread Francisco Jerez
From: Topi Pohjolainen Also changed a couple of direct shifts into SET_FIELD(). Reviewed-by: Matt Turner Reviewed-by: Kenneth Graunke Signed-off-by: Topi Pohjolainen [ Francisco Jerez: Non-trivial rebase. ] Reviewed-by: Francisco Jerez --- src/mesa/drivers/dri/i965/brw_context.h |

Re: [Mesa-dev] [PATCH 07/27] i965: Enable gather push constants

2015-05-07 Thread Pohjolainen, Topi
On Tue, Apr 28, 2015 at 11:08:04PM +0300, Abdiel Janulgue wrote: > The 3DSTATE_GATHER_POOL_ALLOC is used to enable or disable the gather > push constants feature within a context. This patch provides the toggle > functionality of using gather push constants to program constant data > within a batch

[Mesa-dev] [PATCH 6/7] i965: Pass slice details as parameters for surface setup

2015-05-07 Thread Francisco Jerez
From: Topi Pohjolainen Also changed a couple of direct shifts into SET_FIELD(). Fixes: arb_copy_image-formats -auto -fbo on ILK. In principle, minimum level settings are only for TextureView to use. We, however, also take advantage of that internally when blitting. Before this patch this wasn't

Re: [Mesa-dev] [PATCH v2 03/15] i965/fs_cse: Factor out code to create copy instructions

2015-05-07 Thread Jason Ekstrand
On Thu, May 7, 2015 at 5:52 AM, Pohjolainen, Topi wrote: > On Tue, May 05, 2015 at 06:28:06PM -0700, Jason Ekstrand wrote: >> v2: Get rid of the block parameter and make src a const reference >> >> Reviewed-by: Topi Pohjolainen >> Reviewed-by: Matt Turner >> Reviewed-by: Kenneth Graunke >> ---

Re: [Mesa-dev] [PATCH 1/5] prog_to_nir: OPCODE_EXP is not nir_op_fexp

2015-05-07 Thread Jason Ekstrand
On Wed, May 6, 2015 at 7:29 PM, Matt Turner wrote: > On Wed, May 6, 2015 at 7:09 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> It's a weird thing that provides some values related to 2**x. It's also >> already handled by a case in the switch. >> >> Signed-off-by: Ian Romanick > > The ser

Re: [Mesa-dev] [PATCH v2 03/15] i965/fs_cse: Factor out code to create copy instructions

2015-05-07 Thread Pohjolainen, Topi
On Thu, May 07, 2015 at 07:26:12AM -0700, Jason Ekstrand wrote: > On Thu, May 7, 2015 at 5:52 AM, Pohjolainen, Topi > wrote: > > On Tue, May 05, 2015 at 06:28:06PM -0700, Jason Ekstrand wrote: > >> v2: Get rid of the block parameter and make src a const reference > >> > >> Reviewed-by: Topi Pohjol

[Mesa-dev] [PATCH] docs: document the LIBGL_DRI3_DISABLE environment variable

2015-05-07 Thread Martin Peres
Suggested-by: Axel Davy Signed-off-by: Martin Peres --- docs/envvars.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/envvars.html b/docs/envvars.html index 31d14a4..c0d5a51 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -34,6 +34,7 @@ sometimes be useful for debugging en

Re: [Mesa-dev] [PATCH 1/7] i965: Move texture buffer dispatch into single location

2015-05-07 Thread Pohjolainen, Topi
On Thu, May 07, 2015 at 05:15:35PM +0300, Francisco Jerez wrote: > From: Topi Pohjolainen > > All generations do the same exact dispatch and it could be > therefore done in the hardware independent stage. > > Reviewed-by: Matt Turner > Reviewed-by: Kenneth Graunke > Signed-off-by: Topi Pohjola

Re: [Mesa-dev] [PATCH 03/27] i965: Enable hardware-generated binding tables on render path.

2015-05-07 Thread Pohjolainen, Topi
On Thu, May 07, 2015 at 04:43:21PM +0300, Pohjolainen, Topi wrote: > On Tue, Apr 28, 2015 at 11:08:00PM +0300, Abdiel Janulgue wrote: > > This patch implements the binding table enable command which is also > > used to allocate a binding table pool where hardware-generated > > binding table entries

Re: [Mesa-dev] [PATCH 26/27] i965: Disable gather push constants for null constants

2015-05-07 Thread Pohjolainen, Topi
On Tue, Apr 28, 2015 at 11:08:23PM +0300, Abdiel Janulgue wrote: > Programming null constants with gather constant tables seems to > be unsupported and results in a GPU lockup even with the prescribed > GPU workarounds in the bspec. Found out by trial and error that > disabling HW gather constant w

Re: [Mesa-dev] [PATCH 09/27] i965: Allocate space on the gather pool for plain uniforms

2015-05-07 Thread Pohjolainen, Topi
On Tue, Apr 28, 2015 at 11:08:06PM +0300, Abdiel Janulgue wrote: > Reserve space in the gather pool where the gathered uniforms are flushed. > > Signed-off-by: Abdiel Janulgue > --- > src/mesa/drivers/dri/i965/gen6_vs_state.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/

Re: [Mesa-dev] [PATCH 09/27] i965: Allocate space on the gather pool for plain uniforms

2015-05-07 Thread Pohjolainen, Topi
On Thu, May 07, 2015 at 05:52:12PM +0300, Pohjolainen, Topi wrote: > On Tue, Apr 28, 2015 at 11:08:06PM +0300, Abdiel Janulgue wrote: > > Reserve space in the gather pool where the gathered uniforms are flushed. > > > > Signed-off-by: Abdiel Janulgue > > --- > > src/mesa/drivers/dri/i965/gen6_vs

Re: [Mesa-dev] [PATCH 09/27] i965: Allocate space on the gather pool for plain uniforms

2015-05-07 Thread Ilia Mirkin
On Thu, May 7, 2015 at 10:52 AM, Pohjolainen, Topi wrote: > On Tue, Apr 28, 2015 at 11:08:06PM +0300, Abdiel Janulgue wrote: >> Reserve space in the gather pool where the gathered uniforms are flushed. >> >> Signed-off-by: Abdiel Janulgue >> --- >> src/mesa/drivers/dri/i965/gen6_vs_state.c | 8 +

Re: [Mesa-dev] [PATCH 1/7] i965: Move texture buffer dispatch into single location

2015-05-07 Thread Francisco Jerez
"Pohjolainen, Topi" writes: > On Thu, May 07, 2015 at 05:15:35PM +0300, Francisco Jerez wrote: >> From: Topi Pohjolainen >> >> All generations do the same exact dispatch and it could be >> therefore done in the hardware independent stage. >> >> Reviewed-by: Matt Turner >> Reviewed-by: Kenneth

Re: [Mesa-dev] [PATCH 1/7] i965: Move texture buffer dispatch into single location

2015-05-07 Thread Pohjolainen, Topi
On Thu, May 07, 2015 at 05:55:48PM +0300, Francisco Jerez wrote: > "Pohjolainen, Topi" writes: > > > On Thu, May 07, 2015 at 05:15:35PM +0300, Francisco Jerez wrote: > >> From: Topi Pohjolainen > >> > >> All generations do the same exact dispatch and it could be > >> therefore done in the hardw

Re: [Mesa-dev] [PATCH 03/27] i965: Enable hardware-generated binding tables on render path.

2015-05-07 Thread Pohjolainen, Topi
On Thu, May 07, 2015 at 04:43:21PM +0300, Pohjolainen, Topi wrote: > On Tue, Apr 28, 2015 at 11:08:00PM +0300, Abdiel Janulgue wrote: > > This patch implements the binding table enable command which is also > > used to allocate a binding table pool where hardware-generated > > binding table entries

Re: [Mesa-dev] [PATCH 11/27] i965: Store gather table information in the program data

2015-05-07 Thread Pohjolainen, Topi
On Tue, Apr 28, 2015 at 11:08:08PM +0300, Abdiel Janulgue wrote: > The resource streamer is able to gather and pack sparsely-located > constant data from any buffer object by a referring to a gather table > This patch adds support for keeping track of these constant data > fetches into a gather tab

Re: [Mesa-dev] [PATCH 12/27] i965: Assign hw-binding table index for each UBO constant buffer.

2015-05-07 Thread Pohjolainen, Topi
On Tue, Apr 28, 2015 at 11:08:09PM +0300, Abdiel Janulgue wrote: > To be able to refer to a constant buffer, the resource streamer needs > to index it with a hardware binding table entry. This blankets the ubo > buffers with hardware binding table indices. > > Gather constants hardware fetches in

Re: [Mesa-dev] [PATCH 13/27] i965: Assign hw-binding table index for uniform constant buffer block

2015-05-07 Thread Pohjolainen, Topi
On Tue, Apr 28, 2015 at 11:08:10PM +0300, Abdiel Janulgue wrote: > Assign the uploaded uniform block with hardware binding table indices. > This is indexed by the resource streamer to fetch the constant buffers > referred to by our gather table entries. > > Signed-off-by: Abdiel Janulgue > --- >

Re: [Mesa-dev] [PATCH 16/27] i965: Include UBO parameter sizes in push constant parameters

2015-05-07 Thread Pohjolainen, Topi
On Tue, Apr 28, 2015 at 11:08:13PM +0300, Abdiel Janulgue wrote: > Now that we consider UBO constants as push constants, we need to include > the sizes of the UBO's constant slots in the visitor's uniform slot sizes. > This information is needed to properly pack vector constants tightly next to > e

Re: [Mesa-dev] [PATCH 18/27] i965/fs: Append ir_binop_ubo_load entries to the gather table

2015-05-07 Thread Pohjolainen, Topi
On Tue, Apr 28, 2015 at 11:08:15PM +0300, Abdiel Janulgue wrote: > When the const block and offset are immediate values. Otherwise just > fall-back to the previous method of uploading the UBO constant data to > GRF using pull constants. > > Signed-off-by: Abdiel Janulgue > --- > src/mesa/drivers

Re: [Mesa-dev] [PATCH 19/27] i965/fs/nir: Append nir_intrinsic_load_ubo entries to the gather table

2015-05-07 Thread Pohjolainen, Topi
On Tue, Apr 28, 2015 at 11:08:16PM +0300, Abdiel Janulgue wrote: > When the const block and offset are immediate values. Otherwise just > fall-back to the previous method of uploading the UBO constant data to > GRF using pull constants. > > Signed-off-by: Abdiel Janulgue > --- > src/mesa/drivers

[Mesa-dev] [PATCH] i965/fs: Don't forget the force_sechalf flag in lower_load_payload().

2015-05-07 Thread Francisco Jerez
Regression from commit 41868bb6824c6106a55c8442006c1e2215abf567. Fixes a bunch of ARB_shader_image_load_store tests. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 7e4ea

Re: [Mesa-dev] [PATCH] clover: replace --enable-opencl-icd with --with-opencl-icd

2015-05-07 Thread Aaron Watry
I'm not sure what the final consensus will be on how to do this, but FWIW: Tested-By: Aaron Watry I've tested this with 4 combinations: no --with-opencl-icd option specified : libOpenCL.so gets installed in ${prefix}/lib --with-opencl-icd=no : libOpenCL.so gets installed in ${prefix}/lib --with-o

Re: [Mesa-dev] [PATCH] clover: add --with-icd-file-dir option

2015-05-07 Thread Ilia Mirkin
On Thu, May 7, 2015 at 3:59 AM, Michel Dänzer wrote: > On 05.05.2015 01:47, Tom Stellard wrote: >> On Mon, May 04, 2015 at 10:13:19AM -0400, Ilia Mirkin wrote: >>> On Mon, May 4, 2015 at 10:04 AM, Tom Stellard wrote: On Sat, May 02, 2015 at 01:31:41PM -0400, Ilia Mirkin wrote: > On Sat,

Re: [Mesa-dev] [PATCH] i965/wm/gen6: Add option for disabling statistics collection

2015-05-07 Thread Kenneth Graunke
On Thursday, May 07, 2015 04:39:14 PM Topi Pohjolainen wrote: > Normally this always needed but for internal blits and clears > we need to be able to disable it. > > CC: Kenneth Graunke Signed-off-by: Topi Pohjolainen Reviewed-by: Kenneth Graunke signature.asc Description: This is a digitall

[Mesa-dev] [PATCH] i965/fs: Set the header_size on LOAD_PAYLOAD in opt_sampler_eot

2015-05-07 Thread Neil Roberts
Commit 94ee908448 added a header size parameter to the function to create the LOAD_PAYLOAD instruction. However this broke opt_sampler_eot which manually constructs the instruction and so wasn't setting the header_size. This ends up making the parameters for the send message all have the wrong loca

Re: [Mesa-dev] [PATCH] i965/fs: Set the header_size on LOAD_PAYLOAD in opt_sampler_eot

2015-05-07 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Thu, May 7, 2015 at 11:06 AM, Neil Roberts wrote: > Commit 94ee908448 added a header size parameter to the function to > create the LOAD_PAYLOAD instruction. However this broke > opt_sampler_eot which manually constructs the instruction and so > wasn't setting the

Re: [Mesa-dev] [PATCH] clover: add --with-icd-file-dir option

2015-05-07 Thread Tom Stellard
On Thu, May 07, 2015 at 04:59:41PM +0900, Michel Dänzer wrote: > On 05.05.2015 01:47, Tom Stellard wrote: > > On Mon, May 04, 2015 at 10:13:19AM -0400, Ilia Mirkin wrote: > >> On Mon, May 4, 2015 at 10:04 AM, Tom Stellard wrote: > >>> On Sat, May 02, 2015 at 01:31:41PM -0400, Ilia Mirkin wrote: >

Re: [Mesa-dev] [PATCH] docs: document the LIBGL_DRI3_DISABLE environment variable

2015-05-07 Thread Kenneth Graunke
On Thursday, May 07, 2015 05:34:13 PM Martin Peres wrote: > Suggested-by: Axel Davy > Signed-off-by: Martin Peres > --- > docs/envvars.html | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/docs/envvars.html b/docs/envvars.html > index 31d14a4..c0d5a51 100644 > --- a/docs/envvars.html >

Re: [Mesa-dev] [PATCH] i965/skl: In opt_sampler_eot always set destination register to null

2015-05-07 Thread Anuj Phogat
On Thu, May 7, 2015 at 6:20 AM, Neil Roberts wrote: > opt_sampler_eot enables a direct write to framebuffer from a sample. > In order to do this the sample message needs to have a message header > so if there wasn't one already then the function adds one. In addition > the function sets the destin

Re: [Mesa-dev] [PATCH] i965/fs: Set the header_size on LOAD_PAYLOAD in opt_sampler_eot

2015-05-07 Thread Anuj Phogat
On Thu, May 7, 2015 at 11:06 AM, Neil Roberts wrote: > Commit 94ee908448 added a header size parameter to the function to > create the LOAD_PAYLOAD instruction. However this broke > opt_sampler_eot which manually constructs the instruction and so > wasn't setting the header_size. This ends up maki

Re: [Mesa-dev] [PATCH] clover: replace --enable-opencl-icd with --with-opencl-icd

2015-05-07 Thread EdB
Le 2015-05-07 18:55, Aaron Watry a écrit : I'm not sure what the final consensus will be on how to do this, but FWIW: Tested-By: Aaron Watry I've tested this with 4 combinations: no --with-opencl-icd option specified : libOpenCL.so gets installed in ${prefix}/lib --with-opencl-icd=no : libOpenC

[Mesa-dev] [PATCH] i965/wm/gen7: Refactor state setup

2015-05-07 Thread Topi Pohjolainen
CC: Kenneth Graunke Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_state.h | 9 +++ src/mesa/drivers/dri/i965/gen7_wm_state.c | 98 --- 2 files changed, 74 insertions(+), 33 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_state.h b/sr

Re: [Mesa-dev] [PATCH v2 1/6] mesa/es3.1: enable GL_ARB_shader_image_load_store for gles3.1

2015-05-07 Thread Ian Romanick
On 05/07/2015 12:57 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > v2: only expose enums from GL_ARB_shader_image_load_store > for gles 3.1 and GL core > > Signed-off-by: Marta Lofstedt > --- > src/mesa/main/get.c | 6 ++ > src/mesa/main/get_hash_params.py | 17

Re: [Mesa-dev] Initial amdgpu driver release

2015-05-07 Thread Alex Deucher
On Mon, Apr 20, 2015 at 6:33 PM, Alex Deucher wrote: > I'm pleased to announce the initial release of the new amdgpu driver. > This is a partial replacement for the radeon driver for newer AMD > asics. A number of components are still shared. Here is a comparison > of the radeon and amdgpu stack

Re: [Mesa-dev] [PATCH 10/13] mesa/main: Check context pointer in _mesa_error before using it

2015-05-07 Thread Ian Romanick
On 05/07/2015 05:17 AM, Pohjolainen, Topi wrote: > On Tue, May 05, 2015 at 02:25:26PM +0300, Juha-Pekka Heikkila wrote: >> I guess this should not really be able to segfault but still it >> seems to be able to during context creation. >> >> Signed-off-by: Juha-Pekka Heikkila >> --- >> src/mesa/ma

Re: [Mesa-dev] [PATCH 13/13] mesa/main: Verify context creation on progress

2015-05-07 Thread Ian Romanick
On 05/07/2015 05:21 AM, Pohjolainen, Topi wrote: > On Tue, May 05, 2015 at 02:25:29PM +0300, Juha-Pekka Heikkila wrote: >> Stop context creation if something failed. If something errored >> during context creation we'd segfault. Now will clean up and >> return error. >> >> Signed-off-by: Juha-Pekka

Re: [Mesa-dev] [PATCH 1/5] prog_to_nir: OPCODE_EXP is not nir_op_fexp

2015-05-07 Thread Ian Romanick
On 05/07/2015 07:30 AM, Jason Ekstrand wrote: > On Wed, May 6, 2015 at 7:29 PM, Matt Turner wrote: >> On Wed, May 6, 2015 at 7:09 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> It's a weird thing that provides some values related to 2**x. It's also >>> already handled by a case in the s

Re: [Mesa-dev] [PATCH 13/13] SQUASH: nir: Update various components for the new list-based use/def sets

2015-05-07 Thread Connor Abbott
On Tue, Apr 28, 2015 at 12:03 AM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir_from_ssa.c | 11 +-- > src/glsl/nir/nir_lower_locals_to_regs.c | 14 ++ > src/glsl/nir/nir_lower_to_source_mods.c | 20 > src/glsl/nir/nir_lower_vars_to_ssa.c|

Re: [Mesa-dev] [PATCH] clover: replace --enable-opencl-icd with --with-opencl-icd

2015-05-07 Thread Jan Vesely
On Thu, 2015-05-07 at 21:52 +0200, EdB wrote: > Le 2015-05-07 18:55, Aaron Watry a écrit : > > I'm not sure what the final consensus will be on how to do this, but > > FWIW: > > Tested-By: Aaron Watry > > > > I've tested this with 4 combinations: > > no --with-opencl-icd option specified : libOpe

Re: [Mesa-dev] [PATCH 11/13] nir/nir: Use a linked list instead of a has set for use/def sets

2015-05-07 Thread Connor Abbott
Based on the testing you did, it sounds like switching to linked lists gives us some pretty good performance gains, but before we go ahead with this you should collect some numbers using http://anholt.net/compare-perf/ and put them on this commit message. Comparing list vs. no-list as well as NIR v

Re: [Mesa-dev] [PATCH 01/13] nir/validate: Validate SSA def parent instructiosn

2015-05-07 Thread Connor Abbott
I can't seem to find the cover email, so I'll respond to this one. Aside from my comments on patches 11 and 13, patches 1-5 and 11-13 are Reviewed-by: Connor Abbott and FWIW 6-10 are Acked-by: Connor Abbott although what's important there are other people testing those and make sure they don'

Re: [Mesa-dev] [PATCH 4/5] nir: Translate image load, store and atomic intrinsics from GLSL IR.

2015-05-07 Thread Connor Abbott
On Tue, May 5, 2015 at 4:29 PM, Francisco Jerez wrote: > --- > src/glsl/nir/glsl_to_nir.cpp | 125 > +++ > 1 file changed, 114 insertions(+), 11 deletions(-) > > diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp > index f6b8331..a01a

Re: [Mesa-dev] [PATCH 1/5] nir: Define image load, store and atomic intrinsics.

2015-05-07 Thread Connor Abbott
On IRC, Ken and I were discussing using a scheme inspired by SPIR-V, which has an OpImagePointer instruction that forms a pointer to the particular texel of the image as well as OpAtomic{Load,Store,Exchange,etc.} that operate on an image or shared buffer pointer. The advantages would be: * Makes t

[Mesa-dev] [PATCH 1/5] clover: Add threadsafe wrappers for pipe_screen and pipe_context

2015-05-07 Thread Tom Stellard
Events can be added to an OpenCL command queue concurrently from multiple threads, but pipe_context and pipe_screen objects are not threadsafe. The threadsafe wrappers protect all pipe_screen and pipe_context function calls with a mutex, so we can safely use them with multiple threads. --- src/ga

[Mesa-dev] [PATCH 2/5] clover: Replace open-coded event::signalled()

2015-05-07 Thread Tom Stellard
This consolidates signalled checks into the same place. --- src/gallium/state_trackers/clover/core/event.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/core/event.cpp b/src/gallium/state_trackers/clover/core/event.cpp index 58de888..3c933

[Mesa-dev] [PATCH 3/5] clover: Fix a bug with multi-threaded events

2015-05-07 Thread Tom Stellard
It was possible for some events never to get triggered if one thread was creating events and another threads was waiting for them. This patch consolidates soft_event::wait() and hard_event::wait() into event::wait() so that hard_event objects will now wait for all their dependencies to be submitte

[Mesa-dev] [PATCH 4/5] clover: Add a mutex to guard queue::queued_events

2015-05-07 Thread Tom Stellard
This fixes a potential crash where on a sequence like this: Thread 0: Check if queue is not empty. Thread 1: Remove item from queue, making it empty. Thread 0: Do something assuming queue is not empty. --- src/gallium/state_trackers/clover/core/queue.cpp | 2 ++ src/gallium/state_trackers/clover/

[Mesa-dev] [PATCH 5/5] clover: Add a mutex to guard event::chain and event::wait_count

2015-05-07 Thread Tom Stellard
This mutex effectively prevents an event's chain or wait_count from being updated while it is in the process of triggering. Otherwise it may be possible to add to an event's chain after it has been triggered, which causes the chained event to never be triggered. --- src/gallium/state_trackers/clo

[Mesa-dev] [PATCH] i965: Use NIR by default for vertex shaders on GEN8+

2015-05-07 Thread Jason Ekstrand
GLSL IR vs. NIR shader-db results for SIMD8 vertex shaders on Broadwell: total instructions in shared programs: 2724483 -> 2711790 (-0.47%) instructions in affected programs: 1860859 -> 1848166 (-0.68%) helped:4387 HURT:

Re: [Mesa-dev] [PATCH 07/13] util: Move gallium's linked list to util

2015-05-07 Thread Ian Romanick
Isn't this the same as src/util/simple_list.h? On 04/27/2015 09:03 PM, Jason Ekstrand wrote: > The linked list in gallium is pretty much the kernel list and we would like > to have a C-based linked list for all of mesa. Let's not duplicate and > just steal the gallium one. > --- > src/gallium/au

Re: [Mesa-dev] [PATCH 09/13] util/list: Add list_empty and list_length functions

2015-05-07 Thread Ian Romanick
On 05/05/2015 11:21 AM, Neil Roberts wrote: > Jason Ekstrand writes: > >> +static inline bool list_empty(struct list_head *list) >> +{ >> + return list->next == list; >> +} > > It would be good if list.h also included stdbool.h in order to get the > declaration of bool. However, will that caus

Re: [Mesa-dev] [PATCH] i965: Use NIR by default for vertex shaders on GEN8+

2015-05-07 Thread Kenneth Graunke
On Thursday, May 07, 2015 04:50:39 PM Jason Ekstrand wrote: > GLSL IR vs. NIR shader-db results for SIMD8 vertex shaders on Broadwell: > >total instructions in shared programs: 2724483 -> 2711790 (-0.47%) >instructions in affected programs: 1860859 -> 1848166 (-0.68%) >helped:

Re: [Mesa-dev] [PATCH] i965: Use NIR by default for vertex shaders on GEN8+

2015-05-07 Thread Ian Romanick
On 05/07/2015 04:50 PM, Jason Ekstrand wrote: > GLSL IR vs. NIR shader-db results for SIMD8 vertex shaders on Broadwell: > >total instructions in shared programs: 2724483 -> 2711790 (-0.47%) >instructions in affected programs: 1860859 -> 1848166 (-0.68%) >helped:

Re: [Mesa-dev] [PATCH] i965: Use NIR by default for vertex shaders on GEN8+

2015-05-07 Thread Jason Ekstrand
On May 7, 2015 5:38 PM, "Ian Romanick" wrote: > > On 05/07/2015 04:50 PM, Jason Ekstrand wrote: > > GLSL IR vs. NIR shader-db results for SIMD8 vertex shaders on Broadwell: > > > >total instructions in shared programs: 2724483 -> 2711790 (-0.47%) > >instructions in affected programs: 1

[Mesa-dev] [PATCH] main: glGetIntegeri_v fails for GL_VERTEX_BINDING_STRIDE

2015-05-07 Thread Marta Lofstedt
The return type for GL_VERTEX_BINDING_STRIDE is missing, this cause glGetIntegeri_v to fail. Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 6fc0f3f..9fb8fba 100644 --- a/src/mesa/main/get.c

Re: [Mesa-dev] [PATCH] i965: Use NIR by default for vertex shaders on GEN8+

2015-05-07 Thread Ian Romanick
On 05/07/2015 05:44 PM, Jason Ekstrand wrote: > > On May 7, 2015 5:38 PM, "Ian Romanick" > wrote: >> >> On 05/07/2015 04:50 PM, Jason Ekstrand wrote: >> > GLSL IR vs. NIR shader-db results for SIMD8 vertex shaders on Broadwell: >> > >> >total instructions in share

Re: [Mesa-dev] [PATCH] i965: Use NIR by default for vertex shaders on GEN8+

2015-05-07 Thread Matt Turner
On Thu, May 7, 2015 at 4:50 PM, Jason Ekstrand wrote: > GLSL IR vs. NIR shader-db results for SIMD8 vertex shaders on Broadwell: > >total instructions in shared programs: 2724483 -> 2711790 (-0.47%) >instructions in affected programs: 1860859 -> 1848166 (-0.68%) >helped:

Re: [Mesa-dev] [PATCH] i965: Use NIR by default for vertex shaders on GEN8+

2015-05-07 Thread Ian Romanick
On 05/07/2015 06:17 PM, Matt Turner wrote: > On Thu, May 7, 2015 at 4:50 PM, Jason Ekstrand wrote: >> GLSL IR vs. NIR shader-db results for SIMD8 vertex shaders on Broadwell: >> >>total instructions in shared programs: 2724483 -> 2711790 (-0.47%) >>instructions in affected programs: 18

Re: [Mesa-dev] [PATCH] clover: replace --enable-opencl-icd with --with-opencl-icd

2015-05-07 Thread Aaron Watry
On Thu, May 7, 2015 at 5:27 PM, Jan Vesely wrote: > On Thu, 2015-05-07 at 21:52 +0200, EdB wrote: > > Le 2015-05-07 18:55, Aaron Watry a écrit : > > > I'm not sure what the final consensus will be on how to do this, but > > > FWIW: > > > Tested-By: Aaron Watry > > > > > > I've tested this with 4

Re: [Mesa-dev] [PATCH] i965: Use NIR by default for vertex shaders on GEN8+

2015-05-07 Thread Jason Ekstrand
On Thu, May 7, 2015 at 6:17 PM, Matt Turner wrote: > On Thu, May 7, 2015 at 4:50 PM, Jason Ekstrand wrote: >> GLSL IR vs. NIR shader-db results for SIMD8 vertex shaders on Broadwell: >> >>total instructions in shared programs: 2724483 -> 2711790 (-0.47%) >>instructions in affected program

Re: [Mesa-dev] [PATCH] clover: add --with-icd-file-dir option

2015-05-07 Thread Michel Dänzer
On 08.05.2015 03:24, Tom Stellard wrote: > For this particular situation, I'm happy with any solution that: > > 1. Allows a user to install the icd file to /etc if he or she wants to. --sysconfdir=/etc That covers drirc as well. > 2. Does not require the user to read the spec to know that /etc

Re: [Mesa-dev] [PATCH 07/13] util: Move gallium's linked list to util

2015-05-07 Thread Jason Ekstrand
On Thu, May 7, 2015 at 5:30 PM, Ian Romanick wrote: > Isn't this the same as src/util/simple_list.h? In terms of being a two-pointer circularly linked list, yes. In terms of having a decent API, no. 1) Nothing in simple_list is namespaced in any way 2) it's all macros with do-while around them

Re: [Mesa-dev] [PATCH] i965: Use NIR by default for vertex shaders on GEN8+

2015-05-07 Thread Jason Ekstrand
On Thu, May 7, 2015 at 6:17 PM, Matt Turner wrote: > On Thu, May 7, 2015 at 4:50 PM, Jason Ekstrand wrote: >> GLSL IR vs. NIR shader-db results for SIMD8 vertex shaders on Broadwell: >> >>total instructions in shared programs: 2724483 -> 2711790 (-0.47%) >>instructions in affected program

Re: [Mesa-dev] [PATCH v2 1/6] mesa/es3.1: enable GL_ARB_shader_image_load_store for gles3.1

2015-05-07 Thread Tapani Pälli
On 05/08/2015 12:13 AM, Ian Romanick wrote: On 05/07/2015 12:57 AM, Marta Lofstedt wrote: From: Marta Lofstedt v2: only expose enums from GL_ARB_shader_image_load_store for gles 3.1 and GL core Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 6 ++ src/mesa/main

[Mesa-dev] [PATCH 1/2] nv50: keep track of PGRAPH state in nv50_screen

2015-05-07 Thread Ilia Mirkin
Normally this is kept in nv50_context, and on switching the active context, the state is copied from the previous context. However when the last context is destroyed, this is lost, and a new context might later be created. When the currently-active context is destroyed, save its state in the screen

[Mesa-dev] [PATCH 2/2] nvc0: keep track of PGRAPH state in nvc0_screen

2015-05-07 Thread Ilia Mirkin
See identical commit for nv50. Destroying the current context and then creating a new one or switching to another existing context would cause the "current" state to not be properly initialized, so we save it off in the screen. Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org ---

Re: [Mesa-dev] [PATCH] i965: Use NIR by default for vertex shaders on GEN8+

2015-05-07 Thread Jason Ekstrand
On Thu, May 7, 2015 at 8:49 PM, Jason Ekstrand wrote: > On Thu, May 7, 2015 at 6:17 PM, Matt Turner wrote: >> On Thu, May 7, 2015 at 4:50 PM, Jason Ekstrand wrote: >>> GLSL IR vs. NIR shader-db results for SIMD8 vertex shaders on Broadwell: >>> >>>total instructions in shared programs: 27244

[Mesa-dev] [Bug 86701] [regression] weston-simple-egl not running anymore inside qemu

2015-05-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86701 --- Comment #14 from Pekka Paalanen --- Patch series posted by Axel Davy: http://lists.freedesktop.org/archives/mesa-dev/2015-May/083254.html Reviews combined from Daniel Stone and Dave Airlie cover it all. -- You are receiving this mail becaus

[Mesa-dev] [PATCH] nir: fix sampler lowering pass for arrays

2015-05-07 Thread Tapani Pälli
This fixes bugs with special cases where we have arrays of structures containing samplers or arrays of samplers. I've verified that patch results in calculating same index value as returned by _mesa_get_sampler_uniform_value for IR. Patch makes following ES3 conformance test pass: ES3-CTS

  1   2   >